upcloudify 0.1.2 → 0.1.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: efd2a9f31fed02783de401102b11dd3e0b5b468b
-  data.tar.gz: 7ea2e9646754ba7d451777bdb3442b5243d9de0c
+  metadata.gz: 605bf8452d214954513539e39a999a8b7570be96
+  data.tar.gz: 32b53beffe0480001068d605f538a5ce2748bd72
 SHA512:
-  metadata.gz: 473be39ca115c4af04233454c9f7cbdc9c2efbb8785828ff9dbd553a16c6577cb1ee856be30f086bfdb3713e52377755cdf11a4bf91db86980387d06f655ca15
-  data.tar.gz: 42e04aefa4d0851c57cd72f4f6b983dd479e8fa94937aa42a2e1db5cd258e7b11ac302abcb6a9d10ba82123a08991e27734850eb5d3d2aa169e577ce48f3856c
+  metadata.gz: 3a175a0069c8afe53e136c2277a3b90e859062bb22696ceb3387f0d2d421e5db044036527ba469141eadad3a8820afe4c95bba36e997cb6d367df833b023c93e
+  data.tar.gz: 7224a76723d3465d177bd0a6843562c546ff795487f8ec23c1e6599e5c737600d1c0a6fda870060e8c9ab5d8e51417b1d175b2581ed61b645481c7ce5e000e5b

data/.rspec

@@ -0,0 +1,2 @@
+--color
+--require spec_helper

data/Guardfile

@@ -0,0 +1,70 @@
+# A sample Guardfile
+# More info at https://github.com/guard/guard#readme
+
+## Uncomment and set this to only include directories you want to watch
+# directories %w(app lib config test spec features) \
+#  .select{|d| Dir.exists?(d) ? d : UI.warning("Directory #{d} does not exist")}
+
+## Note: if you are using the `directories` clause above and you are not
+## watching the project directory ('.'), then you will want to move
+## the Guardfile to a watched dir and symlink it back, e.g.
+#
+#  $ mkdir config
+#  $ mv Guardfile config/
+#  $ ln -s config/Guardfile .
+#
+# and, you'll have to watch "config/Guardfile" instead of "Guardfile"
+
+# Note: The cmd option is now required due to the increasing number of ways
+#       rspec may be run, below are examples of the most common uses.
+#  * bundler: 'bundle exec rspec'
+#  * bundler binstubs: 'bin/rspec'
+#  * spring: 'bin/rspec' (This will use spring if running and you have
+#                          installed the spring binstubs per the docs)
+#  * zeus: 'zeus rspec' (requires the server to be started separately)
+#  * 'just' rspec: 'rspec'
+
+guard :rspec, cmd: "bundle exec rspec" do
+  require "guard/rspec/dsl"
+  dsl = Guard::RSpec::Dsl.new(self)
+
+  # Feel free to open issues for suggestions and improvements
+
+  # RSpec files
+  rspec = dsl.rspec
+  watch(rspec.spec_helper) { rspec.spec_dir }
+  watch(rspec.spec_support) { rspec.spec_dir }
+  watch(rspec.spec_files)
+
+  # Ruby files
+  ruby = dsl.ruby
+  dsl.watch_spec_files_for(ruby.lib_files)
+
+  # Rails files
+  rails = dsl.rails(view_extensions: %w(erb haml slim))
+  dsl.watch_spec_files_for(rails.app_files)
+  dsl.watch_spec_files_for(rails.views)
+
+  watch(rails.controllers) do |m|
+    [
+      rspec.spec.("routing/#{m[1]}_routing"),
+      rspec.spec.("controllers/#{m[1]}_controller"),
+      rspec.spec.("acceptance/#{m[1]}")
+    ]
+  end
+
+  # Rails config changes
+  watch(rails.spec_helper)     { rspec.spec_dir }
+  watch(rails.routes)          { "#{rspec.spec_dir}/routing" }
+  watch(rails.app_controller)  { "#{rspec.spec_dir}/controllers" }
+
+  # Capybara features specs
+  watch(rails.view_dirs)     { |m| rspec.spec.("features/#{m[1]}") }
+  watch(rails.layouts)       { |m| rspec.spec.("features/#{m[1]}") }
+
+  # Turnip features and steps
+  watch(%r{^spec/acceptance/(.+)\.feature$})
+  watch(%r{^spec/acceptance/steps/(.+)_steps\.rb$}) do |m|
+    Dir[File.join("**/#{m[1]}.feature")][0] || "spec/acceptance"
+  end
+end

data/README.md

@@ -60,4 +60,5 @@ bundle exec ruby sample.rb
 2. Create your feature branch (`git checkout -b my-new-feature`)
 3. Commit your changes (`git commit -am 'Add some feature'`)
 4. Push to the branch (`git push origin my-new-feature`)
-5. Create new Pull Request
+5. Don't forget tests!
+6. Create new Pull Request

data/lib/monkey_patches.rb

@@ -0,0 +1,17 @@
+class Numeric
+  def hour
+    self * 3600
+  end
+  alias_method :hours, :hour
+
+  def day
+    self * 24.hours
+  end
+  alias_method :days, :day
+end
+
+class Time
+  def tomorrow
+    self + 1.day
+  end
+end

data/lib/upcloudify/version.rb

@@ -1,3 +1,3 @@
 module Upcloudify
-  VERSION = "0.1.2"
+  VERSION = "0.1.3"
 end

data/lib/upcloudify.rb

@@ -1,4 +1,5 @@
 require "upcloudify/version"
+require "monkey_patches"
 require 'gem_config'
 require 'zip/zip'
 require 'zippy'
@@ -10,53 +11,56 @@ module Upcloudify
   include GemConfig::Base
 
   with_configuration do
-    has :aws_secret_access_key, default: ENV['AWS_SECRET_ACCESS_KEY']
     has :aws_access_key_id, default: ENV['AWS_ACCESS_KEY_ID']
+    has :aws_secret_access_key, default: ENV['AWS_SECRET_ACCESS_KEY']
     has :aws_directory
   end
 
   class S3
 
     def initialize(options = {
-        s3_id: Upcloudify.configuration.aws_access_key_id,
-        s3_secret: Upcloudify.configuration.aws_secret_access_key,
-        s3_directory: Upcloudify.configuration.aws_directory
+        aws_access_key_id: Upcloudify.configuration.aws_access_key_id,
+        aws_secret_access_key: Upcloudify.configuration.aws_secret_access_key,
+        aws_directory: Upcloudify.configuration.aws_directory
     })
-      @id = options[:s3_id]
-      @secret = options[:s3_secret]
-      @directory = options[:s3_directory]
+      raise ArgumentError, "aws_access_key_id is required" unless options[:aws_access_key_id]
+      raise ArgumentError, "aws_secret_access_key is required" unless options[:aws_secret_access_key]
+      raise ArgumentError, "aws_directory is required" unless options[:aws_directory]
+      @id = options[:aws_access_key_id]
+      @secret = options[:aws_secret_access_key]
+      @directory = options[:aws_directory]
     end
 
-    # Internal: Connects to Amazon S3 using stored credentials
+    # Connects to Amazon S3 using stored credentials
     # Returns an object handle for the S3 bucket-directory
-    def cloud
-      connection = Fog::Storage.new(
+    def cloud(connection = Fog::Storage.new(
         :provider                 => 'AWS',
         :aws_secret_access_key    => @secret,
         :aws_access_key_id        => @id,
       )
+    )
       directory = connection.directories.get(@directory)
       directory.files
     end
 
-    # Internal: Uploads data into Amazon S3
+    # Uploads data into Amazon S3
     # Returns an object representing the uploaded file
     def upload(filename, data)
       file = cloud.create(
-        key: "#{filename}.zip",
-        body: Zippy.new("#{filename}" => data).data,
+        :key    => "#{filename}.zip",
+        :body   => Zippy.new("#{filename}" => data).data,
         :public => false
       )
       file
     end
 
-    # Public: Uploads a file to S3 and emails a link to the file.
+    # Uploads a file to S3 and emails a link to the file.
     # Returns nothing.
     def email(email_address,
       filename,
       attachment,
       options = {
-        suffix: " generated on #{Time.now.to_s}",
+        suffix: "",
         expiration: Time.now.tomorrow,
         from: 'upcloudify',
         subject: 'your file is attached',
@@ -66,7 +70,7 @@ module Upcloudify
 
       suffix = options[:suffix]
       expiration = options[:expiration]
-      file = upload((filename.to_s + suffix.to_s).parameterize, attachment)
+      file = upload((filename.to_s + suffix.to_s), attachment)
 
       Pony.mail to: email_address,
         from: options[:from],

data/spec/spec_helper.rb

@@ -0,0 +1,96 @@
+# This file was generated by the `rspec --init` command. Conventionally, all
+# specs live under a `spec` directory, which RSpec adds to the `$LOAD_PATH`.
+# The generated `.rspec` file contains `--require spec_helper` which will cause
+# this file to always be loaded, without a need to explicitly require it in any
+# files.
+#
+# Given that it is always loaded, you are encouraged to keep this file as
+# light-weight as possible. Requiring heavyweight dependencies from this file
+# will add to the boot time of your test suite on EVERY test run, even for an
+# individual file that may not need all of that loaded. Instead, consider making
+# a separate helper file that requires the additional dependencies and performs
+# the additional setup, and require it from the spec files that actually need
+# it.
+#
+# The `.rspec` file also contains a few flags that are not defaults but that
+# users commonly want.
+#
+# See http://rubydoc.info/gems/rspec-core/RSpec/Core/Configuration
+RSpec.configure do |config|
+  # rspec-expectations config goes here. You can use an alternate
+  # assertion/expectation library such as wrong or the stdlib/minitest
+  # assertions if you prefer.
+  config.expect_with :rspec do |expectations|
+    # This option will default to `true` in RSpec 4. It makes the `description`
+    # and `failure_message` of custom matchers include text for helper methods
+    # defined using `chain`, e.g.:
+    #     be_bigger_than(2).and_smaller_than(4).description
+    #     # => "be bigger than 2 and smaller than 4"
+    # ...rather than:
+    #     # => "be bigger than 2"
+    expectations.include_chain_clauses_in_custom_matcher_descriptions = true
+  end
+
+  # rspec-mocks config goes here. You can use an alternate test double
+  # library (such as bogus or mocha) by changing the `mock_with` option here.
+  config.mock_with :rspec do |mocks|
+    # Prevents you from mocking or stubbing a method that does not exist on
+    # a real object. This is generally recommended, and will default to
+    # `true` in RSpec 4.
+    mocks.verify_partial_doubles = true
+  end
+
+# The settings below are suggested to provide a good initial experience
+# with RSpec, but feel free to customize to your heart's content.
+=begin
+  # These two settings work together to allow you to limit a spec run
+  # to individual examples or groups you care about by tagging them with
+  # `:focus` metadata. When nothing is tagged with `:focus`, all examples
+  # get run.
+  config.filter_run :focus
+  config.run_all_when_everything_filtered = true
+
+  # Allows RSpec to persist some state between runs in order to support
+  # the `--only-failures` and `--next-failure` CLI options. We recommend
+  # you configure your source control system to ignore this file.
+  config.example_status_persistence_file_path = "spec/examples.txt"
+
+  # Limits the available syntax to the non-monkey patched syntax that is
+  # recommended. For more details, see:
+  #   - http://rspec.info/blog/2012/06/rspecs-new-expectation-syntax/
+  #   - http://www.teaisaweso.me/blog/2013/05/27/rspecs-new-message-expectation-syntax/
+  #   - http://rspec.info/blog/2014/05/notable-changes-in-rspec-3/#zero-monkey-patching-mode
+  config.disable_monkey_patching!
+
+  # This setting enables warnings. It's recommended, but in some cases may
+  # be too noisy due to issues in dependencies.
+  config.warnings = true
+
+  # Many RSpec users commonly either run the entire suite or an individual
+  # file, and it's useful to allow more verbose output when running an
+  # individual spec file.
+  if config.files_to_run.one?
+    # Use the documentation formatter for detailed output,
+    # unless a formatter has already been configured
+    # (e.g. via a command-line flag).
+    config.default_formatter = 'doc'
+  end
+
+  # Print the 10 slowest examples and example groups at the
+  # end of the spec run, to help surface which specs are running
+  # particularly slow.
+  config.profile_examples = 10
+
+  # Run specs in random order to surface order dependencies. If you find an
+  # order dependency and want to debug it, you can fix the order by providing
+  # the seed, which is printed after each run.
+  #     --seed 1234
+  config.order = :random
+
+  # Seed global randomization in this process using the `--seed` CLI option.
+  # Setting this allows you to use `--seed` to deterministically reproduce
+  # test failures related to randomization by passing the same `--seed` value
+  # as the one that triggered the failure.
+  Kernel.srand config.seed
+=end
+end

data/spec/upcloudify_spec.rb

@@ -0,0 +1,47 @@
+require 'spec_helper.rb'
+require 'pry'
+require 'upcloudify'
+
+describe Upcloudify::S3 do
+  context 'sanity check' do
+    subject { Upcloudify::S3.new(
+        aws_secret_access_key: 'test_key',
+        aws_access_key_id: 'test_id',
+        aws_directory: 'test_directory'
+      )
+    }
+
+    it 'instantiates an object' do
+      expect(subject).to_not be nil
+    end
+
+    it 'raises an error when the arguments are missing' do
+      expect { subject.email }.to raise_error(ArgumentError)
+    end
+  end
+
+  context 'email' do
+    subject { Upcloudify::S3.new(
+        aws_secret_access_key: 'test_key',
+        aws_access_key_id: 'test_id',
+        aws_directory: 'test_directory'
+      )
+    }
+
+    # TODO: we should probably create an object that has this interface and mock that
+    let(:connection) { double("connection") }
+    let(:directories) { double("directories") }
+    let(:directory) { double("directory") }
+    let(:files) { double("files") }
+
+    before :each do
+      allow(connection).to receive(:directories).and_return(directories)
+      allow(directories).to receive(:get).and_return(directory)
+      allow(directory).to receive(:files).and_return(files)
+    end
+
+    it 'connects to the cloud service and returns the files in the configured directory' do
+      expect(subject.cloud(connection)).to eq files
+    end
+  end
+end

data/upcloudify.gemspec

@@ -12,7 +12,7 @@ Gem::Specification.new do |spec|
                           attachments to the cloud and emailing the recipient
                           a link to that attachment}
   spec.summary       = %q{Upload a file to the cloud and email a link for the attachment}
-  spec.homepage      = ""
+  spec.homepage      = "https://github.com/parasquid/upcloudify"
   spec.license       = "LGPLv3"
 
   spec.files         = `git ls-files`.split($/)
@@ -23,6 +23,8 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "bundler", "~> 1.3"
   spec.add_development_dependency "rake"
   spec.add_development_dependency "pry"
+  spec.add_development_dependency "rspec"
+  spec.add_development_dependency "guard-rspec"
 
   spec.add_dependency 'gem_config'
   spec.add_dependency 'pony'

metadata

@@ -1,139 +1,167 @@
 --- !ruby/object:Gem::Specification
 name: upcloudify
 version: !ruby/object:Gem::Version
-  version: 0.1.2
+  version: 0.1.3
 platform: ruby
 authors:
 - parasquid
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-12-09 00:00:00.000000000 Z
+date: 2015-11-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.3'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.3'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: pry
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: rspec
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: guard-rspec
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: gem_config
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: pony
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: zippy
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: zip-zip
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: fog
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: activesupport
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 description: |-
@@ -146,18 +174,23 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- .gitignore
+- ".gitignore"
+- ".rspec"
 - Gemfile
+- Guardfile
 - LICENSE.txt
 - README.md
 - Rakefile
+- lib/monkey_patches.rb
 - lib/upcloudify.rb
 - lib/upcloudify/version.rb
 - sample_app/Gemfile
 - sample_app/sample.rb
 - sample_app/views/index.erb
+- spec/spec_helper.rb
+- spec/upcloudify_spec.rb
 - upcloudify.gemspec
-homepage: ''
+homepage: https://github.com/parasquid/upcloudify
 licenses:
 - LGPLv3
 metadata: {}
@@ -167,18 +200,20 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.2
+rubygems_version: 2.4.8
 signing_key: 
 specification_version: 4
 summary: Upload a file to the cloud and email a link for the attachment
-test_files: []
+test_files:
+- spec/spec_helper.rb
+- spec/upcloudify_spec.rb