unreliable 0.9.1 → 0.10.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 9b11225a3c1dad62d2a283c3eb36fef7b69fda61815df13a860ce9c1970016eb
-  data.tar.gz: 1994dd9ea21ba01dc839c56cc08ca91742465dc9b850c0b6a5eebbc81c7558a2
+  metadata.gz: f3cf18102610d7a8a8c380f39bad81db77ed33392ecc8dffcdc99ef7c60d222e
+  data.tar.gz: b99100338674b31fbb11036b56ce1443006d1281e5641a0b4f200bbe7a22e832
 SHA512:
-  metadata.gz: 145d5bbe8790fe4ee33bf4f0ea874350edf9655c2ebed35bfb3f18acb123d03efbe86c826dd0d9d4ca7ff12938c368e5cc4ebdc7afba224e0a8c12669a92e816
-  data.tar.gz: 2a3ca2dfa53cbf67a0f8a6b7128df829874409a698586c15d10746624a71a18eddc77914768ec5da361541aa54706bd1899f473aa1f6093ec839f689428b36ed
+  metadata.gz: 96139a8994cdb3badf0f80e3bc96c94c375864f9973d9b85b56fa6ad97486001dbaa56e24b42cdb2d4ba7d051a22877851fac26a5a993b07773984521cb456e2
+  data.tar.gz: 890b786b597e60b980937d792555a3666082f7d38ab6e6b1113acdfb01adc5ec6596ef59ed2041a89215526c2ca8dacccef1184967db68356f178155617d3aaa

data/CHANGELOG.md

@@ -1,3 +1,11 @@
+## Unreliable 0.10.0 (January 15, 2024) ##
+
+### Changed
+
+* Rails 5.0 and 5.1 compatibility removed due to bug in interaction with Arel 8. This is not a breaking change because it didn't work before. If you must run Rails < 5.2, do not use Unreliable.
+* PostgreSQL bug with SELECT DISTINCT fixed (#10).
+* Many tests added; CI dockerized; test suite runs against SQLite, PostgreSQL, and MySQL (#3).
+
 ## Unreliable 0.9.1 (November 21, 2022) ##
 
 ### Changed

data/README.md

@@ -15,7 +15,7 @@ Add `unreliable` to your `Gemfile`'s `test` group:
 # Gemfile
 
 group :test do
-  gem "unreliable", "~> 0.1"
+  gem "unreliable", "~> 0.10"
 end
 ```
 
@@ -27,17 +27,26 @@ Here's an [open secret](#references): **relational databases do not guarantee th
 
 If all your ActiveRecord ordering is already unambiguous, congratulations! `unreliable` will have no effect.
 
-But sometimes we think we specified an unambiguous order, but didn't. Maybe we ordered on timestamps, which are usually unique but sometimes not. And the test suite will stay silent as long as our database just happens to return the same order.
+But sometimes... we think we specified an unambiguous order, but we didn't. For example, maybe we ordered on timestamps, which are usually unique but sometimes not.
 
-If ambiguous ordering is fine for your app's purposes, but your tests rely on a specific order, that's a bug in your tests. Your tests are incorrectly failing -- rarely -- which can be confusing and annoying.
+The test suite will stay silent about that, as long as our database just happens to return the same order. That silence is a problem.
 
-Or, if your Rails code relies on that accidental ordering, that's a bug in your app. Your tests are passing when they should be failing.
+If ambiguous ordering is fine for your app's purposes, but your tests rely on a specific order, that's a **bug in your tests**. Your tests are incorrectly failing -- rarely -- which can be confusing and annoying.
+
+Or, if your Rails code relies on that accidental ordering, that's a **bug in your app**. Your tests are passing when they should be failing.
 
 In both cases, `unreliable` exposes the problem by making those tests fail most of the time.
 
 ## Fixing the new failures
 
-When `unreliable` turns up a new test failure, you fix it in one of two ways. Either relax your test so it stops relying on order, or tighten up your app to specify order rigorously. (In my company's app, it was about 50/50.)
+When `unreliable` turns up a new test failure, you fix it in one of two ways.
+
+Either:
+
+ * relax your test so it stops relying on order,
+ * or tighten up your app to specify order rigorously.
+
+In my company's app, it was about 50/50.
 
 ### Relax a test
 
@@ -45,7 +54,7 @@ Take a look at what your test is checking. If you're testing a method or an endp
 
 * Make your test accept all correct answers. For example, sort an array in the method's response before comparing.
 
-* Help your test suite focus on what you're testing. If your fixtures' "latest" element could change because they don't specify a timestamp, that might be a distraction that's not relevant to how your app works, so you could assign timestamps to the fixtures.
+* Help your test suite focus on what you're testing. If your fixtures' "latest" element could change because they don't specify a timestamp, that might be a distraction that's not relevant to how your app works, so you could assign unique timestamps to the fixtures.
 
 This makes your test suite more robust.
 
@@ -53,7 +62,9 @@ If your test suite is checking generated `.to_sql` against known-good SQL text,
 
 ### Tighten the app
 
-If your app should be returning results in a particular order, and now with `unreliable` it sometimes does not, your test is correct and your app is wrong. Specify order rigorously in your app.
+If your app should be returning results in a particular order, and now with `unreliable` it sometimes does not, your test is correct and your app is wrong.
+
+Specify order rigorously in your app.
 
 Maybe you're testing `Book.reverse_chron.first`, and you've defined that ordering this way:
 
@@ -75,19 +86,23 @@ Or, if `title` is not unique:
   scope :reverse_chron, -> { order(year_published: :desc, title: :desc, id: :desc) }
 ```
 
-The problem in this example is easy to see because many books are published each year. But this error can occur at any time granularity.
+This example's problem is easy to see because many books are published each year.
+
+But this error can occur at any granularity, in time or other data types.
 
 ## Requirements
 
-`unreliable` is tested to support Ruby 2.6 through 3.1, and Rails 5.0 through 7.0.
+`unreliable` is tested on every valid combination of:
 
-As of November 2022, this is all released versions of both that are currently supported, plus several older releases.
+ * sqlite, postgresql, and mysql2 adapters
+ * Ruby 2.6 through 3.3
+ * Rails 5.2 through 7.1
 
 `unreliable` depends only on ActiveRecord and Railties. If you have a non-Rails app that uses ActiveRecord, you can still use it.
 
 ## Implementation
 
-`unreliable` does exactly nothing outside of test environments. There is intentionally no way to enable `unreliable` in production, and there never will be.
+`unreliable` does exactly nothing outside of test environments. There is intentionally no way to enable it in production, and there never will be.
 
 In a Rails test environment, `unreliable` patches ActiveRecord to append a final `ORDER BY` clause, when necessary, that returns results in a random order.
 
@@ -101,47 +116,41 @@ This means that the `ORDER BY` applies to not just `SELECT` but e.g. `delete_all
 
 The patch is only applied when `Rails.env.test?`, and that boolean is also checked on every invocation, just to make certain it has no effect in any other environment.
 
+The gem has a large test suite that checks for correctness at several abstraction layers inside ActiveRecord. It ensures the correct SQL is generated and that it executes correctly.
+
 ### No dual-purpose environment please
 
-Your test environment is just for running your test suite. If you've overloaded the test environment to do any actual work, you'd be frustrated when `unreliable` slows it down and changes its behavior, so don't install it (yet).
+Your test environment is just for running your test suite. If you've overloaded the test environment to do any actual work, you'll be frustrated when `unreliable` slows it down and changes its behavior. Don't do that.
 
 ## Contributing
 
-Thoughts and suggestions are welcome. Please read the code of conduct, then create an issue or pull request on GitHub. If you just have questions, go ahead and open an issue, I'm pretty friendly.
+Thoughts and suggestions are welcome. Please read the code of conduct, then create an issue or pull request on GitHub. If you just have questions, please go ahead and open an issue!
 
 ### Run the gem's tests
 
-To test locally, against the different versions of ActiveRecord, use Ruby 2.7, the only version currently compatible with all the ActiveRecord versions supported. Install the required gems with:
-
-```
-gem install bundler
-bundle install
-bundle exec appraisal install
-```
+To test locally, see the hint at the top of `compose.yaml` to spin up docker containers.
 
-Run `unreliable`'s linter with:
+After you spin up the containers and open a shell in the app container, run `unreliable`'s linter with:
 
 ```
-bundle exec standardrb
+standardrb
 ```
 
-Then you can run `unreliable`'s tests with:
+Run its tests in three separate passes:
 
 ```
-bundle exec appraisal rake
+RSPEC_ADAPTER=sqlite bundle exec rake
+RSPEC_ADAPTER=postgresql bundle exec rake
+RSPEC_ADAPTER=mysql2 bundle exec rake
 ```
 
-Appraisal ensures the tests run against every compatible minor version of ActiveRecord.
-
 The GitHub CI workflow in `.github/` ensures those tests are also run against against every compatible minor version of Ruby. Your PR won't trigger my GitHub project's workflow, but you're welcome to run your own, or ask me to run mine manually.
 
-Testing against ActiveRecord is done with [Combustion](https://github.com/pat/combustion), which stands up a local SQLite database and ActiveRecord-based models for it. This gives more reliable coverage than mocking unit tests within ActiveRecord itself, though I do some of that too.
-
 ### Experiment
 
 If you'd like to see `unreliable` in action on a small but real Rails app locally, you can do this:
 
-1. In a directory next to your `unreliable` working directory, create a `.ruby-version` of `2.7.6` and a 2-line `Gemfile`: `source "https://rubygems.org"`, `gem "rails", "~> 7.0"`
+1. In a directory next to your `unreliable` working directory, create a `.ruby-version` of `2.7.8` and a 2-line `Gemfile`: `source "https://rubygems.org"`, `gem "rails", "~> 7.0"`
 2. `bundle install && bundle exec rails new . --force`
 3. `echo 'gem "unreliable", path: "../unreliable"' >> Gemfile`
 4. `bundle install && bundle exec rails generate model post title:string body:text`
@@ -166,8 +175,8 @@ The most common ambiguous ordering is an ORDER BY one column that is not unique,
 But there are other ways you can order a relation but still have your query be ambiguous:
 
 * ORDER BY multiple columns, but with no subset which is unique
-* ORDER BY a column with values that differ only by [character case](https://dev.mysql.com/doc/refman/8.0/en/sorting-rows.html)
-* ORDER BY values that are identical within the [prefix length limit](https://dev.mysql.com/doc/refman/8.0/en/server-system-variables.html#sysvar_max_sort_length) examined for sorting
+* ORDER BY a column your [pre-Rails-6.1](https://guides.rubyonrails.org/6_1_release_notes.html#active-record-notable-changes) application thought was unique, but currently isn't, due to your non-UNIQUE database column's accent- or case-insensitive [collation](https://dev.mysql.com/doc/refman/8.0/en/charset-general.html)
+* ORDER BY values that are identical only within the [prefix length limit](https://dev.mysql.com/doc/refman/8.0/en/server-system-variables.html#sysvar_max_sort_length) examined for sorting
 
 `unreliable` ensures correct testing because it appends a random order to each of these cases.
 
@@ -181,11 +190,11 @@ MySQL ([5.6](https://dev.mysql.com/doc/refman/5.6/en/limit-optimization.html), [
 
 > If multiple rows have identical values in the `ORDER BY` columns, the server is free to return those rows in any order, and may do so differently depending on the overall execution plan. In other words, the sort order of those rows is nondeterministic with respect to the nonordered columns.
 
-Postgres ([12](https://www.postgresql.org/docs/12/sql-select.html#SQL-ORDERBY), [13](https://www.postgresql.org/docs/13/sql-select.html#SQL-ORDERBY), [14](https://www.postgresql.org/docs/14/sql-select.html#SQL-ORDERBY)):
+Postgres ([13](https://www.postgresql.org/docs/13/sql-select.html#SQL-ORDERBY), [14](https://www.postgresql.org/docs/14/sql-select.html#SQL-ORDERBY), [15](https://www.postgresql.org/docs/15/sql-select.html#SQL-ORDERBY), [16](https://www.postgresql.org/docs/16/sql-select.html#SQL-ORDERBY)):
 
 > If two rows are equal according to the leftmost expression, they are compared according to the next expression and so on. If they are equal according to all specified expressions, they are returned in an implementation-dependent order.
 
-SQLite ([3.39](https://www.sqlite.org/lang_select.html#the_order_by_clause)):
+SQLite ([3.45](https://www.sqlite.org/lang_select.html#the_order_by_clause)):
 
 > The order in which two rows for which all ORDER BY expressions evaluate to equal values are returned is undefined.
 

data/Rakefile

@@ -1,5 +1,7 @@
 # frozen_string_literal: true
 
+require "bundler/gem_tasks"
+
 begin
   require "rspec/core/rake_task"
 

data/lib/unreliable/build_order.rb

@@ -9,17 +9,19 @@ module Unreliable
     def build_order(arel)
       super(arel)
 
+      adapter_name = Arel::Table.engine.connection.adapter_name
       return unless Unreliable::Config.enabled?
+      return if distinct_on_postgres?(adapter_name)
       return if from_only_internal_metadata?(arel)
       return if from_one_table_with_ordered_pk?(arel)
 
-      case Arel::Table.engine.connection.adapter_name
+      case adapter_name
       when "Mysql2"
         # https://dev.mysql.com/doc/refman/8.0/en/mathematical-functions.html#function_rand
         arel.order("RAND()")
 
       when "PostgreSQL", "SQLite"
-        # https://www.postgresql.org/docs/13/functions-math.html#FUNCTIONS-MATH-RANDOM-TABLE
+        # https://www.postgresql.org/docs/16/functions-math.html#FUNCTIONS-MATH-RANDOM-TABLE
         # https://www.sqlite.org/lang_corefunc.html#random
         arel.order("RANDOM()")
 
@@ -29,6 +31,10 @@ module Unreliable
       end
     end
 
+    def distinct_on_postgres?(adapter_name)
+      distinct_value && adapter_name == "PostgreSQL"
+    end
+
     def from_only_internal_metadata?(arel)
       # No need to randomize queries on ar_internal_metadata
       arel.froms.map(&:name) == [ActiveRecord::Base.internal_metadata_table_name]

data/lib/unreliable/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Unreliable
-  VERSION = "0.9.1"
+  VERSION = "0.10.0"
 end

data/spec/adapter_option_spec.rb

@@ -0,0 +1,7 @@
+# frozen_string_literal: true
+
+RSpec.describe "rspec adapter" do
+  it "is as specified" do
+    expect(ActiveRecord::Base.connection.adapter_name.downcase).to eq(UnreliableTest.find_adapter)
+  end
+end

data/spec/env_spec.rb

@@ -3,14 +3,14 @@
 RSpec.describe Unreliable do
   it "does nothing in prod" do
     Rails.env = "production"
-    expect(Cat.where(word: "foo").to_sql).to end_with(%q(WHERE "cats"."word" = 'foo'))
+    expect(Cat.where(word: "foo").to_sql).to end_with(adapter_text(%q(WHERE "cats"."word" = 'foo')))
   ensure
     Rails.env = "test"
   end
 
   it "does nothing in dev" do
     Rails.env = "development"
-    expect(Cat.where(word: "foo").to_sql).to end_with(%q(WHERE "cats"."word" = 'foo'))
+    expect(Cat.where(word: "foo").to_sql).to end_with(adapter_text(%q(WHERE "cats"."word" = 'foo')))
   ensure
     Rails.env = "test"
   end

data/spec/execute_queries_spec.rb

@@ -0,0 +1,125 @@
+# frozen_string_literal: true
+
+class CatTest < UnreliableTest
+  # 12 factorial is about half a billion possible shuffles
+  NAMES = %w[angus Rashad bertha harry moka bubbles Morty Tofu Purrito Neffy Zoe stinky].freeze
+  RESPONSE_COUNT = 10
+end
+
+RSpec.describe Cat do
+  it "adds and selects all cats" do
+    expect(Cat.count).to eq(0)
+    CatTest::NAMES.shuffle.each { |name| Cat.new(name: name).save! }
+    expect(Cat.all.to_a.size).to eq(CatTest::NAMES.size)
+  ensure
+    Cat.delete_all
+  end
+
+  it "adds, updates-via-instance, and selects some cats" do
+    expect(Cat.count).to eq(0)
+    CatTest::NAMES.shuffle.each { |name| Cat.new(name: name).save! }
+    expect(Cat.where(name: "Rashad").to_a.size).to eq(1)
+    expect(Cat.where("name LIKE '%a%'").to_a.size).to eq(5)
+    Cat.find_by(name: "harry").destroy!
+    expect(Cat.where("name LIKE '%a%'").to_a.size).to eq(4)
+    Cat.where("name NOT LIKE '%a%'").first.update!(name: "Mantissa")
+    expect(Cat.where("name LIKE '%a%'").to_a.size).to eq(5)
+  ensure
+    Cat.delete_all
+  end
+
+  it "adds, updates-via-class, and selects some cats" do
+    expect(Cat.count).to eq(0)
+    CatTest::NAMES.shuffle.each { |name| Cat.new(name: name).save! }
+    expect(Cat.where(name: "Rashad").to_a.size).to eq(1)
+    expect(Cat.where("name LIKE '%a%'").to_a.size).to eq(5)
+    Cat.find_by(name: "harry").destroy!
+    expect(Cat.where("name LIKE '%a%'").to_a.size).to eq(4)
+    Cat.update(Cat.where("name NOT LIKE '%a%'").pluck(:id).first, name: "Mantissa")
+    expect(Cat.where("name LIKE '%a%'").to_a.size).to eq(5)
+  ensure
+    Cat.delete_all
+  end
+
+  it "adds and selects all ordered data unpredictably" do
+    expect(Cat.count).to eq(0)
+    CatTest::NAMES.shuffle.each { |name| Cat.new(name: name).save! }
+    responses = (1..CatTest::RESPONSE_COUNT).map do
+      Cat.all.map(&:name).join(":")
+    end
+    # The chances that there's one repeat in 10 randomly-ordered SELECTs
+    # is about 1 in ten billion, and we allow for that. The chances that
+    # there's two and this test incorrectly fails is in the quintillionths.
+    expect(responses.uniq.size).to(satisfy { |v| v >= 9 })
+  ensure
+    Cat.delete_all
+  end
+
+  it "adds and selects some ordered data unpredictably" do
+    expect(Cat.count).to eq(0)
+    CatTest::NAMES.shuffle.each { |name| Cat.new(name: name).save! }
+    responses = (1..CatTest::RESPONSE_COUNT).map do
+      Cat.where.not(name: "bubbles").map(&:name).join(":")
+    end
+    expect(responses.uniq.size).to(satisfy { |v| v >= 8 })
+  ensure
+    Cat.delete_all
+  end
+
+  it "adds and selects all ordered data predictably with order by id" do
+    expect(Cat.count).to eq(0)
+    CatTest::NAMES.shuffle.each { |name| Cat.new(name: name).save! }
+    responses = (1..CatTest::RESPONSE_COUNT).map do
+      Cat.order(:id).map(&:name).join(":")
+    end
+    expect(responses.uniq.size).to eq(1)
+  ensure
+    Cat.delete_all
+  end
+
+  it "adds and selects all ordered data predictably with order by name" do
+    expect(Cat.count).to eq(0)
+    CatTest::NAMES.shuffle.each { |name| Cat.new(name: name).save! }
+    responses = (1..CatTest::RESPONSE_COUNT).map do
+      Cat.order(:name).map(&:name).join(":")
+    end
+    expect(responses.uniq.size).to eq(1)
+  ensure
+    Cat.delete_all
+  end
+
+  it "adds and selects some ordered data predictably with order" do
+    expect(Cat.count).to eq(0)
+    CatTest::NAMES.shuffle.each { |name| Cat.new(name: name).save! }
+    responses = (1..CatTest::RESPONSE_COUNT).map do
+      Cat.where.not(name: "Groovy").order(:id).map(&:name).join(":")
+    end
+    expect(responses.uniq.size).to eq(1)
+  ensure
+    Cat.delete_all
+  end
+
+  it "adds and selects all ordered data predictably with disable" do
+    expect(Cat.count).to eq(0)
+    CatTest::NAMES.shuffle.each { |name| Cat.new(name: name).save! }
+    responses =
+      Unreliable::Config.disable do
+        (1..CatTest::RESPONSE_COUNT).map do
+          Cat.all.map(&:name).join(":")
+        end
+      end
+    # This is testing the actual undefined database behavior that Unreliable
+    # was created to account for! In practice it's quite rare to observe
+    # differing results on sequential SELECTs. I can't quantify the chances
+    # of it like I can with expected-truly-random behavior above, but I'm
+    # making an educated guess here and saying if we see more than 3 of 10,
+    # something went wrong with the gem disabling its behavior. But because
+    # database and protocol documentation all says it can do whatever it
+    # wants, the number of unique responses might be up to RESPONSE_COUNT!
+    # If this test fails erroneously basically ever, I would think it
+    # should be rewritten or removed!
+    expect(responses.uniq.size).to(satisfy { |v| v <= 3 })
+  ensure
+    Cat.delete_all
+  end
+end

data/spec/execute_subqueries_spec.rb

@@ -0,0 +1,46 @@
+# frozen_string_literal: true
+
+class DreamTest < UnreliableTest
+  SUBJECTS = %w[fire air water earth life death].freeze
+  DREAMER_NAMES = %w[Morpheus Cluracan Mervyn Gilbert Nuala].freeze
+  raise ArgumentError, "DreamTest needs at least as many subjects as dreamers" if SUBJECTS.size < DREAMER_NAMES.size
+end
+
+RSpec.describe Dream do
+  it "adds and selects all dreams and dreamers" do
+    expect(Dream.count).to eq(0)
+    DreamTest::SUBJECTS.shuffle.each { |subject| Dream.new(subject: subject).save! }
+    expect(Dream.all.to_a.size).to eq(DreamTest::SUBJECTS.size)
+    DreamTest::DREAMER_NAMES.shuffle.each do |name|
+      dream = Dream.find_by(subject: DreamTest::SUBJECTS.sample)
+      Dreamer.new(name: name, dream: dream).save!
+    end
+    expect(Dreamer.all.to_a.size).to eq(DreamTest::DREAMER_NAMES.size)
+  ensure
+    Dreamer.delete_all
+    Dream.delete_all
+  end
+
+  it "deletes some dreams and dreamers" do
+    expect(Dream.count).to eq(0)
+    DreamTest::SUBJECTS.shuffle.each { |subject| Dream.new(subject: subject).save! }
+    expect(Dream.all.to_a.size).to eq(DreamTest::SUBJECTS.size)
+
+    one_dream_subject_per_dreamer = DreamTest::SUBJECTS.shuffle
+    DreamTest::DREAMER_NAMES.shuffle.each do |dreamer_name|
+      expect(one_dream_subject_per_dreamer.size).to(satisfy { |v| v > 0 })
+      dream = Dream.find_by(subject: one_dream_subject_per_dreamer.shift)
+      Dreamer.new(name: dreamer_name, dream: dream).save!
+    end
+    expect(Dreamer.all.to_a.size).to eq(DreamTest::DREAMER_NAMES.size)
+    expect(Dream.all.pluck(:dreamer_id).compact.size).to eq(DreamTest::DREAMER_NAMES.size)
+
+    sample_dreamer = Dreamer.find_by(name: DreamTest::DREAMER_NAMES.sample)
+    expect(Dream.where(dreamer: sample_dreamer).to_a.size).to eq(1)
+    Dream.where(dreamer: sample_dreamer).delete_all
+    expect(Dream.all.size).to eq(DreamTest::SUBJECTS.size - 1)
+  ensure
+    Dreamer.delete_all
+    Dream.delete_all
+  end
+end

data/spec/model_indexes_books_spec.rb

@@ -2,14 +2,14 @@
 
 RSpec.describe "model_indexes_books" do
   it "randomly selects from books with no order" do
-    expect(Book.all.to_sql).to end_with("ORDER BY RANDOM()")
+    expect(Book.all.to_sql).to end_with(adapter_text("ORDER BY RANDOM()"))
   end
 
   it "randomly selects from books ordered by nonindexed column" do
-    expect(Book.all.order(:subject).to_sql).to end_with('ORDER BY "books"."subject" ASC, RANDOM()')
+    expect(Book.all.order(:subject).to_sql).to end_with(adapter_text('ORDER BY "books"."subject" ASC, RANDOM()'))
   end
 
   it "randomly selects from books ordered by unique column" do
-    expect(Book.all.order(:isbn).to_sql).to end_with('ORDER BY "books"."isbn" ASC, RANDOM()')
+    expect(Book.all.order(:isbn).to_sql).to end_with(adapter_text('ORDER BY "books"."isbn" ASC, RANDOM()'))
   end
 end

data/spec/model_indexes_cats_spec.rb

@@ -2,10 +2,10 @@
 
 RSpec.describe "model_indexes_cats" do
   it "randomly selects from cats" do
-    expect(Cat.all.to_sql).to end_with("ORDER BY RANDOM()")
+    expect(Cat.all.to_sql).to end_with(adapter_text("ORDER BY RANDOM()"))
   end
 
   it "nonrandomly selects from cats by implied primary key descending" do
-    expect(Cat.all.order(id: :desc).to_sql).to end_with('ORDER BY "cats"."id" DESC')
+    expect(Cat.all.order(id: :desc).to_sql).to end_with(adapter_text('ORDER BY "cats"."id" DESC'))
   end
 end

data/spec/model_indexes_dreams_spec.rb

@@ -2,10 +2,10 @@
 
 RSpec.describe "model_indexes_dreams" do
   it "randomly selects from dreams ordered by nonindexed column" do
-    expect(Dream.all.order(:subject).to_sql).to end_with('ORDER BY "dreams"."subject" ASC, RANDOM()')
+    expect(Dream.all.order(:subject).to_sql).to end_with(adapter_text('ORDER BY "dreams"."subject" ASC, RANDOM()'))
   end
 
   it "nonrandomly selects from dreams by explicit primary key" do
-    expect(Dream.all.order(:dream_id).to_sql).to end_with('ORDER BY "dreams"."dream_id" ASC')
+    expect(Dream.all.order(:dream_id).to_sql).to end_with(adapter_text('ORDER BY "dreams"."dream_id" ASC'))
   end
 end

data/spec/model_indexes_shelves_spec.rb

@@ -2,32 +2,32 @@
 
 RSpec.describe "model_indexes_shelves" do
   it "randomly selects from shelves" do
-    expect(Shelf.all.to_sql).to end_with("ORDER BY RANDOM()")
+    expect(Shelf.all.to_sql).to end_with(adapter_text("ORDER BY RANDOM()"))
   end
 
   it "randomly selects from some shelves" do
-    expect(Shelf.where(contents: "foo").to_sql).to end_with("ORDER BY RANDOM()")
+    expect(Shelf.where(contents: "foo").to_sql).to end_with(adapter_text("ORDER BY RANDOM()"))
   end
 
   it "randomly selects from shelves ordered by id" do
-    expect(Shelf.order(:shelf_id).to_sql).to end_with('ORDER BY "shelves"."shelf_id" ASC, RANDOM()')
+    expect(Shelf.order(:shelf_id).to_sql).to end_with(adapter_text('ORDER BY "shelves"."shelf_id" ASC, RANDOM()'))
   end
 
   it "randomly selects from shelves ordered by position" do
     expect(Shelf.order(:shelf_position).to_sql).to end_with(
-      'ORDER BY "shelves"."shelf_position" ASC, RANDOM()'
+      adapter_text('ORDER BY "shelves"."shelf_position" ASC, RANDOM()')
     )
   end
 
   it "nonrandomly selects from shelves ordered by id and position" do
     expect(Shelf.order(:shelf_id, :shelf_position).to_sql).to end_with(
-      'ORDER BY "shelves"."shelf_id" ASC, "shelves"."shelf_position" ASC'
+      adapter_text('ORDER BY "shelves"."shelf_id" ASC, "shelves"."shelf_position" ASC')
     )
   end
 
   it "nonrandomly selects from some shelves ordered by id and position" do
     expect(Shelf.where(contents: "bar").order(:shelf_id, :shelf_position).to_sql).to end_with(
-      'ORDER BY "shelves"."shelf_id" ASC, "shelves"."shelf_position" ASC'
+      adapter_text('ORDER BY "shelves"."shelf_id" ASC, "shelves"."shelf_position" ASC')
     )
   end
 end

data/spec/model_joins_spec.rb

@@ -6,22 +6,22 @@
 
 RSpec.describe "model_indexes_joins" do
   it "randomly selects from owner has_many cats" do
-    expect(Owner.joins(:cats).all.to_sql).to end_with("ORDER BY RANDOM()")
+    expect(Owner.joins(:cats).all.to_sql).to end_with(adapter_text("ORDER BY RANDOM()"))
   end
 
   it "randomly selects from owner has_many ordered cats" do
-    expect(Owner.joins(:cats).order("owners.id": :asc).all.to_sql).to end_with(", RANDOM()")
-    expect(Owner.joins(:cats).order(:"cats.id").all.to_sql).to end_with(", RANDOM()")
-    expect(Owner.joins(:cats).order(:"owners.id", "cats.id": :desc).all.to_sql).to end_with(", RANDOM()")
-    expect(Owner.joins(:cats).order(:"owners.id", :"cats.name").all.to_sql).to end_with(", RANDOM()")
+    expect(Owner.joins(:cats).order("owners.id": :asc).all.to_sql).to end_with(adapter_text(", RANDOM()"))
+    expect(Owner.joins(:cats).order(:"cats.id").all.to_sql).to end_with(adapter_text(", RANDOM()"))
+    expect(Owner.joins(:cats).order(:"owners.id", "cats.id": :desc).all.to_sql).to end_with(adapter_text(", RANDOM()"))
+    expect(Owner.joins(:cats).order(:"owners.id", :"cats.name").all.to_sql).to end_with(adapter_text(", RANDOM()"))
   end
 
   it "randomly selects from dreamer has_one dream" do
-    expect(Dreamer.joins(:dream).all.to_sql).to end_with("ORDER BY RANDOM()")
+    expect(Dreamer.joins(:dream).all.to_sql).to end_with(adapter_text("ORDER BY RANDOM()"))
   end
 
   it "randomly selects from dreamer has_one ordered dream" do
-    expect(Dreamer.joins(:dream).order("dreamers.id": :desc).all.to_sql).to end_with(", RANDOM()")
-    expect(Dreamer.joins(:dream).order(:"dreams.id").all.to_sql).to end_with(", RANDOM()")
+    expect(Dreamer.joins(:dream).order("dreamers.id": :desc).all.to_sql).to end_with(adapter_text(", RANDOM()"))
+    expect(Dreamer.joins(:dream).order(:"dreams.id").all.to_sql).to end_with(adapter_text(", RANDOM()"))
   end
 end

data/spec/model_select_distinct_spec.rb

@@ -0,0 +1,48 @@
+# frozen_string_literal: true
+
+RSpec.describe Cat do
+  it "randomly selects distinctly except on postgres" do
+    expect(Cat.distinct.all.to_sql).to end_with(
+      case UnreliableTest.find_adapter
+      when "postgresql"
+        ' FROM "cats"'
+      else
+        adapter_text("ORDER BY RANDOM()")
+      end
+    )
+  end
+
+  it "randomly selects distinctly from some" do
+    expect(Cat.where(name: "foo").distinct.to_sql).to end_with(
+      case UnreliableTest.find_adapter
+      when "postgresql"
+        %q( "cats"."name" = 'foo')
+      else
+        adapter_text("ORDER BY RANDOM()")
+      end
+    )
+  end
+
+  it "adds randomness to existing distinct order" do
+    expect(Cat.order(:name).distinct.to_sql).to end_with(
+      case UnreliableTest.find_adapter
+      when "postgresql"
+        ' ORDER BY "cats"."name" ASC'
+      else
+        adapter_text('ORDER BY "cats"."name" ASC, RANDOM()')
+      end
+    )
+  end
+
+  it "executes a distinct" do
+    expect(Cat.distinct.count).to eq(0)
+    Cat.new(name: "Chet").save!
+    Cat.new(name: "Cab").save!
+    Cat.new(name: "Oscar").save!
+    Cat.new(name: "Chet").save!
+    expect(Cat.select(:name).to_a.size).to eq(4)
+    expect(Cat.select(:name).distinct.to_a.size).to eq(3)
+  ensure
+    Cat.delete_all
+  end
+end

data/spec/model_select_spec.rb

@@ -2,21 +2,21 @@
 
 RSpec.describe Cat do
   it "randomly selects from all" do
-    expect(Cat.all.to_sql).to end_with("ORDER BY RANDOM()")
+    expect(Cat.all.to_sql).to end_with(adapter_text("ORDER BY RANDOM()"))
   end
 
   it "randomly selects from some" do
-    expect(Cat.where(name: "foo").to_sql).to end_with("ORDER BY RANDOM()")
+    expect(Cat.where(name: "foo").to_sql).to end_with(adapter_text("ORDER BY RANDOM()"))
   end
 
   it "adds randomness to existing order" do
-    expect(Cat.order(:name).to_sql).to end_with('ORDER BY "cats"."name" ASC, RANDOM()')
+    expect(Cat.order(:name).to_sql).to end_with(adapter_text('ORDER BY "cats"."name" ASC, RANDOM()'))
   end
 
   it "respects a disable block" do
     Unreliable::Config.disable do
-      expect(Cat.where(name: "foo").to_sql).to_not end_with("ORDER BY RANDOM()")
-      expect(Cat.where(name: "foo").to_sql).to end_with(%q("cats"."name" = 'foo'))
+      expect(Cat.where(name: "foo").to_sql).to_not end_with(adapter_text("ORDER BY RANDOM()"))
+      expect(Cat.where(name: "foo").to_sql).to end_with(adapter_text(%q("cats"."name" = 'foo')))
     end
   end
 end

data/spec/model_subquery_spec.rb

@@ -4,7 +4,7 @@ RSpec.describe Cat do
   it "randomly selects in main query and subquery" do
     # rubocop:disable Layout/SpaceInsideParens,Layout/DotPosition
     expect( Cat.where(name: Cat.where(name: "foo")).to_sql ).
-      to end_with( %q[WHERE "cats"."name" = 'foo' ORDER BY RANDOM()) ORDER BY RANDOM()] )
+      to end_with(adapter_text( %q[WHERE "cats"."name" = 'foo' ORDER BY RANDOM()) ORDER BY RANDOM()] ))
     # rubocop:enable Layout/SpaceInsideParens,Layout/DotPosition
   end
 end

data/spec/model_update_arel_10_spec.rb

@@ -4,6 +4,15 @@
 # by build_arel. It returns an Arel::UpdateManager. This makes sure that internal call
 # assembles the update query correctly.
 
+# For three of the four tests in this file, we special-case MySQL to check for the
+# different query it produces. The reason MySQL is handled differently is described
+# in Arel 10 here:
+# https://github.com/rails/rails/blob/v7.1.2/activerecord/lib/arel/visitors/to_sql.rb#L924-L942
+# As it says, MySQL forbids using the *same* table in a subquery UPDATE:
+# https://dev.mysql.com/doc/refman/8.0/en/subquery-errors.html
+# Different tables are allowed though, as in our "update cats where id in (select owners..."
+# test below.
+
 module Unreliable
   class SqlTestingData
     class_attribute :update_manager_sql
@@ -11,7 +20,7 @@ module Unreliable
 end
 
 RSpec.describe "update_manager" do
-  it "in ActiveRecord >= 7, updates by subquery with select in random order",
+  it "in ActiveRecord >= 7, updates by subquery with select",
     skip: ((ActiveRecord::VERSION::MAJOR < 7) ? "test is for ActiveRecord >= 7 only" : false) do
     module Arel
       class SelectManager
@@ -24,12 +33,66 @@ RSpec.describe "update_manager" do
         alias_method :compile_update, :testing_compile_update
       end
     end
-    Cat.update_all(name: "bar")
-    expect(Unreliable::SqlTestingData.update_manager_sql).to end_with("ORDER BY RANDOM())")
+
+    # rubocop:disable Layout/SpaceInsideParens,Layout/DotPosition
+
+    # Single subquery for sqlite/postgresql:
+    #   "update cats where id in (select cats where name=bar)"
+    # Direct update for mysql:
+    #   "update cats where name=bar"
+
     Cat.where(name: "foo").update_all(name: "bar")
-    expect(Unreliable::SqlTestingData.update_manager_sql).to end_with("ORDER BY RANDOM())")
-    Cat.where(name: "bar").order(:id).update_all(name: "baz")
-    expect(Unreliable::SqlTestingData.update_manager_sql).to end_with("ORDER BY \"cats\".\"id\" ASC)")
+    expect(Unreliable::SqlTestingData.update_manager_sql).
+      to end_with(
+        case UnreliableTest.find_adapter
+        when "mysql2"
+          "ORDER BY RAND()"
+        else
+          adapter_text("ORDER BY RANDOM())")
+        end
+      )
+
+    # Double-nested subquery for sqlite/postgresql:
+    #   "update cats where id in (select cats where id in (select owners where name=baz))"
+    # Single-nested for mysql:
+    #   "update cats where id in (select owners where name=baz)"
+
+    Cat.where( id: Owner.where(name: "bar") ).update_all(name: "baz")
+    expect(Unreliable::SqlTestingData.update_manager_sql).
+      to end_with(
+        case UnreliableTest.find_adapter
+        when "mysql2"
+          "ORDER BY RAND()"
+        else
+          adapter_text("ORDER BY RANDOM()) ORDER BY RANDOM())")
+        end
+      )
+
+    # Single ordered subquery for sqlite/postgresql:
+    #   "update cats where id in (select cats where name=bar limit ?)"
+    # Direct update for mysql:
+    #   "update cats where name=baz"
+
+    Cat.where(name: "bar").limit(1).update_all(name: "baz")
+    expect(Unreliable::SqlTestingData.update_manager_sql).
+      to match(
+        case UnreliableTest.find_adapter
+        when "mysql2"
+          'ORDER BY RAND\(\) LIMIT '
+        else
+          adapter_text('ORDER BY RANDOM\(\) LIMIT ')
+        end
+      )
+
+    # Single ordered subquery:
+    #   "update cats where id in (select cats where name=bar order by id limit ?)"
+    # The presence of the primary-key order means Unreliable does not apply its own order.
+
+    Cat.where(name: "bar").order(:id).limit(1).update_all(name: "baz")
+    expect(Unreliable::SqlTestingData.update_manager_sql).
+      to match(adapter_text('ORDER BY "cats"\."id" ASC LIMIT '))
+
+    # rubocop:enable Layout/SpaceInsideParens,Layout/DotPosition
   ensure
     module Arel
       class SelectManager

data/spec/spec_helper.rb

@@ -1,5 +1,31 @@
 # frozen_string_literal: true
 
+class UnreliableTest
+  DEFAULT_ADAPTER = "sqlite"
+  VALID_ADAPTERS = %w[mysql2 postgresql sqlite].freeze
+  ORIG_EXTENSION = "orig"
+  DATABASE_YML_FILENAME = "spec/internal/config/database.yml"
+
+  def self.find_adapter
+    ENV["RSPEC_ADAPTER"].presence || ::UnreliableTest::DEFAULT_ADAPTER
+  end
+
+  def self.assert_valid_adapter!(adapter)
+    raise "RSPEC_ADAPTER '#{adapter}' not valid" unless ::UnreliableTest::VALID_ADAPTERS.include? adapter
+  end
+
+  def self.cp_adapter_file(adapter)
+    FileUtils.cp(
+      "#{::UnreliableTest::DATABASE_YML_FILENAME}.#{adapter}",
+      ::UnreliableTest::DATABASE_YML_FILENAME
+    )
+  end
+
+  def self.restore_adapter_file
+    cp_adapter_file(::UnreliableTest::ORIG_EXTENSION)
+  end
+end
+
 require "bundler"
 
 Bundler.require :default, :development
@@ -11,6 +37,52 @@ if ActiveRecord.gem_version >= Gem::Version.new("5.2") && ActiveRecord.gem_versi
   ActiveRecord::ConnectionAdapters::SQLite3Adapter.represent_boolean_as_integer = true
 end
 
+if ActiveRecord.gem_version >= Gem::Version.new("6.1") && ActiveRecord.gem_version < Gem::Version.new("7.1")
+  # This causes all Rails deprecation warnings to raise.
+  # We would like to use this feature all the time, but it was only introduced in 6.1,
+  # and combustion <= 1.3.7 throws a deprecation in Rails 7.1. The next release of
+  # combustion should fix it: https://github.com/pat/combustion/pull/131
+  ActiveSupport::Deprecation.disallowed_warnings = :all
+end
+
+if ActiveRecord.gem_version >= Gem::Version.new("5.2") && ActiveRecord.gem_version < Gem::Version.new("6.1")
+  # This setting was introduced in Rails 5.2, deprecated in Rails 6.1, and
+  # removed in Rails 7.0.
+  ActiveRecord::Base.allow_unsafe_raw_sql = :disabled
+end
+
+# Convert the sqlite3 version of the text that each test is `expect`ing to see,
+# into the text that the adapter would produce.
+
+def adapter_text(sql)
+  case ActiveRecord::Base.connection.adapter_name
+  when "Mysql2"
+    sql.tr('"', "`").gsub("RANDOM()", "RAND()")
+  when "pg"
+    sql.tr('"', "`")
+  else
+    sql
+  end
+end
+
+# ActiveRecord checks textual .order() arguments to ensure they match the adapter.
+# This converts our test's text to match. See spec/textual_order_spec.rb for more.
+
+def order_text(sql)
+  case ActiveRecord::Base.connection.adapter_name
+  when "Mysql2"
+    sql.tr('"', "`")
+  else
+    sql
+  end
+end
+
+# Set the adapter for this run by copying the appropriate file into place.
+adapter = UnreliableTest.find_adapter
+UnreliableTest.assert_valid_adapter!(adapter)
+UnreliableTest.cp_adapter_file(adapter)
+puts "Running RSpec for #{adapter} on ActiveRecord #{ActiveRecord.version} on ruby #{RUBY_VERSION}"
+
 Combustion.initialize! :active_record
 
 RSpec.configure do |config|
@@ -25,5 +97,10 @@ RSpec.configure do |config|
   config.shared_context_metadata_behavior = :apply_to_host_groups
   config.example_status_persistence_file_path = "spec/examples.txt"
   config.warnings = true
+  config.raise_errors_for_deprecations!
   config.default_formatter = "doc" if config.files_to_run.count == 1
+
+  config.after(:suite) do
+    UnreliableTest.restore_adapter_file
+  end
 end

data/spec/textual_order_raw_spec.rb

@@ -0,0 +1,98 @@
+# frozen_string_literal: true
+
+# These are funny tests written in funny ways, using the utility function
+# `order_text` -- which is used only here -- and here's why.
+#
+# Start by reading the docs for `order`, especially the "strings" and "Arel"
+# sections:
+# https://api.rubyonrails.org/classes/ActiveRecord/QueryMethods.html#method-i-order
+#
+# The docs claim "only strings composed of plain column names" are allowed,
+# but "plain" (since at least Rails 5.2) has allowed a table prefix as well, e.g.:
+# https://github.com/rails/rails/blob/v6.0.0/activerecord/lib/active_record/connection_adapters/abstract/quoting.rb#L171-L194
+#
+# To test non-quoted column and/or table names, across all three supported
+# databases, we have to use `order_text` to convert the string specifying
+# the order into whichever format the current adapter is expecting. What
+# this means is that in the tests where we quote table and/or column name,
+# the MySQL adapter will require the table and column name quoted with
+# `backticks` and the other two with "quotes".
+#
+# To make this work, `order_text` ensures we send the adapter the correct format.
+# Then `adapter_text`, as usual, makes sure we check the result in the right way.
+#
+# This test is to ensure that unreliable works even when an app writes an order
+# in this not-well-documented way. So here we want to send Shelf.order() a
+# fully-qualified textual order, i.e., an order that (unnecessarily, as it happens)
+# specifies table name along with column name.
+#
+# We do this with spec_helper.rb having set the strictest setting for raw sql,
+# "ActiveRecord::Base.allow_unsafe_raw_sql = :disabled", in the ActiveRecord
+# versions where that's available -- which is only 5.2 and 6.0. This may have
+# been an ill-advised setting because it makes ordering by quoted column
+# and/or table names raise an UnknownAttributeReference error only in 5.2.
+# Maybe this unexpected change is why this feature was quickly deprecated and
+# removed. We test 5.2 separately from other verions.
+
+RSpec.describe "textual order raw" do
+  it "randomly selects from shelves ordered by Arel-escaped quoted table and column name" do
+    expect(Shelf.order(Arel.sql(order_text('"shelves"."shelf_id"'))).to_sql).to end_with(
+      adapter_text('ORDER BY "shelves"."shelf_id", RANDOM()')
+    )
+  end
+
+  it "randomly selects from shelves ordered by Arel-escaped quoted column name" do
+    expect(Shelf.order(Arel.sql(order_text('"shelf_id"'))).to_sql).to end_with(
+      adapter_text('ORDER BY "shelf_id", RANDOM()')
+    )
+  end
+
+  it "raises (in 5.2) on non-Arel-escaped quoted table and column name",
+    skip: (
+      (ActiveRecord.version < Gem::Version.new("5.2") || ActiveRecord.version >= Gem::Version.new("6.0")
+      ) ? "test is for ActiveRecord 5.2 only" : false) do
+    # It actually raises ActiveRecord::UnknownAttributeReference, but since
+    # that's not defined in Rails < 5.2, and there's a chance we might
+    # restore Rails 5.0 and 5.1 compatibility at some point in the future,
+    # we don't want to reference that constant if it might not exist.
+    # So we name that class by its superclass here.
+    expect { Shelf.order(order_text('"shelves"."shelf_id"')).to_sql }.to raise_error(ActiveRecord::ActiveRecordError)
+  end
+
+  it "raises (in 5.2) on non-Arel-escaped quoted column name",
+    skip: (
+      (ActiveRecord.version < Gem::Version.new("5.2") || ActiveRecord.version >= Gem::Version.new("6.0")
+      ) ? "test is for ActiveRecord 5.2 only" : false) do
+    expect { Shelf.order(order_text('"shelf_id"')).to_sql }.to raise_error(ActiveRecord::ActiveRecordError)
+  end
+
+  it "randomly selects (except in 5.2) on non-Arel-escaped quoted table and column name",
+    skip: (
+      (ActiveRecord.version >= Gem::Version.new("5.2") && ActiveRecord.version < Gem::Version.new("6.0")
+      ) ? "test is not for ActiveRecord 5.2" : false) do
+    expect(Shelf.order(order_text('"shelves"."shelf_id"')).to_sql).to end_with(
+      adapter_text('ORDER BY "shelves"."shelf_id", RANDOM()')
+    )
+  end
+
+  it "randomly selects (except in 5.2) on non-Arel-escaped quoted column name",
+    skip: (
+      (ActiveRecord.version >= Gem::Version.new("5.2") && ActiveRecord.version < Gem::Version.new("6.0")
+      ) ? "test is not for ActiveRecord 5.2" : false) do
+    expect(Shelf.order(order_text('"shelf_id"')).to_sql).to end_with(
+      adapter_text('ORDER BY "shelf_id", RANDOM()')
+    )
+  end
+
+  it "randomly selects from shelves ordered by non-Arel-escaped unquoted table and column name" do
+    expect(Shelf.order("shelves.shelf_id").to_sql).to end_with(
+      adapter_text("ORDER BY shelves.shelf_id, RANDOM()")
+    )
+  end
+
+  it "randomly selects from shelves ordered by non-Arel-escaped unquoted column name" do
+    expect(Shelf.order("shelf_id").to_sql).to end_with(
+      adapter_text("ORDER BY shelf_id, RANDOM()")
+    )
+  end
+end

data/spec/textual_order_spec.rb

@@ -2,34 +2,38 @@
 
 RSpec.describe "textual order" do
   it "randomly selects from shelves ordered by textual id asc" do
-    expect(Shelf.order("shelf_id ASC").to_sql).to end_with("ORDER BY shelf_id ASC, RANDOM()")
-  end
-
-  it "randomly selects from shelves ordered by fully qualified textual id asc" do
-    expect(Shelf.order('"shelves"."shelf_id"').to_sql).to end_with('ORDER BY "shelves"."shelf_id", RANDOM()')
+    expect(Shelf.order("shelf_id ASC").to_sql).to end_with(
+      adapter_text("ORDER BY shelf_id ASC, RANDOM()")
+    )
   end
 
   it "randomly selects from shelves ordered by textual position asc" do
-    expect(Shelf.order("shelf_position ASC").to_sql).to end_with("ORDER BY shelf_position ASC, RANDOM()")
+    expect(Shelf.order("shelf_position ASC").to_sql).to end_with(
+      adapter_text("ORDER BY shelf_position ASC, RANDOM()")
+    )
   end
 
   it "randomly selects from shelves ordered by textual id desc" do
-    expect(Shelf.order("shelf_id DESC").to_sql).to end_with("ORDER BY shelf_id DESC, RANDOM()")
+    expect(Shelf.order("shelf_id DESC").to_sql).to end_with(
+      adapter_text("ORDER BY shelf_id DESC, RANDOM()")
+    )
   end
 
   it "randomly selects from shelves ordered by textual position desc" do
-    expect(Shelf.order("shelf_position DESC").to_sql).to end_with("ORDER BY shelf_position DESC, RANDOM()")
+    expect(Shelf.order("shelf_position DESC").to_sql).to end_with(
+      adapter_text("ORDER BY shelf_position DESC, RANDOM()")
+    )
   end
 
   it "randomly selects from shelves ordered by textual id and position asc" do
     expect(Shelf.order("shelf_id ASC, shelf_position ASC").to_sql).to end_with(
-      "ORDER BY shelf_id ASC, shelf_position ASC, RANDOM()"
+      adapter_text("ORDER BY shelf_id ASC, shelf_position ASC, RANDOM()")
     )
   end
 
   it "randomly selects from shelves ordered by textual id and position desc" do
     expect(Shelf.order("shelf_id DESC, shelf_position DESC").to_sql).to end_with(
-      "ORDER BY shelf_id DESC, shelf_position DESC, RANDOM()"
+      adapter_text("ORDER BY shelf_id DESC, shelf_position DESC, RANDOM()")
     )
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: unreliable
 version: !ruby/object:Gem::Version
-  version: 0.9.1
+  version: 0.10.0
 platform: ruby
 authors:
 - James McCarthy
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2022-11-21 00:00:00.000000000 Z
+date: 2024-01-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -16,7 +16,7 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '5.0'
+        version: '5.2'
     - - "<"
       - !ruby/object:Gem::Version
         version: '8.0'
@@ -26,7 +26,7 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '5.0'
+        version: '5.2'
     - - "<"
       - !ruby/object:Gem::Version
         version: '8.0'
@@ -36,7 +36,7 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '5.0'
+        version: '5.2'
     - - "<"
       - !ruby/object:Gem::Version
         version: '8.0'
@@ -46,7 +46,7 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '5.0'
+        version: '5.2'
     - - "<"
       - !ruby/object:Gem::Version
         version: '8.0'
@@ -92,6 +92,34 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '1.3'
+- !ruby/object:Gem::Dependency
+  name: mysql2
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.5'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.5'
+- !ruby/object:Gem::Dependency
+  name: pg
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.5'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.5'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -126,14 +154,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.4'
+        version: 1.6.9
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.4'
+        version: 1.6.9
 - !ruby/object:Gem::Dependency
   name: standard
   requirement: !ruby/object:Gem::Requirement
@@ -148,6 +176,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '1.17'
+- !ruby/object:Gem::Dependency
+  name: yamllint
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.0.9
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.0.9
 description: |
   Unreliable helps uncover bugs in Rails apps that rely on ambiguous database ordering.
   Installing it makes both your app and your test suite more robust.
@@ -167,19 +209,23 @@ files:
 - lib/unreliable/config.rb
 - lib/unreliable/railtie.rb
 - lib/unreliable/version.rb
+- spec/adapter_option_spec.rb
 - spec/env_spec.rb
-- spec/examples.txt
+- spec/execute_queries_spec.rb
+- spec/execute_subqueries_spec.rb
 - spec/model_cache_versioning_spec.rb
 - spec/model_indexes_books_spec.rb
 - spec/model_indexes_cats_spec.rb
 - spec/model_indexes_dreams_spec.rb
 - spec/model_indexes_shelves_spec.rb
 - spec/model_joins_spec.rb
+- spec/model_select_distinct_spec.rb
 - spec/model_select_spec.rb
 - spec/model_subquery_spec.rb
 - spec/model_update_arel_10_spec.rb
 - spec/railtie_spec.rb
 - spec/spec_helper.rb
+- spec/textual_order_raw_spec.rb
 - spec/textual_order_spec.rb
 - spec/version_spec.rb
 homepage: https://github.com/jamiemccarthy/unreliable
@@ -203,7 +249,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.6
+rubygems_version: 3.5.3
 signing_key: 
 specification_version: 4
 summary: For ActiveRecord tests, surface ambiguous-ordering bugs

data/spec/examples.txt

@@ -1,39 +0,0 @@
-example_id                                 | status | run_time        |
------------------------------------------- | ------ | --------------- |
-./spec/env_spec.rb[1:1]                    | passed | 0.00346 seconds |
-./spec/env_spec.rb[1:2]                    | passed | 0.00049 seconds |
-./spec/model_cache_versioning_spec.rb[1:1] | passed | 0.03983 seconds |
-./spec/model_indexes_books_spec.rb[1:1]    | passed | 0.00152 seconds |
-./spec/model_indexes_books_spec.rb[1:2]    | passed | 0.00132 seconds |
-./spec/model_indexes_books_spec.rb[1:3]    | passed | 0.00108 seconds |
-./spec/model_indexes_cats_spec.rb[1:1]     | passed | 0.00105 seconds |
-./spec/model_indexes_cats_spec.rb[1:2]     | passed | 0.0015 seconds  |
-./spec/model_indexes_dreams_spec.rb[1:1]   | passed | 0.00313 seconds |
-./spec/model_indexes_dreams_spec.rb[1:2]   | passed | 0.00129 seconds |
-./spec/model_indexes_shelves_spec.rb[1:1]  | passed | 0.00178 seconds |
-./spec/model_indexes_shelves_spec.rb[1:2]  | passed | 0.00174 seconds |
-./spec/model_indexes_shelves_spec.rb[1:3]  | passed | 0.00076 seconds |
-./spec/model_indexes_shelves_spec.rb[1:4]  | passed | 0.00087 seconds |
-./spec/model_indexes_shelves_spec.rb[1:5]  | passed | 0.00079 seconds |
-./spec/model_indexes_shelves_spec.rb[1:6]  | passed | 0.00101 seconds |
-./spec/model_joins_spec.rb[1:1]            | passed | 0.01262 seconds |
-./spec/model_joins_spec.rb[1:2]            | passed | 0.00359 seconds |
-./spec/model_joins_spec.rb[1:3]            | passed | 0.01319 seconds |
-./spec/model_joins_spec.rb[1:4]            | passed | 0.00217 seconds |
-./spec/model_select_spec.rb[1:1]           | passed | 0.0007 seconds  |
-./spec/model_select_spec.rb[1:2]           | passed | 0.00093 seconds |
-./spec/model_select_spec.rb[1:3]           | passed | 0.00091 seconds |
-./spec/model_select_spec.rb[1:4]           | passed | 0.00127 seconds |
-./spec/model_subquery_spec.rb[1:1]         | passed | 0.00155 seconds |
-./spec/model_update_arel_10_spec.rb[1:1]   | passed | 0.00536 seconds |
-./spec/railtie_spec.rb[1:1]                | passed | 0.00013 seconds |
-./spec/railtie_spec.rb[1:2]                | passed | 0.00008 seconds |
-./spec/textual_order_spec.rb[1:1]          | passed | 0.00108 seconds |
-./spec/textual_order_spec.rb[1:2]          | passed | 0.00067 seconds |
-./spec/textual_order_spec.rb[1:3]          | passed | 0.00078 seconds |
-./spec/textual_order_spec.rb[1:4]          | passed | 0.00087 seconds |
-./spec/textual_order_spec.rb[1:5]          | passed | 0.00069 seconds |
-./spec/textual_order_spec.rb[1:6]          | passed | 0.00079 seconds |
-./spec/textual_order_spec.rb[1:7]          | passed | 0.00088 seconds |
-./spec/version_spec.rb[1:1]                | passed | 0.00151 seconds |
-./spec/version_spec.rb[1:2]                | passed | 0.0002 seconds  |