unread 0.10.0 → 0.10.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 783e65e652089e8325398c9f593d126f4332d83041cd2fd88cc86266105a1809
-  data.tar.gz: 24f73b4d3038e0d81acff4ca44c7fead8f628a2eea5e7479420b47952d8215fe
+  metadata.gz: 05b6ec999b0b08aecbed6fc07c6e1d8e24fa5220d9b360b1fb6a1aa7293cbadc
+  data.tar.gz: be06fff51e62ecdaeddb2d5d86e89c950c3080db70dbed8b4736d976e17ab1a5
 SHA512:
-  metadata.gz: ba242fd2a04f70545c5313bc73d5aff1a5bbee97b29a52625df620a3290800a90267693e8d3d5d488b00d4dd72e6dfe0a8eb1eae12428cb56ccd6cbff4dd04fe
-  data.tar.gz: 849a46af19decb7627d0359b46bfd79f269751603144e59c621d27c56caac81943b8b2ae9b85e03a0326ac84f28d4fca59288d627d4d8eacca61fe05decb1ae7
+  metadata.gz: 9b0c1ac98cdf02095d66c6b77959a039083f5dc9e0a5d350aff8274ba9d6589cf873a46872a32c9a09080bc52f5dce4ab4fcf9450fbe0f4088f2efe6bec80224
+  data.tar.gz: '0879f93f42eee16f150e64bce7a1271dce8dc5c728f1ece62d7da2ed8c47d7d034c98a7a3619564fb6f8e4a4d35e7e111d123c0dad6e7e0234328e73b47321da'

data/lib/unread/version.rb

@@ -1,3 +1,3 @@
 module Unread
-  VERSION = '0.10.0'
+  VERSION = '0.10.1'
 end

data/unread.gemspec

@@ -1,5 +1,6 @@
 # -*- encoding: utf-8 -*-
-$:.push File.expand_path("../lib", __FILE__)
+lib = File.expand_path('../lib', __FILE__)
+$LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require "unread/version"
 
 Gem::Specification.new do |s|
@@ -13,15 +14,16 @@ Gem::Specification.new do |s|
   s.description = %q{This gem creates a scope for unread objects and adds methods to mark objects as read }
   s.required_ruby_version = '>= 2.2'
 
-  s.rubyforge_project = "unread"
-
-  s.files         = `git ls-files`.split("\n")
-  s.test_files    = `git ls-files -- {test,spec,features}/*`.split("\n")
-  s.executables   = `git ls-files -- bin/*`.split("\n").map{ |f| File.basename(f) }
+  s.files         = `git ls-files -z`.split("\x0").reject do |f|
+    f.match(%r{^(test|spec|features)/})
+  end
+  s.bindir        = "exe"
+  s.executables   = s.files.grep(%r{^exe/}) { |f| File.basename(f) }
   s.require_paths = ["lib"]
 
   s.add_dependency 'activerecord', '>= 3'
 
+  s.add_development_dependency 'bundler'
   s.add_development_dependency 'rake'
   s.add_development_dependency 'timecop'
   s.add_development_dependency 'sqlite3'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: unread
 version: !ruby/object:Gem::Version
-  version: 0.10.0
+  version: 0.10.1
 platform: ruby
 authors:
 - Georg Ledermann
 autorequire: 
-bindir: bin
+bindir: exe
 cert_chain: []
-date: 2018-02-14 00:00:00.000000000 Z
+date: 2018-03-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -24,6 +24,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '3'
+- !ruby/object:Gem::Dependency
+  name: bundler
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -168,8 +182,7 @@ description: 'This gem creates a scope for unread objects and adds methods to ma
   objects as read '
 email:
 - mail@georg-ledermann.de
-executables:
-- console
+executables: []
 extensions: []
 extra_rdoc_files: []
 files:
@@ -201,25 +214,6 @@ files:
 - lib/unread/reader.rb
 - lib/unread/reader_scopes.rb
 - lib/unread/version.rb
-- spec/app/models/customer.rb
-- spec/app/models/different_reader.rb
-- spec/app/models/document.rb
-- spec/app/models/email.rb
-- spec/app/models/multi_level_sti_readable.rb
-- spec/app/models/reader.rb
-- spec/app/models/sti_reader.rb
-- spec/database.yml
-- spec/spec_helper.rb
-- spec/support/matchers/perform_queries.rb
-- spec/support/query_counter.rb
-- spec/support/spec_migration.rb
-- spec/support/timecop.rb
-- spec/unread/base_spec.rb
-- spec/unread/garbage_collector_spec.rb
-- spec/unread/read_mark_spec.rb
-- spec/unread/readable_spec.rb
-- spec/unread/reader_scopes_spec.rb
-- spec/unread/reader_spec.rb
 - unread.gemspec
 homepage: https://github.com/ledermann/unread
 licenses:
@@ -240,28 +234,9 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: unread
-rubygems_version: 2.7.5
+rubyforge_project: 
+rubygems_version: 2.7.6
 signing_key: 
 specification_version: 4
 summary: Manages read/unread status of ActiveRecord objects
-test_files:
-- spec/app/models/customer.rb
-- spec/app/models/different_reader.rb
-- spec/app/models/document.rb
-- spec/app/models/email.rb
-- spec/app/models/multi_level_sti_readable.rb
-- spec/app/models/reader.rb
-- spec/app/models/sti_reader.rb
-- spec/database.yml
-- spec/spec_helper.rb
-- spec/support/matchers/perform_queries.rb
-- spec/support/query_counter.rb
-- spec/support/spec_migration.rb
-- spec/support/timecop.rb
-- spec/unread/base_spec.rb
-- spec/unread/garbage_collector_spec.rb
-- spec/unread/read_mark_spec.rb
-- spec/unread/readable_spec.rb
-- spec/unread/reader_scopes_spec.rb
-- spec/unread/reader_spec.rb
+test_files: []

data/spec/app/models/customer.rb

@@ -1,2 +0,0 @@
-class Customer < ActiveRecord::Base
-end

data/spec/app/models/different_reader.rb

@@ -1,5 +0,0 @@
-class DifferentReader < ActiveRecord::Base
-  self.primary_key = 'number'
-
-  acts_as_reader
-end

data/spec/app/models/document.rb

@@ -1,4 +0,0 @@
-class Document < ActiveRecord::Base
-  self.primary_key = 'uid'
-  acts_as_readable on: :updated_at
-end

data/spec/app/models/email.rb

@@ -1,2 +0,0 @@
-class Email < Document
-end

data/spec/app/models/multi_level_sti_readable.rb

@@ -1,2 +0,0 @@
-class MultiLevelStiReadable < Email
-end

data/spec/app/models/reader.rb

@@ -1,12 +0,0 @@
-class Reader < ActiveRecord::Base
-  self.primary_key = 'number'
-
-  scope :not_foo, -> { where("name <> 'foo'") }
-  scope :not_bar, -> { where("name <> 'bar'") }
-
-  acts_as_reader
-
-  def self.reader_scope
-    not_foo.not_bar
-  end
-end

data/spec/app/models/sti_reader.rb

@@ -1,3 +0,0 @@
-class StiReader < Customer
-  acts_as_reader
-end

data/spec/database.yml

@@ -1,12 +0,0 @@
-sqlite:
-  adapter: sqlite3
-  database: ":memory:"
-mysql:
-  adapter: mysql2
-  database: unread_test
-  username: root
-  encoding: utf8
-postgres:
-  adapter: postgresql
-  database: unread_test
-  username: postgres

data/spec/spec_helper.rb

@@ -1,82 +0,0 @@
-require 'simplecov'
-require 'coveralls'
-
-SimpleCov.formatter = SimpleCov::Formatter::MultiFormatter.new([
-  SimpleCov::Formatter::HTMLFormatter,
-  Coveralls::SimpleCov::Formatter
-])
-SimpleCov.start do
-  add_filter '/spec/'
-end
-
-require 'timecop'
-require 'unread'
-require 'generators/unread/migration/templates/migration.rb'
-
-require 'app/models/reader'
-require 'app/models/different_reader'
-require 'app/models/customer'
-require 'app/models/sti_reader'
-require 'app/models/document'
-require 'app/models/email'
-require 'app/models/multi_level_sti_readable'
-
-# Requires supporting ruby files with custom matchers and macros, etc,
-# in spec/support/ and its subdirectories.
-Dir[File.expand_path(File.join(File.dirname(__FILE__),'support','**','*.rb'))].each {|f| require f}
-
-# This file was generated by the `rspec --init` command. Conventionally, all
-# specs live under a `spec` directory, which RSpec adds to the `$LOAD_PATH`.
-# Require this file using `require "spec_helper"` to ensure that it is only
-# loaded once.
-#
-# See http://rubydoc.info/gems/rspec-core/RSpec/Core/Configuration
-RSpec.configure do |config|
-  # Run specs in random order to surface order dependencies. If you find an
-  # order dependency and want to debug it, you can fix the order by providing
-  # the seed, which is printed after each run.
-  #     --seed 1234
-  #  config.order = 'random'
-
-  config.before :each do
-    clear_db
-  end
-
-  config.after :each do
-    Timecop.return
-  end
-
-  config.after :suite do
-    UnreadMigration.down
-  end
-end
-
-if I18n.respond_to?(:enforce_available_locales=)
-  I18n.enforce_available_locales = false
-end
-
-def setup_db
-  configs = YAML.load_file('spec/database.yml')
-  ActiveRecord::Base.configurations = configs
-
-  db_name = ENV['DB'] || 'sqlite'
-
-  puts "Testing with ActiveRecord #{ActiveRecord::VERSION::STRING} on #{db_name}"
-
-  ActiveRecord::Base.establish_connection(db_name.to_sym)
-  ActiveRecord::Base.default_timezone = :utc
-  ActiveRecord::Migration.verbose = false
-
-  UnreadMigration.up
-  SpecMigration.up
-end
-
-def clear_db
-  Reader.delete_all
-  DifferentReader.delete_all
-  StiReader.delete_all
-  Email.delete_all
-  ReadMark.delete_all
-end
-
-setup_db

data/spec/support/matchers/perform_queries.rb

@@ -1,19 +0,0 @@
-RSpec::Matchers.define :perform_queries do |expected|
-  supports_block_expectations
-
-  match do |block|
-    query_count(&block) == expected
-  end
-
-  failure_message do |actual|
-    "Expected to run #{expected} queries, got #{@counter.query_count}"
-  end
-
-  def query_count(&block)
-    @counter = ActiveRecord::QueryCounter.new
-    ActiveSupport::Notifications.subscribe('sql.active_record', @counter.to_proc)
-    yield
-    ActiveSupport::Notifications.unsubscribe(@counter.to_proc)
-    @counter.query_count
-  end
-end

data/spec/support/query_counter.rb

@@ -1,17 +0,0 @@
-module ActiveRecord
-  class QueryCounter
-    attr_reader :query_count
-
-    def initialize
-      @query_count = 0
-    end
-
-    def to_proc
-      lambda(&method(:callback))
-    end
-
-    def callback(name, start, finish, message_id, values)
-      @query_count += 1 unless %w(CACHE SCHEMA).include?(values[:name]) || values[:sql] =~ /^begin/i || values[:sql] =~ /^commit/i
-    end
-  end
-end

data/spec/support/spec_migration.rb

@@ -1,23 +0,0 @@
-class SpecMigration < Unread::MIGRATION_BASE_CLASS
-  def self.up
-    create_table Reader, primary_key: 'number', force: true do |t|
-      t.string :name
-    end
-
-    create_table DifferentReader, primary_key: 'number', force: true do |t|
-      t.string :name
-    end
-
-    create_table Customer, force: true do |t|
-      t.string :type
-    end
-
-    create_table Document, primary_key: 'uid', force: true do |t|
-      t.string :type
-      t.string :subject
-      t.text :content
-      t.datetime :created_at
-      t.datetime :updated_at
-    end
-  end
-end

data/spec/support/timecop.rb

@@ -1,3 +0,0 @@
-def wait
-  Timecop.freeze(1.minute.from_now.change(usec: 0))
-end

data/spec/unread/base_spec.rb

@@ -1,61 +0,0 @@
-require 'spec_helper'
-
-describe Unread::Base do
-  before :each do
-    @email = Email.create!
-    wait
-    @reader = Reader.create! name: 'John'
-  end
-
-  describe :acts_as_reader do
-    it "should create global read mark" do
-      expect(@reader.read_marks.count).to eq 1
-      expect(@reader.read_marks.global.count).to eq 1
-    end
-
-    it "should define association for ReadMark" do
-      expect(@reader.read_marks.first.reader).to eq(@reader)
-    end
-
-    it "should reset read_marks for created reader" do
-      expect(Email.unread_by(@reader)).to be_empty
-    end
-
-    it "should memoize read_mark_global" do
-      expect {
-        rm1 = @reader.read_mark_global(Email)
-        rm2 = @reader.read_mark_global(Email)
-      }.to perform_queries(1)
-    end
-
-    it "should be idempotent" do
-      expect {
-        Reader.acts_as_reader
-        Reader.acts_as_reader
-        Reader.acts_as_reader
-      }.to_not change { ReadMark.reader_classes }
-    end
-  end
-
-  describe :acts_as_readable do
-    it "should define association" do
-      expect(@email.read_marks.count).to eq 0
-    end
-
-    it "should add class to ReadMark.readable_classes" do
-      expect(ReadMark.readable_classes).to eq [ Document ]
-    end
-
-    it "should use default options" do
-      expect(Email.readable_options).to eq({ on: :updated_at })
-    end
-
-    it "should be idempotent" do
-      expect {
-        Document.acts_as_readable
-        Document.acts_as_readable
-        Document.acts_as_readable
-      }.to_not change { ReadMark.readable_classes }
-    end
-  end
-end

data/spec/unread/garbage_collector_spec.rb

@@ -1,52 +0,0 @@
-require 'spec_helper'
-
-describe Unread::GarbageCollector do
-  before :each do
-    @reader = Reader.create! name: 'David'
-    @other_reader = Reader.create name: 'Matz'
-    @sti_reader = StiReader.create!
-    wait
-    @email1 = Email.create!
-    wait
-    @email2 = MultiLevelStiReadable.create!
-  end
-
-  describe :run! do
-    it "should delete all single read marks" do
-      expect(@reader.read_marks.single.count).to eq 0
-
-      @email1.mark_as_read! for: @reader
-
-      expect(Email.unread_by(@reader)).to eq [@email2]
-      expect(@reader.read_marks.single.count).to eq 1
-
-      Unread::GarbageCollector.new(Email).run!
-
-      @reader.reload
-      expect(@reader.read_marks.single.count).to eq 0
-    end
-
-    it "should reset if all objects are read" do
-      @email1.mark_as_read! for: @reader
-      @email2.mark_as_read! for: @reader
-
-      expect(@reader.read_marks.single.count).to eq 2
-
-      Unread::GarbageCollector.new(Email).run!
-
-      expect(@reader.read_marks.single.count).to eq 0
-    end
-
-    it "should not delete read marks from other readables" do
-      other_read_mark = @reader.read_marks.create! do |rm|
-        rm.readable_type = 'Foo'
-        rm.readable_id   = 42
-        rm.timestamp     = 5.years.ago
-      end
-
-      Unread::GarbageCollector.new(Email).run!
-
-      expect(ReadMark.exists?(other_read_mark.id)).to be_truthy
-    end
-  end
-end

data/spec/unread/read_mark_spec.rb

@@ -1,11 +0,0 @@
-require 'spec_helper'
-
-describe ReadMark do
-  it "should have reader_class" do
-    expect(ReadMark.reader_classes).to eq [Reader, DifferentReader, StiReader]
-  end
-
-  it "should have readable_classes" do
-    expect(ReadMark.readable_classes).to eq [Document]
-  end
-end

data/spec/unread/readable_spec.rb

@@ -1,345 +0,0 @@
-require 'spec_helper'
-
-describe Unread::Readable do
-  before :each do
-    @reader = Reader.create! name: 'David'
-    @other_reader = Reader.create name: 'Matz'
-    @sti_reader = StiReader.create!
-    wait
-    @email1 = Email.create!
-    wait
-    @email2 = MultiLevelStiReadable.create!
-  end
-
-  describe :unread_by do
-    it "should return all objects" do
-      expect(Email.unread_by(@reader)).to eq [@email1, @email2]
-      expect(Email.unread_by(@other_reader)).to eq [@email1, @email2]
-    end
-
-    it "should return unread records" do
-      @email1.mark_as_read! for: @reader
-
-      expect(Email.unread_by(@reader)).to eq [@email2]
-      expect(Email.unread_by(@reader).count).to eq 1
-
-      expect(Email.unread_by(@other_reader)).to eq [@email1, @email2]
-    end
-
-    it "should return empty array directly after marking all as read" do
-      Email.mark_as_read! :all, for: @reader
-      expect(Email.unread_by(@reader)).to eq([])
-    end
-
-    it "should not allow invalid parameter" do
-      [ 42, nil, 'foo', :foo, {} ].each do |not_a_reader|
-        expect {
-          Email.unread_by(not_a_reader)
-        }.to raise_error(ArgumentError)
-      end
-    end
-
-    it "should not allow unsaved reader" do
-      unsaved_reader = Reader.new
-
-      expect {
-        Email.unread_by(unsaved_reader)
-      }.to raise_error(ArgumentError)
-    end
-
-    describe "should work without any read_marks" do
-      before do
-        ReadMark.delete_all
-      end
-
-      it "should return all objects" do
-        expect(Email.unread_by(@reader)).to eq [@email1, @email2]
-        expect(Email.unread_by(@other_reader)).to eq [@email1, @email2]
-      end
-
-      it "should return unread records" do
-        @email1.mark_as_read! for: @reader
-
-        expect(Email.unread_by(@reader)).to eq [@email2]
-        expect(Email.unread_by(@reader).count).to eq 1
-      end
-
-      it "should not allow invalid parameter" do
-        [ 42, nil, 'foo', :foo, {} ].each do |not_a_reader|
-          expect {
-            Email.unread_by(not_a_reader)
-          }.to raise_error(ArgumentError)
-        end
-      end
-
-      it "should not allow unsaved reader" do
-        unsaved_reader = Reader.new
-
-        expect {
-          Email.unread_by(unsaved_reader)
-        }.to raise_error(ArgumentError)
-      end
-    end
-  end
-
-  describe :read_by do
-    it "should return an empty array" do
-      expect(Email.read_by(@reader)).to be_empty
-      expect(Email.read_by(@other_reader)).to be_empty
-    end
-
-    it "should return read records" do
-      @email1.mark_as_read! for: @reader
-
-      expect(Email.read_by(@reader)).to eq [@email1]
-      expect(Email.read_by(@reader).count).to eq 1
-    end
-
-    it "should return all records when all read" do
-      Email.mark_as_read! :all, for: @reader
-
-      expect(Email.read_by(@reader)).to eq [@email1, @email2]
-    end
-
-    it "should not allow invalid parameter" do
-      [ 42, nil, 'foo', :foo, {} ].each do |not_a_reader|
-        expect {
-          Email.read_by(not_a_reader)
-        }.to raise_error(ArgumentError)
-      end
-    end
-
-    it "should not allow unsaved reader" do
-      unsaved_reader = Reader.new
-
-      expect {
-        Email.read_by(unsaved_reader)
-      }.to raise_error(ArgumentError)
-    end
-
-    describe "should work without any read_marks" do
-      before do
-        ReadMark.delete_all
-      end
-
-      it "should return an empty array" do
-        expect(Email.read_by(@reader)).to be_empty
-        expect(Email.read_by(@other_reader)).to be_empty
-      end
-
-      it "should return read records" do
-        @email1.mark_as_read! for: @reader
-
-        expect(Email.read_by(@reader)).to eq [@email1]
-        expect(Email.read_by(@reader).count).to eq 1
-      end
-
-      it "should return all records when all read" do
-        Email.mark_as_read! :all, for: @reader
-
-        expect(Email.read_by(@reader)).to eq [@email1, @email2]
-      end
-
-      it "should not allow invalid parameter" do
-        [ 42, nil, 'foo', :foo, {} ].each do |not_a_reader|
-          expect {
-            Email.read_by(not_a_reader)
-          }.to raise_error(ArgumentError)
-        end
-      end
-
-      it "should not allow unsaved reader" do
-        unsaved_reader = Reader.new
-
-        expect {
-          Email.read_by(unsaved_reader)
-        }.to raise_error(ArgumentError)
-      end
-    end
-  end
-
-  describe :with_read_marks_for do
-    it "should return readables" do
-      expect(Email.with_read_marks_for(@reader).to_a).to eq([@email1, @email2])
-    end
-
-    it "should be countable" do
-      expect(Email.with_read_marks_for(@reader).count(:uid)).to eq(2)
-    end
-
-    it "should not allow invalid parameter" do
-      [ 42, nil, 'foo', :foo, {} ].each do |not_a_reader|
-        expect {
-          Email.with_read_marks_for(not_a_reader)
-        }.to raise_error(ArgumentError)
-      end
-    end
-
-    it "should not allow unsaved reader" do
-      unsaved_reader = Reader.new
-
-      expect {
-        Email.with_read_marks_for(unsaved_reader)
-      }.to raise_error(ArgumentError)
-    end
-  end
-
-  describe :unread? do
-    it "should recognize unread object" do
-      expect(@email1.unread?(@reader)).to be_truthy
-      expect(@email1.unread?(@other_reader)).to be_truthy
-    end
-
-    it "should handle updating object" do
-      @email1.mark_as_read! for: @reader
-      wait
-      expect(@email1.unread?(@reader)).to be_falsey
-
-      @email1.update_attributes! subject: 'changed'
-      expect(@email1.unread?(@reader)).to be_truthy
-    end
-
-    it "should raise error for invalid argument" do
-      expect {
-        @email1.unread?(42)
-      }.to raise_error(ArgumentError)
-    end
-
-    it "should work with eager-loaded read marks" do
-      @email1.mark_as_read! for: @reader
-
-      expect {
-        emails = Email.with_read_marks_for(@reader).to_a
-
-        expect(emails[0].unread?(@reader)).to be_falsey
-        expect(emails[1].unread?(@reader)).to be_truthy
-      }.to perform_queries(1)
-    end
-
-    it "should work without any read_marks" do
-      ReadMark.delete_all
-
-      emails = Email.with_read_marks_for(@reader).to_a
-      expect(emails[0].unread?(@reader)).to be_truthy
-      expect(emails[1].unread?(@reader)).to be_truthy
-    end
-
-    it "should work with eager-loaded read marks for the correct reader" do
-      @email1.mark_as_read! for: @reader
-
-      emails = Email.with_read_marks_for(@reader).to_a
-      expect(emails[0].unread?(@reader)).to be_falsey
-      expect(emails[0].unread?(@other_reader)).to be_truthy
-    end
-  end
-
-  describe '#mark_as_read!' do
-    it "should mark a single object as read" do
-      @email1.mark_as_read! for: @reader
-
-      expect(@email1.unread?(@reader)).to be_falsey
-      expect(Email.unread_by(@reader)).to eq [@email2]
-
-      expect(@email1.unread?(@other_reader)).to be_truthy
-      expect(Email.unread_by(@other_reader)).to eq [@email1, @email2]
-
-      expect(@reader.read_marks.single.count).to eq 1
-      expect(@reader.read_marks.single.first.readable).to eq @email1
-    end
-
-    it "should be idempotent" do
-      @email1.mark_as_read! for: @reader
-      @email1.mark_as_read! for: @reader
-
-      expect(@reader.read_marks.single.count).to eq 1
-    end
-  end
-
-  describe '.mark_as_read!' do
-    it "should mark multi objects as read" do
-      expect(@email1.unread?(@reader)).to be_truthy
-      expect(@email2.unread?(@reader)).to be_truthy
-
-      Email.mark_as_read! [ @email1, @email2 ], for: @reader
-
-      expect(@email1.unread?(@reader)).to be_falsey
-      expect(@email2.unread?(@reader)).to be_falsey
-    end
-
-    it "should mark the rest as read when the first record is not unique" do
-      Email.mark_as_read! [ @email1 ], for: @reader
-
-      allow(@email1).to receive_message_chain("read_marks.find_or_initialize_by")
-        .and_return(@email1.read_marks.build(reader: @reader))
-
-      expect do
-        Email.mark_as_read! [ @email1, @email2 ], for: @reader
-      end.to change(ReadMark, :count).by(1)
-
-      expect(@email1.unread?(@reader)).to be_falsey
-      expect(@email2.unread?(@reader)).to be_falsey
-    end
-
-    it "should perform less queries if the objects are already read" do
-      Email.mark_as_read! :all, for: @reader
-
-      expect {
-        Email.mark_as_read! [ @email1, @email2 ], for: @reader
-      }.to perform_queries(1)
-    end
-
-    it "should allow a collection of records to be marked as read" do
-      Email.mark_as_read! Email.all, for: @reader
-
-      expect(@email1.unread?(@reader)).to be_falsey
-      expect(@email2.unread?(@reader)).to be_falsey
-    end
-
-    it "should mark all objects as read" do
-      Email.mark_as_read! :all, for: @reader
-
-      expect(@reader.read_mark_global(Email).timestamp).to eq Time.current
-      expect(@reader.read_marks.single).to eq []
-      expect(ReadMark.single.count).to eq 0
-      expect(ReadMark.global.count).to eq 3
-    end
-
-    it "should mark all objects as read with existing read objects" do
-      wait
-
-      Email.mark_as_read! :all, for: @reader
-      @email1.mark_as_read! for: @reader
-
-      expect(@reader.read_marks.single).to eq []
-    end
-
-    it "should reset memoized global read mark" do
-      rm_global = @reader.read_mark_global(Email)
-
-      Email.mark_as_read! :all, for: @reader
-      expect(@reader.read_mark_global(Email)).not_to eq(rm_global)
-    end
-
-    it "should not allow invalid arguments" do
-      expect {
-        Email.mark_as_read! :foo, for: @reader
-      }.to raise_error(ArgumentError)
-
-      expect {
-        Email.mark_as_read! :foo, :bar
-      }.to raise_error(ArgumentError)
-    end
-
-    it "should work with STI readers" do
-      Email.mark_as_read! [ @email1 ], for: Customer.find(@sti_reader.id)
-      expect(@email1.unread?(@sti_reader)).to be_falsey
-    end
-  end
-
-  describe :cleanup_read_marks! do
-    it "should run garbage collector" do
-      expect(Unread::GarbageCollector).to receive(:new).with(Email).and_return(double :run! => true)
-      Email.cleanup_read_marks!
-    end
-  end
-end

data/spec/unread/reader_scopes_spec.rb

@@ -1,9 +0,0 @@
-require 'spec_helper'
-
-describe Unread::Reader::Scopes do
-  it 'should define reader_scope' do
-    expect(Reader.reader_scope).to eq Reader.not_foo.not_bar
-    expect(DifferentReader.reader_scope).to eq DifferentReader
-    expect(StiReader.reader_scope).to eq StiReader
-  end
-end

data/spec/unread/reader_spec.rb

@@ -1,181 +0,0 @@
-require 'spec_helper'
-
-describe Unread::Reader do
-  before :each do
-    @reader = Reader.create! name: 'David'
-    @other_reader = Reader.create name: 'Matz'
-    @different_reader = DifferentReader.create! name: 'Behrooz', number: @reader.number
-    wait
-    @email1 = Email.create!
-    wait
-    @email2 = MultiLevelStiReadable.create!
-  end
-
-  describe :have_not_read do
-    it "should return all readers that have not read a given object" do
-      expect(Reader.have_not_read(@email1)).to eq [@reader, @other_reader]
-      expect(Reader.have_not_read(@email2)).to eq [@reader, @other_reader]
-    end
-
-    it "should return *only* the readers that have not read a given object" do
-      @email1.mark_as_read! for: @reader
-
-      expect(Reader.have_not_read(@email1)).to eq [@other_reader]
-      expect(Reader.have_not_read(@email1).count).to eq 1
-
-      expect(Reader.have_not_read(@email2)).to eq [@reader, @other_reader]
-    end
-
-    it "should take the type of reader into account" do
-      # even though the id of @reader and @different_reader is the same because
-      # they are different object types, the @email1 should only be marked as
-      # read for @reader.
-      @email1.mark_as_read! for: @reader
-
-      expect(Reader.have_not_read(@email1)).to eq [@other_reader]
-      expect(Reader.have_not_read(@email1).count).to eq 1
-
-      expect(DifferentReader.have_not_read(@email1)).to eq [@different_reader]
-      expect(DifferentReader.have_not_read(@email1).count).to eq 1
-
-      @email1.mark_as_read! for: @different_reader
-
-      expect(DifferentReader.have_not_read(@email1).count).to eq 0
-
-      expect(Reader.have_not_read(@email2)).to eq [@reader, @other_reader]
-    end
-
-    it "should not allow invalid parameter" do
-      [ 42, nil, 'foo', :foo, {} ].each do |not_a_readable|
-        expect {
-          Reader.have_not_read(not_a_readable)
-        }.to raise_error(ArgumentError)
-      end
-    end
-
-    it "should not allow unsaved readable" do
-      unsaved_readable = Email.new
-
-      expect {
-        Reader.have_not_read(unsaved_readable)
-      }.to raise_error(ArgumentError)
-    end
-  end
-
-  describe :have_read do
-    it "should return an empty array" do
-      expect(Reader.have_read(@email1)).to be_empty
-      expect(Reader.have_read(@email2)).to be_empty
-    end
-
-    it "should return *only* the readers that have read the given object" do
-      @email1.mark_as_read! for: @reader
-
-      expect(Reader.have_read(@email1)).to eq [@reader]
-      expect(Reader.have_read(@email1).count).to eq 1
-
-      expect(Reader.have_read(@email2)).to be_empty
-    end
-
-    it "should return the reader for all the object when all read" do
-      Email.mark_as_read! :all, for: @reader
-
-      expect(Reader.have_read(@email1)).to eq [@reader]
-      expect(Reader.have_read(@email1).count).to eq 1
-
-      expect(Reader.have_read(@email2)).to eq [@reader]
-      expect(Reader.have_read(@email2).count).to eq 1
-    end
-
-    it "should not allow invalid parameter" do
-      [ 42, nil, 'foo', :foo, {} ].each do |not_a_readable|
-        expect {
-          Reader.have_read(not_a_readable)
-        }.to raise_error(ArgumentError)
-      end
-    end
-
-    it "should not allow unsaved readable" do
-      unsaved_readable = Email.new
-
-      expect {
-        Reader.have_read(unsaved_readable)
-      }.to raise_error(ArgumentError)
-    end
-  end
-
-  describe :with_read_marks_for do
-    it "should return readers" do
-      expect(Reader.with_read_marks_for(@email1).to_a).to eq([@reader, @other_reader])
-    end
-
-    it "should have elements that respond to :read_mark_id" do
-      all_respond_to_read_mark_id = Reader.with_read_marks_for(@email1).to_a.all? do |reader|
-        reader.respond_to?(:read_mark_id)
-      end
-
-      expect(all_respond_to_read_mark_id).to be_truthy
-    end
-
-    it "should be countable" do
-      expect(Reader.with_read_marks_for(@email1).count(:number)).to eq(2)
-    end
-
-    it "should not allow invalid parameter" do
-      [ 42, nil, 'foo', :foo, {} ].each do |not_a_readable|
-        expect {
-          Reader.with_read_marks_for(not_a_readable)
-        }.to raise_error(ArgumentError)
-      end
-    end
-
-    it "should not allow unsaved readable" do
-      unsaved_readable = Email.new
-
-      expect {
-        Reader.with_read_marks_for(unsaved_readable)
-      }.to raise_error(ArgumentError)
-    end
-  end
-
-  describe :have_read? do
-    it "should recognize read objects" do
-      expect(@reader.have_read?(@email1)).to be_falsey
-      expect(@reader.have_read?(@email2)).to be_falsey
-    end
-
-    it "should handle updating object" do
-      @email1.mark_as_read! for: @reader
-      wait
-      expect(@reader.have_read?(@email1)).to be_truthy
-
-      @email1.update_attributes! subject: 'changed'
-      expect(@reader.have_read?(@email1)).to be_falsey
-    end
-
-    it "should raise error for invalid argument" do
-      expect {
-        @reader.have_read?(42)
-      }.to raise_error(ArgumentError)
-    end
-
-    it "should work with eager-loaded read marks" do
-      @email1.mark_as_read! for: @reader
-
-      expect {
-        readers = Reader.with_read_marks_for(@email1).to_a
-
-        expect(readers[0].have_read?(@email1)).to be_truthy
-        expect(readers[1].have_read?(@email1)).to be_falsey
-      }.to perform_queries(1)
-    end
-
-    it "should work with eager-loaded read marks for the correct readable" do
-      @email1.mark_as_read! for: @reader
-
-      readers = Reader.with_read_marks_for(@email1).to_a
-      expect(readers[0].have_read?(@email1)).to be_truthy
-      expect(readers[0].have_read?(@email2)).to be_falsey
-    end
-  end
-end