unparser 0.1.4 → 0.1.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: bd330877f92585ef66cfd283dba22e1d6202446c
-  data.tar.gz: ec9dbaaf5b7e460bc19e2f6564e25e016b4149c8
+  metadata.gz: 7b6b34a335d81e60393e168fed525e222b2c5300
+  data.tar.gz: dafb68722a32c72bd1200db7b92a1a6477f54c95
 SHA512:
-  metadata.gz: 2ac84d618bb92e5b9ec2f8360378c820f55545f993532febac3b5b4715cf85e16ccc88271fad3a2c6a8efa34e5297432799b0cc31481396807799c415ecab7b0
-  data.tar.gz: 45bc61077ae22a0c74538fda91621319ea99ace383338a5e6a6f90f66eb5e02ed88938f07f2d5f95999b1ed2372f68c8ddddc9009b23ea1df493854d6d52de90
+  metadata.gz: 77fda7c1b4c35dfad959a0a9c47bc9f5cdaae335fb3d302bb4b3f0e683c9733e6c6005ffe2495f0c91c0bf5d39e1b173bf99e1c918d13ef6f622d73079e4c534
+  data.tar.gz: b0252bbfb29b1c29b7e1de2fc7dd3719288c5b8227684558e7db7bc2c2cb347863123a10131a52c8ea6c2261a88879d6d64aec347189f68b09a7356a8e03531d

data/Changelog.md

@@ -1,3 +1,7 @@
+# v0.1.5 2013-11-01
+
+* Fix crash with comment reproduction.
+
 # v0.1.4 2013-11-01
 
 * Code cleanups.

data/config/rubocop.yml

@@ -41,6 +41,9 @@ AccessControl:
 LineLength:
   Max: 113  # TODO: lower to 79 once the rubocop branch in shared/Gemfile is removed
 
+ClassLength:
+  Max: 196
+
 # Disabled because of indenting with private keyword in class bodies.
 IndentationWidth:
   Enabled: false

data/lib/unparser/comments.rb

@@ -67,7 +67,7 @@ module Unparser
     #
     def take_before(node, source_part)
       location = node.location
-      if location
+      if location.respond_to?(source_part)
         range = location.public_send(source_part)
         take_while { |comment| comment.location.expression.end_pos <= range.begin_pos }
       else

data/spec/unit/unparser/comments/take_before_spec.rb

@@ -3,23 +3,45 @@ require 'parser/current'
 
 describe Unparser::Comments, '#take_before' do
 
-  let(:ast_and_comments) do
-    Parser::CurrentRuby.parse_with_comments(<<-RUBY)
-      def hi # EOL 1
-        # comment
-      end # EOL 2
-    RUBY
-  end
   let(:ast)      { ast_and_comments[0] }
   let(:comments) { ast_and_comments[1] }
   let(:object)   { described_class.new(comments) }
 
-  it 'should return no comments none are before the node' do
-    expect(object.take_before(ast, :expression)).to eql([])
+  context 'usual case' do
+
+    let(:ast_and_comments) do
+      Parser::CurrentRuby.parse_with_comments(<<-RUBY)
+        def hi # EOL 1
+          # comment
+        end # EOL 2
+      RUBY
+    end
+
+    it 'should return no comments none are before the node' do
+      expect(object.take_before(ast, :expression)).to eql([])
+    end
+
+    it 'should only the comments that are before the specified part of the node' do
+      expect(object.take_before(ast, :end)).to eql(comments.first(2))
+      expect(object.take_all).to eql([comments[2]])
+    end
   end
 
-  it 'should only the comments that are before the specified part of the node' do
-    expect(object.take_before(ast, :end)).to eql(comments.first(2))
-    expect(object.take_all).to eql([comments[2]])
+  context 'when node does not respond to source part' do
+
+    let(:ast_and_comments) do
+      Parser::CurrentRuby.parse_with_comments(<<-RUBY)
+        expression ? :foo : :bar # EOL 1
+        # EOL 2
+      RUBY
+    end
+
+    it 'should return no comments none are before the node' do
+      expect(object.take_before(ast, :expression)).to eql([])
+    end
+
+    it 'should only the comments that are before the specified part of the node' do
+      expect(object.take_before(ast, :end)).to eql([])
+    end
   end
 end

data/unparser.gemspec

@@ -2,7 +2,7 @@
 
 Gem::Specification.new do |s|
   s.name     = 'unparser'
-  s.version  = '0.1.4'
+  s.version  = '0.1.5'
 
   s.authors  = ['Markus Schirp']
   s.email    = 'mbj@schir-dso.com'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: unparser
 version: !ruby/object:Gem::Version
-  version: 0.1.4
+  version: 0.1.5
 platform: ruby
 authors:
 - Markus Schirp
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-11-01 00:00:00.000000000 Z
+date: 2013-11-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: parser