unobtrusive_flash 3.1.0 → 3.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 2eb8a0a2384eecefacf6fd3aff7dc0799567aca4
-  data.tar.gz: c4d0f68f87e5fc0f7b4b39725ad12b1b384e90e3
+  metadata.gz: bcf0d645c08a7ad2d63f5955edace9e8a4578be0
+  data.tar.gz: fdeae4c247e4ca3705983042b7697d77b4220406
 SHA512:
-  metadata.gz: b7ed858fbdb382db5a0823e3677a6f4609062710d9789fbd2924f86fd47bf1a0843ba90f9e2edd31297f9ae413a5281cf393c01940fbb910c02296fab3c00e95
-  data.tar.gz: ea0a2251c0366a6a81aae1f230d4a3982da82148d86cca0bc4ed0ee120fdecb9d2e6d7e9858602c37a7bd23da0d3fd4f980c1814a24c1d5e40168e538d3617ab
+  metadata.gz: b73cbd1239dcde8e44719d92f0e265ff70da474a6eb4e523ce399a6f49f2fd6cfbd5209b073929ed9d4de69e6c4e23f3f8fdfedce6ad545640e206650f5a1a50
+  data.tar.gz: acc75fb3ca59e8973ab6a318f438861112a8a864755c4700a9e44d8799e1cbaf9780f546fd6d62ac090a2761f7de896b5fe8f252c6ed5e787256f14747255d2e

data/.gitignore

@@ -14,4 +14,5 @@ rdoc
 spec/reports
 test/tmp
 test/version_tmp
-tmp
+tmp
+log

data/.travis.yml

@@ -1,6 +1,17 @@
+sudo: false
 language: ruby
 rvm:
-  - 1.9
-  - 2.0
-  - 2.1
-script: "rspec"
+- 1.9
+- 2.0
+- 2.2
+gemfile:
+  - gemfiles/rails_3.2.gemfile
+  - gemfiles/rails_4.0.gemfile
+  - gemfiles/rails_4.1.gemfile
+  - gemfiles/rails_4.2.gemfile
+env:
+  matrix:
+  - JQUERY_VERSION=2.1.1
+  - JQUERY_VERSION=1.11.1
+
+script: bundle exec rake spec

data/Appraisals

@@ -0,0 +1,25 @@
+appraise "rails-3.2" do
+  gem "rails", "~>3.2.22"
+  gem 'jquery-rails', '~> 2.1'
+end
+
+appraise "rails-4.0" do
+  gem "rails", "~>4.0.13"
+  gem 'jquery-rails', '~> 2.1'
+  gem 'turbolinks'
+  gem 'jquery-turbolinks', '>2'
+end
+
+appraise "rails-4.1" do
+  gem "rails", "~>4.1.13"
+  gem 'jquery-rails', '~> 2.1'
+  gem 'turbolinks'
+  gem 'jquery-turbolinks', '>2'
+end
+
+appraise "rails-4.2" do
+  gem "rails", "~>4.2.4"
+  gem 'jquery-rails', '~> 2.1'
+  gem 'turbolinks'
+  gem 'jquery-turbolinks', '>2'
+end

data/CHANGELOG.md

@@ -1,3 +1,12 @@
+## 2015-11-06 3.2.0
+
+* Support passing flash with non-successful (non-200) AJAX requests thanks to @Markwallow [#28]
+* Tested with Rails 4.2
+
+## 2015-10-23 3.1.1
+
+* Fix typo that didn't clear domainless cookies thanks to @pavelgnom [#23]
+
 ## 2014-06-23 3.1.0
 
 * Extracted default flash options to `UnobtrusiveFlash.flashOptions` so you can set the message timeout.
@@ -25,4 +34,4 @@
 * Dropped compatibility with Rails 2
 * Decoupled logic from presentation
 * Compatibility with Bootstrap
-* Event-driven architecture
+* Event-driven architecture

data/README.markdown

@@ -13,28 +13,26 @@ about 3 extra lines of code in your app - how's that for unobtrusive?
 You can pass up to 4K of text into flash this way, and you don't need to worry about cookie size since they are
 cleared immediately upon rendering.
 
-Tested in: 
-
-* Internet Explorer 8 and later
-* Firefox up to v24
-* Chrome up to v30
-* Safari 6
-* Opera 12
+Tested in all major browsers, including Internet Explorer 8 and later.
 
 ## Requirements
 
-* Rails >=3
-* jQuery (tested with v1.10)
+* Rails >=3 (Latest versions of 3.2, 4.0, 4.1, 4.2 are automatically tested)
+* jQuery (Latest versions of both jQuery 1 and jQuery 2 are automatically tested)
 
 ## Usage
 
 1. Add the `unobtrusive_flash` gem to your Gemfile.
 
-        gem 'unobtrusive_flash', '>=3'
+    ```ruby
+    gem 'unobtrusive_flash', '>=3'
+    ```
 
 2. Add the following to the controllers that generate flash messages (or better, to the `ApplicationController`):
 
-        after_filter :prepare_unobtrusive_flash
+    ```ruby
+    after_filter :prepare_unobtrusive_flash
+    ```
 
     Flash messages are HTML escaped in the same manner as regular Rails view code: if a message is not `html_safe`, it is escaped, otherwise not. This lets you use helpers such as `link_to` in your messages.
 
@@ -52,7 +50,9 @@ Either declare a `.unobtrusive-flash-container` element somewhere on the page to
 
 If you want the flash messages to disappear automatically, set this in your Javascript:
 
-    UnobtrusiveFlash.flashOptions['timeout'] = 2000; // milliseconds
+```javascript
+UnobtrusiveFlash.flashOptions['timeout'] = 2000; // milliseconds
+```
 
 ### Option 2: For non-Bootstrap projects
 
@@ -60,30 +60,64 @@ Also `require unobtrusive_flash_ui` in your `application.js` and `require unobtr
 
 If you want the flash messages to disappear automatically, set this in your Javascript:
 
-    UnobtrusiveFlash.flashOptions['timeout'] = 2000; // milliseconds
+```javascript
+UnobtrusiveFlash.flashOptions['timeout'] = 2000; // milliseconds
+```
 
 ### Option 3: Roll your own
 
 Unobtrusive Flash triggers jQuery events when flash is received. If you want to integrate it with your own UI, implement and bind a handler:
 
-    flashHandler = function(e, params) {
-      alert('Received flash message '+params.message+' with type '+params.type);
-    };
+```javascript
+flashHandler = function(e, params) {
+  alert('Received flash message '+params.message+' with type '+params.type);
+};
 
-    $(window).bind('rails:flash', flashHandler);
+$(window).bind('rails:flash', flashHandler);
+```
 
 ## Using UnobtrusiveFlash with a frontend framework that doesn't use jQuery for AJAX
 
 Call `UnobtrusiveFlash.showFlashFromCookies()` in your Javascript after a completed request.
- 
+
 ## Bonus: show 'flash messages' from the front-end
 
 Both Bootstrap and non-Bootstrap versions contain a function to display flash messages:
 
-    // Shown for 5 seconds (default)
-    UnobtrusiveFlash.showFlashMessage('Hello World', {type: 'notice'})
-    // Shown forever
-    UnobtrusiveFlash.showFlashMessage('Error', {type: 'error', timeout: 0})
+```javascript
+// Shown for 5 seconds (default)
+UnobtrusiveFlash.showFlashMessage('Hello World', {type: 'notice'})
+// Shown forever
+UnobtrusiveFlash.showFlashMessage('Error', {type: 'error', timeout: 0})
+```
+
+## Issue with certain "hosted domains"
+
+There are [certain domains](https://publicsuffix.org/list/) that are considered "public" or "hosting" and specifically don't share cookies across subdomains. An example is `herokuapp.com` - a cookie set for `yourapp.herokuapp.com` will not be applied for `myapp.herokuapp.com`. This breaks the logic of `unobtrusive_flash` which is tuned for regular domains that could have internal subdomains.
+
+In this case, you should explicitly specify your domain:
+
+```ruby
+class ApplicationController
+  def unobtrusive_flash_domain
+    request.host # last resort is hardcoding the domain here
+  end
+end
+```
+
+## Running tests
+
+This plugin's test suite includes a full set of integration tests for various versions of Rails. To run them:
+
+```shell
+bundle install
+appraisal install
+appraisal rake spec
+```
+
+The same tests are ran on Travis CI against multiple versions of Ruby and jQuery.
+
+The Travis CI build does not test turbolinks as of now, because PhantomJS 1 does not support the necessary APIs. However, if you run the tests outside of Travis, they will use Selenium and perform a full range of tests.
 
 * * *
 

data/Rakefile

@@ -1 +1,7 @@
 require "bundler/gem_tasks"
+require 'rspec/core/rake_task'
+require 'rails' # for Sauce to work
+
+RSpec::Core::RakeTask.new(:spec)
+
+task :default => :spec

data/gemfiles/rails_3.2.gemfile

@@ -0,0 +1,8 @@
+# This file was generated by Appraisal
+
+source "https://rubygems.org"
+
+gem "rails", "~>3.2.22"
+gem "jquery-rails", "~> 2.1"
+
+gemspec :path => "../"

data/gemfiles/rails_3.2.gemfile.lock

@@ -0,0 +1,155 @@
+PATH
+  remote: ../
+  specs:
+    unobtrusive_flash (3.1.1)
+      railties
+
+GEM
+  remote: https://rubygems.org/
+  specs:
+    actionmailer (3.2.22)
+      actionpack (= 3.2.22)
+      mail (~> 2.5.4)
+    actionpack (3.2.22)
+      activemodel (= 3.2.22)
+      activesupport (= 3.2.22)
+      builder (~> 3.0.0)
+      erubis (~> 2.7.0)
+      journey (~> 1.0.4)
+      rack (~> 1.4.5)
+      rack-cache (~> 1.2)
+      rack-test (~> 0.6.1)
+      sprockets (~> 2.2.1)
+    activemodel (3.2.22)
+      activesupport (= 3.2.22)
+      builder (~> 3.0.0)
+    activerecord (3.2.22)
+      activemodel (= 3.2.22)
+      activesupport (= 3.2.22)
+      arel (~> 3.0.2)
+      tzinfo (~> 0.3.29)
+    activeresource (3.2.22)
+      activemodel (= 3.2.22)
+      activesupport (= 3.2.22)
+    activesupport (3.2.22)
+      i18n (~> 0.6, >= 0.6.4)
+      multi_json (~> 1.0)
+    appraisal (2.1.0)
+      bundler
+      rake
+      thor (>= 0.14.0)
+    arel (3.0.3)
+    builder (3.0.4)
+    capybara (2.5.0)
+      mime-types (>= 1.16)
+      nokogiri (>= 1.3.3)
+      rack (>= 1.0.0)
+      rack-test (>= 0.5.4)
+      xpath (~> 2.0)
+    childprocess (0.5.6)
+      ffi (~> 1.0, >= 1.0.11)
+    cliver (0.3.2)
+    diff-lcs (1.2.5)
+    erubis (2.7.0)
+    ffi (1.9.10)
+    hike (1.2.3)
+    i18n (0.7.0)
+    journey (1.0.4)
+    jquery-rails (2.3.0)
+      railties (>= 3.0, < 5.0)
+      thor (>= 0.14, < 2.0)
+    json (1.8.3)
+    mail (2.5.4)
+      mime-types (~> 1.16)
+      treetop (~> 1.4.8)
+    mime-types (1.25.1)
+    mini_portile (0.6.2)
+    multi_json (1.11.2)
+    nokogiri (1.6.6.2)
+      mini_portile (~> 0.6.0)
+    poltergeist (1.7.0)
+      capybara (~> 2.1)
+      cliver (~> 0.3.1)
+      multi_json (~> 1.0)
+      websocket-driver (>= 0.2.0)
+    polyglot (0.3.5)
+    rack (1.4.7)
+    rack-cache (1.5.0)
+      rack (>= 0.4)
+    rack-ssl (1.3.4)
+      rack
+    rack-test (0.6.3)
+      rack (>= 1.0)
+    rails (3.2.22)
+      actionmailer (= 3.2.22)
+      actionpack (= 3.2.22)
+      activerecord (= 3.2.22)
+      activeresource (= 3.2.22)
+      activesupport (= 3.2.22)
+      bundler (~> 1.0)
+      railties (= 3.2.22)
+    railties (3.2.22)
+      actionpack (= 3.2.22)
+      activesupport (= 3.2.22)
+      rack-ssl (~> 1.3.2)
+      rake (>= 0.8.7)
+      rdoc (~> 3.4)
+      thor (>= 0.14.6, < 2.0)
+    rake (10.4.2)
+    rdoc (3.12.2)
+      json (~> 1.4)
+    rspec (3.3.0)
+      rspec-core (~> 3.3.0)
+      rspec-expectations (~> 3.3.0)
+      rspec-mocks (~> 3.3.0)
+    rspec-core (3.3.2)
+      rspec-support (~> 3.3.0)
+    rspec-expectations (3.3.1)
+      diff-lcs (>= 1.2.0, < 2.0)
+      rspec-support (~> 3.3.0)
+    rspec-mocks (3.3.2)
+      diff-lcs (>= 1.2.0, < 2.0)
+      rspec-support (~> 3.3.0)
+    rspec-support (3.3.0)
+    rubyzip (1.1.7)
+    selenium-webdriver (2.48.1)
+      childprocess (~> 0.5)
+      multi_json (~> 1.0)
+      rubyzip (~> 1.0)
+      websocket (~> 1.0)
+    sprockets (2.2.3)
+      hike (~> 1.2)
+      multi_json (~> 1.0)
+      rack (~> 1.0)
+      tilt (~> 1.1, != 1.3.0)
+    thor (0.19.1)
+    tilt (1.4.1)
+    treetop (1.4.15)
+      polyglot
+      polyglot (>= 0.3.1)
+    tzinfo (0.3.45)
+    websocket (1.2.2)
+    websocket-driver (0.6.2)
+      websocket-extensions (>= 0.1.0)
+    websocket-extensions (0.1.2)
+    xpath (2.0.0)
+      nokogiri (~> 1.3)
+
+PLATFORMS
+  ruby
+
+DEPENDENCIES
+  appraisal
+  bundler (~> 1.3)
+  capybara (>= 2.5)
+  jquery-rails (~> 2.1)
+  poltergeist
+  rails (~> 3.2.22)
+  rake
+  rspec (~> 3)
+  rspec-mocks (~> 3)
+  selenium-webdriver
+  unobtrusive_flash!
+
+BUNDLED WITH
+   1.10.6

data/gemfiles/rails_4.0.gemfile

@@ -0,0 +1,10 @@
+# This file was generated by Appraisal
+
+source "https://rubygems.org"
+
+gem "rails", "~>4.0.13"
+gem "jquery-rails", "~> 2.1"
+gem "turbolinks"
+gem "jquery-turbolinks", ">2"
+
+gemspec :path => "../"

data/gemfiles/rails_4.0.gemfile.lock

@@ -0,0 +1,153 @@
+PATH
+  remote: ../
+  specs:
+    unobtrusive_flash (3.1.1)
+      railties
+
+GEM
+  remote: https://rubygems.org/
+  specs:
+    actionmailer (4.0.13)
+      actionpack (= 4.0.13)
+      mail (~> 2.5, >= 2.5.4)
+    actionpack (4.0.13)
+      activesupport (= 4.0.13)
+      builder (~> 3.1.0)
+      erubis (~> 2.7.0)
+      rack (~> 1.5.2)
+      rack-test (~> 0.6.2)
+    activemodel (4.0.13)
+      activesupport (= 4.0.13)
+      builder (~> 3.1.0)
+    activerecord (4.0.13)
+      activemodel (= 4.0.13)
+      activerecord-deprecated_finders (~> 1.0.2)
+      activesupport (= 4.0.13)
+      arel (~> 4.0.0)
+    activerecord-deprecated_finders (1.0.4)
+    activesupport (4.0.13)
+      i18n (~> 0.6, >= 0.6.9)
+      minitest (~> 4.2)
+      multi_json (~> 1.3)
+      thread_safe (~> 0.1)
+      tzinfo (~> 0.3.37)
+    appraisal (2.1.0)
+      bundler
+      rake
+      thor (>= 0.14.0)
+    arel (4.0.2)
+    builder (3.1.4)
+    capybara (2.5.0)
+      mime-types (>= 1.16)
+      nokogiri (>= 1.3.3)
+      rack (>= 1.0.0)
+      rack-test (>= 0.5.4)
+      xpath (~> 2.0)
+    childprocess (0.5.6)
+      ffi (~> 1.0, >= 1.0.11)
+    cliver (0.3.2)
+    coffee-rails (4.1.0)
+      coffee-script (>= 2.2.0)
+      railties (>= 4.0.0, < 5.0)
+    coffee-script (2.4.1)
+      coffee-script-source
+      execjs
+    coffee-script-source (1.9.1.1)
+    diff-lcs (1.2.5)
+    erubis (2.7.0)
+    execjs (2.6.0)
+    ffi (1.9.10)
+    i18n (0.7.0)
+    jquery-rails (2.3.0)
+      railties (>= 3.0, < 5.0)
+      thor (>= 0.14, < 2.0)
+    jquery-turbolinks (2.1.0)
+      railties (>= 3.1.0)
+      turbolinks
+    mail (2.6.3)
+      mime-types (>= 1.16, < 3)
+    mime-types (2.6.2)
+    mini_portile (0.6.2)
+    minitest (4.7.5)
+    multi_json (1.11.2)
+    nokogiri (1.6.6.2)
+      mini_portile (~> 0.6.0)
+    poltergeist (1.7.0)
+      capybara (~> 2.1)
+      cliver (~> 0.3.1)
+      multi_json (~> 1.0)
+      websocket-driver (>= 0.2.0)
+    rack (1.5.5)
+    rack-test (0.6.3)
+      rack (>= 1.0)
+    rails (4.0.13)
+      actionmailer (= 4.0.13)
+      actionpack (= 4.0.13)
+      activerecord (= 4.0.13)
+      activesupport (= 4.0.13)
+      bundler (>= 1.3.0, < 2.0)
+      railties (= 4.0.13)
+      sprockets-rails (~> 2.0)
+    railties (4.0.13)
+      actionpack (= 4.0.13)
+      activesupport (= 4.0.13)
+      rake (>= 0.8.7)
+      thor (>= 0.18.1, < 2.0)
+    rake (10.4.2)
+    rspec (3.3.0)
+      rspec-core (~> 3.3.0)
+      rspec-expectations (~> 3.3.0)
+      rspec-mocks (~> 3.3.0)
+    rspec-core (3.3.2)
+      rspec-support (~> 3.3.0)
+    rspec-expectations (3.3.1)
+      diff-lcs (>= 1.2.0, < 2.0)
+      rspec-support (~> 3.3.0)
+    rspec-mocks (3.3.2)
+      diff-lcs (>= 1.2.0, < 2.0)
+      rspec-support (~> 3.3.0)
+    rspec-support (3.3.0)
+    rubyzip (1.1.7)
+    selenium-webdriver (2.48.1)
+      childprocess (~> 0.5)
+      multi_json (~> 1.0)
+      rubyzip (~> 1.0)
+      websocket (~> 1.0)
+    sprockets (3.4.0)
+      rack (> 1, < 3)
+    sprockets-rails (2.3.3)
+      actionpack (>= 3.0)
+      activesupport (>= 3.0)
+      sprockets (>= 2.8, < 4.0)
+    thor (0.19.1)
+    thread_safe (0.3.5)
+    turbolinks (2.5.3)
+      coffee-rails
+    tzinfo (0.3.45)
+    websocket (1.2.2)
+    websocket-driver (0.6.2)
+      websocket-extensions (>= 0.1.0)
+    websocket-extensions (0.1.2)
+    xpath (2.0.0)
+      nokogiri (~> 1.3)
+
+PLATFORMS
+  ruby
+
+DEPENDENCIES
+  appraisal
+  bundler (~> 1.3)
+  capybara (>= 2.5)
+  jquery-rails (~> 2.1)
+  jquery-turbolinks (> 2)
+  poltergeist
+  rails (~> 4.0.13)
+  rake
+  rspec (~> 3)
+  rspec-mocks (~> 3)
+  selenium-webdriver
+  turbolinks
+  unobtrusive_flash!
+
+BUNDLED WITH
+   1.10.6