unix_utils 0.0.6 → 0.0.7

data/History.txt

@@ -1,3 +1,9 @@
+== 0.0.7 / 2012-04-11
+
+* Bug fixes
+
+  * Make sure UnixUtils.tmp_path doesn't create too-long filenames
+
 == 0.0.6 / 2012-04-11
 
 * Enhancements

data/lib/unix_utils.rb

@@ -243,11 +243,12 @@ module UnixUtils
   end
 
   def self.tmp_path(ancestor, extname = nil) # :nodoc:
+    ancestor = ancestor.to_s
     extname ||= ::File.extname ancestor
-    basename = ::File.basename ancestor.sub(/^unix_utils-[0-9]+-/, '').gsub(/\W+/, '_')
-    name = basename + extname
+    basename = ::File.basename ancestor.sub(/^unix_utils-[0-9]+-/, '')
+    basename.gsub! /\W+/, '_'
     ::Kernel.srand
-    ::File.join ::Dir.tmpdir, "unix_utils-#{::Kernel.rand(1e11)}-#{name}"
+    ::File.join ::Dir.tmpdir, "unix_utils-#{::Kernel.rand(1e11)}-#{basename[0..(231-extname.length)]}#{extname}"
   end
 
   def self.spawn(argv, options = {}) # :nodoc:

data/lib/unix_utils/version.rb

@@ -1,3 +1,3 @@
 module UnixUtils
-  VERSION = "0.0.6"
+  VERSION = "0.0.7"
 end

data/test/test_unix_utils.rb

@@ -401,4 +401,22 @@ describe UnixUtils do
       safe_delete outfile
     end
   end
+
+  describe :tmp_path do
+    it "includes basename of ancestor" do
+      UnixUtils.tmp_path("dirname1/dirname2/basename.extname").must_include 'basename'
+    end
+    it "includes extname of ancestor" do
+      UnixUtils.tmp_path("dirname1/dirname2/basename.extname").must_include 'extname'
+    end
+    it "optionally appends extname" do
+      File.extname(UnixUtils.tmp_path("dirname1/dirname2/basename.extname", '.foobar')).must_equal '.foobar'
+    end
+    it "doesn't create excessively long filenames" do
+      File.basename(UnixUtils.tmp_path("a"*5000)).length.must_equal 255
+    end
+    it "doesn't include directory part of ancestor" do
+      UnixUtils.tmp_path("dirname1/dirname2/basename.extname").wont_include 'dirname1'
+    end
+  end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: unix_utils
 version: !ruby/object:Gem::Version
-  version: 0.0.6
+  version: 0.0.7
   prerelease: 
 platform: ruby
 authors: