unit4-checkout 0.2.0 → 0.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: daaa49e8775ebbc94ab1fcd91ebc047772dcf21a129487c1a7661ee4137071ff
-  data.tar.gz: 64c3fcd3083a1d907505c05df723ae6b380968ebdf99f7e3b59a87a8b7e4a46e
+  metadata.gz: 3539766a2698101358c85167d1f34d563461cdc23b24098439e1948c2e815fba
+  data.tar.gz: 40bc469e6c776039f1d2d424b73d9904e08546181af2f95a117fbd9b4e39d553
 SHA512:
-  metadata.gz: ea07d980c46d2cb90f2d8b2e3db5049438472b70d6562246a59d457548d8066b42b0b0566f768372a44c89cc18540185e8b70763cb68d36483bb805136b4993e
-  data.tar.gz: fc7d39fe9a7b4b383d1b8d77f4f96f1a46f6b279f1d501302f00bac20f7575c246c1534134d50c238549e1656dcbaceaffbac965de79aee4b1ddde8ed18d2041
+  metadata.gz: 7abf3c6c31eeaff5105c9f966d8751e14e94aeb585c31a7a6c3e42321797429ce6ae1e6a7fcd083e30801df9b4795144be22967bb5d759c81ca94af447ce146d
+  data.tar.gz: d5c3abb4a0ce0c7599fc5193d44d73560b7de229b1bdb8c9a1607ee71ab2dd569a860292487a9b05fac605082f950a0e6d001fc20a9e119940b03490c6e4a073

data/Gemfile

@@ -14,5 +14,3 @@ gem "rubocop", "~> 1.21"
 gem "activerecord"
 
 gem "erb"
-
-gem "sqlite3"

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    unit4-checkout (0.1.3)
+    unit4-checkout (0.2.0)
 
 GEM
   remote: https://rubygems.org/
@@ -57,7 +57,6 @@ GEM
     rubocop-ast (1.15.2)
       parser (>= 3.0.1.1)
     ruby-progressbar (1.11.0)
-    sqlite3 (1.4.4)
     tzinfo (2.0.5)
       concurrent-ruby (~> 1.0)
     unicode-display_width (2.1.0)
@@ -71,7 +70,6 @@ DEPENDENCIES
   rake (~> 13.0)
   rspec (~> 3.0)
   rubocop (~> 1.21)
-  sqlite3
   unit4-checkout!
 
 BUNDLED WITH

data/lib/unit4/checkout/checkout.rb

@@ -1,25 +1,26 @@
 # frozen_string_literal: true
 
-require "active_record"
-require "erb"
-
 class Checkout
-  attr_reader :promotional_rules, :total, :basket, :total_price_discount_applied_flag, :result
+  attr_reader :total
 
   def initialize(promotional_rules = {})
-    raise TypeError, "expected a Hash, got #{promotional_rules.class.name}" unless promotional_rules.is_a? Hash
-    raise KeyError, "expected Hash with optional keys 'product_discounts' and 'total_price_discount" unless correct_keys?(promotional_rules)
+    raise PromotionalRulesTypeError, promotional_rules.class.name unless promotional_rules.is_a? Hash
+    raise PromotionalRulesForbiddenKeys unless correct_keys?(promotional_rules)
 
     @promotional_rules = promotional_rules
     @total = 0
     @basket = Basket.new
-    establish_connection
+    create_db_connection
   end
 
   def correct_keys?(promotional_rules)
     (promotional_rules.keys - %i[product_discounts total_price_discount]).empty?
   end
 
+  def create_db_connection
+    Connection.new
+  end
+
   # maybe facilitate scanning multiple items at once
   # no structure for item given, assumed id
   def scan(item)
@@ -27,7 +28,6 @@ class Checkout
     add_to_basket(item)
     calculate_total(item)
     puts "Item with ID '#{item}' has been added to the basket successfully!"
-    @total
   end
 
   def calculate_total(item)
@@ -38,18 +38,12 @@ class Checkout
       item_discounted?(item) ? apply_item_discount(item, item_price) : @total += item_price
       apply_total_discount if total_price_discounted?
     end
-    @total = @total.ceil(2)
+    @total = @total.round(2)
   end
 
   def item_price(item)
-    # TODO: check if user has supplied price
     # TODO: facilitate DB name different from products, i.e. ask gem user for db name???
-    find_price_sql(item)
-  end
-
-  def prepare_sql_statement(item)
-    # TODO: keep seen items in cache or variable  !!!!!!!!!
-    ActiveRecord::Base.sanitize_sql_array(["SELECT 'products'.'price' FROM 'products' WHERE 'products'.'id' = ?", item])
+    PriceQuery.new(item).find_price
   end
 
   def apply_item_and_total_discount(item, item_price)
@@ -106,32 +100,6 @@ class Checkout
     @total_price_discount_applied_flag = true
   end
 
-  def find_price_sql(item)
-    sanitized_query = prepare_sql_statement(item)
-    results = ActiveRecord::Base.connection.exec_query(sanitized_query)
-    results.rows.first.first if results.present?
-  end
-
-  def establish_connection
-    db_config = setup_db_config
-    ActiveRecord::Base.establish_connection(adapter: db_config["adapter"], database: db_config["database"])
-  end
-
-  def setup_db_config
-    defined?(Rails) && defined?(Rails.env) ? rails_db_config : non_rails_db_config
-  end
-
-  def rails_db_config
-    Rails.application.config.database_configuration[Rails.env]
-  end
-
-  def non_rails_db_config
-    # TODO: use current database instead of development
-    YAML.safe_load(ERB.new(File.read("./config/database.yml")).result, aliases: true)["development"]
-  end
-
-  # maybe add remove item function
-
   def add_to_basket(item)
     @basket.items[item] ? @basket.items[item] += 1 : @basket.items[item] = 1
   end

data/lib/unit4/checkout/connection.rb

@@ -0,0 +1,24 @@
+# frozen_string_literal: true
+
+require "active_record"
+require "erb"
+
+class Connection
+  def initialize
+    db_config = setup_db_config
+    ActiveRecord::Base.establish_connection(adapter: db_config["adapter"], database: db_config["database"])
+  end
+
+  def setup_db_config
+    defined?(Rails) && defined?(Rails.env) ? rails_db_config : non_rails_db_config
+  end
+
+  def rails_db_config
+    Rails.application.config.database_configuration[Rails.env]
+  end
+
+  def non_rails_db_config
+    # TODO: use current database instead of development
+    YAML.safe_load(ERB.new(File.read("./config/database.yml")).result, aliases: true)["development"]
+  end
+end

data/lib/unit4/checkout/exceptions.rb

@@ -0,0 +1,16 @@
+# frozen_string_literal: true
+
+class PromotionalRulesTypeError < TypeError
+  def initialize(class_name, msg = "expected a Hash, got ", exception_type = "custom")
+    msg += class_name
+    @exception_type = exception_type
+    super(msg)
+  end
+end
+
+class PromotionalRulesForbiddenKeys < TypeError
+  def initialize(msg = "expected Hash with optional keys 'product_discounts' and 'total_price_discount", exception_type = "custom")
+    @exception_type = exception_type
+    super(msg)
+  end
+end

data/lib/unit4/checkout/price_query.rb

@@ -0,0 +1,16 @@
+class PriceQuery
+
+  def initialize(item)
+    @sanitized_query = prepare_sql_statement(item)
+  end
+
+  def prepare_sql_statement(item)
+    # TODO: keep seen items in cache or variable  !!!!!!!!!
+    ActiveRecord::Base.sanitize_sql_array(["SELECT 'products'.'price' FROM 'products' WHERE 'products'.'id' = ?", item])
+  end
+
+  def find_price
+    results = ActiveRecord::Base.connection.exec_query(@sanitized_query)
+    results.rows.first.first if results.present?
+  end
+end

data/lib/unit4/checkout/version.rb

@@ -2,6 +2,6 @@
 
 module Unit4
   module Checkout
-    VERSION = "0.2.0"
+    VERSION = "0.2.1"
   end
 end

data/lib/unit4/checkout.rb

@@ -3,6 +3,9 @@
 require_relative "checkout/version"
 require_relative "checkout/checkout"
 require_relative "checkout/basket"
+require_relative "checkout/connection"
+require_relative "checkout/price_query"
+require_relative "checkout/exceptions"
 
 module Unit4
   module Checkout

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: unit4-checkout
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.2.1
 platform: ruby
 authors:
 - Boyan Georgiev
@@ -10,7 +10,8 @@ bindir: exe
 cert_chain: []
 date: 2022-07-22 00:00:00.000000000 Z
 dependencies: []
-description: Initial commit
+description: A Ruby gem that helps the user implement a checkout system by supplying
+  only the promotional rules
 email:
 - bbgeorgiev96@gmail.com
 executables: []
@@ -26,10 +27,14 @@ files:
 - lib/unit4/checkout.rb
 - lib/unit4/checkout/basket.rb
 - lib/unit4/checkout/checkout.rb
+- lib/unit4/checkout/connection.rb
+- lib/unit4/checkout/exceptions.rb
+- lib/unit4/checkout/price_query.rb
 - lib/unit4/checkout/version.rb
 - sig/unit4/checkout.rbs
 homepage: https://github.com/BoyanGeorgiev96/unit4-checkout
-licenses: []
+licenses:
+- MIT
 metadata:
   allowed_push_host: https://rubygems.org/
   homepage_uri: https://github.com/BoyanGeorgiev96/unit4-checkout
@@ -52,5 +57,5 @@ requirements: []
 rubygems_version: 3.3.3
 signing_key:
 specification_version: 4
-summary: Initial commit
+summary: Checkout gem for Unit4 technical task
 test_files: []