unique_validation_inspector 0.2.0 → 0.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 657d8b8f263904dcf7ddc6bd423c28de265fe5e0
-  data.tar.gz: f1a2ddead37ddd750d97ed91c7831937263917f6
+  metadata.gz: 58622ad0fd72e028cbfaf0120a3f5ca17608df0d
+  data.tar.gz: c45ece8f05bf7446d2563caf9f7cc40745a7e0ab
 SHA512:
-  metadata.gz: b1b2d0d481f3d1d0e156ee6de7a913363a98c76e05a4c7fc93078471ad25a3da2d651fcd3a0c73e838d0dd58916e14119b907a8578df96d2d576ae80d347fdb5
-  data.tar.gz: 72ce6e1f88ffeef1d9ea43d68df50226e7885c0c7d83461d0acc0da75f5912d4c60dc1c7793d2ff64a8614b9a4980aff1c612f93fdb876c72babfc134d60b3d8
+  metadata.gz: 3b73b05f061e7c8f5cc7dbffae6364e3d418aedcb477b20699605651a02f6e365c57070c1bf3c393db3d7755f4f360152dc1d207768722004dcd7e0cf674520d
+  data.tar.gz: 596425f9a286607a3293029f128f6b198022cb1f398b3d12113ae2467fc718021711876b279cfe9202e0cb8da7974715c11bc62bd79f5fdd5d1f92dcc4f475cb

data/CHANGELOG.md

@@ -1,14 +1,30 @@
+## 0.3.0 (February 28, 2018)
+
+#### Features
+
+* Now we look for unique DB indexes only ([#4](https://github.com/soulfly/unique_validation_inspector/pull/4) by [@mrdougwright](https://github.com/mrdougwright))
+
+#### Fixes
+
+* Issue where DB indexes for validations with scope were not properly recognized ([#4](https://github.com/soulfly/unique_validation_inspector/pull/4) by [@mrdougwright](https://github.com/mrdougwright))
+
+## 0.2.0 (September 16, 2017)
+
+#### Features
+
+* Better output message format
+
 ## 0.1.3 (August 23, 2017)
 
 #### Fixes
 
-* No models are loaded on some apps (https://github.com/soulfly/unique_validation_inspector/pull/2)
+* No models are loaded on some apps ([#2](https://github.com/soulfly/unique_validation_inspector/pull/2))
 
 ## 0.1.2 (August 14, 2017)
 
 #### Fixes
 
-* Task fails with abstract model with no table on db (https://github.com/soulfly/unique_validation_inspector/issues/1)
+* Task fails with abstract model with no table on db ([#1](https://github.com/soulfly/unique_validation_inspector/issues/1))
 
 ## 0.1.1 (August 11, 2017)
 

data/README.md

@@ -12,16 +12,18 @@ For example, you have **User** model and uniqueness validation for **facebook_id
 ```sql
  SELECT  1 AS one FROM `users` WHERE (`users`.`facebook_id ` = 1523123128921623) LIMIT 1
 ```
-If you do not have DB index for **facebook_id** field then your **Model.create**, **Model.save**, **Model.update** ... operations will be slower and slower with user base grow. 
+If you do not have DB index for **facebook_id** field then your **Model.create**, **Model.save**, **Model.update** ... operations will be slower and slower with user base grow.
 
 So this gem is here to notify you about it.
 
-Read [How I Reduced my DB Server Load by 80%](https://schneems.com/2017/07/18/how-i-reduced-my-db-server-load-by-80/) article to understand what kind of performance issues you may have without proper indexes.
+Read [Rails: make sure you have proper DB indexes for your model’s unique validations](https://medium.com/@igorkhomenko/rails-make-sure-you-have-proper-db-indexes-for-your-models-unique-validations-ffd0364df26f) article to understand what kind of performance issues you may have without proper indexes.
+
+Also read [How I Reduced my DB Server Load by 80%](https://schneems.com/2017/07/18/how-i-reduced-my-db-server-load-by-80/) article.
 
 ## Supported versions
-* Ruby 1.8.7, 1.9.2, 1.9.3, 2.0, 2.1, 2.2, 2.3, 2.4, 2.5 (trunk)
+* Ruby 1.8.7, 1.9.2, 1.9.3, 2.0, 2.1, 2.2, 2.3, 2.4, 2.5
 
-* Rails 3.0.x, 3.1.x, 3.2.x, 4.0.x, 4.1.x, 5.0.x
+* Rails 3.0.x, 3.1.x, 3.2.x, 4.0.x, 4.1.x, 5.0.x, 5.1.x, 5.2.x
 
 ## Installation
 
@@ -59,10 +61,15 @@ Model 'User':
 [:facebook_id] (scope 'application_id'). Index exists: true
 [:twitter_id] (scope 'application_id'). Index exists: false
 [:external_user_id] (scope 'application_id'). Index exists: false
-[:blob_id] (scope ''). Index exists: true
+[:blob_id]. Index exists: true
 ```
 All things with **Index exists: false** are problematic and you should fix it by adding proper DB indexes.
 
+Consider use one of the following solutions to resolve above issues:
+* Add proper DB index.
+* Move unique validation to DB level.
+More info in the article https://medium.com/@igorkhomenko/rails-make-sure-you-have-proper-db-indexes-for-your-models-unique-validations-ffd0364df26f
+
 ## Copyright
 
 Copyright © 2017 Igor Khomenko. See LICENSE file for further details.

data/lib/unique_validation_inspector.rb

@@ -12,7 +12,6 @@ module UniqueValidationInspector
 
     def initialize(app)
       @app = app
-
     end
 
     def load_everything!
@@ -31,16 +30,23 @@ module UniqueValidationInspector
         validators = model.validators.select {|v| v.is_a?(ActiveRecord::Validations::UniquenessValidator) }
         {:model => model,  :validators => validators}
       end
-
     end
 
-    def defined_unique_indexes(table_name, fields, scope)
+    def defined_unique_indexes(table_name, field, scope)
       #https://dev.mysql.com/doc/refman/5.7/en/multiple-column-indexes.html
-
       columns = []
-      columns += fields
-      columns.unshift(scope) if scope
-      ActiveRecord::Base.connection.indexes(table_name.to_sym).any? { |i| [lambda { |i| i.columns == columns.map(&:to_s) }].all? { |check| check[i] } }
+      columns += field
+      columns = columns + Array(scope) if scope
+
+      unique_indexes(table_name).any? do |index_def|
+        columns.map(&:to_s) == index_def.columns
+      end
+    end
+
+    private
+
+    def unique_indexes(table_name)
+      ActiveRecord::Base.connection.indexes(table_name.to_sym).select{|i| i.unique }
     end
 
   end

data/lib/unique_validation_inspector/version.rb

@@ -1,3 +1,3 @@
 module UniqueValidationInspector
-  VERSION = "0.2.0"
+  VERSION = "0.3.0"
 end

data/unique_validation_inspector.gemspec

@@ -7,7 +7,7 @@ Gem::Specification.new do |spec|
   spec.name          = "unique_validation_inspector"
   spec.version       = UniqueValidationInspector::VERSION
   spec.authors       = ["Igor Khomenko"]
-  spec.email         = ["igor@quickblox.com"]
+  spec.email         = ["khomenkoigor@gmail.com"]
 
   spec.summary       = "A Rake task that helps you find unique validations in models that do not have proper DB indexes."
   spec.description   = "A Rake task investigates the application's models definition, then tells you unique validations that do not have DB indexes."

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: unique_validation_inspector
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.3.0
 platform: ruby
 authors:
 - Igor Khomenko
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2017-09-16 00:00:00.000000000 Z
+date: 2018-02-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -83,7 +83,7 @@ dependencies:
 description: A Rake task investigates the application's models definition, then tells
   you unique validations that do not have DB indexes.
 email:
-- igor@quickblox.com
+- khomenkoigor@gmail.com
 executables: []
 extensions: []
 extra_rdoc_files: []