union_bank-e_crediting 0.1.0 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 4aea3632f33f1c9d1149a76b770dc3d26e17d4e9
-  data.tar.gz: 64c0c5527442b56b34bde72e7c208476294c7536
+SHA256:
+  metadata.gz: 83fe712564b36b301b8f9860e4c08eb733fd72df84aa179f8aead4303ad84f29
+  data.tar.gz: 242a4351d1c5fee4b961949b83c3dff4e42ba4cd3e329d83640c570190d33af0
 SHA512:
-  metadata.gz: 5a7144edc2682a8f55fb33c2789bd527af2ff80e2c8d6d299dfe2d45c35fa0817724e01d2f26a3b59ce929a3f60cacf246b86134a280d83f57cf1489756f273e
-  data.tar.gz: 92372ffc2051cb34c7d813f1eaf8d6eb3908fa2cfc4c3c0808be75b0dc9862426d60565525a9eab6d89f12f1f808152392b4bdcd3a2bb04ae5f157d9b26c99e6
+  metadata.gz: c9e5b3c44f3e0a4f796bf8c4d595388638c9a1960b8ce6bc1c0880ed0da5558c3a4d07e9ea1ffa7ec20a7a3a7cf4d86ba2bae08389fa5c6fbb71624e76b3706a
+  data.tar.gz: 8157ce0545991ed5045b7fdf53d9965c137317a7178e26a37b905e3b416820f1507d7fb90564ed84df074a5efe03021dfbd7b1566ec32bf38e94526dc4446105

data/.github/workflows/rubocop-challenger.yml

@@ -0,0 +1,26 @@
+name: "RuboCop Challenge"
+
+on:
+  schedule:
+    - cron: '30 23 * * 2,3,4' # この設定の場合、火水木のAM8:30に自動でPRが作られます。
+
+jobs:
+  create-pr:
+    name: Create Pull Request
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v2
+      - name: Set up Ruby 2.7
+        uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: 2.7.6
+      - name: Install bundler
+        run: gem install bundler
+      - name: Install gems
+        run: bundle install --jobs 4 --retry 3
+      - name: Set git configuration
+        run: git config remote.origin.url "git@github.com:payrollhero/union_bank-e_crediting.git" # プロジェクトごとに変わる値です。
+      - name: Create RuboCop challenge pull request
+        env:
+          GITHUB_ACCESS_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+        run: bundle exec rubocop_challenger go --base-branch=master --email=rubocop@payrollhero.com --name="Rubocop Challenger" --mode=random

data/.github/workflows/test-suite.yml

@@ -0,0 +1,50 @@
+# This workflow uses actions that are not certified by GitHub.
+# They are provided by a third-party and are governed by
+# separate terms of service, privacy policy, and support
+# documentation.
+# This workflow will download a prebuilt Ruby version, install dependencies and run tests with Rake
+# For more information see: https://github.com/marketplace/actions/setup-ruby-jruby-and-truffleruby
+
+name: test-suite
+
+on: [push, pull_request]
+
+jobs:
+  test:
+    runs-on: ubuntu-20.04
+    strategy:
+      fail-fast: false
+      matrix:
+        gemfile: ["rails-7.0.x"]
+        ruby: [3.2]
+        include:
+          - gemfile: rails-7.0.x
+            ruby: '3.1'
+          - gemfile: rails-7.0.x
+            ruby: '3.0'
+          - gemfile: rails-7.0.x
+            ruby: '2.7'
+          - gemfile: rails-6.1.x
+            ruby: '3.1'
+          - gemfile: rails-6.1.x
+            ruby: '3.0'
+          - gemfile: rails-6.1.x
+            ruby: 2.7
+          - gemfile: rails-6.1.x
+            ruby: 2.6
+          - gemfile: rails-6.0.x
+            ruby: 2.7
+          - gemfile: rails-6.0.x
+            ruby: 2.6
+          - gemfile: rails-5.2.x
+            ruby: 2.6
+
+    env:
+      BUNDLE_GEMFILE: ${{ github.workspace }}/gemfiles/Gemfile.${{ matrix.gemfile }}
+    steps:
+    - uses: actions/checkout@v2
+    - uses: ruby/setup-ruby@v1
+      with:
+        ruby-version: ${{ matrix.ruby }}
+        bundler-cache: true
+    - run: bundle exec rake

data/.gitignore

@@ -1,6 +1,7 @@
 /.bundle/
 /.yardoc
 /Gemfile.lock
+/gemfiles/*.lock
 /_yardoc/
 /coverage/
 /doc/

data/.rubocop.yml

@@ -0,0 +1,5 @@
+inherit_from: .rubocop_todo.yml
+
+AllCops:
+  NewCops: enable
+

data/.rubocop_todo.yml

@@ -0,0 +1,194 @@
+# This configuration was generated by
+# `rubocop --auto-gen-config`
+# on 2022-12-09 07:10:21 UTC using RuboCop version 1.39.0.
+# The point is for the user to remove these configuration records
+# one by one as the offenses are removed from the code base.
+# Note that changes in the inspected code, or installation of new
+# versions of RuboCop, may require this file to be generated again.
+
+# Offense count: 1
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: TreatCommentsAsGroupSeparators, ConsiderPunctuation, Include.
+# Include: **/*.gemspec
+Gemspec/OrderedDependencies:
+  Exclude:
+    - 'union_bank-e_crediting.gemspec'
+
+# Offense count: 1
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: Include.
+# Include: **/*.gemspec
+Gemspec/RequireMFA:
+  Exclude:
+    - 'union_bank-e_crediting.gemspec'
+
+# Offense count: 1
+# Configuration parameters: Include.
+# Include: **/*.gemspec
+Gemspec/RequiredRubyVersion:
+  Exclude:
+    - 'union_bank-e_crediting.gemspec'
+
+# Offense count: 1
+# This cop supports safe autocorrection (--autocorrect).
+Layout/EmptyLineAfterMagicComment:
+  Exclude:
+    - 'union_bank-e_crediting.gemspec'
+
+# Offense count: 2
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: empty_lines, no_empty_lines
+Layout/EmptyLinesAroundBlockBody:
+  Exclude:
+    - 'spec/union_bank/e_crediting/enrollment_file_spec.rb'
+    - 'spec/union_bank/e_crediting/transaction_file_spec.rb'
+
+# Offense count: 7
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: AllowForAlignment, EnforcedStyleForExponentOperator.
+# SupportedStylesForExponentOperator: space, no_space
+Layout/SpaceAroundOperators:
+  Exclude:
+    - 'spec/union_bank/e_crediting/common/header_line_spec.rb'
+    - 'spec/union_bank/e_crediting/enrollment_file/detail_line_spec.rb'
+    - 'spec/union_bank/e_crediting/transaction_file/detail_line_spec.rb'
+
+# Offense count: 2
+# This cop supports safe autocorrection (--autocorrect).
+Lint/AmbiguousOperator:
+  Exclude:
+    - 'lib/union_bank/e_crediting/enrollment_file.rb'
+    - 'lib/union_bank/e_crediting/transaction_file.rb'
+
+# Offense count: 1
+# Configuration parameters: AllowComments, AllowNil.
+Lint/SuppressedException:
+  Exclude:
+    - 'Rakefile'
+
+# Offense count: 4
+# Configuration parameters: CountComments, CountAsOne, ExcludedMethods, AllowedMethods, AllowedPatterns, IgnoredMethods.
+# AllowedMethods: refine
+Metrics/BlockLength:
+  Max: 37
+
+# Offense count: 7
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: EnforcedStyle, ProceduralMethods, FunctionalMethods, AllowedMethods, AllowedPatterns, IgnoredMethods, AllowBracesOnProceduralOneLiners, BracesRequiredMethods.
+# SupportedStyles: line_count_based, semantic, braces_for_chaining, always_braces
+# ProceduralMethods: benchmark, bm, bmbm, create, each_with_object, measure, new, realtime, tap, with_object
+# FunctionalMethods: let, let!, subject, watch
+# AllowedMethods: lambda, proc, it
+Style/BlockDelimiters:
+  Exclude:
+    - 'spec/union_bank/e_crediting/common/header_line_spec.rb'
+    - 'spec/union_bank/e_crediting/enrollment_file/detail_line_spec.rb'
+    - 'spec/union_bank/e_crediting/enrollment_file_spec.rb'
+    - 'spec/union_bank/e_crediting/transaction_file/detail_line_spec.rb'
+    - 'spec/union_bank/e_crediting/transaction_file_spec.rb'
+
+# Offense count: 2
+# This cop supports unsafe autocorrection (--autocorrect-all).
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: nested, compact
+Style/ClassAndModuleChildren:
+  Exclude:
+    - 'lib/union_bank/e_crediting/enrollment_file/detail_line.rb'
+    - 'lib/union_bank/e_crediting/transaction_file/detail_line.rb'
+
+# Offense count: 1
+# This cop supports safe autocorrection (--autocorrect).
+Style/Encoding:
+  Exclude:
+    - 'union_bank-e_crediting.gemspec'
+
+# Offense count: 2
+# This cop supports safe autocorrection (--autocorrect).
+Style/ExpandPathArguments:
+  Exclude:
+    - 'spec/spec_helper.rb'
+    - 'union_bank-e_crediting.gemspec'
+
+# Offense count: 1
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: format, sprintf, percent
+Style/FormatString:
+  Exclude:
+    - 'lib/union_bank/e_crediting/transaction_file/detail_line.rb'
+
+# Offense count: 20
+# This cop supports unsafe autocorrection (--autocorrect-all).
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: always, always_true, never
+Style/FrozenStringLiteralComment:
+  Enabled: false
+
+# Offense count: 1
+# This cop supports unsafe autocorrection (--autocorrect-all).
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: literals, strict
+Style/MutableConstant:
+  Exclude:
+    - 'lib/union_bank/e_crediting/version.rb'
+
+# Offense count: 2
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: PreferredDelimiters.
+Style/PercentLiteralDelimiters:
+  Exclude:
+    - 'union_bank-e_crediting.gemspec'
+
+# Offense count: 2
+# This cop supports safe autocorrection (--autocorrect).
+Style/RedundantPercentQ:
+  Exclude:
+    - 'union_bank-e_crediting.gemspec'
+
+# Offense count: 115
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: EnforcedStyle, ConsistentQuotesInMultiline.
+# SupportedStyles: single_quotes, double_quotes
+Style/StringLiterals:
+  Exclude:
+    - 'Rakefile'
+    - 'bin/console'
+    - 'lib/union_bank/e_crediting.rb'
+    - 'lib/union_bank/e_crediting/common/header_line.rb'
+    - 'lib/union_bank/e_crediting/enrollment_file/detail_line.rb'
+    - 'lib/union_bank/e_crediting/pipe_delimited_file.rb'
+    - 'lib/union_bank/e_crediting/transaction_file.rb'
+    - 'lib/union_bank/e_crediting/transaction_file/detail_line.rb'
+    - 'lib/union_bank/e_crediting/version.rb'
+    - 'spec/union_bank/e_crediting/common/header_line_spec.rb'
+    - 'spec/union_bank/e_crediting/enrollment_file/detail_line_spec.rb'
+    - 'spec/union_bank/e_crediting/enrollment_file_spec.rb'
+    - 'spec/union_bank/e_crediting/transaction_file/detail_line_spec.rb'
+    - 'spec/union_bank/e_crediting/transaction_file_spec.rb'
+    - 'union_bank-e_crediting.gemspec'
+
+# Offense count: 3
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: EnforcedStyleForMultiline.
+# SupportedStylesForMultiline: comma, consistent_comma, no_comma
+Style/TrailingCommaInArrayLiteral:
+  Exclude:
+    - 'lib/union_bank/e_crediting/transaction_file/detail_line.rb'
+    - 'spec/union_bank/e_crediting/enrollment_file_spec.rb'
+    - 'spec/union_bank/e_crediting/transaction_file_spec.rb'
+
+# Offense count: 3
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: EnforcedStyleForMultiline.
+# SupportedStylesForMultiline: comma, consistent_comma, no_comma
+Style/TrailingCommaInHashLiteral:
+  Exclude:
+    - 'spec/union_bank/e_crediting/transaction_file_spec.rb'
+
+# Offense count: 5
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, AllowedPatterns, IgnoredPatterns.
+# URISchemes: http, https
+Layout/LineLength:
+  Max: 124

data/gemfiles/Gemfile.rails-5.0.x

@@ -0,0 +1,5 @@
+source 'https://rubygems.org'
+
+gemspec path: '../'
+
+gem 'activerecord', '~> 5.0.0'

data/gemfiles/Gemfile.rails-5.1.x

@@ -0,0 +1,5 @@
+source 'https://rubygems.org'
+
+gemspec path: '../'
+
+gem 'activerecord', '~> 5.1.0'

data/gemfiles/Gemfile.rails-5.2.x

@@ -0,0 +1,5 @@
+source 'https://rubygems.org'
+
+gemspec path: '../'
+
+gem 'activerecord', '~> 5.2.0'

data/gemfiles/Gemfile.rails-6.0.x

@@ -0,0 +1,5 @@
+source 'https://rubygems.org'
+
+gemspec path: '../'
+
+gem 'activerecord', '~> 6.0.0'

data/gemfiles/Gemfile.rails-6.1.x

@@ -0,0 +1,5 @@
+source 'https://rubygems.org'
+
+gemspec path: '../'
+
+gem 'activerecord', '~> 6.1.0'

data/gemfiles/Gemfile.rails-7.0.x

@@ -0,0 +1,5 @@
+source 'https://rubygems.org'
+
+gemspec path: '../'
+
+gem 'activerecord', '~> 7.0.0'

data/gemfiles/Gemfile.rails-edge

@@ -0,0 +1,5 @@
+source 'https://rubygems.org'
+
+gemspec path: '../'
+
+gem 'activerecord', github: 'rails/rails'

data/lib/union_bank/e_crediting/enrollment_file.rb

@@ -6,7 +6,7 @@ module UnionBank
 
       # @return [Array<UnionBank::ECrediting::EnrollmentFile::DetailLine>]
       def detail_lines
-        @detail_lines ||= details.map { |detail| DetailLine.new detail }
+        @detail_lines ||= details.map { |detail| DetailLine.new **detail }
       end
     end
   end

data/lib/union_bank/e_crediting/pipe_delimited_file.rb

@@ -41,7 +41,9 @@ module UnionBank
       end
 
       def detail_lines
+        # :nocov:
         raise NotImplementedError, "#{self.class} must implement #detail_lines"
+        # :nocov:
       end
 
       private

data/lib/union_bank/e_crediting/transaction_file.rb

@@ -9,7 +9,7 @@ module UnionBank
       # @return [Array<UnionBank::ECrediting::TransactionFile::DetailLine>]
       def detail_lines
         @detail_lines ||= details.each_with_index.map do |detail, index|
-          DetailLine.new detail.merge(ref_number: (index + 1))
+          DetailLine.new **detail.merge(ref_number: (index + 1))
         end
       end
     end

data/lib/union_bank/e_crediting/version.rb

@@ -1,5 +1,7 @@
+# :nocov:
 module UnionBank
   module ECrediting
-    VERSION = "0.1.0"
+    VERSION = "0.2.0"
   end
 end
+# :nocov:

data/union_bank-e_crediting.gemspec

@@ -19,10 +19,12 @@ Gem::Specification.new do |spec|
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ["lib"]
 
-  spec.add_development_dependency "bundler", "~> 1.9"
-  spec.add_development_dependency "rake", "~> 10.0"
+  spec.add_development_dependency "bundler", "> 1.17", "< 3"
+  spec.add_development_dependency "rake"
   spec.add_development_dependency "rspec"
+  spec.add_development_dependency "rubocop_challenger"
+  spec.add_development_dependency "simplecov"
 
-  spec.add_dependency "activesupport"
-  spec.add_dependency "activemodel"
+  spec.add_dependency "activesupport", "> 5.2"
+  spec.add_dependency "activemodel", "> 5.2"
 end

metadata

@@ -1,43 +1,49 @@
 --- !ruby/object:Gem::Specification
 name: union_bank-e_crediting
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.2.0
 platform: ruby
 authors:
 - Ronald Maravilla
-autorequire: 
+autorequire:
 bindir: exe
 cert_chain: []
-date: 2015-09-03 00:00:00.000000000 Z
+date: 2022-12-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">"
       - !ruby/object:Gem::Version
-        version: '1.9'
+        version: '1.17'
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '3'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">"
+      - !ruby/object:Gem::Version
+        version: '1.17'
+    - - "<"
       - !ruby/object:Gem::Version
-        version: '1.9'
+        version: '3'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
@@ -53,13 +59,13 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: activesupport
+  name: rubocop_challenger
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-  type: :runtime
+  type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
@@ -67,19 +73,47 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: activemodel
+  name: simplecov
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-  type: :runtime
+  type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: activesupport
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">"
+      - !ruby/object:Gem::Version
+        version: '5.2'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">"
+      - !ruby/object:Gem::Version
+        version: '5.2'
+- !ruby/object:Gem::Dependency
+  name: activemodel
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">"
+      - !ruby/object:Gem::Version
+        version: '5.2'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">"
+      - !ruby/object:Gem::Version
+        version: '5.2'
 description: Generates file contents for UnionBank's eCrediting enrollment and transaction
   files.
 email:
@@ -88,8 +122,12 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".github/workflows/rubocop-challenger.yml"
+- ".github/workflows/test-suite.yml"
 - ".gitignore"
 - ".rspec"
+- ".rubocop.yml"
+- ".rubocop_todo.yml"
 - ".travis.yml"
 - CODE_OF_CONDUCT.md
 - Gemfile
@@ -98,6 +136,13 @@ files:
 - Rakefile
 - bin/console
 - bin/setup
+- gemfiles/Gemfile.rails-5.0.x
+- gemfiles/Gemfile.rails-5.1.x
+- gemfiles/Gemfile.rails-5.2.x
+- gemfiles/Gemfile.rails-6.0.x
+- gemfiles/Gemfile.rails-6.1.x
+- gemfiles/Gemfile.rails-7.0.x
+- gemfiles/Gemfile.rails-edge
 - lib/union_bank/e_crediting.rb
 - lib/union_bank/e_crediting/common.rb
 - lib/union_bank/e_crediting/common/header_line.rb
@@ -112,7 +157,7 @@ homepage: https://github.com/payrollhero/union_bank-e_crediting
 licenses:
 - BSD-3-Clause
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -127,11 +172,9 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.2.3
-signing_key: 
+rubygems_version: 3.2.33
+signing_key:
 specification_version: 4
 summary: Generates file contents for UnionBank's eCrediting enrollment and transaction
   files.
 test_files: []
-has_rdoc: