unified_db 0.1.0 → 0.1.1

data/.gitignore

@@ -1 +1,2 @@
 Gemfile.lock
+pkg

data/.travis.yml

@@ -0,0 +1,6 @@
+script: "bundle exec rake spec"
+rvm:
+  - 1.8.7
+  - 1.9.2
+  - ree
+  - rbx

data/README.md

@@ -1,5 +1,3 @@
-# Unified Movie Database
+# Unified Movie Database [![](http://travis-ci.org/imanel/UnifiedDB.png)](http://travis-ci.org/imanel/UnifiedDB)
 
 This is project for unifying multiple movie database. Currently it support only IMDB and TVDB, but TMDB will be done shortly.
-
-To see it in action please go to [demo site](http://unified-db.heroku.com)

data/lib/unified_db.rb

@@ -15,5 +15,3 @@ module UnifiedDB
     end
   end
 end
-
-require "#{UnifiedDB::ROOT}/ext/crack"

data/lib/unified_db/backend/tvdb.rb

@@ -6,6 +6,8 @@ module UnifiedDB
     
       def find_by_id(id)
         movie = handler.get_series_by_id(id)
+        raise if movie.nil?
+        
         @result = Result::ID.new(
           :id => movie.id,
           :title => movie.name,
@@ -43,7 +45,8 @@ module UnifiedDB
       end
         
       def format_posters(posters)
-        posters.select{|poster| poster.banner_type == 'season'}.collect(&:url)
+        list = posters.select { |poster| ['season', 'poster'].include? poster.banner_type }
+        list.sort { |a,b| b.banner_type <=> a.banner_type }.collect(&:url)
       end
     
     end

data/lib/unified_db/version.rb

@@ -1,5 +1,5 @@
 module UnifiedDB
   
-  VERSION = '0.1.0'
+  VERSION = '0.1.1'
   
 end

data/spec/support/do_sort.rb

@@ -0,0 +1,5 @@
+# This is fix for Ruby 1.8.7 inability to sort symbols
+
+def do_sort(array)
+  array.sort { |a, b| a.to_s <=> b.to_s }
+end

data/spec/unified_db/backend/imdb_spec.rb

@@ -6,7 +6,7 @@ describe UnifiedDB::Backend::IMDB do
   it "should return valid find by title" do
     result = subject.find(:title => 'Dark Knight')
     result.class.should eql(Hash)
-    result.keys.sort.should eql([:result, :service, :status])
+    do_sort(result.keys).should eql([:result, :service, :status])
     result[:status].should eql('success')
     result[:service].should eql('imdb')
     result[:result].class.should eql(Array)
@@ -22,7 +22,7 @@ describe UnifiedDB::Backend::IMDB do
     decoded = Yajl::Parser.new.parse encoded
     
     decoded.class.should eql(Hash)
-    decoded.keys.sort.should eql(['result', 'service', 'status'])
+    do_sort(decoded.keys).should eql(['result', 'service', 'status'])
     decoded['status'].should eql('success')
     decoded['service'].should eql('imdb')
     decoded['result'].class.should eql(Array)
@@ -38,7 +38,7 @@ describe UnifiedDB::Backend::IMDB do
   it "should return empty array if invalid find by title specified" do
     result = subject.find(:title => "qwertyuiopasdfghjkllzxcvbnm")
     result.class.should eql(Hash)
-    result.keys.sort.should eql([:result, :service, :status])
+    do_sort(result.keys).should eql([:result, :service, :status])
     result[:status].should eql('success')
     result[:service].should eql('imdb')
     result[:result].class.should eql(Array)
@@ -49,7 +49,7 @@ describe UnifiedDB::Backend::IMDB do
   it "should return valid find by id" do
     result = subject.find(:id => 'tt0468569')
     result.class.should eql(Hash)
-    result.keys.sort.should eql([:result, :service, :status])
+    do_sort(result.keys).should eql([:result, :service, :status])
     result[:status].should eql('success')
     result[:service].should eql('imdb')
     
@@ -59,7 +59,7 @@ describe UnifiedDB::Backend::IMDB do
     result[:result].overview.class.should eql(String)
     result[:result].overview.length.should be > 20
     result[:result].release_date.class.should eql(String)
-    result[:result].genres.should eql(["Action", "Crime", "Thriller"])
+    result[:result].genres.should eql(["Action", "Crime", "Drama", "Thriller"])
     result[:result].rating.class.should eql(Float)
     result[:result].rating.should be > 4
     result[:result].rating.should be < 10
@@ -75,7 +75,7 @@ describe UnifiedDB::Backend::IMDB do
   it "should return error if id was not found" do
     result = subject.find(:id => 'tt046856910')
     result.class.should eql(Hash)
-    result.keys.sort.should eql([:reason, :status])
+    do_sort(result.keys).should eql([:reason, :status])
     result[:status].should eql('error')
     result[:reason].should eql('not found')
   end

data/spec/unified_db/backend/tvdb_spec.rb

@@ -4,13 +4,13 @@ describe UnifiedDB::Backend::TVDB do
   subject { described_class.new }
   
   it "should return valid find by title" do
-    result = subject.find(:title => 'StarGate')
+    result = subject.find(:title => 'StarGate SG-1')
     result.class.should eql(Hash)
-    result.keys.sort.should eql([:result, :service, :status])
+    do_sort(result.keys).should eql([:result, :service, :status])
     result[:status].should eql('success')
     result[:service].should eql('tvdb')
     result[:result].class.should eql(Array)
-    result[:result].size.should be > 3
+    result[:result].size.should eql 1
     
     first_result = result[:result].first
     first_result.class.should eql(UnifiedDB::Result::Title)
@@ -22,11 +22,11 @@ describe UnifiedDB::Backend::TVDB do
     decoded = Yajl::Parser.new.parse encoded
     
     decoded.class.should eql(Hash)
-    decoded.keys.sort.should eql(['result', 'service', 'status'])
+    do_sort(decoded.keys).should eql(['result', 'service', 'status'])
     decoded['status'].should eql('success')
     decoded['service'].should eql('tvdb')
     decoded['result'].class.should eql(Array)
-    decoded['result'].size.should be > 3
+    decoded['result'].size.should eql 1
     
     first_result = decoded['result'].first
     first_result.class.should eql(Hash)
@@ -38,7 +38,7 @@ describe UnifiedDB::Backend::TVDB do
   it "should return empty array if invalid find by title specified" do
     result = subject.find(:title => "qwertyuiopasdfghjkllzxcvbnm")
     result.class.should eql(Hash)
-    result.keys.sort.should eql([:result, :service, :status])
+    do_sort(result.keys).should eql([:result, :service, :status])
     result[:status].should eql('success')
     result[:service].should eql('tvdb')
     result[:result].class.should eql(Array)
@@ -49,7 +49,7 @@ describe UnifiedDB::Backend::TVDB do
   it "should return valid find by id" do
     result = subject.find(:id => '72449')
     result.class.should eql(Hash)
-    result.keys.sort.should eql([:result, :service, :status])
+    do_sort(result.keys).should eql([:result, :service, :status])
     result[:status].should eql('success')
     result[:service].should eql('tvdb')
     
@@ -75,7 +75,7 @@ describe UnifiedDB::Backend::TVDB do
   it "should return error if id was not found" do
     result = subject.find(:id => '72449123')
     result.class.should eql(Hash)
-    result.keys.sort.should eql([:reason, :status])
+    do_sort(result.keys).should eql([:reason, :status])
     result[:status].should eql('error')
     result[:reason].should eql('not found')
   end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: unified_db
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
   prerelease: 
 platform: ruby
 authors:
@@ -9,12 +9,12 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2011-08-22 00:00:00.000000000 +02:00
+date: 2011-10-16 00:00:00.000000000 +02:00
 default_executable: 
 dependencies:
 - !ruby/object:Gem::Dependency
   name: yajl-ruby
-  requirement: &70343143888220 !ruby/object:Gem::Requirement
+  requirement: &70329097056220 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -22,10 +22,10 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *70343143888220
+  version_requirements: *70329097056220
 - !ruby/object:Gem::Dependency
   name: imdb_party
-  requirement: &70343143887680 !ruby/object:Gem::Requirement
+  requirement: &70329097055680 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -33,10 +33,10 @@ dependencies:
         version: 0.6.0
   type: :runtime
   prerelease: false
-  version_requirements: *70343143887680
+  version_requirements: *70329097055680
 - !ruby/object:Gem::Dependency
   name: tvdb_party
-  requirement: &70343143887140 !ruby/object:Gem::Requirement
+  requirement: &70329097055120 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -44,10 +44,10 @@ dependencies:
         version: 0.6.0
   type: :runtime
   prerelease: false
-  version_requirements: *70343143887140
+  version_requirements: *70329097055120
 - !ruby/object:Gem::Dependency
   name: rspec
-  requirement: &70343143886640 !ruby/object:Gem::Requirement
+  requirement: &70329097054580 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -55,7 +55,7 @@ dependencies:
         version: '2.0'
   type: :development
   prerelease: false
-  version_requirements: *70343143886640
+  version_requirements: *70329097054580
 description: Scrapper for multiple Movie Databases
 email:
 - bernard.potocki@imanel.org
@@ -64,10 +64,10 @@ extensions: []
 extra_rdoc_files: []
 files:
 - .gitignore
+- .travis.yml
 - Gemfile
 - README.md
 - Rakefile
-- lib/ext/crack.rb
 - lib/unified_db.rb
 - lib/unified_db/api_error.rb
 - lib/unified_db/backend.rb
@@ -80,6 +80,7 @@ files:
 - lib/unified_db/result/title.rb
 - lib/unified_db/version.rb
 - spec/spec_helper.rb
+- spec/support/do_sort.rb
 - spec/unified_db/backend/imdb_spec.rb
 - spec/unified_db/backend/tvdb_spec.rb
 - unified_db.gemspec
@@ -110,5 +111,6 @@ specification_version: 3
 summary: Scrapper for multiple Movie Databases
 test_files:
 - spec/spec_helper.rb
+- spec/support/do_sort.rb
 - spec/unified_db/backend/imdb_spec.rb
 - spec/unified_db/backend/tvdb_spec.rb

data/lib/ext/crack.rb

@@ -1,10 +0,0 @@
-require 'crack/json'
-require 'yajl'
-
-module Crack
-  class JSON
-    def self.parse(json)
-      Yajl::Parser.parse(json)
-    end
-  end
-end