unidom-inventory 1.0.1 → 1.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 6bdac4a21869a3ffda95c4ab54a216342b29134d
-  data.tar.gz: c5e234b4d38366f9bc335161f89bb1284af18d11
+  metadata.gz: e7d10e6c316c3238d67e6be51e20f47f89adadfc
+  data.tar.gz: c6966f7274504bc4564f13ac89edcc7aca5f98f6
 SHA512:
-  metadata.gz: c956e76be390a4575e9a9981b50ce4039c92b0fc48e34499a22a537370a5035076ac875838ecf678bdebfc270c9c4a77ea8daf7a3a075a4e44a4dfee00f1ac66
-  data.tar.gz: 0c4928c27816f8c7fe22a17072ddbd45c920c5b50063eb428a24edc761b839d53c01c7bb17a1d31057f1e4f3e2c15bb5ca68a4f05e634bd6af551567a9f4331a
+  metadata.gz: 9dcc0199d34c53fdbb07e98eefb3efa9017d9c6d5bc6246f05d0c0597780990180859996a8c6d05f234c4e5fa81dc00dc3fa59619505b37140667b14a47ae23d
+  data.tar.gz: 0353dd0e2b2b354b5217483ace80f90a0015bab8efb2ddc7cd1db5453a09d9c7bfcd297358f3802d177cf92fa16b0f7e0c0d9b1bf75d42031214a3418be85cfe

data/app/models/unidom/inventory/grouped_inventory_item.rb

@@ -8,7 +8,6 @@ class Unidom::Inventory::GroupedInventoryItem < Unidom::Inventory::ApplicationRe
   include Unidom::Common::Concerns::ModelExtension
   include Unidom::Inventory::Concerns::AsInventoryItem
 
-  #validates :quantity, presence: true, numericality: true
-  validates :quantity, presence: true, numericality: { greater_than_or_equal_to: 0.0, less_than: 1_000_000_000.00 }
+  validates :quantity, presence: true, numericality: { greater_than_or_equal_to: 0.0, less_than_or_equal_to: 1_000_000_000.00 }
 
 end unless Unidom::Common::Neglection.namespace_neglected? 'Unidom::Inventory::GroupedInventoryItem'

data/lib/rspec/models/unidom/inventory/grouped_inventory_item_spec.rb

@@ -19,27 +19,8 @@ describe Unidom::Inventory::GroupedInventoryItem, type: :model do
 
     it_behaves_like 'Unidom::Common::Concerns::ModelExtension', model_attributes
 
-    it_behaves_like 'validates', model_attributes, :quantity,
-      {                              } => 0,
-      { quantity: nil                } => 2,
-      { quantity: ''                 } => 2,
-      { quantity: '1'                } => 0,
-      { quantity: 1                  } => 0,
-      { quantity: 'A'                } => 1,
-      { quantity: '1.23'             } => 0,
-      { quantity: 1.23               } => 0,
-      { quantity: '-0.01'            } => 1,
-      { quantity: -0.01              } => 1,
-      { quantity: '0'                } => 0,
-      { quantity: 0                  } => 0,
-      { quantity: '0.01'             } => 0,
-      { quantity: 0.01               } => 0,
-      { quantity: '999_999_999.99'   } => 0,
-      { quantity: 999_999_999.99     } => 0,
-      { quantity: '1_000_000_000'    } => 1,
-      { quantity: 1_000_000_000      } => 1,
-      { quantity: '1_000_000_000.01' } => 1,
-      { quantity: 1_000_000_000.01   } => 1
+    it_behaves_like 'validates numericality', model_attributes, :quantity,
+      range: 0..1_000_000_000, minimum_inclusive: true, maximum_inclusive: true
 
   end
 

data/lib/rspec/models/unidom/inventory/serialized_inventory_item_spec.rb

@@ -17,26 +17,10 @@ describe Unidom::Inventory::SerializedInventoryItem, type: :model do
       serial_number: '123456789012'
     }
 
-    serial_number_max_length = described_class.columns_hash['serial_number'].limit
-
     it_behaves_like 'Unidom::Common::Concerns::ModelExtension', model_attributes
 
-    it_behaves_like 'validates', model_attributes, :serial_number,
-      {                      } => 0,
-      { serial_number: nil   } => 2,
-      { serial_number: ''    } => 2,
-      { serial_number: '1'   } => 1,
-      { serial_number: '11'  } => 0,
-      { serial_number: '111' } => 0,
-      { serial_number: 'A'   } => 1,
-      { serial_number: 'AA'  } => 0,
-      { serial_number: 'AAA' } => 0,
-      { serial_number: '1'*(serial_number_max_length-1) } => 0,
-      { serial_number: '1'*serial_number_max_length     } => 0,
-      { serial_number: '1'*(serial_number_max_length+1) } => 1,
-      { serial_number: 'A'*(serial_number_max_length-1) } => 0,
-      { serial_number: 'A'*serial_number_max_length     } => 0,
-      { serial_number: 'A'*(serial_number_max_length+1) } => 1
+    it_behaves_like 'validates text', model_attributes, :serial_number,
+      length: 2..described_class.columns_hash['serial_number'].limit
 
   end
 

data/lib/unidom/inventory/version.rb

@@ -1,5 +1,5 @@
 module Unidom
   module Inventory
-    VERSION = '1.0.1'.freeze
+    VERSION = '1.0.2'.freeze
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: unidom-inventory
 version: !ruby/object:Gem::Version
-  version: 1.0.1
+  version: 1.0.2
 platform: ruby
 authors:
 - Topbit Du
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-03-13 00:00:00.000000000 Z
+date: 2017-03-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: unidom-common