unidom-common-rspec 0.6 → 0.6.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 9bc9d62357cf28e32abbdbcdac81fe842e6ba045
-  data.tar.gz: 65338e314cbb0633f8a586856472bcc27f7bbf07
+  metadata.gz: 2da7a6fa1baf6889f7e39b8f4e24fece96ba6596
+  data.tar.gz: e93a8669818a91ed003ebfc1e5d372719e35bd1f
 SHA512:
-  metadata.gz: 439f897d6c939e3943ffc90e68808b8d2f0f571b50caa000590019e7ab4d8d727f629cec941e43567f424c0faf4561d5874c588313d6c9a96578f6434224c738
-  data.tar.gz: 0c54ac2b809fe7d97bab55a7e67fc004afa8b1687548c46dc46741da00923d4572fecde4de55437f0e7e9d4b6228005d9eaf13ba5d3ee96f6b5cf14171738141
+  metadata.gz: 7795d2019dd3b40cbba76146cd0b3f398730005ea23a8c0890f1f0931bd354a2eb41bc9415314e0ded693878b6775bfd965a27fe5fa3fa251a9fede13cefd29f
+  data.tar.gz: 013d1670898e0173062130aa12da57719cbc88c48af527f9e959a76feede563b49a025cc82c0490bb2047cd124b92864648ba7093f138a51f9d873394b79457d

data/CHANGELOG.md

@@ -19,3 +19,7 @@
 
 ## v0.6
 1. Has One shared examples
+
+## v0.6.1
+1. Improve the Belongs To shared examples for the #build_association method, the #create_association method, & the #create_association! method
+2. Improve the Has One shared examples for the #build_association method, the #create_association method, & the #create_association! method

data/README.md

@@ -35,7 +35,7 @@ Or install it yourself as:
 
 ## Usage
 
-Assume we have the Person model & the Pet model as the following:
+Assume we have the Person model, the Pet model, & the Identity Card model as the following:
 ```ruby
 # person.rb
 class Person < ApplicationRecord
@@ -130,79 +130,79 @@ describe Person, type: :model do
 end
 ```
 
-### Has Many shared examples Has Many 共享用例
+### Belongs To shared examples Belongs To 共享用例
 
-The ``person_spec.rb`` looks like the following:
+The ``pet_spec.rb`` looks like the following:
 ```ruby
 require 'rails_helper'
 
-describe Person, type: :model do
+describe Pet, type: :model do
 
   context do
 
+    cat_attributes = { name: 'Pearl', species: 'Persian' }
     tim_attributes = { name: 'Tim' }
-    cat_attributes = { name: 'Pearl',  species: 'Persian'   }
-    dog_attribtues = { name: 'Flower', species: 'Chihuahua' }
 
-    it_behaves_like 'has_many', tim_attributes, :pets, Pet, [ cat_attributes, dog_attribtues ]
+    it_behaves_like 'belongs_to', cat_attributes, :person, Person, tim_attributes
 
   end
 
 end
 ```
 
-### Has One shared examples Has Many 共享用例
-
-The ``person_spec.rb`` looks like the following:
+The ``identity_card_spec.rb`` looks like the following:
 ```ruby
 require 'rails_helper'
 
-describe Person, type: :model do
+describe IdentityCard, type: :model do
 
   context do
 
     tim_attributes = { name: 'Tim' }
     tim_identity_card_attributes = { name: 'Tim', gender_code: '1', birth_date: '1980-07-01' }
 
-    it_behaves_like 'has_one', tim_attributes, :identity_card, IdentityCard, tim_identity_card_attributes
+    it_behaves_like 'belongs_to', tim_identity_card_attributes, :person, Person, tim_attributes
 
   end
 
 end
 ```
 
-### Belongs To shared examples Belongs To 共享用例
+### Has Many shared examples Has Many 共享用例
 
-The ``pet_spec.rb`` looks like the following:
+The ``person_spec.rb`` looks like the following:
 ```ruby
 require 'rails_helper'
 
-describe Pet, type: :model do
+describe Person, type: :model do
 
   context do
 
-    cat_attributes = { name: 'Pearl', species: 'Persian' }
     tim_attributes = { name: 'Tim' }
+    cat_attributes = { name: 'Pearl',  species: 'Persian'   }
+    dog_attribtues = { name: 'Flower', species: 'Chihuahua' }
 
-    it_behaves_like 'belongs_to', cat_attributes, :person, Person, tim_attributes
+    it_behaves_like 'has_many', tim_attributes, :pets, Pet, [ cat_attributes, dog_attribtues ]
 
   end
 
 end
 ```
 
-The ``identity_card_spec.rb`` looks like the following:
+### Has One shared examples Has Many 共享用例
+
+The ``person_spec.rb`` looks like the following:
 ```ruby
 require 'rails_helper'
 
-describe IdentityCard, type: :model do
+describe Person, type: :model do
 
   context do
 
     tim_attributes = { name: 'Tim' }
     tim_identity_card_attributes = { name: 'Tim', gender_code: '1', birth_date: '1980-07-01' }
 
-    it_behaves_like 'belongs_to', tim_identity_card_attributes, :person, Person, tim_attributes
+    it_behaves_like 'has_one', tim_attributes, :identity_card, IdentityCard, tim_identity_card_attributes
 
   end
 
@@ -228,6 +228,8 @@ describe Person, type: :model do
 end
 ```
 
+
+
 ## Development
 
 After checking out the repo, run `bin/setup` to install dependencies. Then, run `rake spec` to run the tests. You can also run `bin/console` for an interactive prompt that will allow you to experiment.

data/ROADMAP.md

@@ -19,3 +19,10 @@
 
 ## v0.6
 1. Has One shared examples
+
+## v0.6.1
+1. Improve the Belongs To shared examples for the #build_association method, the #create_association method, & the #create_association! method
+2. Improve the Has One shared examples for the #build_association method, the #create_association method, & the #create_association! method
+
+## v0.6.2
+1. Improve the Has Many shared examples for the #build_association method, the #create_association method, & the #create_association! method

data/lib/unidom/common/rspec/belongs_to_shared_examples.rb

@@ -1,3 +1,12 @@
+##
+# The ``belongs_to :associated_model`` macro uses the ActiveRecord::Associations::BelongsToAssociation.
+# This association generates the following 5 methods:
+# #associated_model, #associated_model=, #build_associated_model, #create_associated_model, and #create_associated_model!.
+#
+# The ``belongs_to :associated_model, polymorphic: true`` macro uses the ActiveRecord::Associations::BelongsToPolymorphicAssociation.
+# This association generates the 2 methods: #associated_model and #associated_model=.
+# It does not generate the 3 methods: #build_associated_model, #create_associated_model, and #create_associated_model!
+
 shared_examples 'belongs_to' do |model_attributes, association_name, association_class, association_attributes|
 
   describe "##{association_name}: #{association_class.name}" do
@@ -5,32 +14,49 @@ shared_examples 'belongs_to' do |model_attributes, association_name, association
     model_instance       = described_class.new        model_attributes
     association_instance = association_class.new      association_attributes
     association          = model_instance.association association_name.to_sym
-    association_writable = association.class==ActiveRecord::Associations::BelongsToAssociation
+    association_writable = [ ActiveRecord::Associations::BelongsToAssociation ].include? association.class
 
-    methods = [ association_name, "#{association_name}=" ]
-    methods = methods+[ "build_#{association_name}", "create_#{association_name}", "create_#{association_name}!" ] if association_writable
+    gained_methods = [ association_name.to_sym ]
+    gained_methods << [ :"#{association_name}=", :"build_#{association_name}", :"create_#{association_name}", :"create_#{association_name}!" ] if association_writable
+    gained_methods.flatten!
 
-    methods.each do |method|
-      describe "##{method}" do
+    subject do described_class.new model_attributes end
 
-        it 'is responded to' do expect(model_instance).to respond_to(association_name.to_sym) end
+    gained_methods.each do |method|
+      it do is_expected.to respond_to(method.to_sym) end
+    end
 
-        case method
+    describe "#{association_name}=" do
+      before :each do
+        subject.send "#{association_name}=", nil
+        subject.send "#{association_name}=", association_instance
+      end
+      it 'should return the assigned association' do
+        expect(subject.send association_name.to_sym).to eq(association_instance)
+      end
+    end
 
-          when "#{association_name}="
-            it 'assigns association successfully' do
-              model_instance.send "#{association_name}=".to_sym, association_instance
-              expect(model_instance.send association_name.to_sym).to eq(association_instance)
-            end
+    if association_writable
 
-          when association_name
-            it 'saves successfully' do
-              model_instance.send "#{association_name}=".to_sym, association_instance
-              expect(model_instance.save).to be_truthy
-            end
-        end
+      context "#build_#{association_name}" do
+        let :association_instance_1                 do subject.send                          "build_#{association_name}" end
+        let :association_instance_2                 do subject.send                          "build_#{association_name}" end
+        it  "should be a #{association_class.name}" do expect(association_instance_1).to     be_a(association_class)     end
+        it  'should not be a new record'            do expect(association_instance_1).to     be_new_record               end
+        it  "should be a #{association_class.name}" do expect(association_instance_2).to     be_a(association_class)     end
+        it  'should not be a new record'            do expect(association_instance_2).to     be_new_record               end
+        it  'should not be identical'               do expect(association_instance_1).to_not be(association_instance_2)  end
+      end
 
+      [ "create_#{association_name}", "create_#{association_name}!" ].each do |method_name|
+        context "##{method_name}" do
+          subject do described_class.create! model_attributes end
+          let :created_association_instance do subject.send method_name, association_attributes end
+          it "should be a #{association_class.name}" do expect(created_association_instance).to     be_an_instance_of(association_class) end
+          it 'should not be a new record'            do expect(created_association_instance).to_not be_new_record                        end
+        end
       end
+
     end
 
   end

data/lib/unidom/common/rspec/has_one_shared_examples.rb

@@ -10,116 +10,62 @@ shared_examples 'has_one' do |model_attributes, association_name, association_cl
     gained_methods << [ :"#{association_name}=", :"build_#{association_name}", :"create_#{association_name}", :"create_#{association_name}!" ] if association_writable
     gained_methods.flatten!
 
-    #subject :model_instance       do described_class.new   model_attributes                         end
-    #let     :association_instance do association_class.new association_attributes                   end
-    #let     :reflection           do model_instance.association(association_name.to_sym).reflection end
-    #let     :association_writable do reflection.class==ActiveRecord::Reflection::HasOneReflection   end
+    subject do described_class.new model_attributes end
 
-    before :each do
-      subject do
-        described_class.new model_attributes
-      end
+    gained_methods.each do |method|
+      it do is_expected.to respond_to(method.to_sym) end
     end
 
-    after :each do
-      subject do
-        nil
+    describe "#{association_name}=" do
+      before :each do
+        subject.send "#{association_name}=", nil
+        subject.send "#{association_name}=", association_instance
       end
-    end
-
-    #describe do
-      gained_methods.each do |method|
-        it do is_expected.to respond_to(method.to_sym) end
+      it 'should return the assigned association' do
+        expect(subject.send association_name.to_sym).to eq(association_instance)
       end
-    #end
-
-    it 'assigns association successfully' do
-      model_instance.send "#{association_name}=", association_instance
-      expect(model_instance.send association_name.to_sym).to eq(association_instance)
     end
-=begin
-    if association_writable
-      context do
-      it 'builds an association instance' do
-        item_1 = model_instance.send "build_#{association_name}"
-        expect(item_1).to     be_an_instance_of(association_class)
-        expect(item_1).to     be_new_record
-        item_2 = model_instance.send "build_#{association_name}"
-        expect(item_2).to     be_an_instance_of(association_class)
-        expect(item_2).to     be_new_record
-        expect(item_1).to_not be(item_2)
-      end
-      end
-      context do
-        before :each do
-          puts '---- before each...'
-          subject do described_class.new   model_attributes                         end
-            puts "----!!!! subject = #{subject.inspect}"
-            puts "subject.clear_text = #{subject.clear_text}"
-            puts "model_attributes = #{model_attributes.inspect}"
-        end
-      it 'creates an association instance' do
-subject do described_class.new   model_attributes                         end
-subject.valid?
-        puts "---- errors = #{subject.errors.inspect}"
-puts "---- **** subject = #{subject.inspect}"
 
-        expect(subject.save).to be_truthy
+    if association_writable
 
-        created_association_instance = subject.send "create_#{association_name}", association_attributes
-        expect(created_association_instance).to     be_an_instance_of(association_class)
-        expect(created_association_instance).to_not be_new_record
+      context "#build_#{association_name}" do
+        let :association_instance_1                 do subject.send                          "build_#{association_name}" end
+        let :association_instance_2                 do subject.send                          "build_#{association_name}" end
+        it  "should be a #{association_class.name}" do expect(association_instance_1).to     be_a(association_class)     end
+        it  'should not be a new record'            do expect(association_instance_1).to     be_new_record               end
+        it  "should be a #{association_class.name}" do expect(association_instance_2).to     be_a(association_class)     end
+        it  'should not be a new record'            do expect(association_instance_2).to     be_new_record               end
+        it  'should not be identical'               do expect(association_instance_1).to_not be(association_instance_2)  end
       end
+
+      [ "create_#{association_name}", "create_#{association_name}!" ].each do |method_name|
+        context "##{method_name}" do
+          subject do described_class.create! model_attributes end
+          let :created_association_instance do subject.send method_name, association_attributes end
+          it "should be a #{association_class.name}" do expect(created_association_instance).to     be_an_instance_of(association_class) end
+          it 'should not be a new record'            do expect(created_association_instance).to_not be_new_record                        end
+        end
       end
-    end
-=end
-=begin
-    [ association_name, "#{association_name}=".to_sym, "build_#{association_name}".to_sym, "create_#{association_name}".to_sym ].each do |method|
-      association_writable = #model_instance.reflections[association_name].class==::ActiveRecord::Reflection::AssociationReflection
-        #model_instance._reflections[association_name].class==ActiveRecord::Reflection::AssociationReflection
-        model_instance.association(association_name)._reflections.class==ActiveRecord::Reflection::AssociationReflection
-      describe ".#{method}" do
 
-        if association_writable
-          it 'is responded to' do expect(model_instance).to respond_to(method.to_sym) end
-        else
-          unless [ "build_#{association_name}".to_sym, "create_#{association_name}".to_sym ].include? method
-            it 'is responded to' do expect(model_instance).to respond_to(method.to_sym) end
-          end
+      # Pending
+=begin
+      context "#create_#{association_name}" do
+        subject do described_class.create! model_attributes end
+        it 'should return false with {}' do
+          expect { subject.send "create_#{association_name}", {} }.to be_falsey
         end
+      end
 
-        case method
-          when "build_#{association_name}".to_sym
-            if association_writable
-              it 'builds an association instance' do
-                item_1 = model_instance.send method
-                expect(item_1).to     be_an_instance_of(association_class)
-                expect(item_1).to     be_new_record
-                item_2 = model_instance.send method
-                expect(item_2).to     be_an_instance_of(association_class)
-                expect(item_2).to     be_new_record
-                expect(item_1).to_not be(item_2)
-              end
-            end
-          when "create_#{association_name}".to_sym
-            if association_writable
-              it 'creates an association instance' do
-                pending 'Can not create association instance.'
-                created_association_instance = model_instance.send method, association_attributes
-                expect(created_association_instance).to     be_an_instance_of(association_class)
-                expect(created_association_instance).to_not be_new_record
-              end
-            end
-          when "#{association_name}=".to_sym
-            it 'assigns association successfully' do
-              model_instance.send method, association_instance
-              expect(model_instance.send association_name.to_sym).to eq(association_instance)
-            end
+      context "#create_#{association_name}!" do
+        subject do described_class.create! model_attributes end
+        it 'should raise error with {}' do
+          expect { subject.send "create_#{association_name}!", {} }.to raise_error(ActiveRecord::RecordInvalid)
         end
       end
-    end
 =end
 
+    end
+
   end
 
 end

data/lib/unidom/common/rspec/version.rb

@@ -1,7 +1,7 @@
 module Unidom
   module Common
     module RSpec
-      VERSION = '0.6'
+      VERSION = '0.6.1'
     end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: unidom-common-rspec
 version: !ruby/object:Gem::Version
-  version: '0.6'
+  version: 0.6.1
 platform: ruby
 authors:
 - Topbit Du
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2017-01-01 00:00:00.000000000 Z
+date: 2017-01-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec-rails