undo-storage-redis 0.0.4 → 0.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: c8a882c3f5c0a35076305a12e0ac865a59c69154
-  data.tar.gz: 75bce602064d04e209fa91b6bbdee752e020b0da
+  metadata.gz: 6c4552cc3c216da926a6ff07a2f0955c7cc5fc9a
+  data.tar.gz: 8b99208784965fe42e37e14ff27331e03c4cda59
 SHA512:
-  metadata.gz: c12060ce18bae507d6559fa1ee796a4a93245fd8cb76348d865711d382810ddd10dbb000f806de21d7e5caa2a1f0d4c5fc38b68030ec19096a8172ef518e9542
-  data.tar.gz: baaee65da3bf978c953acf6e6431550052002fb49b88540b43737e744ff9eb5ae1286ea21b51823747a9f525be5802aa370ecf64b151e7db5f95a6ef9f310c4e
+  metadata.gz: 93001b74756c0ed421c4c4c8a2d933f4c69fa870abd91f6c4ece0197d8a1463b67088dba569f75b88f4720939e8b242c6b182ddabb9635e4f9ca6800e3cd36f3
+  data.tar.gz: 4e5c5594cfad0415544451a72287c2cbfa74a538fbe6a529d8a3407dce34d519c0a2ddd04f0837fcc4fa96fec236586437180a4a40609c57e84180f5adffbb1a

data/.ruby-version

@@ -1 +1 @@
-2.1.0-p0
+2.1.1

data/.travis.yml

@@ -17,3 +17,6 @@ matrix:
 
 script:
   - "bundle exec rake ci:all"
+
+services:
+  - redis-server

data/Gemfile

@@ -9,3 +9,7 @@ group :test do
     gem "pry-plus" if "ruby" == RUBY_ENGINE
   end
 end
+
+group :test, :development do
+  gem 'redis'
+end

data/README.md

@@ -5,7 +5,7 @@ Undo
 [![Coverage Status](https://coveralls.io/repos/AlexParamonov/undo-storage-redis/badge.png?branch=master)](https://coveralls.io/r/AlexParamonov/undo-storage-redis?branch=master)
 [![Gem Version](https://badge.fury.io/rb/undo-storage-redis.png)](http://badge.fury.io/rb/undo-storage-redis)
 
-Redis storage adapter for Undo gem.
+Redis storage adapter for [Undo gem](https://github.com/AlexParamonov/undo).
 
 Contents
 ---------
@@ -34,6 +34,7 @@ Or install it yourself as:
 Requirements
 ------------
 1. Ruby 1.9 or above
+1. Undo gem
 
 Contacts
 -------------

data/VERSION

@@ -0,0 +1 @@
+0.1.0

data/lib/undo/storage/redis.rb

@@ -1,33 +1,31 @@
 require 'json'
+require 'undo/storage/adapter'
 
 module Undo
   module Storage
-    class Redis
-      VERSION = "0.0.4"
-
+    class Redis < Adapter
       def initialize(redis, options = {})
         @redis = redis
-        @options = options
+        super options
       end
 
-      def put(uuid, object)
-        redis.set uuid, serialize(object), options
+      def store(uuid, object, options = {})
+        redis.set uuid,
+                  pack(object),
+                  adapter_options(options)
       end
 
-      def fetch(uuid)
-        deserialize redis.get uuid, options
+      def fetch(uuid, options = {})
+        data = redis.get(uuid) or raise KeyError, "key #{uuid} not found"
+        unpack data
       end
 
-      private
-      attr_reader :redis, :options
-
-      def serialize(object)
-        object.to_json
+      def delete(uuid, options = {})
+        redis.del uuid
       end
 
-      def deserialize(data)
-        JSON.load data
-      end
+      private
+      attr_reader :redis
     end
   end
 end

data/spec/integration/undo_spec.rb

@@ -0,0 +1,12 @@
+require "spec_helper_lite"
+require "undo"
+require "redis"
+require 'undo/integration/shared_undo_integration_examples.rb'
+
+Undo.configure do |config|
+  config.storage = Undo::Storage::Redis.new Redis.new
+end
+
+describe Undo do
+  include_examples "undo integration"
+end

data/spec/spec_helper_lite.rb

@@ -1,11 +1,5 @@
-if !!ENV['CI']
-  require 'coveralls'
-  Coveralls.wear!
-else
-  require 'pry'
-end
-
-ENV['RAILS_ENV'] ||= 'test'
 require 'rspec'
+require_relative "support/ci_helper"
+require 'undo/storage/redis'
 
 $: << File.expand_path('../lib', File.dirname(__FILE__))

data/spec/support/ci_helper.rb

@@ -0,0 +1,16 @@
+if !!ENV["CI"]
+  require 'simplecov'
+  require 'coveralls'
+  SimpleCov.formatter = SimpleCov::Formatter::MultiFormatter[
+    SimpleCov::Formatter::HTMLFormatter,
+    Coveralls::SimpleCov::Formatter
+  ]
+
+  SimpleCov.start do
+    add_filter '/spec/'
+    add_filter '/vendor/'
+    minimum_coverage(90)
+  end
+else
+  require "pry"
+end

data/spec/undo/storage/redis_spec.rb

@@ -1,37 +1,65 @@
 require "spec_helper_lite"
-require 'undo/storage/redis'
 
 describe Undo::Storage::Redis do
-  let(:adapter) { described_class.new redis }
+  subject { described_class.new redis }
   let(:redis) { double :redis }
 
-  it "writes hash to redis" do
+  it "uses provided storage" do
+    subject = described_class.new redis
+
+    expect(redis).to receive :set
+    subject.store "foo", "bar"
+  end
+
+  it "writes hash as json" do
     expect(redis).to receive(:set).with "123", '{"hello":"world"}', anything
-    adapter.put "123", "hello" => "world"
+    subject.store "123", "hello" => "world"
   end
 
-  it "reads hash from redis" do
-    expect(redis).to receive(:get).with("123", anything) { '{"hello":"world"}' }
-    expect(adapter.fetch "123").to eq "hello" => "world"
+  it "reads hash" do
+    expect(redis).to receive(:get).with("123") { '{"hello":"world"}' }
+    expect(subject.fetch "123").to eq "hello" => "world"
   end
 
-  describe "options" do
-    let(:adapter) { described_class.new redis, options }
-    let(:options) { { :additional => :option } }
+  describe "default options" do
+    subject { described_class.new redis, options }
+    let(:options) { { additional: :option } }
 
-    it "sends provided options to redis.get" do
-      expect(redis).to receive(:get).with anything, options
-      adapter.fetch "foo"
+    it "does not send options to redis.get" do
+      expect(redis).to receive(:get).with("foo") { "bar".to_json }
+      subject.fetch "foo"
+    end
+
+    it "does not send options to redis.del" do
+      expect(redis).to receive(:del).with "foo"
+      subject.delete "foo"
     end
 
     it "sends provided options to redis.set" do
       expect(redis).to receive(:set).with anything, anything, options
-      adapter.put "foo", "bar"
+      subject.store "foo", "bar"
+    end
+  end
+
+  describe "options" do
+    let(:object) { double :object }
+    let(:options) { { foo: :bar } }
+
+    it "accepts options per method" do
+      redis.as_null_object
+
+      expect do
+        subject.store 123, object, options
+        subject.fetch 123, options
+        subject.delete 123, options
+      end.not_to raise_error
     end
 
-    before do
-      # JSON.load behaves differently in 1.9
-      allow(redis).to receive(:get).with(any_args) { { :foo => :bar }.to_json }
-    end if RUBY_VERSION < "2.0"
+    it "has higher priority than default options" do
+      subject = described_class.new redis, ex: 10
+
+      expect(redis).to receive(:set).with anything, anything, ex: 1
+      subject.store 123, object, ex: 1
+    end
   end
 end

data/undo-storage-redis.gemspec

@@ -1,11 +1,10 @@
 # coding: utf-8
 lib = File.expand_path('../lib', __FILE__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
-require 'undo/storage/redis'
 
 Gem::Specification.new do |spec|
   spec.name          = "undo-storage-redis"
-  spec.version       = Undo::Storage::Redis::VERSION
+  spec.version       = IO.read("VERSION")
   spec.authors       = ["Alexander Paramonov"]
   spec.email         = ["alexander.n.paramonov@gmail.com"]
   spec.summary       = %q{Redis storage adapter for Undo}
@@ -18,7 +17,8 @@ Gem::Specification.new do |spec|
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ["lib"]
 
-  spec.add_development_dependency "bundler", "~> 1.5"
+  spec.add_dependency "undo", "~> 1.0"
+  spec.add_development_dependency "bundler", "~> 1.0"
   spec.add_development_dependency "rake"
   spec.add_development_dependency "rspec", ">= 3.0.0.beta1"
 end

metadata

@@ -1,29 +1,43 @@
 --- !ruby/object:Gem::Specification
 name: undo-storage-redis
 version: !ruby/object:Gem::Version
-  version: 0.0.4
+  version: 0.1.0
 platform: ruby
 authors:
 - Alexander Paramonov
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-02-18 00:00:00.000000000 Z
+date: 2014-05-11 00:00:00.000000000 Z
 dependencies:
+- !ruby/object:Gem::Dependency
+  name: undo
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.0'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.5'
+        version: '1.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.5'
+        version: '1.0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -69,8 +83,11 @@ files:
 - LICENSE.txt
 - README.md
 - Rakefile
+- VERSION
 - lib/undo/storage/redis.rb
+- spec/integration/undo_spec.rb
 - spec/spec_helper_lite.rb
+- spec/support/ci_helper.rb
 - spec/undo/storage/redis_spec.rb
 - undo-storage-redis.gemspec
 homepage: http://github.com/AlexParamonov/undo-storage-redis
@@ -93,11 +110,13 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.2
+rubygems_version: 2.1.11
 signing_key: 
 specification_version: 4
 summary: Redis storage adapter for Undo
 test_files:
+- spec/integration/undo_spec.rb
 - spec/spec_helper_lite.rb
+- spec/support/ci_helper.rb
 - spec/undo/storage/redis_spec.rb
 has_rdoc: