undercover 0.1.7 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: f2c8fd3763c8494ad7be8661f9d0d1e6fb7dfda9
-  data.tar.gz: 19a2961fa7f865971a82c8c80f2f2d8b51510e9b
+SHA256:
+  metadata.gz: 34741f7a74c75b9b6c91597b849a7d543864809b0dc8ec505f80d31fc7ed8ba2
+  data.tar.gz: 91a6589eac0676253c1c2c0ce3a8e0399c18cfd62b37e38aab06364397b1f4b9
 SHA512:
-  metadata.gz: eb1b3f61949ee3cce0d14bf3efe502902b0ee2bc0915ec2c9af20f475ec6d8ded1f016011bba616e469503c1dd9fc5fddf20eeae9ac1e30f6b81089721941238
-  data.tar.gz: ec7b3f43d7e76298fc3dd6b4fa38a9f3a4863ff74b599756f68432045b78173af5805cb76e354920c8882998829dd0457057ceb685709adae068f79254c0afad
+  metadata.gz: 6e2334be919b81fa7f186824da3a289cf4af15e875fb758aa93f1df1d7a1e8704082765a616a657c0f37efaa6d44640396cc8875ca9f39037902fe9ce5bb5f68
+  data.tar.gz: 4272d22c6e46532c552a1a9f01f815ee2a5be257bc951e04afdb34a9c4a812fdf7b609231c3ad2f2463f9e293bc46fc7a40d3e869a12a9edf8aa722899d85384

data/CHANGELOG.md

@@ -0,0 +1,61 @@
+# Changelog
+All notable changes to this project will be documented in this file.
+
+The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
+and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).
+
+## [Unreleased]
+
+## [0.2.0] - 2018-08-19
+### Added
+- This `CHANGELOG.md`
+- Ruby syntax version customisable with `-r` or `--ruby-syntax`
+
+### Fixed
+- Relative and absolute project path support
+- typo in stale coverage warning message by @ilyakorol
+
+## [0.1.7] - 2018-08-03
+### Changed
+- Readme updates by @westonganger.
+
+### Fixed
+- Handled invalid UTF-8 encoding errors from `parser`
+
+## [0.1.6] - 2018-07-10
+### Fixed
+- Updated `imagen` to `0.1.3` which avoids a broken release of `parser`
+
+## [0.1.5] - 2018-06-25
+### Changed
+- Avoided conflicts between `rainbow` and `pronto` versions for use in upcoming `pronto-undercover` gem
+
+## [0.1.4] - 2018-05-20
+### Fixed
+- Quick fix 🤷‍♂️
+
+## [0.1.3] - 2018-05-20
+### Added
+- `imagen` version bump adding block syntax support
+
+## [0.1.2] - 2018-05-18
+### Fixed
+- `--version` cli option fix
+
+## [0.1.1] - 2018-05-17
+### Fixed
+- CLI exit codes on success error
+
+## [0.1.0] - 2018-05-10
+### Added
+- First release of `undercover` 🎉
+
+[Unreleased]: https://github.com/grodowski/undercover/compare/v0.2.0...HEAD
+[0.2.0]: https://github.com/grodowski/undercover/compare/v0.1.7...v0.2.0
+[0.1.7]: https://github.com/grodowski/undercover/compare/v0.1.6...v0.1.7
+[0.1.6]: https://github.com/grodowski/undercover/compare/v0.1.5...v0.1.6
+[0.1.5]: https://github.com/grodowski/undercover/compare/v0.1.4...v0.1.5
+[0.1.4]: https://github.com/grodowski/undercover/compare/v0.1.3...v0.1.4
+[0.1.3]: https://github.com/grodowski/undercover/compare/v0.1.2...v0.1.3
+[0.1.2]: https://github.com/grodowski/undercover/compare/v0.1.1...v0.1.2
+[0.1.1]: https://github.com/grodowski/undercover/compare/v0.1.0...v0.1.1

data/lib/undercover/cli.rb

@@ -9,16 +9,18 @@ module Undercover
     # traversing the whole project at first!
 
     WARNINGS_TO_S = {
-      stale_coverage: Rainbow('♻️  Coverage data is older than your' \
+      stale_coverage: Rainbow('♻️  Coverage data is older than your ' \
         'latest changes. Re-run tests to update').yellow,
       no_changes: Rainbow('✅ No reportable changes').green
     }.freeze
 
     WARNINGS_TO_EXITCODE = {stale_coverage: 1, no_changes: 0}.freeze
 
+    # rubocop:disable Metrics/MethodLength, Metrics/AbcSize
     def self.run(args)
       opts = Undercover::Options.new.parse(args)
-      report = Undercover::Report.new(opts).build
+      syntax_version(opts.syntax_version)
+      report = Undercover::Report.new(changeset(opts), opts).build
 
       error = report.validate(opts.lcov)
       if error
@@ -30,5 +32,16 @@ module Undercover
       puts Undercover::Formatter.new(warnings)
       warnings.any? ? 1 : 0
     end
+    # rubocop:enable Metrics/MethodLength, Metrics/AbcSize
+
+    def self.syntax_version(version)
+      return unless version
+      Imagen.parser_version = version
+    end
+
+    def self.changeset(opts)
+      git_dir = File.join(opts.path, opts.git_dir)
+      Undercover::Changeset.new(git_dir, opts.compare)
+    end
   end
 end

data/lib/undercover/options.rb

@@ -17,7 +17,7 @@ module Undercover
       # OUTPUT_CIRCLEMATOR = :circlemator # posts warnings as review comments
     ].freeze
 
-    attr_accessor :lcov, :path, :git_dir, :compare
+    attr_accessor :lcov, :path, :git_dir, :compare, :syntax_version
 
     def initialize
       # TODO: use run modes
@@ -29,7 +29,7 @@ module Undercover
       self.git_dir = '.git'
     end
 
-    # rubocop:disable Metrics/MethodLength
+    # rubocop:disable Metrics/MethodLength, Metrics/AbcSize
     def parse(args)
       OptionParser.new do |opts|
         opts.banner = 'Usage: undercover [options]'
@@ -48,15 +48,15 @@ module Undercover
         project_path_option(opts)
         git_dir_option(opts)
         compare_option(opts)
+        ruby_syntax_option(opts)
         # TODO: parse dem other options and assign to self
         # --quiet (skip progress bar)
         # --exit-status (do not print report, just exit)
-        # --ruby-version (string, like '2.4.4', how to support in parser?)
       end.parse(args)
       guess_lcov_path unless lcov
       self
     end
-    # rubocop:enable Metrics/MethodLength
+    # rubocop:enable Metrics/MethodLength, Metrics/AbcSize
 
     private
 
@@ -86,6 +86,14 @@ module Undercover
       end
     end
 
+    def ruby_syntax_option(parser)
+      versions = Imagen::AVAILABLE_RUBY_VERSIONS.sort.join(', ')
+      desc = "Ruby syntax version, one of: #{versions}"
+      parser.on('-r', '--ruby-synax ver', desc) do |version|
+        self.syntax_version = version.strip
+      end
+    end
+
     def guess_lcov_path
       cwd = Pathname.new(File.expand_path(path))
       self.lcov = File.join(cwd, 'coverage', 'lcov', "#{cwd.split.last}.lcov")

data/lib/undercover/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Undercover
-  VERSION = '0.1.7'
+  VERSION = '0.2.0'
 end

data/lib/undercover.rb

@@ -26,18 +26,20 @@ module Undercover
 
     # Initializes a new Undercover::Report
     #
-    # @param options [Undercover::Options]
-    def initialize(opts)
+    # @param changeset [Undercover::Changeset]
+    # @param opts [Undercover::Options]
+    def initialize(changeset, opts)
       @lcov = LcovParser.parse(File.open(opts.lcov))
       @code_dir = opts.path
-      git_dir = File.join(opts.path, opts.git_dir)
-      @changeset = Changeset.new(git_dir, opts.compare).update
-      @results = Hash.new { |hsh, key| hsh[key] = [] }
+      @changeset = changeset.update
+      @results = {}
     end
 
     def build
       each_result_arg do |filename, coverage, imagen_node|
-        results[filename.gsub(/^\.\//, '')] << Result.new(
+        key = filename.gsub(/^\.\//, '')
+        results[key] ||= []
+        results[key] << Result.new(
           imagen_node, coverage, filename
         )
       end
@@ -57,6 +59,7 @@ module Undercover
           dist_from_line_no[res1] <=> dist_from_line_no[res2]
         end
 
+        next unless results[filepath]
         res = results[filepath].min(&dist_from_line_no_sorter)
         flagged_results << res if res&.uncovered?(line_no)
       end
@@ -80,12 +83,12 @@ module Undercover
     # so is this still good idea? (Rakefile, .gemspec etc)
     def each_result_arg
       match_all = ->(_) { true }
-      lcov.source_files.each do |filename, coverage|
-        path = File.join(code_dir, filename)
+      lcov.source_files.each do |relative_filename, coverage|
+        path = File.join(code_dir, relative_filename)
         root_ast = Imagen::Node::Root.new.build_from_file(path)
         next if root_ast.children.empty?
         root_ast.children[0].find_all(match_all).each do |node|
-          yield(path, coverage, node)
+          yield(relative_filename, coverage, node)
         end
       end
     end

data/undercover.gemspec

@@ -23,7 +23,7 @@ Gem::Specification.new do |spec|
   spec.executables   = spec.files.grep(/^bin\//) { |f| File.basename(f) }
   spec.require_paths = ['lib']
 
-  spec.add_dependency 'imagen', '~> 0.1.4'
+  spec.add_dependency 'imagen', '~> 0.1.5'
   spec.add_dependency 'rainbow', '~> 2.1'
   spec.add_dependency 'rugged', '~> 0.27.0'
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: undercover
 version: !ruby/object:Gem::Version
-  version: 0.1.7
+  version: 0.2.0
 platform: ruby
 authors:
 - Jan Grodowski
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-08-03 00:00:00.000000000 Z
+date: 2018-08-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: imagen
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.1.4
+        version: 0.1.5
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.1.4
+        version: 0.1.5
 - !ruby/object:Gem::Dependency
   name: rainbow
   requirement: !ruby/object:Gem::Requirement
@@ -191,6 +191,7 @@ files:
 - ".rspec"
 - ".rubocop.yml"
 - ".travis.yml"
+- CHANGELOG.md
 - Gemfile
 - LICENSE.txt
 - README.md
@@ -227,7 +228,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.14.1
+rubygems_version: 2.7.6
 signing_key: 
 specification_version: 4
 summary: Actionable code coverage - detects untested code blocks in recent changes