un_locode 0.0.4 → 0.0.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 6b2ad7a1efc457f1b2eb89fc3b3cb1299492e17f
-  data.tar.gz: 4ed762adb6e2b0eab5b8b23fcd68c38f7d7bb44b
+  metadata.gz: 77e82eda82d1196c613e18cb50e64e6dc8decc29
+  data.tar.gz: f1342cfbdd1deba5f104214229804585e0bb4763
 SHA512:
-  metadata.gz: 983e46fd27f67d4e596ead59d59f05d52b72376867f93f48323b4c871630cdaf2caf11f32e7622d6c58abb26f20f7e5a2c41737f086af91564672b12849bdaea
-  data.tar.gz: 2a511ea2736af6f4b03a96fc5607d17f4fadaa2d29f0a5f315b501a0881b97a6c88fccfab4b41f46bef169d3bb6c3950df5131d53a6591d51125e5ad517baa1f
+  metadata.gz: b1bb35412af0bae937672e59a74ecb4776d2753873bcffb0865726a79eeaf26671afe38b3be1f3ad854f027b76fe9c3a633de709807e3cfc2c45fce96d851569
+  data.tar.gz: 33fa3890ec41ee225a694dcca692e6245206952f9a7ddac0df4482ebcd343e37e00b3e1c866ca148d2f879e87ff531f7e11e7565524b16f9a716e061026c3f57

data/.hound.yml

@@ -0,0 +1,2 @@
+ruby:
+  config_file: .ruby-style.yml

data/.ruby-style.yml

@@ -0,0 +1,25 @@
+Metrics/LineLength:
+  Description: Limit lines to 80 characters.
+  StyleGuide: https://github.com/bbatsov/ruby-style-guide#80-character-limits
+  Enabled: true
+  Max: 120
+  AllowURI: true
+  URISchemes:
+  - http
+  - https
+Style/StringLiterals:
+  Description: Checks if uses of quotes match the configured preference.
+  StyleGuide: https://github.com/bbatsov/ruby-style-guide#consistent-string-literals
+  Enabled: true
+  EnforcedStyle: single_quotes
+  SupportedStyles:
+  - single_quotes
+  - double_quotes
+Style/StringLiteralsInInterpolation:
+  Description: Checks if uses of quotes inside expressions in interpolated strings
+    match the configured preference.
+  Enabled: true
+  EnforcedStyle: single_quotes
+  SupportedStyles:
+  - single_quotes
+  - double_quotes

data/README.md

@@ -1,6 +1,6 @@
 # Locode
 
-[![Build Status](https://travis-ci.org/kabisaict/un_locode.png)](https://travis-ci.org/kabisaict/un_locode)
+[![Build Status](https://travis-ci.org/kabisa/un_locode.svg?branch=master)](https://travis-ci.org/kabisa/un_locode)
 [![Gem Version](https://badge.fury.io/rb/un_locode.png)](http://badge.fury.io/rb/un_locode)
 
 The un_locode gem gives you the ability to lookup UN/LOCODE codes. You can read more about the UN/LOCODE specifications here: [wiki](http://en.wikipedia.org/wiki/UN/LOCODE) and [UNECE](http://www.unece.org/fileadmin/DAM/cefact/locode/Service/LocodeColumn.htm).

data/lib/un_locode/locode.rb

@@ -29,9 +29,8 @@ module UnLocode
     end
 
     def self.find_by_locode(locode)
-      locode = locode.split(' ')
-      includes(:country).where(city_code: locode.last)
-        .where(countries: { code: locode.first }).first
+      locode = locode.gsub(' ', '').upcase
+      includes(:country).find_by(city_code: locode[2..4], countries: { code: locode[0..1] })
     end
 
     def as_json options = {}

data/lib/un_locode/version.rb

@@ -1,3 +1,3 @@
 module UnLocode
-  VERSION = '0.0.4'
+  VERSION = '0.0.5'
 end

data/spec/un_locode_spec.rb

@@ -94,13 +94,26 @@ describe UnLocode::Locode do
       let!(:country) { UnLocode::Country.create name: 'NETHERLANDS', code: 'NL' }
       let!(:location) { UnLocode::Locode.create name: 'Venlo', city_code: 'VEN', country: country }
 
-      context 'with supported functions' do
+      context 'with supported functions and space in search' do
         subject { UnLocode::Locode.find_by_locode(search_term) }
         let(:search_term) { 'NL VEN' }
-
+        its(:city_code) { should eql('VEN') }
         its(:name) { should eql('Venlo') }
         its(:country) { should eql(country) }
       end
+      context 'with supported functions with actual space-less locode' do
+        subject { UnLocode::Locode.find_by_locode(search_term) }
+        let(:search_term) { 'NLVEN' }
+        its(:city_code) { should eql('VEN') }
+        its(:name) { should eql('Venlo') }
+        its(:country) { should eql(country) }
+      end
+      context 'with supported functions with mixed case locode' do
+        subject { UnLocode::Locode.find_by_locode(search_term) }
+        let(:search_term) { 'NlVen' }
+        its(:city_code) { should eql('VEN') }
+      end
+
     end
   end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: un_locode
 version: !ruby/object:Gem::Version
-  version: 0.0.4
+  version: 0.0.5
 platform: ruby
 authors:
 - Michel de Graaf
@@ -12,7 +12,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-07-10 00:00:00.000000000 Z
+date: 2015-07-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -125,7 +125,9 @@ extra_rdoc_files: []
 files:
 - ".DS_Store"
 - ".gitignore"
+- ".hound.yml"
 - ".rspec"
+- ".ruby-style.yml"
 - ".ruby-version"
 - ".travis.yml"
 - Gemfile