umappp 0.1.5 → 0.1.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: cc70f43249cb1993d3fdb810a0cc542e9da383c113f3119414c43723e613ccf0
-  data.tar.gz: ec95857557261b5d1aa066dae830ffb7648e7758dd50a96c14af5332a2563e9f
+  metadata.gz: 4268767d4aa68fb7795e72e48a9822b629390091cd5214d460e1d99a3127a3c3
+  data.tar.gz: 684fdcf60aa7dc40a061927103692dda85fc2e40bb1680b0c61f014980197292
 SHA512:
-  metadata.gz: b0d0be70caca251226572ae920adab0938451383a90444235ffd939ad23e58c73034cdce95fa4639d26da9f5517453f0aa2b78fcb8d254d03685726b55ceb10d
-  data.tar.gz: 4cebd1fb124c6d61bf083af58283f75a9e6a714c2ad4425a2c72871fa1bee579bb7377859691187ecfb6f845d6e2b8d4bb670e1837813fe7e6dbb33975aa2c70
+  metadata.gz: 7a9d5181ec290f40b5b22079c36d90a2fe07e1072b35b933ee30da253fc0f734431081334b6fc7510317df330e7c321386bc46da742d4515a646437e70602835
+  data.tar.gz: 05d42582e0d559591bd22b767a6d7df7b821288fa8b44da86d8255822b49e629c15dd33e719d383a08d933ff1dfdd3fdf839e3eed7f2131dc0bf868c3ad467b4

data/README.md

@@ -16,7 +16,6 @@
 
 ## Installation
 
-
 ```
 gem install umappp
 ```

data/ext/umappp/umappp.cpp

@@ -1,7 +1,6 @@
 // Uniform Manifold Approximation and Projection for Ruby
 // https://github.com/kojix2/ruby-umappp
 
-
 #include <rice/rice.hpp>
 #include <rice/stl.hpp>
 #include "numo.hpp"
@@ -52,7 +51,7 @@ Object umappp_run(
 {
   // Parameters are taken from a Ruby Hash object.
   // If there is key, set the value.
-  
+
   auto umap_ptr = new Umap;
 
   double local_connectivity = Umap::Defaults::local_connectivity;
@@ -159,7 +158,7 @@ Object umappp_run(
     num_threads = params.get<int>(Symbol("num_threads"));
     umap_ptr->set_num_threads(num_threads);
   }
-  
+
   // initialize_from_matrix
 
   const float *y = data.read_ptr();
@@ -181,12 +180,16 @@ Object umappp_run(
   std::vector<Float> embedding(ndim * nobs);
 
   auto status = umap_ptr->initialize(knncolle_ptr.get(), ndim, embedding.data());
-
+  if (nobs < 0 || ndim < 0)
+  {
+    throw std::runtime_error("nobs or ndim is negative");
+  }
   if (tick == 0)
   {
     status.run(ndim, embedding.data(), 0);
 
-    auto na = numo::SFloat({(uint)nobs, (uint)ndim});
+    // it is safe to cast to unsigned int
+    auto na = numo::SFloat({(unsigned int)nobs, (unsigned int)ndim});
     std::copy(embedding.begin(), embedding.end(), na.write_ptr());
 
     return na;
@@ -201,7 +204,8 @@ Object umappp_run(
 
       status.run(ndim, embedding.data(), epoch_limit);
 
-      auto na = numo::SFloat({(uint)nobs, (uint)ndim});
+      //it is safe to cast to unsigned int
+      auto na = numo::SFloat({(unsigned int)nobs, (unsigned int)ndim});
       std::copy(embedding.begin(), embedding.end(), na.write_ptr());
 
       rb_ary_push(ret, na.value());

data/lib/umappp/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Umappp
-  VERSION = "0.1.5"
+  VERSION = "0.1.6"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: umappp
 version: !ruby/object:Gem::Version
-  version: 0.1.5
+  version: 0.1.6
 platform: ruby
 authors:
 - kojix2
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2022-11-02 00:00:00.000000000 Z
+date: 2022-11-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: numo-narray