uk_account_validator 0.0.2 → 0.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: c637157bc170af3a8dfffc98dc8eb077c8399a53
-  data.tar.gz: 306471bc50f263137a9345d71bdbb01030dfedd9
+  metadata.gz: ebcd385fc8ba4ecc1703657a83b9b0eb45b30b51
+  data.tar.gz: 5114241aa01ffbfcc0ce676084f133b0c134dea4
 SHA512:
-  metadata.gz: 5d4c22ba1364efd73e909e109f99875f281ec87dbbd90e27042cd50223f3a899e7efe803da9aeac4d7f4c634fdfb256413f51ee6f9255f47958ad0ff5f69cdc2
-  data.tar.gz: 8455a102924d27c735870f1fe061c6200105a8a766a6fe36bf14e761b0e78aad6dc8a4f64b1258a718174d41ee2ca3cb2b0e0d8287de0fdcfe957821584adad3
+  metadata.gz: e95c9284cbc1423203ea396c5cba5d97ff46c104458ec031c63a3e6f60433c124d6e43905d7d0e54e5d04f4d98f410f5d05b7b8d16087e6e2288f44bde26c7cc
+  data.tar.gz: 9cdb8baca1a7cd094f963331fae6cd72a2f59616b693c398206a65b326b9799e4d18007dc9e2a5fc90cadebb225989111c7476ea2ba19df90fb167e3b2a8f5d9

data/README.md

@@ -7,6 +7,10 @@ This gem validates uk account numbers against their sort codes in accordance wit
 
 http://www.vocalink.com/media/700427/vocalink_-_validating_account_numbers_v3.20.pdf
 
+Note that this gem ensures the sort code and account number are valid, not that they exist.
+
+NB the resource text files valacdos.txt and scsubtab.txt are produced and released by VocaLink.
+
 Requires Ruby > 2.0.0
 
 Usage

data/features/allow_hyphens_in_sort_codes.feature

@@ -0,0 +1,9 @@
+Feature: Allow hyphens in sort codes
+  Background:
+    Given I create a new checker
+
+  Scenario: A user supplies a valid sort code separated by hyphens
+    Given I have a sort code 08-99-99
+    And I have an account number 66374958
+
+    Then the combination is valid

data/features/invalid_formats.feature

@@ -0,0 +1,33 @@
+Feature: Account number and sort code must be in recognised format
+  Background:
+    Given I create a new checker
+
+  Scenario: Account number contains letters
+    Given I have a sort code 089999
+    And I have an account number abcdefgh
+
+    Then the combination is invalid
+
+  Scenario: Account number must be at least 6 digits
+    Given I have a sort code 089999
+    And I have an account number 66374
+
+    Then the combination is invalid
+
+  Scenario: Account number may not be more than 10 digits
+    Given I have a sort code 089999
+    And I have an account number 66374958663
+
+    Then the combination is invalid
+
+  Scenario: The sort code may not be less than 6 digits
+    Given I have a sort code 08999
+    And I have an account number 66374958
+
+    Then the combination is invalid
+
+  Scenario: The sort code may not be more than 6 digits
+    Given I have a sort code 0899999
+    And I have an account number 66374958
+
+    Then the combination is invalid

data/features/step_definitions/basics.rb

@@ -2,11 +2,11 @@ Given(/^I create a new checker$/) do
   @checker = UkAccountValidator::Validator.new
 end
 
-Given(/^I have a sort code (\d+)$/) do |sort_code|
+Given(/^I have a sort code (\S+)$/) do |sort_code|
   @checker.sort_code = sort_code
 end
 
-Given(/^I have an account number (\d+)$/) do |acc_number|
+Given(/^I have an account number (\S+)$/) do |acc_number|
   @checker.account_number = acc_number
 end
 

data/lib/uk_account_validator/validator.rb

@@ -1,12 +1,18 @@
 module UkAccountValidator
   class Validator
-    attr_accessor :account_number, :sort_code
+
+    attr_writer   :sort_code
+    attr_accessor :account_number
 
     def initialize(account_number = nil, sort_code = nil)
       @account_number = account_number
       @sort_code      = sort_code
     end
 
+    def sort_code
+      @sort_code.gsub('-', '')
+    end
+
     def modulus_weights
       @modulus_weights ||= UkAccountValidator.modulus_weights_table.find(sort_code)
     end
@@ -25,6 +31,8 @@ module UkAccountValidator
     end
 
     def valid?
+      return false unless valid_format?
+
       exceptions = modulus_weights.map(&:exception)
       exception_class = self.exception_class(exceptions)
 
@@ -43,6 +51,15 @@ module UkAccountValidator
       results.all?
     end
 
+    def valid_format?
+      return false if account_number =~ /\D/
+      return false if account_number.length < 6
+      return false if account_number.length > 10
+      return false if sort_code.length != 6
+
+      return true
+    end
+
     def exception_class(exception_strings)
       case
       when exception_strings.include?('1')

data/lib/uk_account_validator/version.rb

@@ -1,3 +1,3 @@
 module UkAccountValidator
-  VERSION = '0.0.2'
+  VERSION = '0.0.3'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: uk_account_validator
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.3
 platform: ruby
 authors:
 - Hayden Ball
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-05-16 00:00:00.000000000 Z
+date: 2015-05-17 00:00:00.000000000 Z
 dependencies: []
 description: Validate UK Account Numbers and Sort Codes
 email:
@@ -26,7 +26,9 @@ files:
 - Rakefile
 - data/scsubtab.txt
 - data/valacdos.txt
+- features/allow_hyphens_in_sort_codes.feature
 - features/exceptions.feature
+- features/invalid_formats.feature
 - features/modulus10.feature
 - features/modulus11.feature
 - features/modulus_weight.feature
@@ -85,7 +87,9 @@ signing_key:
 specification_version: 4
 summary: Validate UK Account Numbers and Sort Codes
 test_files:
+- features/allow_hyphens_in_sort_codes.feature
 - features/exceptions.feature
+- features/invalid_formats.feature
 - features/modulus10.feature
 - features/modulus11.feature
 - features/modulus_weight.feature