uber 0.0.10 → 0.0.11

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: c817ac8bf31287641d793288fd317cb89818c834
-  data.tar.gz: 79d88494f259334a88606b95bd4f1e3315d9248f
+  metadata.gz: 542663f6bd6360841443f9ac9cb3a3e5d8ea6672
+  data.tar.gz: 2bf5d837bc6d9f64b32a48aa28f8ad3dd5a3cd37
 SHA512:
-  metadata.gz: 1ef9075f772764e736bfee3213d525be71d65ef1b23b23fa787bc0886f748d8a59049c567648c20e6aacd06b8f5c7ecfea10f17d775b14ea401e8eeaf7b15d65
-  data.tar.gz: e9441a4deb06ba1630bb7e06bebebbb7f679b5448a6013a878caa9f108f64a8d1817ab5e0ce11445dbffa3957929156b20c6771fe8fce836a55f9a1703a2e763
+  metadata.gz: 8b135d80f988a6e9230c5a3317df4dc16ea982fba517c27c4b1638538b204f1d388829fcf194ed93e679f8536efc402c66c8c21c961e5b057113676bf9bfbb10
+  data.tar.gz: 44c29b8fa99ec1c7a97bffd4792d198ebf9baef598326fdf14fdbf254e0c3f6f84f53a50398736d1b508bcaa1fb3682f4bd176c9c99bf5311d8b33ee5a15026e

data/CHANGES.md

@@ -1,3 +1,7 @@
+# 0.0.11
+
+* Don't clone nil, false, true and symbols in `::inheritable_attr`.
+
 # 0.0.10
 
 * Builders are _not_ inherited to subclasses. This allows instantiating subclasses directly without running builders.

data/README.md

@@ -14,7 +14,8 @@ Ready?
 
 # Inheritable Class Attributes
 
-This is for you if you want class attributes to be inherited, which is a mandatory mechanism for creating DSLs.
+If you want inherited class attributes, this is for you.
+This is a mandatory mechanism for creating DSLs.
 
 ```ruby
 require 'uber/inheritable_attr'
@@ -27,15 +28,13 @@ class Song
 end
 ```
 
-Note that you have to initialize your attribute which whatever you want - usually a hash or an array.
-
-You can now use that attribute on the class level.
+Note that you have to initialize your class attribute with whatever you want - usually a hash or an array.
 
 ```ruby
 Song.properties #=> [:title, :track]
 ```
 
-Inheriting from `Song` will result in the `properties` object being `clone`d to the sub-class.
+A subclass of `Song` will have a `clone`d `properties` class attribute.
 
 ```ruby
 class Hit < Song
@@ -44,7 +43,7 @@ end
 Hit.properties #=> [:title, :track]
 ```
 
-The cool thing about the inheritance is: you can work on the inherited attribute without any restrictions, as it is a _copy_ of the original.
+The cool thing about the inheritance is: you can work on the inherited attribute without any restrictions. It is a _copy_ of the original.
 
 ```ruby
 Hit.properties << :number
@@ -53,10 +52,10 @@ Hit.properties  #=> [:title, :track, :number]
 Song.properties #=> [:title, :track]
 ```
 
-It's similar to ActiveSupport's `class_attribute` but with a simpler implementation resulting in a less dangerous potential. Also, there is no restriction about the way you modify the attribute [as found in `class_attribute`](http://apidock.com/rails/v4.0.2/Class/class_attribute).
-
-This module is very popular amongst numerous gems like Cells, Representable, Roar and Reform.
+It's similar to ActiveSupport's `class_attribute` but with a simpler implementation.
+It is less dangerous. There are no restrictions for modifying the attribute. [compared to `class_attribute`](http://apidock.com/rails/v4.0.2/Class/class_attribute).
 
+This module is used across several other gems like [Cells](https://rubygems.org/gems/cells), [Representable](https://rubygems.org/gems/representable), [Roar](https://rubygems.org/gems/roar) and [Reform](https://rubygems.org/gems/reform).
 
 # Dynamic Options
 
@@ -274,4 +273,4 @@ version.~ "1.1", "1.2" #=> true
 
 Copyright (c) 2014 by Nick Sutterer <apotonick@gmail.com>
 
-Roar is released under the [MIT License](http://www.opensource.org/licenses/MIT).
+Uber is released under the [MIT License](http://www.opensource.org/licenses/MIT).

data/lib/uber/inheritable_attr.rb

@@ -7,14 +7,29 @@ module Uber
         end
 
         def #{name}
-          @#{name} ||= InheritableAttribute.inherit_for(self, :#{name})
+          return @#{name} if instance_variable_defined?(:@#{name})
+          @#{name} = InheritableAttribute.inherit_for(self, :#{name})
         end
       }
     end
 
     def self.inherit_for(klass, name)
-      return unless klass.superclass.respond_to?(name) and value = klass.superclass.send(name)
-      value.clone # only do this once.
+      return unless klass.superclass.respond_to?(name)
+
+      value = klass.superclass.send(name) # could be nil.
+      Clone.(value) # this could be dynamic, allowing other inheritance strategies.
+    end
+
+    class Clone
+      # The second argument allows injecting more types.
+      def self.call(value, uncloneable=uncloneable)
+        uncloneable.each { |klass| return value if value.kind_of?(klass) }
+        value.clone
+      end
+
+      def self.uncloneable
+        [Symbol, TrueClass, FalseClass, NilClass]
+      end
     end
   end
 

data/lib/uber/uber_version.rb

@@ -1,3 +1,3 @@
 module Uber
-  VERSION = "0.0.10"
+  VERSION = "0.0.11"
 end

data/test/inheritable_attr_test.rb

@@ -7,9 +7,14 @@ class InheritableAttrTest < MiniTest::Spec
       Class.new(Object) do
         extend Uber::InheritableAttribute
         inheritable_attr :drinks
+        inheritable_attr :glass
       end
     }
 
+    def assert_nothing_raised(*)
+      yield
+    end
+
     it "provides a reader with empty inherited attributes, already" do
       assert_equal nil, subject.drinks
     end
@@ -50,5 +55,26 @@ class InheritableAttrTest < MiniTest::Spec
       subklass.drinks = [:merlot] # we only want merlot explicitely.
       assert_equal [:merlot], subklass.drinks # no :cabernet, here
     end
+
+    it "does not attempt to clone symbols" do
+      subject.glass = :highball
+      subklass = Class.new(subject)
+
+      subklass.glass.must_equal :highball
+    end
+
+    it "does not attempt to clone true" do
+      subject.glass = true
+      subklass = Class.new(subject)
+
+      subklass.glass.must_equal true
+    end
+
+    it "does not attempt to clone false" do
+      subject.glass = false
+      subklass = Class.new(subject)
+
+      subklass.glass.must_equal false
+    end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: uber
 version: !ruby/object:Gem::Version
-  version: 0.0.10
+  version: 0.0.11
 platform: ruby
 authors:
 - Nick Sutterer
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-10-23 00:00:00.000000000 Z
+date: 2014-11-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake