typesafe_enum 0.1.8 → 0.1.9

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 1f9b1132621b9e769433ef61e8fd2512a66197c4
-  data.tar.gz: f5394bf7f1a1e88c56c727352f8d2dd113934855
+SHA256:
+  metadata.gz: 993bd214447b49bb0ad4d3586e4486f45b5a4e728d6240c1cf72909c62f37577
+  data.tar.gz: f8110980c436802a9737425ecca99641d837f56458cdc6c2afb4ec7789685c82
 SHA512:
-  metadata.gz: ffd661decf927ce85719a8cac164e7105f674e4289d68d546102f500aeb8d3a70907a25fafee22960c07967104ec77b8ee4ac8310450ba2febeafdb75c31dfa0
-  data.tar.gz: 6f4770854fe78d823c0031f16338c081a4fbac9def1e519e4f7c579566c57ffbac0a13f4d597890b42fe97df614a52a3f6ff83b48fca5b505c96004bcf9833c0
+  metadata.gz: f1ecbac3bef591d12993ecb0d0252d625720e9ce7259e7bd673eb754c4d6db98b489aeb581be92a3c21f506a8bcf362f8d52e237e65e2882e5eed3894ad82393
+  data.tar.gz: 829ad9e7e94d28d3682aca8d0295ac5bfb4eb75982a6f1399e49538689f223ee0df673613756b05f8d49b53002aa9510bf66debf14c3b90f19d5feb4d11e0945

data/.rubocop.yml

@@ -3,22 +3,87 @@ Style/ClassAndModuleChildren:
   Exclude:
     - 'example.rb'
 
-# Disable line-length check; it's too easy for the cure to be worse than the disease
+# Allow one line around block body (Layout/EmptyLines will still disallow two or more)
+Layout/EmptyLinesAroundBlockBody:
+  Enabled: false
+
+# Allow one line around class body (Layout/EmptyLines will still disallow two or more)
+Layout/EmptyLinesAroundClassBody:
+  Enabled: false
+
+# Allow one line around module body (Layout/EmptyLines will still disallow two or more)
+Layout/EmptyLinesAroundModuleBody:
+  Enabled: false
+
+# Make indents consistent regardless of the lengths of variables and method names and whatnot
+Layout/MultilineMethodCallIndentation:
+  EnforcedStyle: indented
+
+# Produces monsters
+Layout/MultilineOperationIndentation:
+  Enabled: false
+
+# Reasonable line-length check; it's too easy for the cure to be worse than the disease
 Metrics/LineLength:
+  Max: 150
+
+# Just because something looks like an accessor doesn't mean it is one
+Naming/PredicateName:
+  Exclude:
+    - 'app/controllers/application_controller.rb'
+
+# Confusing and weird
+Naming/VariableNumber:
+  Enabled: False
+
+# We meant to do that
+Naming/MemoizedInstanceVariableName:
+  Enabled: False
+
+# It works in context, trust us
+Naming/UncommunicativeMethodParamName:
+  Enabled: False
+
+# Do what's readable in the context you're in
+Style/AccessModifierDeclarations:
+  Enabled: false
+
+# 👎 to cultural imperialism
+Style/AsciiComments:
+  Enabled: false
+
+# Sometimes we want to distinguish hash parameters from keyword arguments
+Style/BracesAroundHashParameters:
+  Enabled: False
+
+# Seriously?
+Style/CommentedKeyword:
   Enabled: False
 
 # Disable problematic module documentation check (see https://github.com/bbatsov/rubocop/issues/947)
 Style/Documentation:
   Enabled: false
 
-# Allow one line around class body (Style/EmptyLines will still disallow two or more)
-Layout/EmptyLinesAroundClassBody:
+# Adding more line noise to format strings will not improve them
+Style/FormatStringToken:
   Enabled: false
 
-# Allow one line around module body (Style/EmptyLines will still disallow two or more)
-Layout/EmptyLinesAroundModuleBody:
+# Putting '# frozen_string_literal: true' everywhere does not make the world a better place
+Style/FrozenStringLiteralComment:
   Enabled: false
 
-# Allow one line around block body (Style/EmptyLines will still disallow two or more)
-Layout/EmptyLinesAroundBlockBody:
+# `foo.positive?` is cute, but it's not actually more readable than `foo > 0`
+Style/NumericPredicate:
+  Enabled: false
+
+# The semantics of `foo&.bar` are a lot less interchangeable with `foo && foo.bar` than RuboCop thinks
+Style/SafeNavigation:
+  Enabled: false
+
+# Requiring the lambda() method just makes wordy calls wordier
+Style/Lambda:
+  EnforcedStyle: literal
+
+# Unclear why it's a good idea to give parameters semantically meaningless names
+Style/SingleLineBlockParams:
   Enabled: false

data/.ruby-version

@@ -1 +1 @@
-2.4.1
+2.5.1

data/CHANGES.md

@@ -1,3 +1,9 @@
+## 0.1.9 (28 August 2019)
+
+- Update to Ruby 2.5.1
+- Update to rspec 3.8
+- Update to RuboCop 0.74
+
 ## 0.1.8 (22 December 2017)
 
 - Update to Ruby 2.4.1

data/README.md

@@ -1,9 +1,9 @@
 # TypesafeEnum
 
-[![Build Status](https://travis-ci.org/dmolesUC3/typesafe_enum.svg?branch=master)](https://travis-ci.org/dmolesUC3/typesafe_enum)
-[![Code Climate](https://codeclimate.com/github/dmolesUC3/typesafe_enum.svg)](https://codeclimate.com/github/dmolesUC3/typesafe_enum)
-[![Inline docs](http://inch-ci.org/github/dmolesUC3/typesafe_enum.svg)](http://inch-ci.org/github/dmolesUC3/typesafe_enum)
-[![Gem Version](https://img.shields.io/gem/v/typesafe_enum.svg)](https://github.com/dmolesUC3/typesafe_enum/releases)
+[![Build Status](https://travis-ci.org/dmolesUC/typesafe_enum.svg?branch=master)](https://travis-ci.org/dmolesUC/typesafe_enum)
+[![Code Climate](https://codeclimate.com/github/dmolesUC/typesafe_enum.svg)](https://codeclimate.com/github/dmolesUC/typesafe_enum)
+[![Inline docs](http://inch-ci.org/github/dmolesUC/typesafe_enum.svg)](http://inch-ci.org/github/dmolesUC/typesafe_enum)
+[![Gem Version](https://img.shields.io/gem/v/typesafe_enum.svg)](https://github.com/dmolesUC/typesafe_enum/releases)
 
 A Ruby implementation of Joshua Bloch's
 [typesafe enum pattern](http://www.oracle.com/technetwork/java/page1-139488.html#replaceenums),

data/lib/typesafe_enum.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module TypesafeEnum
-  Dir.glob(File.expand_path('../typesafe_enum/*.rb', __FILE__)).sort.each(&method(:require))
+  Dir.glob(File.expand_path('typesafe_enum/*.rb', __dir__)).sort.each(&method(:require))
 end

data/lib/typesafe_enum/base.rb

@@ -71,6 +71,7 @@ module TypesafeEnum
       # @return [self, nil] the corresponding enum instance, or nil
       def find_by_ord(ord)
         return nil if ord > size || ord.negative?
+
         as_array[ord]
       end
 
@@ -97,10 +98,12 @@ module TypesafeEnum
         value = instance.value
         if (found = find_by_key(key))
           raise NameError, "#{name}::#{key} already exists" unless value == found.value
+
           warn("ignoring redeclaration of #{name}::#{key} with value #{value} (source: #{caller(5..5).first})")
           nil
         else
           raise NameError, "A #{name} instance with value '#{value}' already exists" if find_by_value(value)
+
           [key, value]
         end
       end
@@ -157,6 +160,7 @@ module TypesafeEnum
 
     def initialize(key, value = nil, &block)
       raise TypeError, "#{key} is not a symbol" unless key.is_a?(Symbol)
+
       @key = key
       @value = value || key.to_s.downcase
       @ord = self.class.size

data/lib/typesafe_enum/module_info.rb

@@ -5,8 +5,8 @@ module TypesafeEnum
   NAME = 'typesafe_enum'
 
   # The version of this gem
-  VERSION = '0.1.8'
+  VERSION = '0.1.9'
 
   # The copyright notice for this gem
-  COPYRIGHT = 'Copyright (c) 2017 The Regents of the University of California'
+  COPYRIGHT = 'Copyright (c) 2019 The Regents of the University of California'
 end

data/spec/.rubocop.yml

@@ -1,16 +1,16 @@
 inherit_from: ../.rubocop.yml
 
-Metrics/BlockLength:
+Style/ClassAndModuleChildren:
   Enabled: false
 
-Metrics/MethodLength:
+Metrics/AbcSize:
   Enabled: false
 
-Metrics/ModuleLength:
+Metrics/BlockLength:
   Enabled: false
 
-Style/ClassAndModuleChildren:
+Metrics/ModuleLength:
   Enabled: false
 
-Security/MarshalLoad:
+Metrics/MethodLength:
   Enabled: false

data/spec/unit/typesafe_enum/base_spec.rb

@@ -1,4 +1,3 @@
-
 # frozen_string_literal: true
 
 require 'spec_helper'
@@ -94,7 +93,8 @@ module TypesafeEnum
         class ::IdenticalInstances < Base
           new :SPADES, 'spades'
         end
-        expect(::IdenticalInstances).to receive(:warn).with(a_string_matching(/ignoring redeclaration of IdenticalInstances::SPADES with value spades/))
+        expected_msg = /ignoring redeclaration of IdenticalInstances::SPADES with value spades/
+        expect(::IdenticalInstances).to receive(:warn).with(a_string_matching(expected_msg))
         class ::IdenticalInstances < Base
           new :SPADES, 'spades'
         end
@@ -190,6 +190,7 @@ module TypesafeEnum
         end
       end
 
+      # rubocop:disable Security/MarshalLoad
       it 'survives marshalling' do
         Suit.each do |s1|
           dump = Marshal.dump(s1)
@@ -198,6 +199,7 @@ module TypesafeEnum
           expect(s2 == s1).to eq(true)
         end
       end
+      # rubocop:enable Security/MarshalLoad
     end
 
     describe '#!=' do
@@ -245,6 +247,7 @@ module TypesafeEnum
         end
       end
 
+      # rubocop:disable Security/MarshalLoad
       it 'survives marshalling' do
         Suit.each do |s1|
           dump = Marshal.dump(s1)
@@ -252,6 +255,7 @@ module TypesafeEnum
           expect(s2.hash).to eq(s1.hash)
         end
       end
+      # rubocop:enable Security/MarshalLoad
 
       it 'always returns a Fixnum' do
         Suit.each do |s1|

data/typesafe_enum.gemspec

@@ -1,7 +1,6 @@
-
 # frozen_string_literal: true
 
-lib = File.expand_path('../lib', __FILE__)
+lib = File.expand_path('lib', __dir__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 
 require 'uri'
@@ -16,9 +15,7 @@ Gem::Specification.new do |spec|
   spec.description   = 'A gem that implements the typesafe enum pattern in Ruby'
   spec.license       = 'MIT'
 
-  origin = `git config --get remote.origin.url`.chomp
-  origin_uri = origin.start_with?('http') ? URI(origin) : URI(origin.gsub(%r{git@([^:]+)(.com|.org)[^\/]+}, 'http://\1\2'))
-  spec.homepage = URI::HTTP.build(host: origin_uri.host, path: origin_uri.path.chomp('.git')).to_s
+  spec.homepage = 'https://github.com/dmolesUC/typesafe_enum'
 
   spec.files         = `git ls-files -z`.split("\x0")
   spec.executables   = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }
@@ -26,10 +23,9 @@ Gem::Specification.new do |spec|
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ['lib']
 
-  spec.add_development_dependency 'bundler', '~> 1.7'
   spec.add_development_dependency 'rake', '~> 10.4'
-  spec.add_development_dependency 'rspec', '~> 3.7'
-  spec.add_development_dependency 'rubocop', '~> 0.52'
+  spec.add_development_dependency 'rspec', '~> 3.8'
+  spec.add_development_dependency 'rubocop', '~> 0.74'
   spec.add_development_dependency 'simplecov', '~> 0.9.2'
   spec.add_development_dependency 'simplecov-console', '~> 0.2.0'
   spec.add_development_dependency 'yard', '~> 0.9', '>= 0.9.12'

metadata

@@ -1,29 +1,15 @@
 --- !ruby/object:Gem::Specification
 name: typesafe_enum
 version: !ruby/object:Gem::Version
-  version: 0.1.8
+  version: 0.1.9
 platform: ruby
 authors:
 - David Moles
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-12-22 00:00:00.000000000 Z
+date: 2019-08-28 00:00:00.000000000 Z
 dependencies:
-- !ruby/object:Gem::Dependency
-  name: bundler
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.7'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.7'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -44,28 +30,28 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.7'
+        version: '3.8'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.7'
+        version: '3.8'
 - !ruby/object:Gem::Dependency
   name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.52'
+        version: '0.74'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.52'
+        version: '0.74'
 - !ruby/object:Gem::Dependency
   name: simplecov
   requirement: !ruby/object:Gem::Requirement
@@ -138,7 +124,7 @@ files:
 - spec/spec_helper.rb
 - spec/unit/typesafe_enum/base_spec.rb
 - typesafe_enum.gemspec
-homepage: http://github.com/typesafe_enum
+homepage: https://github.com/dmolesUC/typesafe_enum
 licenses:
 - MIT
 metadata: {}
@@ -157,8 +143,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.6.12
+rubygems_version: 3.0.4
 signing_key: 
 specification_version: 4
 summary: Typesafe enum pattern for Ruby