typeform_data 3.0.0 → 3.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 3da62092341167802dd4565276637320bc9b4239
-  data.tar.gz: c60c7c72ddc21e7732f2ea866639f3c404879706
+  metadata.gz: 6a29d5216f5bc251d42df766ac5f6ee3453a113e
+  data.tar.gz: 824508bc3d4e477d0fbaa7a673fa4abad012c011
 SHA512:
-  metadata.gz: 0b423251f537bb0b5a2a041fa2a80f57ffceefd70c33c886c0fdfc4c7f8df52770148c021f03b8f7d5ee8fa3cf04b9b673ef1cdc713eeffafe154f082e6ecf72
-  data.tar.gz: 1ce2a17d3b448d5a0fa4a2c8aae6d2dcd22026f0590d9d1aaae0a10b652c8114d6a2be4de0bc1d3ecc5f9d9e64443123b11b56e1a2588aa44976b590b5cb4fad
+  metadata.gz: d615981da83f83f61f8663bd3c1182de16255b32d01a90080d679d0bfe5be3c2a50646540a0de7d9300f4aeb3a1ae1f91dbb28e1c54e8dbcab76fe740286a924
+  data.tar.gz: 84bdecd33b209bfd7c0e2eddfc5687321bc23230a6aa32a11506dfe358ae92a6f5f7534d9ac85a11c292fca3e792433f690fb93effa3a36413a49bb4011a1be0

data/lib/typeform_data/typeform/answer.rb

@@ -28,17 +28,6 @@ module TypeformData
       #   typeform.responses(token: response_token)
       # end
 
-      # In the JSON, answer 'ID's are of the form:
-      #
-      # - "textfield_12316024"
-      # - "listimage_12316029_choice_12322262"
-      #
-      # This list may not be exhaustive-- there may be other ID formats not covererd above-- since
-      # this part of the API isn't mentioned in the documentation.
-      #
-      # For our Answer object, we strip out only the 'listimage_12316029' part, giving Answers the
-      # same specificity as Fields.
-      #
       # Use this method to create Answers when initializing a Response.
       #
       # @param config [TypeformData::Config]
@@ -60,15 +49,7 @@ module TypeformData
       # @return [Array<Answer>]
       def self.from_response_attrs(config, attrs, fields)
         (attrs[:answers] || attrs['answers']).group_by { |id, _value|
-          field_id = id.split('_')[1]
-
-          unless field_id && field_id.length.positive?
-            raise UnexpectedError, 'Falsy field ID for answer(s)'
-          end
-
-          fields.find { |field| field.id.to_s == field_id }.tap { |matched|
-            raise UnexpectedError, 'Expected to find a matching field' unless matched
-          }
+          matching_field_for_answer(fields, id)
         }.map { |field, ids_and_values|
           # ids_and_values looks like [[id, value], [id, value], ...]
           values = ids_and_values.map(&:last)
@@ -84,6 +65,23 @@ module TypeformData
         }
       end
 
+      # In the JSON, answer 'ID's are of the form:
+      #
+      # - "textfield_12316024"
+      # - "listimage_12316029_choice_12322262"
+      #
+      # This list may not be exhaustive-- there may be other ID formats not covererd above-- since
+      # this part of the API isn't mentioned in the documentation.
+      private_class_method def self.matching_field_for_answer(fields, answer_id)
+        found = fields.find { |field| field.question_ids.include?(answer_id) }
+
+        unless found
+          raise UnexpectedError, "Expected to find a matching field for Answer ID #{answer_id}"
+        end
+
+        found
+      end
+
     end
 
   end

data/lib/typeform_data/version.rb

@@ -1,4 +1,4 @@
 # frozen_string_literal: true
 module TypeformData
-  VERSION = '3.0.0'
+  VERSION = '3.0.1'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: typeform_data
 version: !ruby/object:Gem::Version
-  version: 3.0.0
+  version: 3.0.1
 platform: ruby
 authors:
 - Max Wallace
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2017-03-01 00:00:00.000000000 Z
+date: 2017-03-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler