txgh-server 2.3.0 → 2.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 359b3bb8990904063bb4b3f9bbdc8602311ff53f
-  data.tar.gz: d4b6f7e1429cadac6cdf8aada177b54de89fc69c
+  metadata.gz: f70d20e0073d7671f6010e1dfd962c7e4758482d
+  data.tar.gz: 9d1167e2d2b25fdbde79051bc93c32535d3fec04
 SHA512:
-  metadata.gz: 8c793ad9b43034ce152d910bbb6dff0f160d6e30c8df666c4cd93d66461efb4490421832b2799d392288a16566e57af77f201634048a58047465946618dc8989
-  data.tar.gz: 25dc3a1ae9b51abb31d0603948c4b8d1ef2a676f545cee664faf84f97f8936877210319c58a6fcffdd677604c39c2979c46d5af81486050f9458652d8f37a411
+  metadata.gz: b3a6abf97a38ed2e92d887ff03e38b5c4327f89816d3c8e87a99ec8f0300326262568f9c5755d08f4451b54fbafe652110dd7685b4c36c4464ffd8c8aa658920
+  data.tar.gz: 25147bc9bd2612a674869236fd13eb78b74aacb58edaf6e5bae058cfa6a97d789d314f21bb62c86ca5fb0840a3ec401153596e4e812058c76918b1cec9d567d5

data/lib/txgh-server/transifex_request_auth.rb

@@ -11,7 +11,7 @@ module TxghServer
       def authentic_request?(request, secret)
         request.body.rewind
         expected_signature = header_value(request.body.read, secret)
-        actual_signature = request.env[RACK_HEADER]
+        actual_signature = signature_from(request)
         actual_signature == expected_signature
       end
 
@@ -19,6 +19,10 @@ module TxghServer
         digest(transform(content), secret)
       end
 
+      def signature_from(request)
+        request.env[RACK_HEADER]
+      end
+
       private
 
       # In order to generate a correct HMAC hash, the request body must be

data/lib/txgh-server/version.rb

@@ -1,3 +1,3 @@
 module TxghServer
-  VERSION = '2.3.0'
+  VERSION = '2.4.0'
 end

data/lib/txgh-server/webhooks/transifex/request_handler.rb

@@ -20,6 +20,8 @@ module TxghServer
         end
 
         def handle_request
+          publish_event
+
           handle_safely do
             handler = TxghServer::Webhooks::Transifex::HookHandler.new(
               project: config.transifex_project,
@@ -35,6 +37,16 @@ module TxghServer
 
         private
 
+        def publish_event
+          Txgh.events.publish(
+            'transifex.webhook_received', {
+              payload: payload,
+              raw_payload: raw_payload,
+              signature: TransifexRequestAuth.signature_from(request)
+            }
+          )
+        end
+
         def handle_safely
           if authentic_request?
             yield
@@ -63,12 +75,17 @@ module TxghServer
           @config ||= Txgh::Config::KeyManager.config_from_project(payload[:project])
         end
 
-        def payload
-          @payload ||= begin
+        def raw_payload
+          @raw_payload ||= begin
             request.body.rewind
+            request.body.read
+          end
+        end
 
+        def payload
+          @payload ||= begin
             Txgh::Utils.deep_symbolize_keys(
-              Hash[URI.decode_www_form(request.body.read)]
+              Hash[URI.decode_www_form(raw_payload)]
             )
           end
         end

data/spec/webhooks/transifex/request_handler_spec.rb

@@ -10,11 +10,24 @@ describe Transifex::RequestHandler do
 
   let(:logger) { NilLogger.new }
   let(:body) { URI.encode_www_form(payload.to_a) }
-  let(:request) { TestRequest.new(body: body) }
+  let(:signature) { 'abc123' }
+  let(:headers) { { TxghServer::TransifexRequestAuth::RACK_HEADER => signature } }
+  let(:request) { TestRequest.new(body: body, headers: headers) }
   let(:handler) { described_class.new(request, logger) }
   let(:payload) { { 'project' => project_name, 'resource' => resource_slug, 'language' => 'pt' } }
 
   describe '#handle_request' do
+    it 'publishes an event' do
+      expect { handler.handle_request }.to(
+        change { Txgh.events.published_in('transifex.webhook_received').size }.by(1)
+      )
+
+      event = Txgh.events.published_in('transifex.webhook_received').first
+      expect(event[:options][:payload]).to eq(Txgh::Utils.deep_symbolize_keys(payload))
+      expect(event[:options][:raw_payload]).to eq(body)
+      expect(event[:options][:signature]).to eq(signature)
+    end
+
     it 'does not execute if unauthorized' do
       expect_any_instance_of(Transifex::HookHandler).to_not receive(:execute)
       response = handler.handle_request

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: txgh-server
 version: !ruby/object:Gem::Version
-  version: 2.3.0
+  version: 2.4.0
 platform: ruby
 authors:
 - Matthew Jackowski
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-11-21 00:00:00.000000000 Z
+date: 2017-11-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: mime-types
@@ -172,7 +172,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.5.1
+rubygems_version: 2.6.13
 signing_key: 
 specification_version: 4
 summary: An HTTP server for interacting with txgh.