twsms2 1.1.0 → 1.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 548eb03c93dd04ba44a85593a17e14a6d77c85da
-  data.tar.gz: 0eb4402e4e51a566c8476b88d84a43a9c5b40993
+  metadata.gz: 604e4232d10dd76ea6064e215fae633f8b020746
+  data.tar.gz: 5585e90bff7241bdd4bafdf2562e4e3848b6fed6
 SHA512:
-  metadata.gz: 38bd3975a7334dddb430b45269e3f6204ebfd4b6407fe669486b13927c467585342f125be252f41886dae0f06e036d0745d7acfedc03ca03d6a323b682583bd6
-  data.tar.gz: f9b5043d50a38004a9d8f8948202dc7054f0b0e8c12a8477d45fae48c94e954c09b1a2660c356a0e16250cac265db0da19939fd829be5327b5afcf9d12befb6c
+  metadata.gz: 3268a918b026b4f3ff830ffede2457a0a9cd05815121e26a4a7af4164424bc39866026d9b7dd925ddfb43bffb0f486295334aa25fa9a0deaac6670d4726cacc7
+  data.tar.gz: bf60f687de9713a89c52bba76200254aad1da2558ae405581f58a3ded581eead607441e49154c4b619af32189cedfc3fcf4e321f273fc6ef5d13281435be237c

data/README.md

@@ -1,7 +1,9 @@
 Twsms2 ( 2016 新版 台灣簡訊 TwSMS API Ruby 版套件 )
 =================================================
 
-[![Gem Version](https://badge.fury.io/rb/twsms2.svg)](https://badge.fury.io/rb/twsms2) [![Build Status](https://travis-ci.org/guanting112/twsms2.svg?branch=master)](https://travis-ci.org/guanting112/twsms2)
+[![Gem Version](https://badge.fury.io/rb/twsms2.svg)](https://badge.fury.io/rb/twsms2)
+[![Build Status](https://travis-ci.org/guanting112/twsms2.svg?branch=master)](https://travis-ci.org/guanting112/twsms2)
+[![Code Climate](https://codeclimate.com/github/guanting112/twsms2/badges/gpa.svg)](https://codeclimate.com/github/guanting112/twsms2)
 
 ![twsms](http://i.imgur.com/KVuaBIm.png)
 
@@ -42,7 +44,9 @@ gem 'twsms2', '~> 1.1.0'
 require 'twsms2'
 
 # Twsms2 是走 https 的方式進行系統操作
-sms_client = Twsms2::Client.new(username: '會員帳號', password: '會員密碼', agent: "Mozilla/5.0 (可自訂 user-agent)")
+sms_client = Twsms2::Client.new(
+  username: '會員帳號', password: '會員密碼', agent: "Mozilla/5.0 (可自訂 user-agent)"
+)
 ```
 
 使用範例
@@ -86,7 +90,7 @@ sms_client.send_message to: '手機號碼', content: "預約簡訊測試: #{Time
 
 #### 強制直接顯示簡訊內容
 
-可以加入 popup 參數，讓簡訊在收訊人的手機裝置直接顯示在上面 ( 可能不會被手機儲存 )
+可以加入 popup 參數，讓簡訊在收訊人的手機上直接顯示，但有可能不會被手機儲存
 
 ```ruby
 sms_client.send_message to: '手機號碼', content: "簡訊內容..", popup: true
@@ -94,9 +98,9 @@ sms_client.send_message to: '手機號碼', content: "簡訊內容..", popup: tr
 
 #### 關閉長簡訊支援
 
-一般發送簡訊時，預設為長簡訊發送
+一般發送簡訊時，程式預設支援長簡訊發送
 
-因此，若超 SMS 短信字元長度，將會以第二封起開始計算
+因此，若超 SMS 簡訊字元長度，將會以第二封起開始計算
 
 加入 long 參數，若指定為 false 則不會使用長簡訊格式
 
@@ -104,6 +108,8 @@ sms_client.send_message to: '手機號碼', content: "簡訊內容..", popup: tr
 sms_client.send_message to: '手機號碼', content: "簡訊內容..", long: false
 ```
 
+詳細規則請以 台灣簡訊 公告為主
+
 ### 發送簡訊 的 回傳結果
 
 #### 發送成功
@@ -155,7 +161,7 @@ message_quota 則是簡訊餘額，代表你還剩幾封可以用，若為 0 就
 {:access_success=>true, :message_quota=>77, :error=>nil}
 ```
 
-#### 發生錯誤
+#### 發生錯誤時
 
 若 access_success 為 false 則表示過程有出現錯誤，同時 message_quota 會為 0
 
@@ -176,3 +182,4 @@ LICENSE
 
 [twsms_signup]: https://www.twsms.com/accjoin.php
 [twsms_homepage]: https://www.twsms.com/
+

data/Rakefile

@@ -1,5 +1,5 @@
-require "bundler/gem_tasks"
-require "rake/testtask"
+require 'bundler/gem_tasks'
+require 'rake/testtask'
 
 task :default => :spec
 

data/bin/console

@@ -1,14 +1,14 @@
 #!/usr/bin/env ruby
 
-require "bundler/setup"
-require "twsms2"
+require 'bundler/setup'
+require 'twsms2'
 
 # You can add fixtures and/or initialization code here to make experimenting
 # with your gem easier. You can also use a different console, if you like.
 
 # (If you use this, don't forget to add pry to your Gemfile!)
-# require "pry"
+# require 'pry'
 # Pry.start
 
-require "irb"
+require 'irb'
 IRB.start

data/lib/twsms2/formatter.rb

@@ -32,9 +32,7 @@ module Twsms2
       if new_info[:access_success]
         new_info[:message_id] = message_id_text
       else
-        new_info[:error] = "TWSMS:CODE_NOT_FOUND"
-        new_info[:error] = "TWSMS:#{code_text}" unless code_text.nil?
-        new_info[:error].upcase!
+        new_info[:error] = code_text.nil? ? "TWSMS:CODE_NOT_FOUND" : "TWSMS:#{code_text}".upcase
       end
 
       new_info
@@ -55,9 +53,7 @@ module Twsms2
       if new_info[:access_success]
         new_info[:message_quota] = point_text.to_i
       else
-        new_info[:error] = "TWSMS:CODE_NOT_FOUND"
-        new_info[:error] = "TWSMS:#{code_text}" unless code_text.nil?
-        new_info[:error].upcase!
+        new_info[:error] = code_text.nil? ? "TWSMS:CODE_NOT_FOUND" : "TWSMS:#{code_text}".upcase
       end
 
       new_info

data/lib/twsms2/version.rb

@@ -1,3 +1,3 @@
 module Twsms2
-  VERSION = "1.1.0"
+  VERSION = "1.1.1"
 end

data/lib/twsms2.rb

@@ -17,8 +17,7 @@ module Twsms2
 
     def account_is_available
       balance_info = get_balance
-
-      ok = balance_info[:message_quota] > 0 && balance_info[:access_success]
+      balance_info[:message_quota] > 0 && balance_info[:access_success]
     end
 
     def send_message(options={})

data/twsms2.gemspec

@@ -30,6 +30,5 @@ Gem::Specification.new do |spec|
 
   spec.add_development_dependency "bundler", "~> 1.7"
   spec.add_development_dependency "rake", "~> 10.0"
-  # spec.add_development_dependency 'webmock', '~> 1.18'
   spec.add_development_dependency 'minitest', '~> 5.0'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: twsms2
 version: !ruby/object:Gem::Version
-  version: 1.1.0
+  version: 1.1.1
 platform: ruby
 authors:
 - Guanting Chen
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2016-09-03 00:00:00.000000000 Z
+date: 2016-09-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -94,7 +94,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.4
+rubygems_version: 2.5.1
 signing_key: 
 specification_version: 4
 summary: 2016 新版 台灣簡訊 TwSMS API ( 純 Ruby / Rails 專案適用 )