twine-rails 1.2.1 → 1.2.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 9a1f8a165f50cdc666899675823de067c31981e5
-  data.tar.gz: 14a2d531c688fed6badb7144caee3ce4e54576b6
+SHA256:
+  metadata.gz: f8b1f18347a673c2da36ccab84449031136b661d8184beb2cad56ea81e471a87
+  data.tar.gz: e64ca56b6851cb8f7dc692e31812d0745b2ccb9a7f7594f254ff6f1c1b339717
 SHA512:
-  metadata.gz: 50f4bcd70db07b862872902aa7952b8e6918cf613cd9c316dd77914a8cce9c4b6daaa03aa6fd3636b1f4441e3bede39ecfe0dfd4307537e94b5caf577459b2fc
-  data.tar.gz: 067ef8d649ec0933d121ec73a4b20880e8cc259a7f0e8d7ecbbb3ecaaa61de876b675d5c965c26208cbc5e06efde63512e3638be774aaaa90e21561a0ca4f926
+  metadata.gz: 23a2c7c69017ab0f289549aae0cd53d40ee09dfc04b956db63f4d9c4e5f26e0a20b9a56d996764b4e0b8a1b153d44fa8d1e44d52a6be82551dc82f61f293a34c
+  data.tar.gz: 5055a680b4b0a996b3c52c0f38a062e28427ff31a018c75a4d34ec49e846a8b58ccd3eeaa9052a6bea18fd5dab6d2d60b0ecf41f5e84365c42a3e4ae149c05b5

data/lib/assets/javascripts/twine.coffee

@@ -110,12 +110,9 @@
 
     callbacks = currentBindingCallbacks
 
-    # IE and Safari don't support node.children for DocumentFragment and SVGElement nodes.
-    # If the element supports children we continue to traverse the children, otherwise
-    # we stop traversing that subtree.
-    # https://developer.mozilla.org/en-US/docs/Web/API/ParentNode.children
-    # As a result, Twine are unsupported within DocumentFragment and SVGElement nodes.
-    bind(context, childNode, if newContextKey? then null else indexes) for childNode in (node.children || [])
+    # IE and Safari don't support node.children for DocumentFragment or SVGElement,
+    # See explanation in childrenForNode()
+    bind(context, childNode, if newContextKey? then null else indexes) for childNode in childrenForNode(node)
     Twine.count = nodeCount
 
     for callback in callbacks || []
@@ -124,6 +121,18 @@
 
     Twine
 
+  # IE and Safari don't support node.children for DocumentFragment and SVGElement nodes.
+  # If the element supports children we continue to traverse the children, otherwise
+  # we stop traversing that subtree.
+  # https://developer.mozilla.org/en-US/docs/Web/API/ParentNode.children
+  # As a result, Twine are unsupported within DocumentFragment and SVGElement nodes.
+  #
+  # We also prevent nodes from being iterated over more than once by cacheing the
+  # lookup for children nodes, which prevents nodes that are dynamically inserted
+  # or removed as siblings from causing double/ missed binds and unbinds.
+  childrenForNode = (node) ->
+    if node.children then Array::slice.call(node.children, 0) else []
+
   findOrCreateElementForNode = (node) ->
     node.bindingId ?= ++nodeCount
     elements[node.bindingId] ?= {}
@@ -169,10 +178,9 @@
       delete elements[id]
       delete node.bindingId
 
-
     # IE and Safari don't support node.children for DocumentFragment or SVGElement,
-    # See explaination in bind()
-    Twine.unbind(childNode) for childNode in (node.children || [])
+    # See explanation in childrenForNode()
+    Twine.unbind(childNode) for childNode in childrenForNode(node)
     this
 
   # Returns the binding context for a node by looking up the tree.

data/lib/twine-rails/version.rb

@@ -1,3 +1,3 @@
 module TwineRails
-  VERSION = '1.2.1'
+  VERSION = '1.2.2'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: twine-rails
 version: !ruby/object:Gem::Version
-  version: 1.2.1
+  version: 1.2.2
 platform: ruby
 authors:
 - Justin Li
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-02-16 00:00:00.000000000 Z
+date: 2018-10-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: coffee-rails
@@ -100,7 +100,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.14
+rubygems_version: 2.7.6
 signing_key: 
 specification_version: 4
 summary: Minimalistic two-way bindings