twilio_recordings 0.0.7 → 0.0.8

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: b82464745bd864b23b18200a752942e511554f8d
-  data.tar.gz: 48db032d6c9ace15122eaca0217703c18da0ccd6
+  metadata.gz: 8033bae6057d03b97e9b48a9c1ef77c5a1f6405c
+  data.tar.gz: cdad125449613cf7daa2d6f17841dbea0e1d3a13
 SHA512:
-  metadata.gz: a6ff3f5523953e6452b08ac4130fe0fbb982283252fa0689b75962f2fa4223f1f7cb251e80f75ea3d2ea4afa21ff3b3279319aa36e99b010773cdaa7cd80a5b5
-  data.tar.gz: 9859f7880ecce0dedaf94d7a05a937780da9dbb436b42da393c8f054080c49729fe4d58d383debbe48becca24ba3fbe8894f5085c762f2d469d9618da5bb839b
+  metadata.gz: b2d7c6c5a3563262504ca0959bf697c5a6b3c7d084556670a727307849a5e4c0c24485ff025ea5350ef8e06f7b2ffbbb9424084432a8c4a106154567c977985f
+  data.tar.gz: 999c7b8fbf38e64e599a66721349ad4728727a4ab39dbe4eb248bbad427f8949281879bd70b9bf631a3f9148e0d25a25ee660b873500dcc008c8d1bbb655df00

data/lib/twilio_recordings.rb

@@ -19,7 +19,8 @@ class TwilioRecordings
     @account_sid = account_sid
     @recording_sids = recording_sids.map{ |sid| self.class.sanitize(sid) }
     @tmp_dir = options[:tmp_dir] || File.join('','tmp')
-    @recording_downloads = {}
+
+    @tmp_files = {}
   end
 
   ##
@@ -39,7 +40,8 @@ class TwilioRecordings
   #   >> t.twilio_urls
   #   => ["./my_tmp_dir/RE12345678901234567890123456789012.mp3"]
   def filenames
-    @recording_sids.map { |r| File.join(@tmp_dir, "#{r}.mp3") }
+    init_tmp_files
+    @recording_sids.map { |sid| @tmp_files[sid].path }
   end
 
   ##
@@ -56,11 +58,6 @@ class TwilioRecordings
     end
   end
 
-  def download_and_join
-    download
-    join
-  end
-
   ##
   # Download the recordings to @tmp_dir
   #
@@ -70,16 +67,20 @@ class TwilioRecordings
   #   >> t.download
   #   => #<TwilioRecordings:0x00... >
   def download
+    recording_downloads = {}
     # download the recordings
     connection.in_parallel do
-      twilio_urls.zip(filenames).each do |url, filename|
-        @recording_downloads[filename] = connection.get(url)
+      twilio_urls.zip(@recording_sids).each do |url, sid|
+        recording_downloads[sid] = connection.get(url)
       end
     end
 
+    init_tmp_files
+
     # write the recordings to file
-    @recording_downloads.each do |filename, response|
-      File.open(filename, 'wb') { |f| f.write(response.body) }
+    recording_downloads.each do |sid, response|
+      @tmp_files[sid].write(response.body)
+      @tmp_files[sid].close
     end
 
     self
@@ -95,11 +96,27 @@ class TwilioRecordings
   # Arguments:
   #   output: A string to the filename that the output should be written to. (optional, default is '/tmp/joined_{recording_ids}')
   def join(output=nil)
-    output ||= File.join(@tmp_dir, "joined_#{@recording_sids.join('_')}.mp3")
+    unless output
+      output_file = Tempfile.new(['joined_recording','.mp3'], @tmp_dir)
+      output_file.binmode
+      output_file.close
+      output = output_file.path
+    end
     `cat #{filenames.join(" ")} > #{output}`
+    cleanup
     output
   end
 
+  ##
+  # Clean up the temporarily downloaded recordings.
+  #
+  # Example:
+  #   >> t.cleanup
+  #   => true
+  def cleanup
+    remove_tmp_files
+  end
+
   ##
   # Sanitize the filename.
   #
@@ -110,4 +127,22 @@ class TwilioRecordings
   def self.sanitize(filename)
     filename.gsub(/[^a-zA-Z0-9]/, '')
   end
-end
+
+  private
+
+  def init_tmp_files
+    return unless @tmp_files == {}
+    @recording_sids.each do |sid|
+      @tmp_files[sid] = Tempfile.new([sid,'.mp3'], @tmp_dir)
+      @tmp_files[sid].binmode
+    end
+  end
+
+  def remove_tmp_files
+    return if @tmp_files == {}
+    @tmp_files.values.each do |file|
+      file.unlink
+    end
+    @tmp_files = {}
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: twilio_recordings
 version: !ruby/object:Gem::Version
-  version: 0.0.7
+  version: 0.0.8
 platform: ruby
 authors:
 - Paul Boxley