twilio-ruby 3.13.1 → 3.14.0

checksums.yaml

@@ -1,15 +1,7 @@
 ---
-!binary "U0hBMQ==":
-  metadata.gz: !binary |-
-    N2ZkYWFmMjJiYzRiMGFhOTRlNDc5ODdmOTFlZmFlMzJkN2M5NTZiNw==
-  data.tar.gz: !binary |-
-    ZWFkZWY0NDRiOTk1NDVkYzg2ZjdkODgzOGM5OTM5YTJhZWQ4OWMzYQ==
+SHA1:
+  metadata.gz: 1b939e0692e2400ddc4310309010b1227d0c2b70
+  data.tar.gz: 38363b14c3977aab51bd0f021c6b3284e457e3f9
 SHA512:
-  metadata.gz: !binary |-
-    YzIyNzEzZTY3OThiMzcyMTUxOWI5MjMwNTU1NWQwNjVmZTFjNzQwZGQzYzlm
-    MzQzNGU3Njg4NDVhMDdhODY4YzQ5MGYxNzk0NmUwNTAxNDIxNDI0OTI1ZDU3
-    MjA5YzZhODVhM2IwOGFhODcyMmQwOTc5YmIyMzUwM2JmMDA1ZjI=
-  data.tar.gz: !binary |-
-    OWQ0NWE1OTYxNzc4OGY0YTBjYmFjMzQ3MmFjMTJmMGRhMDQ0MjhkYzBkNmVi
-    YjNjMjk0ZjRlYzhkMjg5MTUyNDBmOTkyZjdmNTE3MTI4YTZiM2FiNjExMmM3
-    Nzg2OWY2OGMyN2QxNjcyYWM3OWFiMGZkODFhODRlMmI4NmU4YWE=
+  metadata.gz: 45a7ea0839cb677f5310e0283371233b8a157d778b62a15373b19cb66302417da7442e259c5406a453b41b50b481156622a16d58e8a6b52209f603f069f0260f
+  data.tar.gz: fc3560fa5c61d3da6d9a11600921531241f1c0abfa43ff07869c3d09fb5cc556083d6556c661e75853d301fd3dda442bc2ac8ccf7f31a3191a3b145f33155d8e

data/AUTHORS.md

@@ -6,6 +6,7 @@ A huge thanks to all of our contributors:
 
 - Adam Ballai
 - Alexander Murmann & Ryan Spore
+- Alexandre Payment
 - Andrew Benton
 - Brian Levine
 - Caley Woods

data/CHANGES.md

@@ -1,6 +1,14 @@
 twilio-ruby changelog
 =====================
 
+Version 3.14.0
+--------------
+
+Released November 13, 2014
+
+- Switch to a constant-time string comparison for TwiML request signature validation
+- Add support for Call and Message deletion/redaction
+
 Version 3.13.1
 --------------
 

data/docs/usage/messages.rst

@@ -88,6 +88,25 @@ Retrieving Sent Messages
     @client.messages.list.each do |message|
         puts message.body
 
+Redacting or Deleting Messages
+------------------------------
+
+.. code-block:: ruby
+
+    require 'twilio-ruby'
+
+    # To find these visit https://www.twilio.com/user/account
+    account_sid = "ACXXXXXXXXXXXXXXXXX"
+    auth_token = "YYYYYYYYYYYYYYYYYY"
+
+    @client = Twilio::REST::Client.new account_sid, auth_token
+    @msg_sid = 'MM123'
+    @msg = @client.messages.get('MM123')
+    # Deletes the Body field contents
+    @msg.redact
+
+    # Removes the entire Message record
+    @msg.delete
 
 Filtering Your Messages
 -------------------------

data/docs/usage/phone-calls.rst

@@ -52,6 +52,23 @@ you can use the client to retrieve that record.
     sid = "CA12341234"
     @call = @client.calls.get(sid)
 
+Delete a Call Record
+--------------------
+
+.. code-block:: ruby
+
+    require 'twilio-ruby'
+
+    # To find these visit https://www.twilio.com/user/account
+    account_sid = "ACXXXXXXXXXXXXXXXXX"
+    auth_token = "YYYYYYYYYYYYYYYYYY"
+
+    @client = Twilio::REST::Client.new account_sid, auth_token
+    sid = "CA12341234"
+    @call = @client.calls.get(sid)
+
+    # Removes the entire record from Twilio's storage
+    @call.delete
 
 Accessing Specific Call Resources
 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

data/lib/twilio-ruby/rest/messages.rb

@@ -12,6 +12,11 @@ module Twilio
         super
         resource :media
       end
+
+      def redact()
+        update({body: ''})
+      end
+
     end
   end
 end

data/lib/twilio-ruby/rest/utils.rb

@@ -3,29 +3,18 @@ module Twilio
     module Utils
 
       def twilify(something)
-        if something.is_a? Hash
-          something = something.to_a
-          something = something.map { |a| [twilify(a[0]).to_sym, a[1]] }
-          something = something.flatten(1)
-          Hash[*something]
-        else
-          something.to_s.split('_').map! do |s|
-            [s[0,1].capitalize, s[1..-1]].join
-          end.join
-        end
+        return key_map(something, :twilify) if something.is_a? Hash
+        string = something.to_s
+        string.split('_').map do |string_part|
+          string_part[0,1].capitalize + string_part[1..-1]
+        end.join
       end
 
       def detwilify(something)
-        if something.is_a? Hash
-          something = *something.to_a
-          something.map! { |pair| [detwilify(pair[0]).to_sym, pair[1]] }
-          something = something.flatten
-          Hash[something]
-        else
-          something = something.to_s
-          something = something.gsub(/[A-Z][a-z]*/) { |s| "_#{s.downcase}" }
-          something.gsub(/^_/, '')
-        end
+        return key_map(something, :detwilify) if something.is_a? Hash
+        string = something.to_s
+        string = string[0,1].downcase + string[1..-1]
+        string.gsub(/[A-Z][a-z]*/) { |s| "_#{s.downcase}" }
       end
 
       protected
@@ -46,6 +35,15 @@ module Twilio
         end
         self.class.instance_eval { attr_reader *resources }
       end
+
+      private
+
+      def key_map(something, method)
+        something = something.to_a.flat_map do |pair|
+          [send(method, pair[0]).to_sym, pair[1]]
+        end
+        Hash[*something]
+      end
     end
   end
 end

data/lib/twilio-ruby/util/request_validator.rb

@@ -9,7 +9,7 @@ module Twilio
 
       def validate(url, params, signature)
         expected = build_signature_for url, params
-        expected == signature
+        secure_compare(expected, signature)
       end
 
       def build_signature_for(url, params)
@@ -18,6 +18,20 @@ module Twilio
         Base64.encode64(OpenSSL::HMAC.digest(digest, @auth_token, data)).strip
       end
 
+      private
+
+      # Compares two strings in constant time to avoid timing attacks.
+      # Borrowed from ActiveSupport::MessageVerifier.
+      # https://github.com/rails/rails/blob/master/activesupport/lib/active_support/message_verifier.rb
+      def secure_compare(a, b)
+        return false unless a.bytesize == b.bytesize
+
+        l = a.unpack("C#{a.bytesize}")
+
+        res = 0
+        b.each_byte { |byte| res |= byte ^ l.shift }
+        res == 0
+      end
     end
   end
 end

data/lib/twilio-ruby/version.rb

@@ -1,3 +1,3 @@
 module Twilio
-  VERSION = '3.13.1'
+  VERSION = '3.14.0'
 end

data/spec/rest/client_spec.rb

@@ -181,19 +181,4 @@ describe Twilio::REST::Client do
       expect(client.send(method)).to eq(client.account.send(method))
     end
   end
-
-  it 'should convert all parameter names to Twilio-style names' do
-    twilio = Twilio::REST::Client.new('someSid', 'someToken')
-    untwilified = {
-      :sms_url => 'someUrl',
-      'voiceFallbackUrl' => 'anotherUrl',
-      'Status_callback' => 'yetAnotherUrl'
-    }
-    twilified = {
-      :SmsUrl => 'someUrl',
-      :VoiceFallbackUrl => 'anotherUrl',
-      :StatusCallback => 'yetAnotherUrl'
-    }
-    expect(twilio.twilify(untwilified)).to eq(twilified)
-  end
 end

data/spec/rest/utils_spec.rb

@@ -0,0 +1,45 @@
+require 'spec_helper'
+
+class UtilClass
+  include Twilio::REST::Utils
+end
+
+describe UtilClass do
+  subject(:util) { UtilClass.new }
+
+  it 'should convert a parameter name to a Twilio-style name' do
+    expect(util.twilify('sms_url')).to eq('SmsUrl')
+  end
+
+  it 'should convert all parameter names to Twilio-style names' do
+    untwilified = {
+      :sms_url => 'someUrl',
+      'voiceFallbackUrl' => 'anotherUrl',
+      'Status_callback' => 'yetAnotherUrl'
+    }
+    twilified = {
+      :SmsUrl => 'someUrl',
+      :VoiceFallbackUrl => 'anotherUrl',
+      :StatusCallback => 'yetAnotherUrl'
+    }
+    expect(util.twilify(untwilified)).to eq(twilified)
+  end
+
+  it 'should convert a Twilio-style name to a parameter name' do
+    expect(util.detwilify('SmsUrl')).to eq('sms_url')
+  end
+
+  it 'should convert all Twilio-style names to parameter names' do
+    untwilified = {
+      :sms_url => 'someUrl',
+      :voice_fallback_url => 'anotherUrl',
+      :status_callback => 'yetAnotherUrl'
+    }
+    twilified = {
+      :SmsUrl => 'someUrl',
+      :VoiceFallbackUrl => 'anotherUrl',
+      :StatusCallback => 'yetAnotherUrl'
+    }
+    expect(util.detwilify(twilified)).to eq(untwilified)
+  end
+end

metadata

@@ -1,69 +1,69 @@
 --- !ruby/object:Gem::Specification
 name: twilio-ruby
 version: !ruby/object:Gem::Version
-  version: 3.13.1
+  version: 3.14.0
 platform: ruby
 authors:
 - Andrew Benton
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-10-01 00:00:00.000000000 Z
+date: 2014-11-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: multi_json
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 1.3.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 1.3.0
 - !ruby/object:Gem::Dependency
   name: builder
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 2.1.2
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 2.1.2
 - !ruby/object:Gem::Dependency
   name: jwt
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: 1.0.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: 1.0.0
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.5'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.5'
 description: A simple library for communicating with the Twilio REST API, building
@@ -76,8 +76,8 @@ extra_rdoc_files:
 - README.md
 - LICENSE.md
 files:
-- .gitignore
-- .travis.yml
+- ".gitignore"
+- ".travis.yml"
 - AUTHORS.md
 - CHANGES.md
 - Gemfile
@@ -190,6 +190,7 @@ files:
 - spec/rest/numbers_spec.rb
 - spec/rest/queue_spec.rb
 - spec/rest/recording_spec.rb
+- spec/rest/utils_spec.rb
 - spec/spec_helper.rb
 - spec/support/fakeweb.rb
 - spec/twilio_spec.rb
@@ -204,27 +205,27 @@ licenses:
 metadata: {}
 post_install_message: 
 rdoc_options:
-- --line-numbers
-- --inline-source
-- --title
+- "--line-numbers"
+- "--inline-source"
+- "--title"
 - twilio-ruby
-- --main
+- "--main"
 - README.md
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: 1.9.3
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.1
+rubygems_version: 2.2.2
 signing_key: 
 specification_version: 4
 summary: A simple library for communicating with the Twilio REST API, building TwiML,
@@ -242,6 +243,7 @@ test_files:
 - spec/rest/numbers_spec.rb
 - spec/rest/queue_spec.rb
 - spec/rest/recording_spec.rb
+- spec/rest/utils_spec.rb
 - spec/spec_helper.rb
 - spec/support/fakeweb.rb
 - spec/twilio_spec.rb