tweetabout 0.0.2 → 0.0.3

data/README.md

@@ -1,4 +1,4 @@
-== Tweets About Gem
+## Tweets About Gem
 
 This gem takes a twitter username and returns a list of words.
 
@@ -8,15 +8,25 @@ The words are are ordered list of the most frequently tweeted words based on the
 * URLs are removed, because that makes sense.
 
 
-== Installation
+## Installation
 
 `gem install tweetabout`
 
-Gemfile
+### Gemfile
 
 `gem 'tweetabout'`
 
-==Twitter API
+### Dependencies
+
+`httparty` because httparty > NET::HTTP 
+
+## TODO
+
+* Better test coverage.  Actually this a reqiorement before using this gem in production. And I know I am a bad Rubyist for this but I promise to get better.
+
+* Make this Gem useful.  Right now it returns a list of all words, it might be interesting to strip out articles and pronouns from the list, that might actually give you an interesting insight into a person's interests.
+
+##Twitter API
 
 The Twitter API imposes a restriction on requests for users' timelines.  Each request can only receive a maximum of 200 tweets.  To get 1,000 tweets, that means we have to make 5 round trips to the api server.  Let's see how longs these requests take.  This is the measured response time of the GET request for 5 different twitter usernames:
 
@@ -30,15 +40,14 @@ ex: GET `http://api.twitter.com/1/statuses/user_timeline.json?screen_name=#{user
     request4    480.757   945.29    645.733   605.972   340.256
     request5    575.621   469.731   707.737   826.423   169.244
 
-Based on this small test we can see that response times from the api vary from a few hundred milliseconds up to a full second.  Of course this is all influnced by time of day, network connection, and a variety of factors but it's good to know that if we have to make 5 trips in a row to the twitter api server we can't really count on it being very fast.  In fact, 5 requests could easily take 2.5 to 3 seconds to complete.  No doubt this is the slowest part of this app.
+Based on this small test we can see that response times from the api vary from a few hundred milliseconds up to a full second.  Of course this is all influnced by time of day, network connection, and a variety of factors but it's good to know that if we have to make 5 trips in a row to the twitter api server we can't really count on it being very fast.  In fact, 5 requests could easily take 2.5 to 3 seconds to complete.  No doubt this is the slowest part of this gem.
 
-==Speed
+##Speed
 All these measurments are for processing the maximum of 1,000 tweets.  If the user has less than 1,000 tweets, obviously these processes will be faster.
 
 To see speeds yourself, checkout the speed branch and watch the server output.
 
-===get_tweets method
-`application_controller.rb: 29`
+### get_tweets method
 This method does 5 GET requests to the Twitter api and stores them all in `@responses` These are the different time measurements:
 
     4985.406 ms
@@ -48,8 +57,8 @@ This method does 5 GET requests to the Twitter api and stores them all in `@resp
     3656.680
     4510.602
 
-===Processing responses
-`@responses.each do |tweet|` block in `application_controller.rb:11
+### Processing responses (tweets)
+`@responses.each do |tweet|` block
 This method essentially takes the @responses variable, which is all the tweets, splits the words apart, removes punctuation and creates a hash of keys and values, keys are words, values are the number of times that word has shown up.  (the `bad_key` method below is part of this block.
 
     107.844 ms
@@ -59,12 +68,11 @@ This method essentially takes the @responses variable, which is all the tweets,
     137.528
     134.256    
 
-====bad_key method:
+#### bad_key method:
 
     .006ms - .013ms each word
 
-====Sorting
-`application_controller.rb:21`
+#### Sorting
     
     4.245 ms
     4.016

data/lib/tweetabout/version.rb

@@ -1,3 +1,3 @@
 module Tweetabout
-  VERSION = "0.0.2"
+  VERSION = "0.0.3"
 end

data/lib/tweetabout.rb

@@ -32,34 +32,39 @@ module Tweetabout
     @responses = []
     response1 = HTTParty.get("#{base_url}")
     return if response1.code == 404
+    return if response1.code == 400
     start_at_1 = response1.last["id"]
     response1.each do |object|
       @responses << object["text"]
     end
 
     response2 = HTTParty.get("#{base_url}&max_id=#{start_at_1-1}")
-    return if response2.count == 0
+    return if response2.count == 404
+    return if response2.code == 400
     start_at_2 = response2.last["id"]
     response2.each do |object|
       @responses << object["text"]
     end
     
     response3 = HTTParty.get("#{base_url}&max_id=#{start_at_2-1}")
-    return if response3.count == 0
+    return if response3.count == 404
+    return if response3.code == 400
     start_at_3 = response3.last["id"]
     response3.each do |object|
       @responses << object["text"]
     end
     
     response4 = HTTParty.get("#{base_url}&max_id=#{start_at_3-1}")
-    return if response4.count == 0
+    return if response4.count == 404
+    return if response4.code == 400
     start_at_4 = response4.last["id"]
     response4.each do |object|
       @responses << object["text"]
     end
 
     response5 = HTTParty.get("#{base_url}&max_id=#{start_at_4-1}")
-    return if response5.count == 0
+    return if response5.count == 404
+    return if response5.code == 400
     start_at_5 = response4.last["id"]
     response5.each do |object|
       @responses << object["text"]

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: tweetabout
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.3
   prerelease: 
 platform: ruby
 authors: