tutter 0.0.5 → 0.0.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 4192ecc489da04f7c71eb66580dca786823bce76
-  data.tar.gz: f282b693463e39b6a25fb6656f08a84cc463acc1
+  metadata.gz: 2fd4ec7bd3451798835a4eda2b8840f7cc7c8f28
+  data.tar.gz: cbece5fa4f7c061acae900228c671c1e35a0ffa1
 SHA512:
-  metadata.gz: a5341952596f313eeaac40969fec6e12203e8f99aaf3e521c6b8347b493454c4751adea57ea6e44e514ce001a3fd7a6961d8d48f95ba68e644d3dc39e122ae63
-  data.tar.gz: b9decb7449728ff7873669e4311dfa95cb1f2bebc28ee072b2d2b77e7b3af2f80a7e9fc8cacff618660f1d8ae7a55c7fb015ac2a39d55b8e6f9adb74def8d112
+  metadata.gz: 5a3ba61909d5102036fa717f2e514780b9a07c2efb8f0759a14ec427a8c7442e8d560db3900d5e29def4a19a5f0936fab3b47ab409500fb916944681b78543a9
+  data.tar.gz: 49a1500844a2435bd1decb5aef68bec358c080cd8ac2836ada5462f0f2adba5d4ef5289100a8f53687ac0334287acd52a60073146e8a57cb9997bdbf5cc7db02

data/.travis.yml

@@ -1,13 +1,11 @@
 language: ruby
 rvm:
-- 1.9.3
 - 2.0.0
 deploy:
   provider: rubygems
   api_key:
     secure: n8Dxj8UpauHBzBF10yVOCndmXEfLUQNV9ye9fi+b3tCtZHPqfEAaOfltbgP0Z8UglbiN8zPlt+Ayq4AiYXMx+gWEWpin+euVSvcK2JnMLQP1U9WD9qpTpAUXzIXxdUsoIY0VDfDMWpC+PYVCbNYNviKslaMRvzCd7w5dCOfsI30=
   gem: tutter
-  gemspec: .gemspec
   on:
     tags: true
     repo: jhaals/tutter

data/Gemfile

@@ -1,7 +1,8 @@
 source 'https://rubygems.org'
 
-gem 'octokit', '~> 3.2.0'
+gem 'octokit', '~> 4.3.0'
 gem 'sinatra', '~> 1.4.4'
+gem 'thin', '~> 1.7.0'
 
 group :development do
   gem 'sinatra-reloader'
@@ -11,7 +12,6 @@ group :test do
   gem 'sinatra-contrib'
   gem 'tutter', :path => '.'
   gem 'rake'
-  gem 'rack'
   gem 'rspec'
   gem 'json'
 end

data/README.md

@@ -1,43 +1,39 @@
 # Tutter - Plugin based Github robot
 [![Build Status](https://travis-ci.org/jhaals/tutter.png?branch=master)](https://travis-ci.org/JHaals/tutter)
 
-Tutter is a web app that trigger actions based on Github events(push, pull_reqeust, release, issue, ...)
+Tutter is a robot that can trigger customizable actions based on Github [events]((https://developer.github.com/v3/activity/events/types/)(push, pull_request, release, issue, ..)
 
-# Features
-* Pluggable with custom actions
-* Supports multiple projects
 
 # Installation
 
     gem install tutter
 
-put a configuration file in `/etc/tutter.yaml`
-an example can be found under `conf/tutter.yaml`
-
-Let's install the `thanks` action that thank anyone that creates an issue in your project.
+Place configuration file in `/etc/tutter.yaml`, example can be found in the conf/ directory.
 
 ### tutter.yaml settings
 
-* `name` - username/projectname
-* `access_token` - github access token (can be generated [here](https://github.com/settings/applications))
+* `name` - username/project_name
+* `access_token` - Github access token (can be generated [here](https://github.com/settings/applications))
 * `github_site` - github website
-* `github_api_enpoint` - github api endpint
+* `github_api_endpoint` - github api endpoint
+* `hook_secret` - (Optional) validate hook data based on known secret([more](https://developer.github.com/webhooks/securing/)).
 * `action` - action you wish to use for the project
 * `action_settings` - whatever settings your action require
 
-### Create the Github webhook
-Hooks can be configured just to send the event that you're interested in. The important part is that `Payload URL` points to the webserver running tutter
+### Configure Tutter action
+Hooks can be configured just to send the event that you're interested in. The important part is that `Payload URL` points to the webserver running Tutter
 
     https://github.com/ORG/PROJECT/settings/hooks/new
 
-Example of how the `thanks` demo-action look like. Tutter listen for issue events and posts back with a greeting.
+Example on how the `thanks` action looks like. Tutter listens for `issue` events and posts back with a greeting.
 ![img](http://f.cl.ly/items/1k111I3H1N0L3008301c/tutter.png)
 
 ## Build custom action
 
-See [thanks action](https://github.com/jhaals/tutter/blob/master/lib/tutter/action/thanks.rb)
+A simple action for getting started is the built in [thanks](https://github.com/jhaals/tutter/blob/master/lib/tutter/action/thanks.rb) action.
+More advanced usage can be seen in the [tutter-sppuppet](https://github.com/jhaals/tutter-sppuppet) action that allows non-collaborators to merge pull requests
 
-#####Required methods and their arguments
+##### Required methods and their arguments
 
 `initialize`
 
@@ -52,7 +48,4 @@ See [thanks action](https://github.com/jhaals/tutter/blob/master/lib/tutter/acti
 Tutter uses [octokit.rb](https://github.com/octokit/octokit.rb) to communicate with the Github [API](http://developer.github.com/v3/)
 
 ### Features to implement
-* Support multiple actions per project
 * Authenticate as a Github application
-* Features your're missing (please contribute)
-* Tests!

data/conf/tutter.yaml

@@ -3,9 +3,14 @@ projects:
     access_token: ''
     github_site: 'https://github.com'
     github_api_endpoint: 'https://api.github.com'
+    github_api_auto_paginate: true
 
-    action: 'thanks'
+    actions:
+      issue:
+        - thanks
+        - sassy
+      issue_comment:
+        - sassy
     action_settings:
         whatever_action_specific_setting: 'foo'
         another_setting: false
-

data/lib/tutter.rb

@@ -1,14 +1,16 @@
-require 'rubygems'
+require 'json'
 require 'octokit'
-require 'yaml'
 require 'sinatra'
+require 'thin'
 require 'tutter/action'
-require 'json'
+require 'yaml'
 
+# Modular sinatra app Tutter
 class Tutter < Sinatra::Base
+  enable :logging
 
   configure do
-    set :config_path, ENV['TUTTER_CONFIG_PATH'] || "conf/tutter.yaml"
+    set :config_path, ENV['TUTTER_CONFIG_PATH'] || 'conf/tutter.yaml'
     set :config, YAML.load_file(settings.config_path)
   end
 
@@ -22,78 +24,91 @@ class Tutter < Sinatra::Base
     set :bind, '0.0.0.0'
   end
 
+  def verify_signature(payload_body, secret_token)
+    signature = 'sha1=' + OpenSSL::HMAC.hexdigest(OpenSSL::Digest.new('sha1'), secret_token, payload_body)
+    return halt 500, "Signatures didn't match!" unless Rack::Utils.secure_compare(signature, request.env['HTTP_X_HUB_SIGNATURE'])
+  end
+
   # Return project settings from config
-  def get_project_settings project
+  def project_settings(project)
     settings.config['projects'].each do |p|
       return p if p['name'] == project
     end
-    false
+    error(404, 'Project does not exist in tutter.conf')
   end
 
-  def try_action event, data
-    project = data['repository']['full_name'] || error(400, 'Bad request')
-
-    conf = get_project_settings(project) || error(404, 'Project does not exist in tutter.conf')
+  # Return actions for event from config
+  def actions_for_event(event, config)
+    config['actions'][event] || error(404,
+                                      "No Actions for #{event} in tutter.conf"
+                                     )
+  end
 
-    # Setup octokit endpoints
+  def octokit_client(config)
     Octokit.configure do |c|
-      c.api_endpoint = conf['github_api_endpoint']
-      c.web_endpoint = conf['github_site']
+      c.api_endpoint = config['github_api_endpoint']
+      c.web_endpoint = config['github_site']
+      c.auto_paginate = config['github_api_auto_paginate'] or false
     end
 
-    if conf['access_token_env_var']
-      access_token = ENV[conf['access_token_env_var']] || ''
+    if config['access_token_env_var']
+      access_token = ENV[config['access_token_env_var']] || ''
     else
-      access_token = conf['access_token'] || ''
+      access_token = config['access_token'] || ''
     end
 
-    client = Octokit::Client.new :access_token => access_token
-
-    # Load action
-    action = Action.create(conf['action'],
-                                 conf['action_settings'],
-                                 client,
-                                 project,
-                                 event,
-                                 data)
+    Octokit::Client.new access_token: access_token
+  end
 
-    status_code, message = action.run
+  def prepare_actions(project, event, data, config)
+    client = octokit_client(config)
+    actions_for_event(event, config).each do |a|
+      yield Action.create(a,
+                          config['action_settings'],
+                          client,
+                          project,
+                          event,
+                          data), a
+    end
+  end
 
-    return status_code, message
+  def try_actions(event, data, project, config)
+    responses = { event: event, responses: {} }
+    prepare_actions(project, event, data, config) do |action, name|
+      status_code, message = action.run
+      responses[:responses][name] = { status_code: status_code,
+                                      message: message
+                                    }
+      break if status_code != 200
+    end
+    [responses[:responses].values.last[:status_code], responses.to_json]
   end
 
   post '/' do
-    event = env['HTTP_X_GITHUB_EVENT']
-
-    unless event
-      error(500, "Invalid request")
-    end
+    event = env['HTTP_X_GITHUB_EVENT'] || error(500, 'Invalid request')
 
     # Get a 200 OK message in the Github webhook history
     # Previously this showed an error.
-    if event == "ping"
-      return 200, "Tutter likes this hook!"
-    end
+    return 200, 'Tutter likes this hook!' if event == 'ping'
 
     # Github send data in JSON format, parse it!
+    request_body = request.body.read
     begin
-      data = JSON.parse request.body.read
+      data = JSON.parse request_body
     rescue JSON::ParserError
       error(400, 'POST data is not JSON')
     end
 
-    # Check actions with repo
-
-    if data['repository']
-      return try_action(event, data)
-    end
+    project = data['repository']['full_name'] || error(400, 'Bad request')
+    config = project_settings(project)
+    verify_signature(request_body, config['hook_secret']) if config['hook_secret']
 
-    error(400, "Unsupported request: #{event}")
+    return try_actions(event, data, project, config) if data['repository']
   end
 
   get '/' do
     'Source code and documentation at https://github.com/jhaals/tutter'
   end
 
-  run! if app_file == $0
+  run! if app_file == $PROGRAM_NAME
 end

data/lib/tutter/action/sassy.rb

@@ -0,0 +1,36 @@
+# Example action
+# Thank the person who submit an issue
+# The comment text is configurabe using the 'comment' setting.
+
+class Sassy
+  def initialize(settings, client, project, data, event)
+    @settings = settings # action specific settings
+    @client = client # Octokit client
+    @project = project # project name
+    @event = event # Github event
+    @data = data
+  end
+
+  def run
+    # Only trigger if a new issue is created
+    unless @data['action'] == 'created'
+      return 200, "Web hook from GitHub for #{@project} does not have status created. Dont know what to do."
+    end
+    issue = @data['issue']['number']
+    submitter = @data['issue']['user']['login']
+    comment = @settings['sassy_comment'] || "@#{submitter} Oh! big man eh? knowlage and shit"
+
+    begin
+      @client.add_comment(@project, issue, comment)
+      return 200, "Commented!"
+    rescue Octokit::NotFound
+      return 404, "Octokit returned 404, this could be an issue with your access token"
+    rescue Octokit::Unauthorized
+      return 401, "Authorization to #{@project} failed, please verify your access token"
+    rescue Octokit::TooManyLoginAttempts
+      return 429, "Account for #{@project} has been temporary locked down due to to many failed login attempts"
+    end
+    # TODO - Verify return data from @client.add_comment
+  end
+
+end

data/spec/fixtures/closed_issue.json

@@ -0,0 +1,154 @@
+{
+  "action": "closed",
+  "issue": {
+    "url": "https://api.github.com/repos/JHaals/testing/issues/9",
+    "labels_url": "https://api.github.com/repos/JHaals/testing/issues/9/labels{/name}",
+    "comments_url": "https://api.github.com/repos/JHaals/testing/issues/9/comments",
+    "events_url": "https://api.github.com/repos/JHaals/testing/issues/9/events",
+    "html_url": "https://github.com/JHaals/testing/issues/9",
+    "id": 28705860,
+    "number": 9,
+    "title": "the internet is broken",
+    "user": {
+      "login": "JHaals",
+      "id": 68980,
+      "avatar_url": "https://avatars.githubusercontent.com/u/68980",
+      "gravatar_id": "4e51de553ebfe258f038e040c8b25892",
+      "url": "https://api.github.com/users/JHaals",
+      "html_url": "https://github.com/JHaals",
+      "followers_url": "https://api.github.com/users/JHaals/followers",
+      "following_url": "https://api.github.com/users/JHaals/following{/other_user}",
+      "gists_url": "https://api.github.com/users/JHaals/gists{/gist_id}",
+      "starred_url": "https://api.github.com/users/JHaals/starred{/owner}{/repo}",
+      "subscriptions_url": "https://api.github.com/users/JHaals/subscriptions",
+      "organizations_url": "https://api.github.com/users/JHaals/orgs",
+      "repos_url": "https://api.github.com/users/JHaals/repos",
+      "events_url": "https://api.github.com/users/JHaals/events{/privacy}",
+      "received_events_url": "https://api.github.com/users/JHaals/received_events",
+      "type": "User",
+      "site_admin": false
+    },
+    "labels": [
+
+    ],
+    "state": "closed",
+    "assignee": null,
+    "milestone": null,
+    "comments": 0,
+    "created_at": "2014-03-04T13:46:06Z",
+    "updated_at": "2014-03-04T13:46:06Z",
+    "closed_at": null,
+    "pull_request": {
+      "html_url": null,
+      "diff_url": null,
+      "patch_url": null
+    },
+    "body": "what to do?"
+  },
+  "repository": {
+    "id": 16474769,
+    "name": "testing",
+    "full_name": "JHaals\/testing",
+    "owner": {
+      "login": "JHaals",
+      "id": 68980,
+      "avatar_url": "https://avatars.githubusercontent.com/u/68980",
+      "gravatar_id": "4e51de553ebfe258f038e040c8b25892",
+      "url": "https://api.github.com/users/JHaals",
+      "html_url": "https://github.com/JHaals",
+      "followers_url": "https://api.github.com/users/JHaals/followers",
+      "following_url": "https://api.github.com/users/JHaals/following{/other_user}",
+      "gists_url": "https://api.github.com/users/JHaals/gists{/gist_id}",
+      "starred_url": "https://api.github.com/users/JHaals/starred{/owner}{/repo}",
+      "subscriptions_url": "https://api.github.com/users/JHaals/subscriptions",
+      "organizations_url": "https://api.github.com/users/JHaals/orgs",
+      "repos_url": "https://api.github.com/users/JHaals/repos",
+      "events_url": "https://api.github.com/users/JHaals/events{/privacy}",
+      "received_events_url": "https://api.github.com/users/JHaals/received_events",
+      "type": "User",
+      "site_admin": false
+    },
+    "private": false,
+    "html_url": "https://github.com/JHaals/testing",
+    "description": "this is just for personal tests",
+    "fork": false,
+    "url": "https://api.github.com/repos/JHaals/testing",
+    "forks_url": "https://api.github.com/repos/JHaals/testing/forks",
+    "keys_url": "https://api.github.com/repos/JHaals/testing/keys{/key_id}",
+    "collaborators_url": "https://api.github.com/repos/JHaals/testing/collaborators{/collaborator}",
+    "teams_url": "https://api.github.com/repos/JHaals/testing/teams",
+    "hooks_url": "https://api.github.com/repos/JHaals/testing/hooks",
+    "issue_events_url": "https://api.github.com/repos/JHaals/testing/issues/events{/number}",
+    "events_url": "https://api.github.com/repos/JHaals/testing/events",
+    "assignees_url": "https://api.github.com/repos/JHaals/testing/assignees{/user}",
+    "branches_url": "https://api.github.com/repos/JHaals/testing/branches{/branch}",
+    "tags_url": "https://api.github.com/repos/JHaals/testing/tags",
+    "blobs_url": "https://api.github.com/repos/JHaals/testing/git/blobs{/sha}",
+    "git_tags_url": "https://api.github.com/repos/JHaals/testing/git/tags{/sha}",
+    "git_refs_url": "https://api.github.com/repos/JHaals/testing/git/refs{/sha}",
+    "trees_url": "https://api.github.com/repos/JHaals/testing/git/trees{/sha}",
+    "statuses_url": "https://api.github.com/repos/JHaals/testing/statuses/{sha}",
+    "languages_url": "https://api.github.com/repos/JHaals/testing/languages",
+    "stargazers_url": "https://api.github.com/repos/JHaals/testing/stargazers",
+    "contributors_url": "https://api.github.com/repos/JHaals/testing/contributors",
+    "subscribers_url": "https://api.github.com/repos/JHaals/testing/subscribers",
+    "subscription_url": "https://api.github.com/repos/JHaals/testing/subscription",
+    "commits_url": "https://api.github.com/repos/JHaals/testing/commits{/sha}",
+    "git_commits_url": "https://api.github.com/repos/JHaals/testing/git/commits{/sha}",
+    "comments_url": "https://api.github.com/repos/JHaals/testing/comments{/number}",
+    "issue_comment_url": "https://api.github.com/repos/JHaals/testing/issues/comments/{number}",
+    "contents_url": "https://api.github.com/repos/JHaals/testing/contents/{+path}",
+    "compare_url": "https://api.github.com/repos/JHaals/testing/compare/{base}...{head}",
+    "merges_url": "https://api.github.com/repos/JHaals/testing/merges",
+    "archive_url": "https://api.github.com/repos/JHaals/testing/{archive_format}{/ref}",
+    "downloads_url": "https://api.github.com/repos/JHaals/testing/downloads",
+    "issues_url": "https://api.github.com/repos/JHaals/testing/issues{/number}",
+    "pulls_url": "https://api.github.com/repos/JHaals/testing/pulls{/number}",
+    "milestones_url": "https://api.github.com/repos/JHaals/testing/milestones{/number}",
+    "notifications_url": "https://api.github.com/repos/JHaals/testing/notifications{?since,all,participating}",
+    "labels_url": "https://api.github.com/repos/JHaals/testing/labels{/name}",
+    "releases_url": "https://api.github.com/repos/JHaals/testing/releases{/id}",
+    "created_at": "2014-02-03T09:25:47Z",
+    "updated_at": "2014-02-16T20:25:07Z",
+    "pushed_at": "2014-02-16T20:25:06Z",
+    "git_url": "git://github.com/JHaals/testing.git",
+    "ssh_url": "git@github.com:JHaals/testing.git",
+    "clone_url": "https://github.com/JHaals/testing.git",
+    "svn_url": "https://github.com/JHaals/testing",
+    "homepage": null,
+    "size": 312,
+    "stargazers_count": 0,
+    "watchers_count": 0,
+    "language": null,
+    "has_issues": true,
+    "has_downloads": true,
+    "has_wiki": true,
+    "forks_count": 0,
+    "mirror_url": null,
+    "open_issues_count": 5,
+    "forks": 0,
+    "open_issues": 5,
+    "watchers": 0,
+    "default_branch": "master",
+    "master_branch": "master"
+  },
+  "sender": {
+    "login": "JHaals",
+    "id": 68980,
+    "avatar_url": "https://avatars.githubusercontent.com/u/68980",
+    "gravatar_id": "4e51de553ebfe258f038e040c8b25892",
+    "url": "https://api.github.com/users/JHaals",
+    "html_url": "https://github.com/JHaals",
+    "followers_url": "https://api.github.com/users/JHaals/followers",
+    "following_url": "https://api.github.com/users/JHaals/following{/other_user}",
+    "gists_url": "https://api.github.com/users/JHaals/gists{/gist_id}",
+    "starred_url": "https://api.github.com/users/JHaals/starred{/owner}{/repo}",
+    "subscriptions_url": "https://api.github.com/users/JHaals/subscriptions",
+    "organizations_url": "https://api.github.com/users/JHaals/orgs",
+    "repos_url": "https://api.github.com/users/JHaals/repos",
+    "events_url": "https://api.github.com/users/JHaals/events{/privacy}",
+    "received_events_url": "https://api.github.com/users/JHaals/received_events",
+    "type": "User",
+    "site_admin": false
+  }
+}

data/spec/fixtures/issue_comment.json

@@ -0,0 +1,184 @@
+{
+  "action": "created",
+  "issue": {
+    "url": "https://api.github.com/repos/JHaals/testing/issues/1",
+    "labels_url": "https://api.github.com/repos/JHaals/testing/issues/1/labels{/name}",
+    "comments_url": "https://api.github.com/repos/JHaals/testing/issues/1/comments",
+    "events_url": "https://api.github.com/repos/JHaals/testing/issues/1/events",
+    "html_url": "https://github.com/JHaals/testing/pull/1",
+    "id": 73231160,
+    "number": 1,
+    "title": "Added new fixture",
+    "user": {
+      "login": "JHaals",
+      "id": 568619,
+      "avatar_url": "https://avatars.githubusercontent.com/u/568619?v=3",
+      "gravatar_id": "",
+      "url": "https://api.github.com/users/JHaals",
+      "html_url": "https://github.com/JHaals",
+      "followers_url": "https://api.github.com/users/JHaals/followers",
+      "following_url": "https://api.github.com/users/JHaals/following{/other_user}",
+      "gists_url": "https://api.github.com/users/JHaals/gists{/gist_id}",
+      "starred_url": "https://api.github.com/users/JHaals/starred{/owner}{/repo}",
+      "subscriptions_url": "https://api.github.com/users/JHaals/subscriptions",
+      "organizations_url": "https://api.github.com/users/JHaals/orgs",
+      "repos_url": "https://api.github.com/users/JHaals/repos",
+      "events_url": "https://api.github.com/users/JHaals/events{/privacy}",
+      "received_events_url": "https://api.github.com/users/JHaals/received_events",
+      "type": "User",
+      "site_admin": false
+    },
+    "labels": [
+
+    ],
+    "state": "open",
+    "locked": false,
+    "assignee": null,
+    "milestone": null,
+    "comments": 2,
+    "created_at": "2015-05-05T07:06:01Z",
+    "updated_at": "2015-05-07T16:51:41Z",
+    "closed_at": null,
+    "pull_request": {
+      "url": "https://api.github.com/repos/JHaals/testing/pulls/1",
+      "html_url": "https://github.com/JHaals/testing/pull/1",
+      "diff_url": "https://github.com/JHaals/testing/pull/1.diff",
+      "patch_url": "https://github.com/JHaals/testing/pull/1.patch"
+    },
+    "body": ""
+  },
+  "comment": {
+    "url": "https://api.github.com/repos/JHaals/testing/issues/comments/99936656",
+    "html_url": "https://github.com/JHaals/testing/pull/1#issuecomment-99936656",
+    "issue_url": "https://api.github.com/repos/JHaals/testing/issues/1",
+    "id": 99936656,
+    "user": {
+      "login": "JHaals",
+      "id": 568619,
+      "avatar_url": "https://avatars.githubusercontent.com/u/568619?v=3",
+      "gravatar_id": "",
+      "url": "https://api.github.com/users/JHaals",
+      "html_url": "https://github.com/JHaals",
+      "followers_url": "https://api.github.com/users/JHaals/followers",
+      "following_url": "https://api.github.com/users/JHaals/following{/other_user}",
+      "gists_url": "https://api.github.com/users/JHaals/gists{/gist_id}",
+      "starred_url": "https://api.github.com/users/JHaals/starred{/owner}{/repo}",
+      "subscriptions_url": "https://api.github.com/users/JHaals/subscriptions",
+      "organizations_url": "https://api.github.com/users/JHaals/orgs",
+      "repos_url": "https://api.github.com/users/JHaals/repos",
+      "events_url": "https://api.github.com/users/JHaals/events{/privacy}",
+      "received_events_url": "https://api.github.com/users/JHaals/received_events",
+      "type": "User",
+      "site_admin": false
+    },
+    "created_at": "2015-05-07T16:51:41Z",
+    "updated_at": "2015-05-07T16:51:41Z",
+    "body": "nonsense!"
+  },
+  "repository": {
+    "id": 35081222,
+    "name": "tutter-sppuppet",
+    "full_name": "JHaals/testing",
+    "owner": {
+      "login": "JHaals",
+      "id": 568619,
+      "avatar_url": "https://avatars.githubusercontent.com/u/568619?v=3",
+      "gravatar_id": "",
+      "url": "https://api.github.com/users/JHaals",
+      "html_url": "https://github.com/JHaals",
+      "followers_url": "https://api.github.com/users/JHaals/followers",
+      "following_url": "https://api.github.com/users/JHaals/following{/other_user}",
+      "gists_url": "https://api.github.com/users/JHaals/gists{/gist_id}",
+      "starred_url": "https://api.github.com/users/JHaals/starred{/owner}{/repo}",
+      "subscriptions_url": "https://api.github.com/users/JHaals/subscriptions",
+      "organizations_url": "https://api.github.com/users/JHaals/orgs",
+      "repos_url": "https://api.github.com/users/JHaals/repos",
+      "events_url": "https://api.github.com/users/JHaals/events{/privacy}",
+      "received_events_url": "https://api.github.com/users/JHaals/received_events",
+      "type": "User",
+      "site_admin": false
+    },
+    "private": false,
+    "html_url": "https://github.com/JHaals/testing",
+    "description": "tutter action - code review without collaborator access",
+    "fork": true,
+    "url": "https://api.github.com/repos/JHaals/testing",
+    "forks_url": "https://api.github.com/repos/JHaals/testing/forks",
+    "keys_url": "https://api.github.com/repos/JHaals/testing/keys{/key_id}",
+    "collaborators_url": "https://api.github.com/repos/JHaals/testing/collaborators{/collaborator}",
+    "teams_url": "https://api.github.com/repos/JHaals/testing/teams",
+    "hooks_url": "https://api.github.com/repos/JHaals/testing/hooks",
+    "issue_events_url": "https://api.github.com/repos/JHaals/testing/issues/events{/number}",
+    "events_url": "https://api.github.com/repos/JHaals/testing/events",
+    "assignees_url": "https://api.github.com/repos/JHaals/testing/assignees{/user}",
+    "branches_url": "https://api.github.com/repos/JHaals/testing/branches{/branch}",
+    "tags_url": "https://api.github.com/repos/JHaals/testing/tags",
+    "blobs_url": "https://api.github.com/repos/JHaals/testing/git/blobs{/sha}",
+    "git_tags_url": "https://api.github.com/repos/JHaals/testing/git/tags{/sha}",
+    "git_refs_url": "https://api.github.com/repos/JHaals/testing/git/refs{/sha}",
+    "trees_url": "https://api.github.com/repos/JHaals/testing/git/trees{/sha}",
+    "statuses_url": "https://api.github.com/repos/JHaals/testing/statuses/{sha}",
+    "languages_url": "https://api.github.com/repos/JHaals/testing/languages",
+    "stargazers_url": "https://api.github.com/repos/JHaals/testing/stargazers",
+    "contributors_url": "https://api.github.com/repos/JHaals/testing/contributors",
+    "subscribers_url": "https://api.github.com/repos/JHaals/testing/subscribers",
+    "subscription_url": "https://api.github.com/repos/JHaals/testing/subscription",
+    "commits_url": "https://api.github.com/repos/JHaals/testing/commits{/sha}",
+    "git_commits_url": "https://api.github.com/repos/JHaals/testing/git/commits{/sha}",
+    "comments_url": "https://api.github.com/repos/JHaals/testing/comments{/number}",
+    "issue_comment_url": "https://api.github.com/repos/JHaals/testing/issues/comments{/number}",
+    "contents_url": "https://api.github.com/repos/JHaals/testing/contents/{+path}",
+    "compare_url": "https://api.github.com/repos/JHaals/testing/compare/{base}...{head}",
+    "merges_url": "https://api.github.com/repos/JHaals/testing/merges",
+    "archive_url": "https://api.github.com/repos/JHaals/testing/{archive_format}{/ref}",
+    "downloads_url": "https://api.github.com/repos/JHaals/testing/downloads",
+    "issues_url": "https://api.github.com/repos/JHaals/testing/issues{/number}",
+    "pulls_url": "https://api.github.com/repos/JHaals/testing/pulls{/number}",
+    "milestones_url": "https://api.github.com/repos/JHaals/testing/milestones{/number}",
+    "notifications_url": "https://api.github.com/repos/JHaals/testing/notifications{?since,all,participating}",
+    "labels_url": "https://api.github.com/repos/JHaals/testing/labels{/name}",
+    "releases_url": "https://api.github.com/repos/JHaals/testing/releases{/id}",
+    "created_at": "2015-05-05T06:08:56Z",
+    "updated_at": "2015-05-05T06:08:57Z",
+    "pushed_at": "2015-05-05T07:06:01Z",
+    "git_url": "git://github.com/JHaals/testing.git",
+    "ssh_url": "git@github.com:JHaals/testing.git",
+    "clone_url": "https://github.com/JHaals/testing.git",
+    "svn_url": "https://github.com/JHaals/testing",
+    "homepage": null,
+    "size": 181,
+    "stargazers_count": 0,
+    "watchers_count": 0,
+    "language": "Ruby",
+    "has_issues": false,
+    "has_downloads": true,
+    "has_wiki": true,
+    "has_pages": false,
+    "forks_count": 0,
+    "mirror_url": null,
+    "open_issues_count": 1,
+    "forks": 0,
+    "open_issues": 1,
+    "watchers": 0,
+    "default_branch": "master"
+  },
+  "sender": {
+    "login": "JHaals",
+    "id": 568619,
+    "avatar_url": "https://avatars.githubusercontent.com/u/568619?v=3",
+    "gravatar_id": "",
+    "url": "https://api.github.com/users/JHaals",
+    "html_url": "https://github.com/JHaals",
+    "followers_url": "https://api.github.com/users/JHaals/followers",
+    "following_url": "https://api.github.com/users/JHaals/following{/other_user}",
+    "gists_url": "https://api.github.com/users/JHaals/gists{/gist_id}",
+    "starred_url": "https://api.github.com/users/JHaals/starred{/owner}{/repo}",
+    "subscriptions_url": "https://api.github.com/users/JHaals/subscriptions",
+    "organizations_url": "https://api.github.com/users/JHaals/orgs",
+    "repos_url": "https://api.github.com/users/JHaals/repos",
+    "events_url": "https://api.github.com/users/JHaals/events{/privacy}",
+    "received_events_url": "https://api.github.com/users/JHaals/received_events",
+    "type": "User",
+    "site_admin": false
+  }
+}

data/spec/fixtures/new_issue.json

@@ -48,7 +48,7 @@
   "repository": {
     "id": 16474769,
     "name": "testing",
-    "full_name": "JHaals/testing",
+    "full_name": "JHaals\/testing",
     "owner": {
       "login": "JHaals",
       "id": 68980,
@@ -151,4 +151,4 @@
     "type": "User",
     "site_admin": false
   }
-}
+}

data/spec/tutter_spec.rb

@@ -1,32 +1,88 @@
 require 'spec_helper'
 require 'json'
 
-describe 'tutter' do
+describe 'Tutter' do
+  it 'Complains about missing Github header' do
+    post '/', JSON.generate(repository: { full_name: '404' })
+    expect(last_response.body).to match(/Invalid request/)
+    expect(last_response.status).to be 500
+  end
+
+  it 'Complains about missing project in settings' do
+    post '/', JSON.generate(repository: { full_name: '404' }), 'HTTP_X_GITHUB_EVENT' => 'fake'
+    expect(last_response.body).to match(/Project does not exist in tutter.conf/)
+    expect(last_response.status).to be 404
+  end
+
+  it 'Complains about missing repository name in json payload' do
+    post '/', JSON.generate(repository: {}), 'HTTP_X_GITHUB_EVENT' => 'issue_comment'
+    expect(last_response.body).to match(/Bad request/)
+    expect(last_response.status).to be 400
+  end
+
+  it 'Complains about event not configured for project' do
+    post '/', JSON.generate(repository: { full_name: 'JHaals/testing' }), 'HTTP_X_GITHUB_EVENT' => 'fake'
+    expect(last_response.body).to match(/No Actions for fake in tutter.conf/)
+    expect(last_response.status).to be 404
+  end
 
-  it 'expect complain about missing project in settings' do
-    post '/', params=JSON.generate({'repository' => {'full_name' => '404'}}), {'HTTP_X_GITHUB_EVENT' => 'fake'}
-    expect { last_response.body match /Project does not exist in tutter.conf/ }
-    expect { last_response.status == 404 }
+  it 'Complains about POST data not being JSON' do
+    post '/', { broken: 'data' }, 'HTTP_X_GITHUB_EVENT' => 'fake'
+    expect(last_response.body).to match(/POST data is not JSON/)
+    expect(last_response.status).to be 400
   end
 
-  it 'expect complain about POST data not being JSON' do
-    post '/', params={'broken' => 'data'}, {'HTTP_X_GITHUB_EVENT' => 'fake'}
-    expect { last_response.body match /POST data is not JSON/ }
-    expect { last_response.status == 400 }
+  it 'Responds to Github ping event' do
+    post '/', JSON.generate({}), 'HTTP_X_GITHUB_EVENT' => 'ping'
+    expect(last_response.body).to match(/Tutter likes this hook!/)
+    expect(last_response.status).to be 200
   end
 
-  it 'expect return documentation URL' do
+  it 'Returns documentation URL' do
     get '/'
-    expect { last_response.body match /Source code and documentation/ }
+    expect(last_response.body).to match(/Source code and documentation/)
   end
 
+  it 'Retruns only one response in repsonses due to first action failiure' do
+    data = IO.read('spec/fixtures/new_issue.json')
+    post '/', data, 'HTTP_X_GITHUB_EVENT' => 'issue'
+    body = JSON.parse(last_response.body)
+    expect(body["responses"]["thanks"]["message"]).to match(/Authorization to JHaals\/testing failed, please verify your access token/)
+    expect(body["responses"].length).to be(1)
+    expect(last_response.status).to be 401
+  end
 end
 
-describe 'tutter Hello action' do
-  it 'expect complain about invalid credentials' do
+describe 'Tutter Thanks action' do
+  it 'Complains about invalid credentials' do
     data = IO.read('spec/fixtures/new_issue.json')
-    post '/', params=data, {'HTTP_X_GITHUB_EVENT' => 'fake'}
-    expect { last_response.body match /Authorization to JHaals\/testing failed, please verify your access token/ }
-    expect { last_response.status == 401 }
+    post '/', data, 'HTTP_X_GITHUB_EVENT' => 'issue'
+    body = JSON.parse(last_response.body)
+    expect(body["responses"]["thanks"]["message"]).to match(/Authorization to JHaals\/testing failed, please verify your access token/)
+    expect(last_response.status).to be 401
+  end
+  it 'Will not thank user for anything else that opening an issue' do
+    data = IO.read('spec/fixtures/closed_issue.json')
+    post '/', data, 'HTTP_X_GITHUB_EVENT' => 'issue'
+    body = JSON.parse(last_response.body)
+    expect(body["responses"]["thanks"]["message"]).to match(/Web hook from GitHub for JHaals\/testing does not have status opened. We don't thank people for closing issues/)
+    expect(last_response.status).to be 200
   end
-end
+end
+
+describe 'Tutter Sassy action' do
+  it 'Complains about invalid credentials' do
+    data = IO.read('spec/fixtures/issue_comment.json')
+    post '/', data, 'HTTP_X_GITHUB_EVENT' => 'issue_comment'
+    body = JSON.parse(last_response.body)
+    expect(body["responses"]["sassy"]["message"]).to match(/Authorization to JHaals\/testing failed, please verify your access token/)
+    expect(last_response.status).to be 401
+  end
+  it 'Fails gracefully when it dosent know what to do' do
+    data = IO.read('spec/fixtures/closed_issue.json')
+    post '/', data, 'HTTP_X_GITHUB_EVENT' => 'issue_comment'
+    body = JSON.parse(last_response.body)
+    expect(body["responses"]["sassy"]["message"]).to match(/Web hook from GitHub for JHaals\/testing does not have status created. Dont know what to do./)
+    expect(last_response.status).to be 200
+  end
+end

data/{.gemspec → tutter.gemspec}

@@ -1,7 +1,7 @@
 # -*- encoding: utf-8 -*-
 Gem::Specification.new do |s|
   s.name        = 'tutter'
-  s.version     = '0.0.5'
+  s.version     = '0.0.6'
   s.author      = 'Johan Haals'
   s.email       = ['johan.haals@gmail.com']
   s.homepage    = 'https://github.com/jhaals/tutter'
@@ -15,7 +15,7 @@ Gem::Specification.new do |s|
 
   s.required_ruby_version = '>= 1.8.7'
   s.add_runtime_dependency 'sinatra', '~> 1.4'
-  s.add_runtime_dependency 'octokit', '~> 3.2'
+  s.add_runtime_dependency 'octokit', '~> 4.3'
 
   s.add_development_dependency 'sinatra-contrib', '~> 1.4'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: tutter
 version: !ruby/object:Gem::Version
-  version: 0.0.5
+  version: 0.0.6
 platform: ruby
 authors:
 - Johan Haals
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-01-30 00:00:00.000000000 Z
+date: 2017-05-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: sinatra
@@ -30,14 +30,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.2'
+        version: '4.3'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.2'
+        version: '4.3'
 - !ruby/object:Gem::Dependency
   name: sinatra-contrib
   requirement: !ruby/object:Gem::Requirement
@@ -60,7 +60,6 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- ".gemspec"
 - ".gitignore"
 - ".travis.yml"
 - Gemfile
@@ -69,10 +68,14 @@ files:
 - conf/tutter.yaml
 - lib/tutter.rb
 - lib/tutter/action.rb
+- lib/tutter/action/sassy.rb
 - lib/tutter/action/thanks.rb
+- spec/fixtures/closed_issue.json
+- spec/fixtures/issue_comment.json
 - spec/fixtures/new_issue.json
 - spec/spec_helper.rb
 - spec/tutter_spec.rb
+- tutter.gemspec
 homepage: https://github.com/jhaals/tutter
 licenses:
 - Apache 2.0
@@ -94,7 +97,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.2
+rubygems_version: 2.6.11
 signing_key: 
 specification_version: 4
 summary: Plugin based Github robot