turkish_id 1.2.0 → 1.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 981b26b23fc03c750903f2300a20fbc668f98db0d04da9bcceb029bb43117a59
-  data.tar.gz: 9ef99c3d80572269d44c43b7896c367512e51bb54a813b15bf5c788702e35895
+  metadata.gz: 9f2ce68dae19376b6afae68d92f079c60661ef424d26a58f7a201c43893860dc
+  data.tar.gz: 3370d7423c4cd7b60df5143f6e890242e5381b7d7fe7a0224d9bf3d25950aa8b
 SHA512:
-  metadata.gz: e5ea1ef848cb15b940cab3bdd1ba538abf9926bf8f1ddc229d2a2110786965f0921a240243b852ea1c43c3f391737ab758c57b12f0ebdf8b010b901b0d14f4b3
-  data.tar.gz: 35cb558319958f2931f12e67601b765b793d2b2eb6c5ca2af01e22ae71b18c3e069e3068e8a545e32155665d53d5895b0a9e1e358da8b9bf68bd278a5144db17
+  metadata.gz: b87c07e37a6e77264a43ab52e218c6419b859d6daa79bfcfe38cb35b379fd39f25bf447576fbdaf3b3c43bafca4dca83639ffa485e2bd1e34ddac8b87398c962
+  data.tar.gz: fd1974ed82dd65682b1f5a09a265dc020282551b2be4e53c5eca23bdf5f28bee0c18f6c882c5ca3f40b0501ebd6750c16394f80ae4f7d343d3b06eb16271ecf5

data/.ruby-version

@@ -1 +1 @@
-ruby-2.6.5
+ruby-2.7.1

data/.travis.yml

@@ -1,8 +1,8 @@
 language: ruby
 rvm:
-  - 2.6.5
-  - 2.5.7
-  - 2.4.9
+  - 2.7.1
+  - 2.6.6
+  - 2.5.8
 before_install:
   - 'gem update --system'
   - 'gem --version'

data/Gemfile

@@ -1,11 +1,13 @@
+# frozen_string_literal: true
+
 source 'https://rubygems.org'
 
 # Specify your gem's dependencies in turkish_id.gemspec
 gemspec
 
 group :test do
-  gem 'rake'
   gem 'bundler'
+  gem 'rake'
   gem 'rspec'
   gem 'simplecov'
 end

data/README.md

@@ -30,10 +30,10 @@ Create a new instance:
 identity_number = TurkishId.new(10000000146)
 ```
 
-Use ```is_valid?``` method to check validity:
+Use ```valid?``` method to check validity:
 
 ```rb
-identity_number.is_valid?  #=> true
+identity_number.valid?  #=> true
 ```
 
 Or use the command line executable:
@@ -98,9 +98,9 @@ Remember that a valid identification number does not imply the existence of an I
 
 This gem is used in production and tested against the following Ruby versions:
 
-- ✅ `2.6.5` (stable)
-- ✅ `2.5.7` (stable)
-- ⏳ `2.4.9` (security maintenance)
+- ✅ `2.7.1` (stable)
+- ✅ `2.6.6` (stable)
+- ⏳ `2.5.8` (security maintenance)
 
 ## Development
 

data/Rakefile

@@ -1,6 +1,7 @@
+# frozen_string_literal: true
+
 require 'bundler/gem_tasks'
 require 'rspec/core/rake_task'
 
 RSpec::Core::RakeTask.new(:spec)
-task :default => :spec
-
+task default: :spec

data/bin/console

@@ -1,4 +1,5 @@
 #!/usr/bin/env ruby
+# frozen_string_literal: true
 
 require 'bundler/setup'
 require 'turkish_id'

data/bin/turkish_id

@@ -1,5 +1,5 @@
 #!/usr/bin/env ruby
-# encoding: UTF-8
+# frozen_string_literal: true
 
 lib = File.expand_path(File.dirname(__FILE__) + '/../lib')
 $LOAD_PATH.unshift(lib) if File.directory?(lib) && !$LOAD_PATH.include?(lib)
@@ -22,11 +22,11 @@ end
 
 def validate_id(id_number)
   identity_number = TurkishId.new(id_number)
-  print_result(identity_number.is_valid?)
+  print_result(identity_number.valid?)
 end
 
 def print_result(result)
-  STDOUT.puts "Your identification number is #{ result ? 'valid' : 'invalid' }."
+  STDOUT.puts "Your identification number is #{result ? 'valid' : 'invalid'}."
 end
 
 def print_help

data/lib/turkish_id.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'turkish_id/version'
 
 class TurkishId
@@ -10,17 +12,11 @@ class TurkishId
     @younger_relative = generate_relatives(@id_number, :down)
   end
 
-  def is_valid?
-    # Early termination, bad length or first digit
-    return false if @id_number.length != 11 || @id_number.first == 0
-
-    # Calculate checksum if not already calculated
-    @checksum ||= calculate_checksum(@id_number)
-
-    # Check if tenth or eleventh digits match the algorithm
-    return false if @id_number[9] != @checksum[0] || @id_number[10] != @checksum[1]
+  def valid?
+    return false if @id_number.length != 11 || @id_number.first.zero?
+    return false if @id_number.values_at(9, 10) != @checksum ||= calculate_checksum(@id_number)
 
-    true  # All conditions met
+    true
   end
 
   private
@@ -36,7 +32,7 @@ class TurkishId
 
     # Return checksum
     [d10, d11]
-  rescue
+  rescue StandardError
     []
   end
 
@@ -47,7 +43,7 @@ class TurkishId
 
   def next_relative(id_array, direction)
     tree = { up: 1, down: -1 }
-    get_core(id_array) + 29999 * tree[direction]
+    get_core(id_array) + 29_999 * tree[direction]
   end
 
   def generate_relatives(id_array, direction)
@@ -55,23 +51,26 @@ class TurkishId
       id = join_num(id_array)
       loop do
         id = next_relative(id, direction)
-        break unless id.between?(100000001, 999999999)
+        break unless id.between?(100_000_001, 999_999_999)
+
         y << append_checksum(id)
       end
     end
   end
 
   def get_id_array(id)
-    split_num(Integer(id)) rescue []
+    split_num(Integer(id))
+  rescue StandardError
+    []
   end
 
   def split_num(num)
     n = Math.log10(num).floor
-    (0..n).map{ |i| (num / 10 ** (n - i)) % 10 }
+    (0..n).map { |i| (num / 10**(n - i)) % 10 }
   end
 
   def join_num(id_array)
-    id_array.inject{ |a, i| a * 10 + i }
+    id_array.inject { |a, i| a * 10 + i }
   end
 
   def get_core(id_array)

data/lib/turkish_id/version.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class TurkishId
-  VERSION = '1.2.0'
+  VERSION = '1.3.0'
 end

data/turkish_id.gemspec

@@ -1,5 +1,6 @@
-# coding: utf-8
-lib = File.expand_path('../lib', __FILE__)
+# frozen_string_literal: true
+
+lib = File.expand_path('lib', __dir__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require 'turkish_id/version'
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: turkish_id
 version: !ruby/object:Gem::Version
-  version: 1.2.0
+  version: 1.3.0
 platform: ruby
 authors:
 - Kerem Bozdas
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2019-11-17 00:00:00.000000000 Z
+date: 2020-07-18 00:00:00.000000000 Z
 dependencies: []
 description: Validate Turkish Identification Numbers and More!
 email:
@@ -37,7 +37,7 @@ homepage: https://github.com/krmbzds/turkish_id
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -53,8 +53,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.6
-signing_key: 
+rubygems_version: 3.1.3
+signing_key:
 specification_version: 4
 summary: Validate Turkish Identification Numbers and More!
 test_files: []