turkish_id 0.2.2 → 0.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 6b8dca9f48bfca637f6d987a9469d4a30860fe66
-  data.tar.gz: 66a40925b91acba68bef5a8cfd28e9f6ab0e20d2
+  metadata.gz: 15a42720981e14cba171d93f4aae070f10142976
+  data.tar.gz: 578b38fcffb08ece46644abd56099be085764203
 SHA512:
-  metadata.gz: 7aa6fa00f6f039ad3393c23d8c86d7d6b23f8fd2ca7bf58d3a239cb52f4671647a181092ea561f7bcf1a24d47bb96a4c6a6e3671c5633bb58e93e9cbe207bba3
-  data.tar.gz: 13fba52300273a7876caa6f266e42330453f338323b4b522552a87440401a36dbec97ff2f2cb3b2d599f0666460da90e39908012eb11d099e170067e2cd1509e
+  metadata.gz: f7dba1b5eb2f5c166262a971f5af438f9b78046457ac39a7cc92f42ad7339878625a1a46e5689f5e2ba2afe63abcdf542575aad55abd26b1747e3c66710e59a4
+  data.tar.gz: 1b5f8d025248da5f83fd45b6a3a470f0fab9743c59ffe5e4538a4326045a77e2921706d7f795b33c126f6c420e82125b1583258af938eb2a2dbcac74c44b7ff8

data/.gitignore

@@ -16,3 +16,4 @@ test/tmp
 test/version_tmp
 tmp
 .idea/
+coverage

data/.travis.yml

@@ -1,11 +1,25 @@
 language: ruby
 rvm:
-  - 2.2.0
+  - ruby-head
+  - 2.5.1
+  - 2.4.4
+  - 2.3.7
+  - 2.2.10
+  - 2.1.8
   - 1.9.3
-install:
-  - gem uninstall bundler
+before_install:
+  - gem update --system
+  - gem --version
   - gem install bundler
-  - bundle install
-addons:
-  code_climate:
-    repo_token: ae61bac6e33448d6990e3f36d9f16dbabfcae03d279e2b2226108f39a0212a59
+
+env:
+  global:
+    - CC_TEST_REPORTER_ID=92655ba2c8b47200f80e996afb80c410b9491514845d414d7517108ad35a5178
+before_script:
+  - curl -L https://codeclimate.com/downloads/test-reporter/test-reporter-latest-linux-amd64 > ./cc-test-reporter
+  - chmod +x ./cc-test-reporter
+  - ./cc-test-reporter before-build
+script:
+  - bundle exec rspec
+after_script:
+  - ./cc-test-reporter after-build --exit-code $TRAVIS_TEST_RESULT

data/Gemfile

@@ -3,5 +3,8 @@ source 'https://rubygems.org'
 # Specify your gem's dependencies in turkish_id.gemspec
 gemspec
 
-gem 'codeclimate-test-reporter', group: :test, require: nil
-gem 'pry', '~> 0.10.3', group: :development, require: nil
+gem 'rake', group: :test
+gem 'simplecov', group: :test, require: false
+gem 'simplecov-console', group: :test, require: false
+gem 'pry', '~> 0.10.3', group: :development, require: nil
+

data/README.md

@@ -41,13 +41,6 @@ $ turkish_id 10000000078
 Your identification number is valid.
 ```
 
-Use ```get_relatives``` method to check relatives:
-
-```rb
-identity_number.get_relatives(3)
-=> ["10003000082", "10005999902", "10008999848"]
-```
-
 ## Anatomy of the Turkish ID Number
 
 The Turkish Identification Number consists of ```11``` digits.

data/Rakefile

@@ -3,3 +3,4 @@ require 'rspec/core/rake_task'
 
 RSpec::Core::RakeTask.new(:spec)
 task :default => :spec
+

data/lib/turkish_id/version.rb

@@ -1,3 +1,3 @@
 class TurkishId
-  VERSION = "0.2.2"
+  VERSION = "0.3.0"
 end

data/lib/turkish_id.rb

@@ -1,78 +1,54 @@
 require "turkish_id/version"
 
-class String
-  def digitize
-    self.split('').map { |s| Integer(s) }
-  end
-end
-
 class TurkishId
+  attr_reader :id_number, :checksum
 
   def initialize(id_number)
-    begin
-      @id_number = id_number.digitize  # Convert string into array of integers
-    rescue
-      @id_number = ''  # Suppress error & return false (eventually)
-    end
-  end
-
-
-  def core
-    @id_number.take(9)
-  end
-
-
-  def self.get_checksum(id_core)
-
-    # Calculate the sums of odd and even digits
-    odds = id_core.values_at(0, 2, 4, 6, 8).reduce(:+)
-    evens = id_core.values_at(1, 3, 5, 7).reduce(:+)
-
-    # Generate checksum digits
-    d10 = ((odds * 7) - evens) % 10
-    d11 = (id_core.reduce(:+) + d10) % 10
-
-    [d10, d11]
-  end
-
-  def self.add_checksum(id_core)
-    id_core + TurkishId.get_checksum(id_core)
+    @id_number = digitize(id_number)
+    @checksum = calculate_checksum(@id_number)
   end
 
   def is_valid?
-    id = @id_number  # +1 brevity point
+    id = @id_number  # For brevity
 
-    # Early elimination, bad length or first digit
+    # Early termination, bad length or first digit
     return false if id.length != 11 || id.first == 0
 
-    # Get checksum digits
-    d10, d11 = TurkishId.get_checksum(id)
+    # Calculate checksum if not already calculated
+    @checksum ||= calculate_checksum(id_number)
 
     # Check if the tenth digit matches the algorithm
-    return false if id[9] != d10
+    return false if id[9] != @checksum[0]
 
     # Check if the eleventh digit matches the algorithm
-    return false if id[10] != d11
+    return false if id[10] != @checksum[1]
 
     true  # All conditions met
   end
 
-  def get_relatives(num, direction='up')
+  private
 
-    id = self.core.join.to_i  # Our core id as integer
+  def calculate_checksum(id_number)
+    # Calculate the sums of odd and even digits
+    odds = id_number.values_at(0, 2, 4, 6, 8).reduce(:+)
+    evens = id_number.values_at(1, 3, 5, 7).reduce(:+)
 
-    tree = {'up' => 1, 'down' => -1}      # + or - based on direction
-    magic = 131 * 229 * tree[direction]   # Eliminates if statement
+    # Generate checksum digits
+    d10 = ((odds * 7) - evens) % 10
+    d11 = (id_number.take(9).reduce(:+) + d10) % 10
 
-    relatives = []
+    # Return checksum
+    [d10, d11]
+  rescue
+    []  # Unable to calculate checksum, initial value remains unchainged
+  end
 
-    num.times do
-      id += magic      # Gives us the next relative
-      relatives << id  # Collecting ids in an array
-    end
+  def digitize(id_number)
+    # Narrow down scope of accepted types
+    return [] unless [String, Integer, Fixnum].include?(id_number.class)
 
-    # Traverse relatives and append checksum digits
-    relatives.map { |r| TurkishId.add_checksum(r.to_s.digitize).join }
+    # Convert string of numbers into an array of integers
+    id_number.to_s.split('').map { |s| Integer(s) }
   end
 
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: turkish_id
 version: !ruby/object:Gem::Version
-  version: 0.2.2
+  version: 0.3.0
 platform: ruby
 authors:
 - Kerem Bozdas
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-04-10 00:00:00.000000000 Z
+date: 2018-04-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -110,7 +110,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.6
+rubygems_version: 2.6.14
 signing_key: 
 specification_version: 4
 summary: Validate Turkish Identification Numbers and More!