turkish_banks 0.6.0 → 1.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 507f9a4bb17809fdf68a95947bb937759701a2f4f0267df1efb769187bdcfee8
-  data.tar.gz: 5a6d1c8c8fe43d984b7028f0c41526a898a730bac0dee0b8c1814d02b33b255f
+  metadata.gz: 5a4a1e3454cffe707870cf8ad1b4ae3cd0158b40ff58c3251028063e57c94c85
+  data.tar.gz: '09afc7a80cbb76814f595ebd89113697d28ab8e77a912fff8205a8ed4c2542b1'
 SHA512:
-  metadata.gz: '08c7a3f09d95afef0e09da7c5980e392e0b8768e9e3ed2e179ea0af90380fa7ae3f986c8b60f5aefea59f5d288121618e7280bb83d3023e67a620ffb606ba893'
-  data.tar.gz: 0163fc54c49b07bb180b940ad2d3219fde863ce77beba7e54c4b2a2677441d24faff68e2ccc24df897ae5dd76dda92bd0ee662a273ec062afc0ffebe13af8313
+  metadata.gz: 8552c337e65bb399cb91cb844d4ee5197e7314b854b59052719741bd84ea2b1ac6ebda409349d54cd43612dc825a310c55b53725243a1c0a2fd1db85d3c123a8
+  data.tar.gz: 636f245cc55b582d2539999788b653515322ff22a238eda3d73c59391eccadfe05a189bc55d1754153a9b25266bb7cd58592ff82fea59777839358f975a42831

data/.gitignore

@@ -7,3 +7,4 @@
 /pkg/
 /spec/reports/
 /tmp/
+/.idea/

data/README.md

@@ -24,25 +24,34 @@ Or install it yourself as:
 ## Usage
 
 ```ruby
-# Creates a TurkishBank object
-turkish_bank = TurkishBanks::TurkishBank.new
-
 # Gets last update date
-turkish_bank.last_update_date
+TurkishBanks::LAST_UPDATE
 
 # Gets all banks
-turkish_bank.banks
+TurkishBanks.banks
+
+# Create a bank from its name
+bank = TurkishBanks::Bank.new("türkiye cumhuriyeti ziraat bankası a.ş.")
+bank.name # => "TÜRKİYE CUMHURİYETİ ZIRAAT BANKASI A.Ş."
 
-# Returns a bank object
-bank = turkish_bank.get_information_of "türkiye cumhuriyeti ziraat bankası a.ş."
-bank.name # => TÜRKİYE CUMHURİYETİ ZIRAAT BANKASI A.Ş.
+# Get a collection of branch objects
+branches = bank.branches
+branches.first.name # => "MERKEZ/ANKARA ŞUBESİ"
+branches.size       # => 1791
+```
 
-# Returns a collection of branch objectes
-branches = turkish_bank.get_branches_of "türkiye cumhuriyeti ziraat bankası a.ş."
-branches.first.name # => "ANKARA ŞUBESİ"
-```    
+## Exception Handling
 
-## TODO
+If you pass the wrong bank name to `Bank#new`, it raises `TurkishBanks::BankNotFoundError` exception. You can rescue this error, then do something else.
 
+```ruby
+begin
+  TurkishBanks::Bank.new('fake bank')
+rescue TurkishBanks::BankNotFoundError
+  # do something here
+end
+``` 
+
+## TODO
 * Improve search part.
 * New features. Please send some pull-request.

data/lib/turkish_banks.rb

@@ -1,13 +1,13 @@
-require "active_support/core_ext/hash"
+require 'active_support/core_ext/hash'
 
-require "rubygems"
-require "open-uri"
-require "nokogiri"
-require "turkish_banks/version"
+require 'rubygems'
+require 'open-uri'
+require 'nokogiri'
+require 'turkish_banks/version'
 
-require "turkish_banks/turkish_bank"
-require "turkish_banks/bank"
-require "turkish_banks/branch"
+require 'turkish_banks/turkish_banks'
+require 'turkish_banks/branch'
+require 'turkish_banks/bank'
 
 module TurkishBanks
 end

data/lib/turkish_banks/bank.rb

@@ -1,12 +1,21 @@
 module TurkishBanks
-  class Bank < TurkishBank
-    attr_accessor :name, :code, :city, :address
+  class Bank
+    attr_reader :name, :code, :city, :address
 
-    def initialize(bank)
-      @name    = bank["bAd"]
-      @code    = bank["bKd"]
-      @city    = bank["bIlAd"]
-      @address = bank["adr"]
+    def initialize(bank_name)
+      bank_params = TurkishBanks.get_bank_params(bank_name)
+      @name    = bank_params['bAd']
+      @code    = bank_params['bKd']
+      @city    = bank_params['bIlAd']
+      @address = bank_params['adr']
+    end
+
+    def branches
+      nodes = TurkishBanks::DOC.xpath("//sube[bKd= '#{@code}']")
+      nodes.map do |node|
+        branch_params = Hash.from_xml(node.to_s)['sube']
+        TurkishBanks::Branch.new(branch_params)
+      end
     end
   end
 end

data/lib/turkish_banks/branch.rb

@@ -1,16 +1,17 @@
 module TurkishBanks
-  class Branch < TurkishBank
-    attr_accessor :name, :code, :bank_code, :city_code, :city, :district_code, :district, :phone
+  class Branch
+    attr_reader :name, :code, :bank_code, :city_code,
+                :city, :district_code, :district, :phone
 
-    def initialize(branch)
-      @name          = branch["sAd"]
-      @code          = branch["sKd"]
-      @bank_code     = branch["bKd"]
-      @city_code     = branch["sIlKd"]
-      @city          = branch["sIlAd"]
-      @district_code = branch["sIlcKd"]
-      @district      = branch["sIlcAd"]
-      @phone         = branch["tlf"]
+    def initialize(branch_params)
+      @name          = branch_params['sAd']
+      @code          = branch_params['sKd']
+      @bank_code     = branch_params['bKd']
+      @city_code     = branch_params['sIlKd']
+      @city          = branch_params['sIlAd']
+      @district_code = branch_params['sIlcKd']
+      @district      = branch_params['sIlcAd']
+      @phone         = branch_params['tlf']
     end
   end
 end

data/lib/turkish_banks/turkish_banks.rb

@@ -0,0 +1,25 @@
+module TurkishBanks
+  class BankNotFoundError < StandardError
+    def message
+      'Banka bulunamadı.'
+    end
+  end
+
+  BANKS_URL = 'http://eftemkt.tcmb.gov.tr/bankasubelistesi/bankaSubeTumListe.xml'.freeze
+  DOC = Nokogiri
+        .XML(::OpenURI.open_uri(BANKS_URL), nil, 'UTF-8')
+        .remove_namespaces!.freeze
+  LAST_UPDATE = DOC.at_xpath('//bankaSubeTumListe')['tarih'].freeze
+
+  def self.get_bank_params(bank_name)
+    node = DOC.at_xpath("//banka[bAd= '#{bank_name.upcase(:turkic)}']")
+    raise BankNotFoundError if node.nil?
+
+    Hash.from_xml(node.to_s)['banka']
+  end
+
+  def self.banks
+    nodes = DOC.xpath('//banka')
+    nodes.each.map { |node| Hash.from_xml(node.to_s)['banka'] }
+  end
+end

data/lib/turkish_banks/version.rb

@@ -1,3 +1,3 @@
 module TurkishBanks
-  VERSION = "0.6.0"
+  VERSION = "1.0.0"
 end

data/turkish_banks.gemspec

@@ -24,7 +24,7 @@ Gem::Specification.new do |spec|
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ["lib"]
 
-  spec.add_development_dependency "activesupport", "~> 6.0.2.2"
+  spec.add_development_dependency "activesupport", ">= 6.0.3.1"
   spec.add_development_dependency "bundler", "~> 2.1.4"
   spec.add_development_dependency "nokogiri", "~> 1.10.9"
   spec.add_development_dependency "rake", "~> 13.0.0"

metadata

@@ -1,29 +1,29 @@
 --- !ruby/object:Gem::Specification
 name: turkish_banks
 version: !ruby/object:Gem::Version
-  version: 0.6.0
+  version: 1.0.0
 platform: ruby
 authors:
 - Ender Ahmet Yurt
-autorequire: 
+autorequire:
 bindir: exe
 cert_chain: []
-date: 2020-04-24 00:00:00.000000000 Z
+date: 2020-11-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 6.0.2.2
+        version: 6.0.3.1
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 6.0.2.2
+        version: 6.0.3.1
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -86,14 +86,14 @@ files:
 - lib/turkish_banks.rb
 - lib/turkish_banks/bank.rb
 - lib/turkish_banks/branch.rb
-- lib/turkish_banks/turkish_bank.rb
+- lib/turkish_banks/turkish_banks.rb
 - lib/turkish_banks/version.rb
 - turkish_banks.gemspec
 homepage: https://github.com/enderahmetyurt/turkish_banks
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -108,8 +108,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.2
-signing_key: 
+rubygems_version: 3.1.4
+signing_key:
 specification_version: 4
 summary: Fetch Turkish Banks and their branches.
 test_files: []

data/lib/turkish_banks/turkish_bank.rb

@@ -1,39 +0,0 @@
-module TurkishBanks
-  class TurkishBank
-    attr_accessor :last_update_date, :banks
-
-    BANKS_URL = "http://eftemkt.tcmb.gov.tr/bankasubelistesi/bankaSubeTumListe.xml".freeze
-
-    def initialize
-      doc = Nokogiri.XML(::OpenURI.open_uri(BANKS_URL), nil, 'UTF-8')
-      doc.remove_namespaces!
-      response          = Hash.from_xml(doc.to_s)
-      @last_update_date = response["bankaSubeTumListe"]["tarih"]
-      @banks            = response["bankaSubeTumListe"]["bankaSubeleri"]
-    end
-
-    def get_information_of(bank_name)
-      return "#{bank_name} isminde bir banka bulunamadı." if get_bank(bank_name).empty?
-
-      bank = get_bank(bank_name).first["banka"]
-      TurkishBanks::Bank.new bank
-    end
-
-    def get_branches_of(bank_name)
-      return "#{bank_name} isminde bir bankaya ait şube bilgisi bulunamadı." if get_bank(bank_name).empty?
-
-      bank_branches = []
-      branches = get_bank(bank_name).first["sube"]
-      branches.each do |branch|
-        bank_branches << TurkishBanks::Branch.new(branch)
-      end
-      bank_branches
-    end
-
-    private
-
-    def get_bank(bank_name)
-      @banks.select {|b| b["banka"]["bAd"] == bank_name.upcase(:turkic)}
-    end
-  end
-end