turbot-runner 0.2.19 → 0.2.20

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 76081147102e8b5f21227dc822dc458834855a30
-  data.tar.gz: f3ea3e8235ab0ab19a803a5bc08092aa9c427985
+  metadata.gz: f570fdd4142ee231aac55e792fc748ddbaf19717
+  data.tar.gz: 3f8119df620df1c2e660f2a5be093cae3a0fe982
 SHA512:
-  metadata.gz: baa178b3a0ac7d41910840214cbdd0bd26faddb2888682f5aa3f103659795765cf10cab4279c940f87e352bfbcafa01d00b7aeec53ea54e6fe7ca08be134a3eb
-  data.tar.gz: 95b00b90422db03b7a88e639397624f1a8b74f83ec94960862251f120483f52acc012f16a3dd76da9ad45f91f7941d229ecdb5c07a786cc4653bdf3a0c40156d
+  metadata.gz: 941d062afee4a4cf7d92557b2c7434f91c5acf0c85861bb1936b6415f206d292b19549d622a5003291176efde2769a06bf0764ef975c206fe09d58e1af12dae4
+  data.tar.gz: 9a0a15ce2bfe5e6101082da35f3a7c084a711a218f725353f6412fcea773b37b873ee80ce597107a184863d1bf6f4c58818f68552127428eb260bc268e557e48

data/lib/turbot_runner/processor.rb

@@ -18,12 +18,9 @@ module TurbotRunner
         else
           record = Openc::JsonSchema.convert_dates(schema_path, JSON.parse(line))
 
-          # TODO Document why we aren't passing retrieved_at to the validator.
-          record_to_validate = record.select {|k, v| k != 'retrieved_at'}
-
           error_message = Validator.validate(
             @data_type,
-            record_to_validate,
+            record,
             @identifying_fields,
             @seen_uids
           )

data/lib/turbot_runner/version.rb

@@ -1,3 +1,3 @@
 module TurbotRunner
-  VERSION = '0.2.19'
+  VERSION = '0.2.20'
 end

data/schema/schemas/financial-payment-schema.json

@@ -21,6 +21,10 @@
         "$ref": "includes/financial-payment-data-object.json"
       },
       "additionalItems": false
+    },
+    "retrieved_at": {
+      "type": "string",
+      "format": "date"
     }
   },
   "additionalProperties": false,

data/schema/schemas/register-entry-schema.json

@@ -7,9 +7,13 @@
     },
     "register": {"$ref": "#/definitions/register"},
     "identifier": {
-      "description": "A unique identifier given to the register entry by the register. In some cases – e.g. Charity Register for England & Wales, these identifiers (in this case known as the 'charity number') are used outside of the context of the register",
+      "description": "A unique identifier used by the register to identifier the register entry. In some cases – e.g. Charity Register for England & Wales, these identifiers (in this case known as the 'charity number') are used outside of the context of the register",
       "type": "string"
     },
+    "identifier_system_code": {
+      "type": "string",
+      "description": "A code representing the identifier scheme. Some examples of this are us_fein (US Federal tax number), us_sec_cik (US Securities and Exchange Commission CIK), uk_ew_cc (Charity Commission of England & Wales), lei (Global Legal Entity Identifier System). Not all registers have identifier_systems, and some registers may use identifiers from other identifiers systems (e.g. the EBA is planning on using LEI in its bank register)"
+    },
     "start_date": {
       "description": "The date the register entry started, e.g. the date the entity was registered from, or appeared on the register the first time",
       "type": "string",

data/schema/schemas/simple-financial-payment-schema.json

@@ -54,6 +54,10 @@
       "description": "The jurisdiction of the body that made the payment, eg. UK, France, Delaware, Manchester",
       "type": "string"
     },
+    "retrieved_at": {
+      "type": "string",
+      "format": "date"
+    },
     "more_details_url": {
       "description": "A url from which more details can be seen (may be the same as the source_url)",
       "type": [

data/schema/schemas/simple-licence-schema.json

@@ -63,6 +63,10 @@
       "description": "Status of the licence",
       "type": "string"
     },
+    "retrieved_at": {
+      "type": "string",
+      "format": "date"
+    },
     "category": {
       "description": "Category of licence",
       "type": "string",

data/schema/schemas/simple-subsidiary-schema.json

@@ -31,6 +31,10 @@
         "LOW"
       ]
     },
+    "retrieved_at": {
+      "type": "string",
+      "format": "date"
+    },
     "parent_name": {
       "description": "Name of the controlling company",
       "type": "string",

data/schema/schemas/subsidiary-relationship-schema.json

@@ -21,6 +21,10 @@
     "end_date_type": {
       "type": "string"
     },
+    "retrieved_at": {
+      "type": "string",
+      "format": "date"
+    },
     "source_jurisdiction": {
       "description": "Jurisdiction of the source of the data",
       "type": "string"

data/spec/lib/processor_spec.rb

@@ -126,25 +126,6 @@ describe TurbotRunner::Processor do
         expect(@handler).to receive(:handle_valid_record).with(converted_record, @data_type)
         @processor.process(record.to_json)
       end
-
-      it 'does not pass retrieved_at to validator' do
-        record = {
-          'sample_date' => '2014-06-01',
-          'retrieved_at' => '2014-06-01 12:34:56 +0000',
-          'source_url' => 'http://example.com/123',
-          'number' => 123
-        }
-
-        expected_record_to_validate = {
-          'sample_date' => '2014-06-01',
-          'source_url' => 'http://example.com/123',
-          'number' => 123
-        }
-
-        expect(TurbotRunner::Validator).to receive(:validate).
-          with('primary data', expected_record_to_validate, ['number'], Set.new)
-        @processor.process(record.to_json)
-      end
     end
 
     it 'can handle schemas with $refs' do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: turbot-runner
 version: !ruby/object:Gem::Version
-  version: 0.2.19
+  version: 0.2.20
 platform: ruby
 authors:
 - OpenCorporates
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-03-24 00:00:00.000000000 Z
+date: 2016-03-31 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -226,3 +226,4 @@ signing_key:
 specification_version: 4
 summary: Utilities for running bots with Turbot
 test_files: []
+has_rdoc: