turbolinks_render 0.9.11 → 0.9.12

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 60f02af004bd119d0d38ee2678d8128b93f1e6756c641c60972f7707e755593d
-  data.tar.gz: cee50736d7790b5f9e795c4ad2421274cc3020c1b47e5ed56e48781ccb81784e
+  metadata.gz: 82792bd10eab5f8fbd096ae4ad70300046a2e8f6ebe86a7fddbf46485999ddc6
+  data.tar.gz: 5689e5ad06acacfd115401f31d22af1a38fcb0436ed499783fee1409fe967bb7
 SHA512:
-  metadata.gz: 3dd95e4590be8d63d6c0b57ba1ee0199d5d222537a3fb623379774ff433b6bbfd2aeb56a5ad7a1e9d063431a4c3cd2450bc9630ea014b6e9274eb1f50250d771
-  data.tar.gz: f31224ef7f37349d795982627ad50bb9902eebef345c62afa3e0f8210f31b16e2ae8e313fef79a691e67a03dc0814a8a007a3b4ff700d98316ea160af7435d2e
+  metadata.gz: 3dce7eede742f719282d4103ed573b6fa97f05d7499c9a0dd8ea8173c0b0813762336a670f444430984ba84c1b73cbba0693c11f1b24d29a221b006ee113badf
+  data.tar.gz: d9cfc2681b82792270646001468f60fa77657f5891bb7ce1b12633effe65f711ee74872a0ba2d4ab2ee67f72b252ff57bc865feb5aa8b6ed09f58b0969aec6d1

data/README.md

@@ -53,13 +53,18 @@ In this case, to use turbolinks you should write:
 render turbolinks: true
 ```
 
+## Implementation notes
+
+- It configures a rack middleware that intercept requests and modify responses when the expected conditions are met.
+- It uses some internal Turbolinks classes to perform the rendering. This makes the DOM-update logic very smart but it could introduce problems with future Turbolink versions , since this does not belong to its public API. I'll do my best to keep things up to date.
+
 ## Example 
 
 An [example](https://github.com/jorgemanrubia/rails-form-validations-example) and an [explanatory blog post](https://www.jorgemanrubia.com/2019/02/16/form-validations-with-html5-and-modern-rails/) are also available.
 
 ## Credits
 
-- [Implementation based on this idea by @nerdcave](https://github.com/turbolinks/turbolinks/issues/85#issuecomment-298347900).  
+- Original implementation based on [this idea by @nerdcave](https://github.com/turbolinks/turbolinks/issues/85#issuecomment-298347900).
 
 ## License
 The gem is available as open source under the terms of the [MIT License](https://opensource.org/licenses/MIT).

data/lib/turbolinks_render/middleware.rb

@@ -12,7 +12,7 @@ module TurbolinksRender
 
     Response = Struct.new(:status, :headers, :response) do
       def candidate_for_turbolinks?
-        html_response?
+        html_response? && !empty?
       end
 
       def turbolinks_body
@@ -21,14 +21,21 @@ module TurbolinksRender
 
       private
 
+      def empty?
+        body.blank?
+      end
+
       def html_response?
         headers['Content-Type'] =~ /text\/html/
       end
 
       def body
-        body = ''
-        response.each {|part| body << part}
-        body
+        @body ||= begin
+          body = ''
+          # Response does not have to be an Enumerable. It just has to respond to #each according to Rack spec
+          response.each {|part| body << part}
+          body
+        end
       end
 
       def js_code_to_render_html(html)

data/lib/turbolinks_render/version.rb

@@ -1,3 +1,3 @@
 module TurbolinksRender
-  VERSION = '0.9.11'
+  VERSION = '0.9.12'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: turbolinks_render
 version: !ruby/object:Gem::Version
-  version: 0.9.11
+  version: 0.9.12
 platform: ruby
 authors:
 - Jorge Manrubia
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-02-25 00:00:00.000000000 Z
+date: 2019-02-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails