turbolinks-form 0.0.7 → 0.0.8

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 68b295d51c1948564055c96aa9633189b406fe99
-  data.tar.gz: a0f9a39e4266b8677eca99642688490115dd9ae3
+  metadata.gz: 84fcc12adbcab8aa0ea501f1414779cc1280316b
+  data.tar.gz: 9f15476b1564cf520839ef954466dd5f9759ef16
 SHA512:
-  metadata.gz: 48b377206054822b6e8e9917715a7debd49d0b85846d67fb50c835adc049a47dd5cb380ae8715d5bfdf8b988d10c433199bd02d74142c5528f9c4659297e8635
-  data.tar.gz: e730d8f0d459c64082dd184a4941d37b5c9817d703fcf827b5fc5b891b7dcf16bcb308a515b4bbefa00e1df952fcc1fc667056d625bc3831395b93cf8047136d
+  metadata.gz: c901c6dd2871e074c77b9e877b6bea65105da49717c9713568505942ce0ef20ed7605b8e7dd8a524c8910c17f7fb87b57706d071fc894bb8a0adea11b4b33c0d
+  data.tar.gz: 61b32ad2e7578b9c06572807b4f6cc52fff3fb06c1bfb8d771032520396f71b3bdd900979701462782453b91095a1ccf3639db1560474bb9060a2d50c68d710a

data/app/assets/javascripts/turbolinks-form-core.js

@@ -19,7 +19,7 @@
 
 var TurbolinksForm = function(){};
 
-TurbolinksForm.handleResponse = function(response) {
+TurbolinksForm.handleResponse = function(response, renderingError) {
   // parses response
   var newDom = new DOMParser().parseFromString(response.responseText, "text/html");
 
@@ -41,6 +41,14 @@ TurbolinksForm.handleResponse = function(response) {
 
   // console.log('before-render')
 
+  // replaces whole head if rendering an error page. Useful when handling 500 error, since applications
+  // usually have a whole different set of styles for this page. This is consistent with Turbolinks.
+  if (renderingError) {
+    // head replacement doesn't work the same way as body replacement. We must use the replaceChild()
+    // function for it to work effectively
+    document.documentElement.replaceChild(newDom.head, document.head);
+  }
+
   // Removes/saves all script tags contents.
   // Most browsers don't run the new <script> tags when we replace the page body,
   // but some do (like PhantomJS). So we clear all script tags to ensure nothing
@@ -55,7 +63,7 @@ TurbolinksForm.handleResponse = function(response) {
 
   // if there is no target, replaces whole body
   var target;
-  if (!response.getResponseHeader('turbolinks-form-render-target')) {
+  if (!response.getResponseHeader('turbolinks-form-render-target') || renderingError) {
     document.body = newDom.body;
     target = document.body;
   } else {
@@ -91,22 +99,33 @@ TurbolinksForm.handleResponse = function(response) {
 //  1) HTTP status code is 422 unprocessable_entity
 //  2) Response has the 'turbolinks-form-render' header
 //
-// PS: it is also activated on errors with code 500, so that we can know the
+// PS: it is also activated on errors with code 500 or 404, so that we can know the
 //     error is happening and not that the site is unresponsive
 $(document).on("ajax:error", function(e, response) {
   // dispatches turbolinks event
   Turbolinks.dispatch('turbolinks:request-end', {data: {xhr: response}});
 
-  var isError500 = (response.status == 500)
+  // handles form error (replaces body/target only, does not touch head)
   var isFormErrorResponse = (response.status == 422 && response.getResponseHeader('turbolinks-form-render'));
-  if (isError500 || isFormErrorResponse) {
+  if (isFormErrorResponse) {
     TurbolinksForm.handleResponse(response);
+    return;
+  }
+
+  // replaces whole body and whole head when a true error occurs
+  var isError500 = (response.status == 500)
+  var isError404 = (response.status == 404)
+  if (isError500 || isError404) {
+    TurbolinksForm.handleResponse(response, true);
+    return;
   }
 });
 
 // This code is only activated if:
 //  1) HTTP status code is 200
 //  2) Response has 'turbolinks-form-render' header and 'turbolinks-form-render-when-success' header
+//
+// This handling is useful when we dont want a redirect after a successful submit
 $(document).on("ajax:success", function(e, data, status, response) {
   // dispatches turbolinks event
   Turbolinks.dispatch('turbolinks:request-end', {data: {xhr: response}});

data/lib/turbolinks/form/version.rb

@@ -1,5 +1,5 @@
 module Turbolinks
   module Form
-    VERSION = '0.0.7'
+    VERSION = '0.0.8'
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: turbolinks-form
 version: !ruby/object:Gem::Version
-  version: 0.0.7
+  version: 0.0.8
 platform: ruby
 authors:
 - Henrique Gubert
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-04-24 00:00:00.000000000 Z
+date: 2019-06-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails