tunemygc 1.0.35 → 1.0.36

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: dee917a9ec1d9d1433370df607a9fffebf3770c2
-  data.tar.gz: 417022d4328e4efe72d6bffac93b57890288b5a8
+  metadata.gz: 9efea5ec786e2f04a13f2a60b185badf347f8a30
+  data.tar.gz: 10136f7a07a6b22164280a6c21f14ef22a6ea3c4
 SHA512:
-  metadata.gz: 57b3e42ca8b6274972d1cd2dfa47fb20d100497d0238293b45589d83a2549fbcba234d8cec0d0906060922c8ad3c2938b4eaf6ba473a3630072a5dd9936ae7e7
-  data.tar.gz: be9de035273d60d524df9b1e57e5e81a5dbe4e00a572d4ae75109333627db574159541aad560e1fa219665e588eda613ecea81c325a5f5b76a39f4bb93458732
+  metadata.gz: 648b160d4a42e29716007b54ae1ddfc38c41e2d6d10aa4a13d4c5d44478a6d567cf84131fb4c7f57c01378381d8df0ebadb7121d863976bc72d882216f971e4d
+  data.tar.gz: ae263f9109643864d4271cf530e9cfdc8e078895cb668bc53ed140d8f1e7f0d271144113e8b51c05dddbdcb0c5253870c5c96ae93e57cb3caf0cb184208f1163

data/README.md

@@ -52,7 +52,7 @@ We require a valid email address as a canonical reference for tuner tokens for y
 For the above command sequences, to sample your app or script for tuning, run (inject `RUBY_GC_TOKEN` and `RUBY_GC_TUNE` to your env):
 
 ``` sh
-RUBY_GC_TOKEN=08de9e8822c847244b31290cedfc1d51 RUBY_GC_TUNE=1 bundle exec rails s
+RUBY_GC_TOKEN=08de9e8822c847244b31290cedfc1d51 RUBY_GC_TUNE=200 bundle exec rails s
 ```
 
 And after some profiling requests, when the process terminates, you can visit the given report URL for a config recommendation and some further insights:
@@ -88,14 +88,14 @@ $ bundle exec tunemygc -r lourens@bearmetal.eu
 Application registered. Use RUBY_GC_TOKEN=08de9e8822c847244b31290cedfc1d51 in your environment.
 ```
 
-* `RUBY_GC_TUNE=1`
+* `RUBY_GC_TUNE=200`
 
-Enables the interposer for taking a few lightweight snapshots of Rails requests and submitting them to `tunemygc.com`. Without this environment variable set, it won't interpose itself.
+Enables the interposer and controls it's lifetime for sampling processing. It takes a few lightweight snapshots and submits them to `tunemygc.com`. A value of `200` implies `200` units of work - Rails requests, tests, background jobs etc. Without this environment variable set, it won't interpose itself. A good minimum ballpark sample set would be 200.
 
 For the above command sequences, to sample a Rails app for tuning, run:
 
 ``` sh
-RUBY_GC_TOKEN=08de9e8822c847244b31290cedfc1d51 RUBY_GC_TUNE=1 bundle exec rails s
+RUBY_GC_TOKEN=08de9e8822c847244b31290cedfc1d51 RUBY_GC_TUNE=200 bundle exec rails s
 ```
 
 And after some profiling requests, when the process terminates, you can visit the given report URL for a config recommendation and some further insights:
@@ -112,18 +112,6 @@ And after some profiling requests, when the process terminates, you can visit th
 
 Defines what type of processing you would like to sample for GC activity. An Action Controller spy is the default, but [ActiveJob](https://github.com/rails/rails/tree/master/activejob), [minitest](https://github.com/seattlerb/minitest) and [rspec](http://rspec.info) are also supported as experimental features.
 
-* `RUBY_GC_TUNE_REQUESTS=x` (a numeric value eg. `200`)
-
-Controls the interposer lifetime for sampling Rails requests. It will enable itself, then remove request instrumentation after the specified number of requests. A good minimum ballpark sample set would be 200.
-
-* `RUBY_GC_TUNE_JOBS=x` (a numeric value eg. `200`)
-
-Controls the interposer lifetime for sampling ActiveJob jobs. It will enable itself, then remove job instrumentation after the specified number of jobs were processed. A good minimum ballpark sample set would be 200.
-
-* `RUBY_GC_TUNE_TESTS=x` (a numeric value eg. `200`)
-
-Controls the interposer lifetime for sampling a [minitest](https://github.com/seattlerb/minitest) or [rspec](http://rspec.info) based test suite. It will enable itself, then remove request instrumentation after the specified number of tests has been run. A good minimum ballpark sample set would be 200.
-
 ## How do I use this?
 
 This gem is only a lightweight agent and designed to not get in your way. It samples your application during runtime, syncs data with our web service when it terminates and we provide a report URL where you can view a suggested GC configuration and additional tips and insights.

data/lib/tunemygc/spies/action_controller.rb

@@ -50,17 +50,6 @@ module TuneMyGc
         TuneMyGc.log "uninstalled action_controller spy"
       end
 
-      def check_uninstall
-        if ENV["RUBY_GC_TUNE_REQUESTS"]
-          @limit ||= Integer(ENV["RUBY_GC_TUNE_REQUESTS"])
-          @processed += 1
-          if @processed == @limit
-            uninstall
-            TuneMyGc.log "kamikaze after #{@processed} of #{@limit} requests"
-          end
-        end
-      end
-
       private
       def subscription(pattern, handler)
         @subscriptions << ActiveSupport::Notifications.subscribe(pattern, handler)

data/lib/tunemygc/spies/active_job.rb

@@ -17,17 +17,6 @@ module TuneMyGc
         TuneMyGc.log "uninstalled active_job spy"
       end
 
-      def check_uninstall
-        if ENV["RUBY_GC_TUNE_JOBS"]
-          @limit ||= Integer(ENV["RUBY_GC_TUNE_JOBS"])
-          @processed += 1
-          if @processed == @limit
-            uninstall
-            TuneMyGc.log "kamikaze after #{@processed} of #{@limit} jobs"
-          end
-        end
-      end
-
       def hooks_module
         Module.new do
           def self.included(base)

data/lib/tunemygc/spies/base.rb

@@ -17,7 +17,14 @@ module TuneMyGc
       end
 
       def check_uninstall
-        raise NotImplementedError
+        if ENV["RUBY_GC_TUNE"]
+          @limit ||= Integer(ENV["RUBY_GC_TUNE"])
+          @processed += 1
+          if @processed == @limit
+            uninstall
+            TuneMyGc.log "kamikaze after #{@processed} of #{@limit} units of work"
+          end
+        end
       end
     end
   end

data/lib/tunemygc/spies/manual.rb

@@ -10,9 +10,6 @@ module TuneMyGc
       def uninstall
         TuneMyGc.log "uninstalled manual spy"
       end
-
-      def check_uninstall
-      end
     end
   end
 end

data/lib/tunemygc/spies/minitest.rb

@@ -17,17 +17,6 @@ module TuneMyGc
         TuneMyGc.log "uninstalled minitest spy"
       end
 
-      def check_uninstall
-        if ENV["RUBY_GC_TUNE_TESTS"]
-          @limit ||= Integer(ENV["RUBY_GC_TUNE_TESTS"])
-          @processed += 1
-          if @processed == @limit
-            uninstall
-            TuneMyGc.log "kamikaze after #{@processed} of #{@limit} tests"
-          end
-        end
-      end
-
       def hooks_module
         Module.new do
           def before_setup

data/lib/tunemygc/spies/rspec.rb

@@ -21,17 +21,6 @@ module TuneMyGc
         TuneMyGc.log "uninstalled rspec spy"
       end
 
-      def check_uninstall
-        if ENV["RUBY_GC_TUNE_TESTS"]
-          @limit ||= Integer(ENV["RUBY_GC_TUNE_TESTS"])
-          @processed += 1
-          if @processed == @limit
-            uninstall
-            TuneMyGc.log "kamikaze after #{@processed} of #{@limit} tests"
-          end
-        end
-      end
-
       def hooks_module
         Module.new do
           RSpec.configure do |c|

data/lib/tunemygc/version.rb

@@ -1,5 +1,5 @@
 # encoding: utf-8
 
 module TuneMyGc
-  VERSION = "1.0.35"
+  VERSION = "1.0.36"
 end

data/test/test_action_controller_interposer.rb

@@ -56,7 +56,7 @@ class TestActionControllerInterposer < TuneMyGcTestCase
 
     assert_equal 2, interposer.spy.subscriptions.size
 
-    ENV["RUBY_GC_TUNE_REQUESTS"] = "2"
+    ENV["RUBY_GC_TUNE"] = "2"
 
     process_tunemygc_request
     assert_equal 2, interposer.spy.subscriptions.size
@@ -75,7 +75,7 @@ class TestActionControllerInterposer < TuneMyGcTestCase
 
     interposer.uninstall
   ensure
-    ENV.delete("RUBY_GC_TUNE_REQUESTS")
+    ENV["RUBY_GC_TUNE"] = "1"
   end
 
   def process_tunemygc_request(path = '/test')

data/test/test_activejob_interposer.rb

@@ -63,7 +63,7 @@ class TestActiveJobInterposer < TuneMyGcTestCase
     interposer.install
     TuneMyGc.interposer.on_initialized
 
-    ENV["RUBY_GC_TUNE_JOBS"] = "2"
+    ENV["RUBY_GC_TUNE"] = "2"
 
     run_tunemygc_job
     run_tunemygc_job
@@ -80,7 +80,7 @@ class TestActiveJobInterposer < TuneMyGcTestCase
 
     interposer.uninstall
   ensure
-    ENV.delete("RUBY_GC_TUNE_TESTS")
+    ENV["RUBY_GC_TUNE"] = "1"
   end
 
   def run_tunemygc_job

data/test/test_minitest_interposer.rb

@@ -67,7 +67,7 @@ class TestMinitestInterposer < TuneMyGcTestCase
     interposer.install
     TuneMyGc.interposer.on_initialized
 
-    ENV["RUBY_GC_TUNE_TESTS"] = "2"
+    ENV["RUBY_GC_TUNE"] = "2"
 
     run_tunemygc_test
     run_tunemygc_test
@@ -84,7 +84,7 @@ class TestMinitestInterposer < TuneMyGcTestCase
 
     interposer.uninstall
   ensure
-    ENV.delete("RUBY_GC_TUNE_TESTS")
+    ENV["RUBY_GC_TUNE"] = "1"
   end
 
   def run_tunemygc_test

data/tunemygc.gemspec

@@ -34,7 +34,7 @@ Gem::Specification.new do |s|
 
   Then sample your Rails app for tuning:
 
-  $ RUBY_GC_TOKEN=08de9e8822c847244b31290cedfc1d32 RUBY_GC_TUNE=1 bundle exec rails s
+  $ RUBY_GC_TOKEN=08de9e8822c847244b31290cedfc1d32 RUBY_GC_TUNE=200 bundle exec rails s
 
   We require a valid email address as a canonical reference for tuner tokens for your applications.
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: tunemygc
 version: !ruby/object:Gem::Version
-  version: 1.0.35
+  version: 1.0.36
 platform: ruby
 authors:
 - Bear Metal
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-03-10 00:00:00.000000000 Z
+date: 2015-03-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: certified
@@ -180,7 +180,7 @@ post_install_message: |2
 
     Then sample your Rails app for tuning:
 
-    $ RUBY_GC_TOKEN=08de9e8822c847244b31290cedfc1d32 RUBY_GC_TUNE=1 bundle exec rails s
+    $ RUBY_GC_TOKEN=08de9e8822c847244b31290cedfc1d32 RUBY_GC_TUNE=200 bundle exec rails s
 
     We require a valid email address as a canonical reference for tuner tokens for your applications.