tunable 0.0.3 → 0.0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 2a8d2bbef77fbf42971cd338f96724a7a7f12fed
-  data.tar.gz: 183a44bcb7404f87d161c62ccf0e2ea8447a8f63
+SHA256:
+  metadata.gz: f225cd943a46e53efac5f09ab990d51e4fd27e593f682ebeca3b63801ebbf218
+  data.tar.gz: 7f7ada6810840be255a3092d8373edb56009dc39bc3ca272b1bcec7fabdb8731
 SHA512:
-  metadata.gz: cb42447896039571c0bdb446bcf494d1805d79e6b9d28abaf52775a1b72f4185ea95087805ef2ec2a8157498b8fdefb3ce77cdc303f32c5db067c8df0d9f727f
-  data.tar.gz: a54821f4d0bb61710eeba8487c318eda54a661d11f9c148455918dbea0f7e3580eb30f900b0ffcb3e461c17ed96eb2526ebbb1ea511708a124234b6eb1f27d4a
+  metadata.gz: 9a8cbc09565c8b2d0aa675fde53896bc684875bbedab4c49d3c8c4f442c97b7f5249db92492fdc0d91990cede6ab78c61dcaf920f29957adc33443ebae62416e
+  data.tar.gz: e74e60a6d936dac6c23f5aab964011801eab15f01a230c381550a5d9df1bce6a1bd7f4d7bb24717a25022026b79abc581a4d432ec10a76bcb8fb452b515e125d

data/Gemfile

@@ -1,4 +1,4 @@
 source :rubygems
 
-# specified in tuktuk.gemspec
+# specified in gemspec
 gemspec

data/README.md

@@ -1,7 +1,16 @@
 Tunable
 =======
 
-A simple gem that provides scoped, pluggable settings for your AR 4+ models. Let's you keep things simple in your models by moving all customizable settings into a separate table, using a polymorphic Settings model. 
+A simple gem that provides scoped, pluggable settings for your AR 4+ models. Lets you keep things simple in your models by moving all customizable settings into a separate table, using a polymorphic Settings model. 
+
+Install
+-------
+
+In your Gemfile:
+
+```
+gem 'tunable'
+```
 
 The code
 --------
@@ -94,7 +103,6 @@ class User < ActiveRecord::Base
   main_settings :layout_type => {
     :default => lambda { |user| user.is_admin? ? 'advanced' : 'simple' }
   }
-
 end
 ```
 

data/Rakefile

@@ -1,2 +1,8 @@
 require 'bundler'
-Bundler::GemHelper.install_tasks
+Bundler::GemHelper.install_tasks
+
+begin
+  require 'rspec/core/rake_task'
+  RSpec::Core::RakeTask.new(:spec)
+rescue LoadError
+end

data/lib/tunable/model.rb

@@ -109,7 +109,7 @@ module Tunable
 
             if value === current
               # puts 'Value is same as current'
-              send('changed_attributes').delete(field) # in case we had set if before
+              @changed_attributes.delete(field) # in case we had set if before
               return
             end
 
@@ -180,14 +180,14 @@ module Tunable
 
     def queue_setting_for_update(context, key, val)
       if self.class.main_settings_list.include?(key.to_sym)
-        send('changed_attributes')[key.to_sym] = val
+        @changed_attributes[key.to_sym] = val if changed_attributes.include?(key.to_sym)
       end
       (modified_settings[context.to_sym] ||= {})[key.to_sym] = val
     end
 
     def queue_setting_for_deletion(context, key)
       if self.class.main_settings_list.include?(key)
-        send('changed_attributes')[key.to_sym] = nil
+        @changed_attributes[key.to_sym] = nil if changed_attributes.include?(key.to_sym)
       end
       (deleted_settings[context.to_sym] ||= []) << key.to_sym
     end
@@ -201,7 +201,7 @@ module Tunable
       else
         current = main_settings[field.to_sym]
         return current if current.present? or !use_default
-        
+
         if default = self.class.default_settings(:main)[field.to_sym]
           return default.is_a?(Proc) ? default.call(self) : default
         end

data/lib/tunable/normalizer.rb

@@ -8,6 +8,7 @@ module Tunable
     def normalize_value(val)
       return 1 if TRUTHIES.include?(val.to_s)
       return 0 if FALSIES.include?(val.to_s)
+      return Integer(val) if is_integer?(val)
       return if val.blank? # false.blank? returns true so this needs to go after the 0 line
       val
     end
@@ -29,6 +30,15 @@ module Tunable
       end
     end
 
+    private
+
+    def is_integer?(val)
+      Integer(val)
+      true
+    rescue
+      false
+    end
+
   end
 
 end

data/lib/tunable/version.rb

@@ -1,5 +1,5 @@
 module Tunable
 
-  VERSION = '0.0.3'
+  VERSION = '0.0.4'
 
 end

data/spec/spec_helper.rb

@@ -5,7 +5,7 @@ require 'active_record'
 require 'tunable'
 
 ActiveRecord::Base.establish_connection(
-  "adapter"  => "sqlite3", 
+  "adapter"  => "sqlite3",
   "database" => ':memory:'
 )
 

data/spec/tunable/defaults_spec.rb

@@ -100,7 +100,7 @@ describe 'defaults' do
 
           TEST_SETTINGS.each do |key, val|
             it "#{key} equals new val" do
-              @foo.main_settings[key].should == @new_settings[key]
+              @foo.main_settings[key].should === @new_settings[key]
             end
           end
 
@@ -110,7 +110,7 @@ describe 'defaults' do
 
           TEST_SETTINGS.each do |key, val|
             it "#{key} equals new val" do
-              @foo.get_main_setting(key).should == @new_settings[key]
+              @foo.get_main_setting(key).should === @new_settings[key]
             end
           end
         end

data/spec/tunable/normalization_spec.rb

@@ -18,7 +18,7 @@ describe 'normalization' do
     :numbers => {
       :number_0 => '0',
       :number_1 => '1',
-      :number_of_the_beast => '666'
+      :number_of_the_beast => 666
     },
     :onoffs => {
       :on  => 'on',
@@ -57,7 +57,7 @@ describe 'normalization' do
       sql = "select `value` from `settings` where `settable_id` = #{id} and `context` = '#{context}' and `key` = '#{key}';"
       res = ActiveRecord::Base.connection.execute(sql)
       # puts res.inspect
-      res[0]['value']
+      res[0] ? res[0]['value'] : nil
     end
 
     describe 'creating a new setting directly' do
@@ -188,10 +188,7 @@ describe 'normalization' do
     describe 'using settings relationship' do
 
       before :all do
-
-        @model.update_attributes({
-          :settings => VALUE_TYPES
-        })
+        @model.update_attributes(:settings => VALUE_TYPES)
       end
 
       after :all do
@@ -292,7 +289,7 @@ describe 'normalization' do
     end
 
     it 'keeps 666 as 666' do
-      get_value_from_model(:numbers, :number_of_the_beast).should == '666'
+      get_value_from_model(:numbers, :number_of_the_beast).should == 666
     end
 
     it 'keeps foo as foo' do

data/tunable.gemspec

@@ -14,12 +14,12 @@ Gem::Specification.new do |s|
   s.required_rubygems_version = ">= 1.3.6"
   # s.rubyforge_project         = "tunable"
 
-  s.add_runtime_dependency "activerecord", "~> 4.0.0"
-  s.add_runtime_dependency "activesupport", "~> 4.0.0"
+  s.add_runtime_dependency "activerecord", "~> 4.2.x"
+  s.add_runtime_dependency "activesupport", "~> 4.2.x"
 
-  s.add_development_dependency "bundler", '~> 1.0', '>= 1.0.0'
-  s.add_development_dependency "rspec", '~> 3.0', '>= 3.0.0'
-  s.add_development_dependency "sqlite3", '~> 1.0', '>= 1.0.0'
+  s.add_development_dependency "bundler" #, '~> 1.0', '>= 1.0.0'
+  s.add_development_dependency "rspec" #, '~> 3.0', '>= 3.0.0'
+  s.add_development_dependency "sqlite3", '< 1.4.x'
 
   s.files        = `git ls-files`.split("\n")
   s.executables  = `git ls-files`.split("\n").map{|f| f =~ /^bin\/(.*)/ ? $1 : nil}.compact

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: tunable
 version: !ruby/object:Gem::Version
-  version: 0.0.3
+  version: 0.0.4
 platform: ruby
 authors:
 - Tomás Pollak
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-09-02 00:00:00.000000000 Z
+date: 2021-03-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -16,88 +16,70 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 4.0.0
+        version: 4.2.x
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 4.0.0
+        version: 4.2.x
 - !ruby/object:Gem::Dependency
   name: activesupport
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 4.0.0
+        version: 4.2.x
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 4.0.0
+        version: 4.2.x
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.0'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.0.0
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.0'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.0.0
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '3.0'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 3.0.0
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '3.0'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 3.0.0
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: sqlite3
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.0'
-    - - ">="
+    - - "<"
       - !ruby/object:Gem::Version
-        version: 1.0.0
+        version: 1.4.x
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.0'
-    - - ">="
+    - - "<"
       - !ruby/object:Gem::Version
-        version: 1.0.0
+        version: 1.4.x
 description: Pluggable settings for your AR models.
 email:
 - tomas@forkhq.com
@@ -145,7 +127,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: 1.3.6
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.5
+rubygems_version: 2.7.3
 signing_key: 
 specification_version: 4
 summary: Pluggable settings for your AR models.