tty-spinner 0.9.1 → 0.9.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 9c407573060088eee9aae20ccbeaea7b7ab2dc6f138f60d4cb70a8f1712deb9f
-  data.tar.gz: 04fdb8167510803571249b1106d8a40c15a116940f39c8c8b01e6ac235f1bf08
+  metadata.gz: 96bd3cd66e3292a4a49e7f51dc0ddf56d06c10427a0de936bd0a963cbe66a68b
+  data.tar.gz: 5c4516265bcdce18a77c920b1311c702e16f99efc367e79e44d50ca816103027
 SHA512:
-  metadata.gz: 0a24fb01f7a56b86e7dc0c2841377313cae84554810034ead9c2648f05c9f3d86f874198afa77d40904334f1504236b8b8aab20d9f2d99ec3f48ea154d8e1ce2
-  data.tar.gz: 0bcefdfe8d58288610029c21fb1ccc04cd862ec540ed0c74cc7511be13b9c4e405586fc5165060cb5cf97287eb7ec3048432c05ea5db1bab31b1e5412ff757e6
+  metadata.gz: fcdeb174e4e46b9479c896086ee16372549e902dd16ca841ce7eb9c388034e954bf676f4af121e33fc2665b8e4c351856d34776d89d8be112593d0f7c9190b15
+  data.tar.gz: e990455d5be05a01f933d7bb6572cb28e00e4c65cccdf8af622b0f7c6edd2356c007b7c49f7a0d7bc4265ff9cca9f0599fb69449415eef03edf73559a4d80dc0

data/CHANGELOG.md

@@ -1,5 +1,10 @@
 # Change log
 
+## [v0.9.2] - 2019-12-08
+
+### Fixed
+* Fix multi spinner cursor hiding by @benklop
+
 ## [v0.9.1] - 2019-05-29
 
 ### Changed
@@ -114,6 +119,7 @@
 
 * Initial implementation and release
 
+[v0.9.2]: https://github.com/piotrmurach/tty-spinner/compare/v0.9.1...v0.9.2
 [v0.9.1]: https://github.com/piotrmurach/tty-spinner/compare/v0.9.0...v0.9.1
 [v0.9.0]: https://github.com/piotrmurach/tty-spinner/compare/v0.8.0...v0.9.0
 [v0.8.0]: https://github.com/piotrmurach/tty-spinner/compare/v0.7.0...v0.8.0

data/lib/tty/spinner.rb

@@ -372,7 +372,7 @@ module TTY
     # @api private
     def redraw_indent
       if @hide_cursor && !spinning?
-        write(ECMA_CSI + DEC_TCEM + DEC_RST)
+        write(TTY::Cursor.hide)
       end
 
       write("", false)

data/lib/tty/spinner/version.rb

@@ -2,6 +2,6 @@
 
 module TTY
   class Spinner
-    VERSION = '0.9.1'
+    VERSION = "0.9.2"
   end # Spinner
 end # TTY

data/spec/unit/spin_spec.rb

@@ -46,26 +46,55 @@ RSpec.describe TTY::Spinner, '#spin' do
     ].join)
   end
 
-  it "can spin and redraw indent" do
-    multi_spinner = double("MultiSpinner")
-    allow(multi_spinner).to receive(:synchronize).and_yield
-    allow(multi_spinner).to receive(:next_row).and_return(1)
-    allow(multi_spinner).to receive(:rows).and_return(1)
-    allow(multi_spinner).to receive(:line_inset).and_return("--- ")
+  context "with the cursor" do
+    before do
+      multi_spinner = double("MultiSpinner")
+      allow(multi_spinner).to receive(:synchronize).and_yield
+      allow(multi_spinner).to receive(:next_row).and_return(1)
+      allow(multi_spinner).to receive(:rows).and_return(1)
+      allow(multi_spinner).to receive(:line_inset).and_return("--- ")
 
-    spinner = TTY::Spinner.new(output: output)
-    spinner.attach_to(multi_spinner)
-    spinner.spin
-    spinner.redraw_indent
+      spinner = TTY::Spinner.new(output: output, hide_cursor: hide_cursor)
+      spinner.attach_to(multi_spinner)
+      spinner.spin
+      spinner.redraw_indent
 
-    output.rewind
-    expect(output.read).to eq([
-      "\e[1G--- |\n",
-      save,
-      "\e[1A",
-      "--- ",
-      restore,
-    ].join)
+      output.rewind
+    end
+
+    context "on" do
+      let(:hide_cursor) { false }
+
+      it "can spin and redraw indent" do
+        expect(output.read).to eq([
+          "\e[1G--- |\n",
+          save,
+          "\e[1A",
+          "--- ",
+          restore
+        ].join)
+      end
+    end
+
+    context "off" do
+      let(:hide_cursor) { true }
+
+      it "can spin and redraw indent" do
+        expect(output.read).to eq([
+          "--- ",
+          "\e[?25l\n",
+          save,
+          "\e[1A",
+          "\e[1G",
+          "--- |",
+          restore,
+          save,
+          "\e[1A",
+          "--- ",
+          restore
+        ].join)
+      end
+    end
   end
 
   it "spins with many threads" do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: tty-spinner
 version: !ruby/object:Gem::Version
-  version: 0.9.1
+  version: 0.9.2
 platform: ruby
 authors:
 - Piotr Murach
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-05-29 00:00:00.000000000 Z
+date: 2019-12-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: tty-cursor
@@ -152,7 +152,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.3
+rubygems_version: 3.0.6
 signing_key: 
 specification_version: 4
 summary: A terminal spinner for tasks that have non-deterministic time frame.