trouble 0.0.10 → 0.0.11

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 0566c1a9f4781b362607e40b234e90092c302d48
-  data.tar.gz: 7068f17853e2a4c21ccf64c5bdba79ce0b1dca21
+  metadata.gz: 7885087ed39042eab24b21212cebc7daaa8bb1ea
+  data.tar.gz: 3f6d91cea26e980c9b0f59107f456db15711bbab
 SHA512:
-  metadata.gz: 7769108b3ed9e1014893b67e4f65d441cd5bf8f6c175f46ef4921974f335be03f9826cf7caf6200112c438e431c747274a03a5602d2f084fcef240d4628eb65e
-  data.tar.gz: c33242b9396cb863fee041689cff9554e1fdf67aeafeeabb74650c02e20a532615ed15950464a72d82b7c4f244f4fc4e27c6c4f64c9c8bf14836e1a87f155722
+  metadata.gz: 40ecc987965b38c882c8be18731de28d2a6b32dc57ae26a6850f9b098f412758d20ba4eb26a52eafc52c72e05d0d1bbfc9a51b9f0a10ed1ed34d4cfff2b8bc96
+  data.tar.gz: 3b0708a2b5af377c89f1e00b6619bcc7ab637049a870972ef385e79b42dbc05f8c0d108915e181dde490f2a042c204ff55221e236d16611247d549090109c861

data/lib/trouble/version.rb

@@ -2,7 +2,7 @@ module Trouble
   module VERSION #:nodoc:
     MAJOR = 0
     MINOR = 0
-    TINY  = 10
+    TINY  = 11
 
     STRING = [MAJOR, MINOR, TINY].compact.join('.')
   end

data/lib/trouble.rb

@@ -19,7 +19,26 @@ module Trouble
   #
   def self.notify(exception, metadata = nil)
     exception.set_backtrace(caller) unless exception.backtrace
-    notify! exception, metadata
+    notify_error_service(exception, metadata)
+    log_in_logger(exception, metadata)
+    increment_metric
+  end
+
+  # Public: Log the error in the logger and track as metric.
+  #
+  # exception - An instance of an Exception
+  # metadata - An Hash with arbitrary additional information (optional)
+  #
+  # Examples
+  #
+  #   Trouble.log RuntimeError.new
+  #   Trouble.log RuntimeError.new, some_idea_why_it_happened: "I don't know, but try this and that."
+  #
+  # Returns nothing.
+  #
+  def self.log(exception, metadata = nil)
+    exception.set_backtrace(caller) unless exception.backtrace
+    log_in_logger(exception, metadata)
     increment_metric
   end
 
@@ -27,8 +46,7 @@ module Trouble
 
   # Internal: Dispatch the Exception to the backend(s).
   #
-  def self.notify!(exception, metadata)
-    log(exception, metadata)            if config.logger
+  def self.notify_error_service(exception, metadata)
     Bugsnag.notify(exception, metadata) if defined?(Bugsnag)
   end
   
@@ -40,8 +58,8 @@ module Trouble
 
   # Internal: Log to the current Logger.
   #
-  def self.log(exception, metadata)
-    config.logger.error "TROUBLE NOTIFICATION #{exception.inspect} at #{exception.backtrace.first} with metadata #{metadata.inspect}"
+  def self.log_in_logger(exception, metadata)
+    config.logger.error("TROUBLE LOG #{exception.inspect} at #{exception.backtrace.first} with metadata #{metadata.inspect}") if config.logger
   end
 
 end

data/spec/lib/trouble_spec.rb

@@ -38,15 +38,32 @@ describe Trouble do
         Bugsnag.stub!(:notify)
       end
 
-      describe '.notify' do
-        it 'uses Bugsnag as notification backend' do
-          Bugsnag.should_receive(:notify).with(exception, metadata)
-          trouble.notify exception, metadata
-        end
+      it 'uses Bugsnag as notification backend' do
+        Bugsnag.should_receive(:notify).with(exception, metadata)
+        trouble.notify exception, metadata
       end
     end
   end
 
+  describe '.log' do
+
+    it 'does not notify the error service' do
+      Bugsnag.should_not_receive(:notify)
+      trouble.log exception, metadata
+    end
+
+    it 'increments the metric' do
+      trouble.should_receive(:increment_metric)
+      trouble.log exception, metadata
+    end
+
+    it 'logs with the configured logger' do
+      trouble.config.logger = logger
+      trouble.config.logger.should_receive(:error)
+      trouble.log exception, metadata
+    end
+  end
+
   describe '.config' do
     before do
       Trouble.reset!

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: trouble
 version: !ruby/object:Gem::Version
-  version: 0.0.10
+  version: 0.0.11
 platform: ruby
 authors:
 - bukowskis
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-03-05 00:00:00.000000000 Z
+date: 2015-03-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
@@ -95,3 +95,4 @@ signing_key:
 specification_version: 4
 summary: A generic abstraction layer for reporting errors and Exceptions.
 test_files: []
+has_rdoc: