tron 1.2.0 → 2.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 0231e5a13e707acc3ec83ffc50af2cb846b01c31ba8e2bb9fc105e78d30bd60e
-  data.tar.gz: b3ab4cd46c20a71bfc2673345f5da04ca0a388e2141c259387976952ddd7c983
+  metadata.gz: d3d033d6fa697cd4da7d443028e7ca891676266f8e41ecf00be057d52e84e0e0
+  data.tar.gz: 222f4a27b2acd1f887ee5deeb6e41b475f45c027c82663174129d7d83db6e5f5
 SHA512:
-  metadata.gz: 187817f794d517f5c176f2c719344485df1afaca69cd32caf4e94b271f38a6a80e9dd0f328e2368bc0762985e7acf711b1f77c47fb77621e77e65080101a084f
-  data.tar.gz: 80811f5605325a75668bdbe9e8de95f18eb481ccd094e2f4b10f6a772b4fb483c876d34c06906b42e89ad8fafffea375d1620d4a0d111e4a1d40f067f34eed04
+  metadata.gz: cbb6fe573460da64aac5a59da8148fc766dfc73152cb8f887950fd4b99e90c7e2f9c0ebabed249d44f6e5b28dc912e48506866f29d0b44a65e84a7318f9339c8
+  data.tar.gz: 497c6f228706f96d9157a9600de35af4bd2e432177ed7c5e66c6c37e10f6dc74a874467a1b8ca235066619e36a3db8bea51c390bd5e540a2ab641e1dfe5f2617

data/README.md

@@ -6,7 +6,7 @@
 
 Tron is a minimalistic combination of a [monad](https://www.morozov.is/2018/09/08/monad-laws-in-ruby.html) and [value object](https://madeintandem.com/blog/creating-value-objects-in-ruby/), implemented in [a few lines](https://github.com/halo/tron/blob/master/lib/tron.rb) of code.
 
-Return `Tron.success(:it_worked)` or `Tron.failure(:aww_too_bad)` from a method to explain why and how it succeded/failed. That returns an immutable Struct (value object) that responds to `result.success?` and `result.failure?`. 
+Return `Tron.success(:it_worked)` or `Tron.failure(:aww_too_bad)` from a method to explain why and how it succeded/failed. That returns an immutable Struct (value object) that responds to `result.success?` and `result.failure?`.
 
 The reason is accessible in `result.success #=> :it_worked`. You can add more metadata as a second argument: `Tron.failure(:nopes, error_code: 404)` which you can access like a Struct: `result.error_code #=> 404`.
 
@@ -64,13 +64,13 @@ class User
   def self.check_id_syntax(id)
     return Tron.failure(:id_missing) unless id
     return Tron.failure(:invalid_id, id: id) unless id.match /[a-f]{8}/
-    
+
     Tron.success :id_looks_good
   end
 
   def self.delete_user(id)
     user = @users[id]
-    
+
     if @users.delete id
       Tron.success :user_deleted, user: user
     else
@@ -144,6 +144,10 @@ You cannot simply test for the `false` as expected return value because it could
 
 While the code you're writing becomes slightly more verbose, that verbosity translates directly into documenation. You see immediately what each line is doing.
 
+## Upgrading from 1.x.x to 2.0.0
+
+* 1.2.0 and 2.0.0 are identical, except that all deprecations have been removed and don't work any more.
+
 ## Upgrading from 0.x.x to 1.x.x
 
 * Don't use `include Tron`, it is not useful any more. There are no subclasses you might want to access.
@@ -157,7 +161,7 @@ Tron is a complete rewrite of its predecessor [operation](https://github.com/hal
 
 ## Requirements
 
-* Ruby >= 2.3.0
+* Ruby >= 2.5.0
 
 ## Copyright
 
@@ -165,4 +169,4 @@ MIT 2015-2019 halo. See [MIT-LICENSE](http://github.com/halo/tron/blob/master/LI
 
 ## Caveats
 
-* There are no setter methods in the returned Struct, so you cannot overwrite the metadata. The values are also frozen, so you don't accidentally modify the attributes in-place. However, they are not deep-frozen, so an object may still be modified if you're ignorant.
+* There are no setter methods in the returned Struct, so you cannot overwrite the metadata. The values are also frozen, so you don't accidentally modify the attributes in-place. However, they are not deep-frozen, so an object may still be modified if you're ignorant.

data/lib/tron/version.rb

@@ -1,7 +1,7 @@
 module Tron
   module VERSION #:nodoc:
-    MAJOR = 1
-    MINOR = 2
+    MAJOR = 2
+    MINOR = 0
     TINY  = 0
     PRE = nil
 

data/lib/tron.rb

@@ -2,10 +2,6 @@
 
 require 'tron/version'
 
-require 'tron/resultable' # Legacy
-require 'tron/success' # Legacy
-require 'tron/failure' # Legacy
-
 module Tron
   def self.success(code, attributes = {}) # rubocop:disable Metrics/MethodLength, Metrics/AbcSize
     code.respond_to?(:to_sym) ||
@@ -33,13 +29,6 @@ module Tron
         nil
       end
 
-      def code
-        warn 'DEPRECATION WARNING: Calling `#code` on a Tron object is deprecated and will be removed in Tron 2.0.0. ' \
-             "Please use `#success` instead. Called from `#{caller.first}`"
-
-        success
-      end
-
       def on_success(proc = nil, &block)
         (proc || block).call self
       end
@@ -76,13 +65,6 @@ module Tron
         nil
       end
 
-      def code
-        warn 'DEPRECATION WARNING: Calling `#code` on a Tron object is deprecated and will be removed in Tron 2.0.0. ' \
-             "Please use `#failure` instead. Called from `#{caller.first}`"
-
-        failure
-      end
-
       def on_success(_ = nil)
         self
       end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: tron
 version: !ruby/object:Gem::Version
-  version: 1.2.0
+  version: 2.0.0
 platform: ruby
 authors:
 - halo
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-11-29 00:00:00.000000000 Z
+date: 2021-10-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: guard-rspec
@@ -66,6 +66,34 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: rubocop
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: rubocop-rspec
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description: General-purpose method return objects that can be chained. Think minimalistic
   value object monads. Heavily inspired by the `deterministic` gem, but much much
   more light-weight.
@@ -76,9 +104,6 @@ extra_rdoc_files: []
 files:
 - README.md
 - lib/tron.rb
-- lib/tron/failure.rb
-- lib/tron/resultable.rb
-- lib/tron/success.rb
 - lib/tron/version.rb
 homepage: https://github.com/halo/tron
 licenses:
@@ -92,7 +117,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 2.3.0
+      version: 2.5.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="

data/lib/tron/failure.rb

@@ -1,13 +0,0 @@
-module Tron
-  class Failure
-    include Resultable
-
-    def on_success(_ = nil)
-      self
-    end
-
-    def on_failure(proc = nil, &block)
-      (proc || block).call
-    end
-  end
-end

data/lib/tron/resultable.rb

@@ -1,65 +0,0 @@
-module Tron
-  module Resultable
-    attr_reader :metadata
-
-    def self.included(receiver)
-      receiver.extend ::Tron::Resultable::ClassMethods
-    end
-
-    module ClassMethods
-      # Convenience wrapper
-      def call(code, metadata = nil)
-        new code: code, metadata: metadata
-      end
-    end
-
-    def initialize(code: nil, metadata: nil)
-      @code     = code
-      @metadata = metadata
-      warn 'DEPRECATION WARNING: As of Tron 1.0.0 calls to `Tron::Success.call` and `Tron::Failure.call` are deprecated. ' \
-           'They will be removed in Tron 2.0.0. Please migrate using `Tron.success` and `Tron.failure`. ' \
-           "See github.com/halo/tron Called in:: `#{caller[2]}`"
-    end
-
-    def success?
-      is_a? ::Tron::Success
-    end
-
-    def failure?
-      is_a? ::Tron::Failure
-    end
-
-    def code
-      return if @code.to_s == ''
-
-      @code.to_s.to_sym
-    end
-
-    # Convenience Wrapper
-    def object
-      metadata[:object] || metadata['object']
-    rescue StandardError
-      nil
-    end
-
-    def meta
-      if defined? ::Hashie::Mash
-        metamash
-      else
-        metadata
-      end
-    end
-
-    private
-
-    def metamash
-      if metadata.respond_to? :each_pair
-        ::Hashie::Mash.new metadata
-      elsif metadata
-        metadata
-      else
-        ::Hashie::Mash.new
-      end
-    end
-  end
-end

data/lib/tron/success.rb

@@ -1,13 +0,0 @@
-module Tron
-  class Success
-    include Resultable
-
-    def on_success(proc = nil, &block)
-      (proc || block).call
-    end
-
-    def on_failure(_ = nil)
-      self
-    end
-  end
-end