trick_bag 0.46.0 → 0.47.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 57ae02e1d4096731aaa9594252922acc1ade8cea
-  data.tar.gz: c42a91603f217852a041a7dbaf5ee44a36c6ff29
+  metadata.gz: d01ca3cfe583081305fb5ab8275177ae10dae944
+  data.tar.gz: 53a75fcdec73d0ef74ef6c5e95d68a78661da520
 SHA512:
-  metadata.gz: 54c102e7e407cb063106c8b387731dfb8844d69580dbc97ff6dc138fa1c40dd06f8c5faa7897fb2f408b5dea9e88437a36923b442653a96ac7bcc291f3f62785
-  data.tar.gz: 8be1ece013e697c268106a184a1e66250b3bfa323e3557930f4a222b99eba7fd91313b2f74a5bb14c9a7b589155ba6863ee621f1ed29bbf4157fb85da93369b5
+  metadata.gz: 947ec282b463b2a1916ef64735bc585a1d9956c76fceebea3c0c8b0112659499a5374a7ad578837eb5d80a3c4be5f63bdf6d5cf483a189a670e10b18d93417f0
+  data.tar.gz: 098840c716d1ecab47b56f663640551d412e3dc9c304f7efec8f56c6a4759f33de0f189e8ece115e2b5a98060449d26929548798f193d364e2f7c5bc71889c19

data/RELEASE_NOTES.md

@@ -1,3 +1,8 @@
+## v0.47.0
+
+* Remove array_as_multiline_string; it's too similar to array.join("\n").
+
+
 ## v0.46.0
 
 * Add array_diff and array_as_multiline_string to Formatters.

data/lib/trick_bag/formatters/formatters.rb

@@ -123,22 +123,13 @@ module Formatters
   end
 
 
-  # Returns a string representation of the array as would be output by puts,
-  # one line per element.
-  def array_as_multiline_string(array)
-    sio = StringIO.new
-    sio.puts(array)
-    sio.string
-  end
-
-
   # Shows a visual diff of 2 arrays by comparing the string representations
   # of the arrays with one element per line.
   # @param format can be any valid Diffy option, e.g. :color
   #     see https://github.com/samg/diffy/blob/master/lib/diffy/format.rb
   def array_diff(array1, array2, format = :text)
-    string1 = array_as_multiline_string(array1)
-    string2 = array_as_multiline_string(array2)
+    string1 = array1.join("\n") + "\n"
+    string2 = array2.join("\n") + "\n"
     Diffy::Diff.new(string1, string2).to_s(format)
   end
 

data/lib/trick_bag/version.rb

@@ -1,3 +1,3 @@
 module TrickBag
-  VERSION = "0.46.0"
+  VERSION = "0.47.0"
 end

data/spec/trick_bag/formatters/formatters_spec.rb

@@ -124,29 +124,13 @@ describe Formatters do
     end
 
 
-    context 'array_as_multiline_string' do
-      specify 'string representation is correct when array is NOT empty' do
-        array = [1, 2, 3]
-        expect(Formatters.array_as_multiline_string(array)).to eq("1\n2\n3\n")
-      end
-
-      specify 'string representation is correct when array is empty' do
-        array = []
-        expect(Formatters.array_as_multiline_string(array)).to eq("")
-      end
-    end
-
-
     context 'array_diff' do
       specify 'text is correct' do
         a1 = [1, 2, 3]
         a2 = [   2, 3, 4]
-        actual_text = Formatters.array_diff(a1, a2, :color)
+        actual_text = Formatters.array_diff(a1, a2)
         expected_text = "-1\n 2\n 3\n+4\n"
         expect(actual_text).to eq(expected_text)
-        puts
-        puts actual_text
-        puts
       end
     end
   end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: trick_bag
 version: !ruby/object:Gem::Version
-  version: 0.46.0
+  version: 0.47.0
 platform: ruby
 authors:
 - Keith Bennett