trick_bag 0.35.0 → 0.36.0

data/RELEASE_NOTES.md

@@ -1,3 +1,8 @@
+## v0.36.0
+
+* Add System module w/lsof and command_available? methods.
+
+
 ## v0.35.0
 
 * Added start_pos and max_count accessors to FileLineReader.

data/lib/trick_bag/system.rb

@@ -0,0 +1,27 @@
+require 'os'
+
+module TrickBag
+
+# Convenience methods for dealing with Posix-compliant systems.
+module System
+
+  module_function
+
+  # Calls lsof to return information about all files *open by this process*.
+  # Output returned is lsof's output, but after calling split("\n") to create
+  # an array of the result strings.
+  #@param options additional options to the lsof command line, if any, defaults to ''
+  def lsof(options = '')
+    raise "Cannot be called on a non-Posix operating system." unless OS.posix?
+    raise "lsof command not found" unless command_available?('lsof')
+    `lsof #{options} -p #{Process.pid}`.split("\n")
+  end
+
+
+  def command_available?(command)
+    raise "Cannot be called on a non-Posix operating system." unless OS.posix?
+    system("which #{command} > /dev/null")
+   end
+
+end
+end

data/lib/trick_bag/version.rb

@@ -1,3 +1,3 @@
 module TrickBag
-  VERSION = "0.35.0"
+  VERSION = "0.36.0"
 end

data/spec/trick_bag/enumerables/file_line_reader_spec.rb

@@ -3,6 +3,7 @@ require 'tempfile'
 
 require_relative '../../spec_helper'
 require 'trick_bag/enumerables/file_line_reader'
+require 'trick_bag/system'
 
 module TrickBag
 module Enumerables
@@ -31,7 +32,7 @@ nbc.com
       @tempfile.unlink
     end
 
-    let(:can_run_lsof?) { OS.posix? && system('which lsof > /dev/null') }
+    let(:can_run_lsof?) { OS.posix? && System.command_available?('lsof') }
 
     subject { FileLineReader.new(@tempfile.path) }
 
@@ -96,13 +97,10 @@ nbc.com
         pending "This test can only be run on a Posix-based OS having the 'lsof' command."
       end
 
-      get_lsof_lines = -> do
-        output = `lsof -p #{Process.pid} | grep file_domain_reader_spec`
-        output.split("\n")
-      end
+      get_lsof_lines = -> { System.lsof.grep(/file_domain_reader_spec/) }
 
       reader = FileLineReader.new(@tempfile.path, 0, 1)
-      reader.each do |line|
+      reader.each do |_|  # using _ as an identifier signifies that the value is not used
         expect(get_lsof_lines.().size).to eq(1)
       end
       expect(get_lsof_lines.().size).to eq(0)
@@ -121,7 +119,6 @@ nbc.com
     specify "max_count returns the value passed to the constructor" do
       expect(FileLineReader.new(@tempfile.path, 10, 200).max_count).to eq(200)
     end
-
   end
 end
 end

data/spec/trick_bag/system_spec.rb

@@ -0,0 +1,35 @@
+require_relative '../spec_helper'
+
+require 'trick_bag/system'
+
+module TrickBag
+module System
+
+  posix_only_test = -> do
+    describe 'System' do
+
+      context "#command_available" do
+        specify 'which ls returns true' do
+          expect(System.command_available?('ls')).to be_true
+        end
+
+        specify 'which fsdfiuowqpfeqpxumwfuqiufqpiufpqwmiurqpruiiqwmxrqupruxmqowiruqmpmu returns false' do
+          expect(System.command_available?('fsdfiuowqpfeqpxumwfuqiufqpiufpqwmiurqpruiiqwmxrqupruxmqowiruqmpmu')).to be_false
+        end
+      end
+
+
+      context ".lsof" do
+        specify "returns ruby lines" do
+          lines = System.lsof
+          has_ruby_line = lines.any? { |line| /ruby/ === line }
+          expect(has_ruby_line).to be_true
+        end
+      end
+    end
+  end
+
+  posix_only_test.() if OS.posix?
+
+end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: trick_bag
 version: !ruby/object:Gem::Version
-  version: 0.35.0
+  version: 0.36.0
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-03-19 00:00:00.000000000 Z
+date: 2014-03-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -136,6 +136,7 @@ files:
 - lib/trick_bag/numeric/start_and_max.rb
 - lib/trick_bag/numeric/totals.rb
 - lib/trick_bag/operators/operators.rb
+- lib/trick_bag/system.rb
 - lib/trick_bag/timing/timing.rb
 - lib/trick_bag/validations/hash_validations.rb
 - lib/trick_bag/validations/object_validations.rb
@@ -155,6 +156,7 @@ files:
 - spec/trick_bag/numeric/start_and_max_spec.rb
 - spec/trick_bag/numeric/totals_spec.rb
 - spec/trick_bag/operators/operators_spec.rb
+- spec/trick_bag/system_spec.rb
 - spec/trick_bag/timing/timing_spec.rb
 - spec/trick_bag/validations/hashes_validations_spec.rb
 - spec/trick_bag/validations/object_validations_spec.rb
@@ -200,6 +202,7 @@ test_files:
 - spec/trick_bag/numeric/start_and_max_spec.rb
 - spec/trick_bag/numeric/totals_spec.rb
 - spec/trick_bag/operators/operators_spec.rb
+- spec/trick_bag/system_spec.rb
 - spec/trick_bag/timing/timing_spec.rb
 - spec/trick_bag/validations/hashes_validations_spec.rb
 - spec/trick_bag/validations/object_validations_spec.rb