trenni-sanitize 0.3.0 → 0.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 692099586ce2e3dfb2e1ff3911cafa0e39a22d5dac957ef4401f3fd31be32565
-  data.tar.gz: d0a4d9ff3f8e5937119f08638b188c6d7c386fa428fb3c98fe64334d8fd8e705
+  metadata.gz: af6bc3fd66dd571a303a216442d9f8abf2e51e28693da8798107bcb540f32f85
+  data.tar.gz: af2f9d45d17c77128d6ed553e6512a0e3345195c867419286ccd527435ee235f
 SHA512:
-  metadata.gz: 4668acf3447f634251f01a4b3ffef72592552ff6da12178b7201a221e25b6dc1f0f6115903201ad75532e73d6df93dda13cb8e4cb68a890e651569710700852c
-  data.tar.gz: bde8b725c3a2455b3eb762eb25036538d4a591aa77e3e6e5c30642a8680f3907fd4f429c906e893b70401b1e7b9b1616dd4153f38d7c0533dfc698351658aebe
+  metadata.gz: 24187244b0995b0a83f5fcf93d7c215514517456894b0523a3d60c51f46729993c4d1fdce35fa1ab1982fb68cc8838bfb6f532df0c73a016cd8f14c4cd0e33ae
+  data.tar.gz: cc6468c2fdaf2a2b5d396378a442a017cf3e64c75cb3fa56e26ffb21dc91e54d70adbde423c38e77ddd2b27322c591bd775c9ab0197412c42836a022766a03ff

data/README.md

@@ -2,7 +2,7 @@
 
 Sanitize markup by adding, changing or removing tags, using the [trenni] stream processor (which has a naive C implementation).
 
-[![Build Status](https://secure.travis-ci.org/ioquatix/trenni-sanitize.svg)](http://travis-ci.org/ioquatix/trenni-sanitize)
+[![Build Status](https://travis-ci.com/ioquatix/trenni-sanitize.svg)](https://travis-ci.com/ioquatix/trenni-sanitize)
 [![Code Climate](https://codeclimate.com/github/ioquatix/trenni-sanitize.svg)](https://codeclimate.com/github/ioquatix/trenni-sanitize)
 [![Coverage Status](https://coveralls.io/repos/ioquatix/trenni-sanitize/badge.svg)](https://coveralls.io/r/ioquatix/trenni-sanitize)
 

data/Rakefile

@@ -4,7 +4,7 @@ require "rspec/core/rake_task"
 # Load all rake tasks:
 import(*Dir.glob('tasks/**/*.rake'))
 
-RSpec::Core::RakeTask.new(:test)
+RSpec::Core::RakeTask.new
 
 task :environment do
 	$LOAD_PATH.unshift File.expand_path('lib', __dir__)
@@ -16,4 +16,4 @@ task :console => :environment do
 	Pry.start
 end
 
-task :default => :test
+task :default => :spec

data/lib/trenni/sanitize/filter.rb

@@ -64,7 +64,7 @@ module Trenni
 				end
 				
 				def [] key
-					self.tag.attributes[key]
+					self.tag&.attributes[key]
 				end
 			end
 			

data/lib/trenni/sanitize/text.rb

@@ -23,7 +23,16 @@ require_relative 'filter'
 module Trenni
 	module Sanitize
 		class Text < Filter
+			CLOSING = {
+				"p" => "\n\n",
+				"div" => "\n\n",
+			}
+			
 			def filter(node)
+				if node.name == "br"
+					text("\n\n")
+				end
+				
 				if node.name == 'script'
 					node.skip!(ALL) # Skip everything including content.
 				else
@@ -31,6 +40,14 @@ module Trenni
 				end
 			end
 			
+			def close_tag(name, offset = nil)
+				super
+				
+				if value = CLOSING[name]
+					text(value)
+				end
+			end
+			
 			def doctype(string)
 			end
 			

data/lib/trenni/sanitize/version.rb

@@ -20,6 +20,6 @@
 
 module Trenni
 	module Sanitize
-		VERSION = "0.3.0"
+		VERSION = "0.4.0"
 	end
 end

data/spec/trenni/sanitize/text_spec.rb

@@ -0,0 +1,43 @@
+# Copyright, 2019, by Samuel G. D. Williams. <http://www.codeotaku.com>
+# 
+# Permission is hereby granted, free of charge, to any person obtaining a copy
+# of this software and associated documentation files (the "Software"), to deal
+# in the Software without restriction, including without limitation the rights
+# to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+# copies of the Software, and to permit persons to whom the Software is
+# furnished to do so, subject to the following conditions:
+# 
+# The above copyright notice and this permission notice shall be included in
+# all copies or substantial portions of the Software.
+# 
+# THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+# IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+# FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+# AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+# LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+# OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
+# THE SOFTWARE.
+
+require 'trenni/sanitize/text'
+
+RSpec.describe Trenni::Sanitize::Text do
+	let(:text) {"One\n\nTwo\n\nThree\n\n"}
+	
+	it "passes through plain text unchanged" do
+		fragment = described_class.parse(text)
+		
+		expect(fragment.output).to be == text
+	end
+	
+	it "should extract text" do
+		fragment = described_class.parse("<p onclick='malicious()'>Hello World</p><script>doot()</script>")
+		
+		expect(fragment.output).to be == "Hello World\n\n"
+	end
+	
+	it "replaces line breaks" do
+		fragment = described_class.parse("One<br/>Two<br/>Three")
+		
+		expect(fragment.output).to be == "One\n\nTwo\n\nThree"
+	end
+end

data/trenni-sanitize.gemspec

@@ -20,7 +20,7 @@ Gem::Specification.new do |spec|
 	spec.add_dependency "trenni", '~> 3.5'
 	
 	spec.add_development_dependency "covered"
-	spec.add_development_dependency "bundler", "~> 1.3"
+	spec.add_development_dependency "bundler"
 	spec.add_development_dependency "rspec", "~> 3.4"
 	spec.add_development_dependency "rake"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: trenni-sanitize
 version: !ruby/object:Gem::Version
-  version: 0.3.0
+  version: 0.4.0
 platform: ruby
 authors:
 - Samuel Williams
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-04-05 00:00:00.000000000 Z
+date: 2019-12-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: trenni
@@ -42,16 +42,16 @@ dependencies:
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.3'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.3'
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
@@ -89,7 +89,6 @@ extra_rdoc_files: []
 files:
 - ".gitignore"
 - ".rspec"
-- ".simplecov"
 - ".travis.yml"
 - Gemfile
 - README.md
@@ -125,7 +124,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.3
+rubygems_version: 3.0.4
 signing_key: 
 specification_version: 4
 summary: Sanitize markdown according to a set of rules.

data/.simplecov

@@ -1,9 +0,0 @@
-
-SimpleCov.start do
-	add_filter "/spec/"
-end
-
-if ENV['TRAVIS']
-	require 'coveralls'
-	Coveralls.wear!
-end