trello_lead_time 0.1.7 → 0.1.9

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 793a7111375f11cb1dac651497ddf9c28a5041a2
-  data.tar.gz: 8d1be23dc738209bf82d6d5bd68be42dbdc1cce7
+  metadata.gz: 100178c3dcb0b5bd52f4a5a64bc683472c849662
+  data.tar.gz: 71b84e248556f0cfebae87f85e1aeb50d70bfc3b
 SHA512:
-  metadata.gz: 6bcbc2ffb7825461fc3b9271feb11c99d47155f604f71264841c5358cd57835560f56ebd16accafc2750d986d171bb4d719a92174c8c00f0e0379d07a25326d3
-  data.tar.gz: 821d941a6d4865f9833ccec0682479301a674ede27766f5a059ff6cb50bcfd25fd561b9bca1360eca285e204268d0ab090a950feaad20eeb1bbdf9feacabb1af
+  metadata.gz: 9f967a9bd0757af27024af72bcf89a067082cab198d5bd93024739d09fad937b9fd756d16e1b4fce3091b4a21a4e64e2f0e900c0618f4f2961e89cc37fd9eccd
+  data.tar.gz: effe775e668e04744394dd076bc33dced219de0321e2b2a786b35a8e4d935c1fe001e0f9164f473bb6a31f795fc5697e1c2576a369b3fcd67947d7c3c690f3a1

data/lib/trello_lead_time/board.rb

@@ -23,7 +23,7 @@ module TrelloLeadTime
 
     def cards(name_of_list_with_done_cards)
       list = find_list_by_name(name_of_list_with_done_cards)
-      response = default_format
+      response = []
       return response if list.nil?
       list.done_or_closed_cards
     end

data/lib/trello_lead_time/card.rb

@@ -13,6 +13,10 @@ module TrelloLeadTime
       @trello_card.name
     end
 
+    def short_url
+      @trello_card.short_url
+    end
+
     def done?
       @timeline.done?
     end

data/lib/trello_lead_time/version.rb

@@ -1,3 +1,3 @@
 module TrelloLeadTime
-  VERSION = '0.1.7'
+  VERSION = '0.1.9'
 end

data/spec/fixtures/missing_lists.json

@@ -0,0 +1,10 @@
+      [
+        {
+          "id": "mylist_id",
+          "name": "Accepted for 2014-03"
+        },
+        {
+          "id": "44444444444",
+          "name": "Refining"
+        }
+      ]

data/spec/lib/trello_lead_time/board_spec.rb

@@ -11,6 +11,7 @@ describe TrelloLeadTime::Board do
   let(:board_id) { "myboard_id" }
   let(:board_name) { "Development Team" }
   let(:list_with_done_cards) { "Done for 2014-03" }
+  let(:list_not_found_on_board) { "Not a real list" }
   let(:list_id) { "mylist_id" }
   let(:card_id) { "mycard_id" }
 
@@ -26,6 +27,10 @@ describe TrelloLeadTime::Board do
     File.read(File.expand_path("../../../fixtures/lists.json", __FILE__))
   }
 
+  let(:missing_lists_json) {
+    File.read(File.expand_path("../../../fixtures/missing_lists.json", __FILE__))
+  }
+
   let(:cards_json) {
     File.read(File.expand_path("../../../fixtures/cards.json", __FILE__))
   }
@@ -63,7 +68,11 @@ describe TrelloLeadTime::Board do
     it "should have some cards" do
       stub_all_requests
       expect(subject.cards(list_with_done_cards).length).to eq(4)
-      puts subject.cards(list_with_done_cards)[0].cycle_time
+    end
+
+    it "should default an empty list of cards when list is not found" do
+      stub_all_requests_missing_list
+      expect(subject.cards(list_not_found_on_board).length).to eq(0)
     end
   end
 
@@ -203,6 +212,11 @@ describe TrelloLeadTime::Board do
     stub_card_requests
   end
 
+  def stub_all_requests_missing_list
+    stub_board_requests
+    stub_missing_list_requests
+  end
+
   def stub_board_requests
     stub_request(:get, "https://api.trello.com/1/organizations/wellmatch?key=#{key}&token=#{token}").
       with(headers).
@@ -223,6 +237,12 @@ describe TrelloLeadTime::Board do
       to_return(stub_returns(cards_json))
   end
 
+  def stub_missing_list_requests
+    stub_request(:get, "https://api.trello.com/1/boards/#{board_id}/lists?filter=all&key=#{key}&token=#{token}").
+      with(headers).
+      to_return(stub_returns(missing_lists_json))
+  end
+
   def stub_card_requests
     %w{1111 2222 3333 4444}.each do |card_id|
       stub_request(:get, "https://api.trello.com/1/cards/#{card_id}/actions?filter=copyCard,moveCardToBoard,createCard,updateCard:idList,updateCard:closed&key=#{key}&token=#{token}").

data/spec/lib/trello_lead_time/card_spec.rb

@@ -37,6 +37,12 @@ describe TrelloLeadTime::Card do
         to_return(:status => 200, :body => comments_json, :headers => {})
     }
 
+    describe "#short_url" do
+      it "should have a url" do
+        expect(subject.short_url).to_not be_nil
+      end
+    end
+
     describe ".done" do
       it "should be a card" do
         subject.should be_an_instance_of(TrelloLeadTime::Card)

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: trello_lead_time
 version: !ruby/object:Gem::Version
-  version: 0.1.7
+  version: 0.1.9
 platform: ruby
 authors:
 - Scott Baldwin
@@ -100,6 +100,7 @@ files:
 - spec/fixtures/labels.4444.json
 - spec/fixtures/labels.json
 - spec/fixtures/lists.json
+- spec/fixtures/missing_lists.json
 - spec/fixtures/organization.json
 - spec/lib/trello_lead_time/array_matcher_spec.rb
 - spec/lib/trello_lead_time/board_spec.rb
@@ -156,6 +157,7 @@ test_files:
 - spec/fixtures/labels.4444.json
 - spec/fixtures/labels.json
 - spec/fixtures/lists.json
+- spec/fixtures/missing_lists.json
 - spec/fixtures/organization.json
 - spec/lib/trello_lead_time/array_matcher_spec.rb
 - spec/lib/trello_lead_time/board_spec.rb