trello_lead_time 0.1.4 → 0.1.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: f4146d251bd7bc7af5b386ddb33e3c78d2db3ec8
-  data.tar.gz: 27e3c1c0d326f7fc6df00f982687caeab04280a2
+  metadata.gz: 228aa9fb04035b427fedc85d2864aef89e386de1
+  data.tar.gz: ea8fe5895b6c8d13e4bc6ded7b820fba7127a887
 SHA512:
-  metadata.gz: 22241cbba0aca85985c957dfe2878bf9bee17798e1969c15f685b31733b4fa4783b1a9a7767b70032bb07022c91b20b9c0fea6f5746d8f71291a445466e58088
-  data.tar.gz: 23187baa0d6c5e129cdc66f70bfea12fe43bb2c90e4a319dc689dcd17849af4ced92e12f48b8fbb8aeaf17be33275891eb42abc0b01094e87ab572a6daf1b797
+  metadata.gz: 43945a74d2d605fa1ac65add0f464f1b9b5fe004c2d741dc77f162b37d55e98bfa11c3914fc017a3c81600f2e9c8cf6c5de1b87c80f21102b0a50f889c82ec32
+  data.tar.gz: c86655aa015464a6118d8f40aab623ce2be5d6dc61a3b0d9cc3a61a2b9616d077561ba6daabe85607b795c2265cacb62aa89f6cbc9abdee4cb9711343abf618b

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    trello_lead_time (0.1.4)
+    trello_lead_time (0.1.5)
 
 GEM
   remote: https://rubygems.org/

data/lib/trello_lead_time/timeline.rb

@@ -49,7 +49,7 @@ module TrelloLeadTime
     end
 
     def filtered_actions
-      @trello_card.actions(filter: 'createCard,updateCard:idList,updateCard:closed').map { |action| Action.from_trello_action(action) }
+      @trello_card.actions(filter: 'copyCard,moveCardToBoard,createCard,updateCard:idList,updateCard:closed').map { |action| Action.from_trello_action(action) }
     end
 
     def creation_date
@@ -58,6 +58,7 @@ module TrelloLeadTime
     end
 
     def calculate_age_in_seconds(start_time, end_time)
+      return 0 unless start_time && end_time
       (end_time - start_time).round(0)
     end
 
@@ -122,7 +123,7 @@ module TrelloLeadTime
     end
 
     def list_from_result_of_action(action)
-      if action.type == "createCard"
+      if %w{createCard copyCard moveCardToBoard}.include?(action.type)
         action.data["list"]
       elsif action.type == "updateCard" && action.data.has_key?("old") && action.data["old"].has_key?("idList")
         action.data["listAfter"]

data/lib/trello_lead_time/version.rb

@@ -1,3 +1,3 @@
 module TrelloLeadTime
-  VERSION = '0.1.4'
+  VERSION = '0.1.5'
 end

data/spec/fixtures/actions.copied.many.json

@@ -0,0 +1,152 @@
+[
+	{
+		"id": "53879d88875d3e408d7cc1a9",
+		"idMemberCreator": "5148b990bb8ad6045b003b1f",
+		"data": {
+			"listAfter": {
+				"name": "Done for 2014-05-16",
+				"id": "536d4d530b76b3fe7435a072"
+			},
+			"listBefore": {
+				"name": "Development",
+				"id": "520d5ac74fd0cd3a5d000b80"
+			},
+			"board": {
+				"shortLink": "2nROp5bq",
+				"name": "Transp Backend",
+				"id": "520d5aa09b5a997f5a000e6b"
+			},
+			"card": {
+				"shortLink": "jht1p9H4",
+				"idShort": 1144,
+				"name": "TEST: Copied card in done column",
+				"id": "538797063ecd8f643503316e",
+				"idList": "536d4d530b76b3fe7435a072"
+			},
+			"old": {
+				"idList": "520d5ac74fd0cd3a5d000b80"
+			}
+		},
+		"type": "updateCard",
+		"date": "2014-05-29T20:50:16.375Z",
+		"memberCreator": {
+			"id": "5148b990bb8ad6045b003b1f",
+			"avatarHash": "4e71215f2b8bfed0e9812634e35d5648",
+			"fullName": "Scott Baldwin",
+			"initials": "SSB",
+			"username": "scottsbaldwin"
+		}
+	},
+	{
+		"id": "53879d78281ca563163800fd",
+		"idMemberCreator": "5148b990bb8ad6045b003b1f",
+		"data": {
+			"listAfter": {
+				"name": "Development",
+				"id": "520d5ac74fd0cd3a5d000b80"
+			},
+			"listBefore": {
+				"name": "Acceptance",
+				"id": "520d5ad05327daf13100050a"
+			},
+			"board": {
+				"shortLink": "2nROp5bq",
+				"name": "Transp Backend",
+				"id": "520d5aa09b5a997f5a000e6b"
+			},
+			"card": {
+				"shortLink": "jht1p9H4",
+				"idShort": 1144,
+				"name": "TEST: Copied card in done column",
+				"id": "538797063ecd8f643503316e",
+				"idList": "520d5ac74fd0cd3a5d000b80"
+			},
+			"old": {
+				"idList": "520d5ad05327daf13100050a"
+			}
+		},
+		"type": "updateCard",
+		"date": "2014-05-29T20:50:00.913Z",
+		"memberCreator": {
+			"id": "5148b990bb8ad6045b003b1f",
+			"avatarHash": "4e71215f2b8bfed0e9812634e35d5648",
+			"fullName": "Scott Baldwin",
+			"initials": "SSB",
+			"username": "scottsbaldwin"
+		}
+	},
+	{
+		"id": "53879d6fc3b3e6c69e4e09bf",
+		"idMemberCreator": "5148b990bb8ad6045b003b1f",
+		"data": {
+			"listAfter": {
+				"name": "Acceptance",
+				"id": "520d5ad05327daf13100050a"
+			},
+			"listBefore": {
+				"name": "Done for 2014-05-16",
+				"id": "536d4d530b76b3fe7435a072"
+			},
+			"board": {
+				"shortLink": "2nROp5bq",
+				"name": "Transp Backend",
+				"id": "520d5aa09b5a997f5a000e6b"
+			},
+			"card": {
+				"shortLink": "jht1p9H4",
+				"idShort": 1144,
+				"name": "TEST: Copied card in done column",
+				"id": "538797063ecd8f643503316e",
+				"idList": "520d5ad05327daf13100050a"
+			},
+			"old": {
+				"idList": "536d4d530b76b3fe7435a072"
+			}
+		},
+		"type": "updateCard",
+		"date": "2014-05-29T20:49:51.716Z",
+		"memberCreator": {
+			"id": "5148b990bb8ad6045b003b1f",
+			"avatarHash": "4e71215f2b8bfed0e9812634e35d5648",
+			"fullName": "Scott Baldwin",
+			"initials": "SSB",
+			"username": "scottsbaldwin"
+		}
+	},
+	{
+		"id": "538797063ecd8f643503316f",
+		"idMemberCreator": "5148b990bb8ad6045b003b1f",
+		"data": {
+			"cardSource": {
+				"shortLink": "7odj0Q15",
+				"idShort": 1143,
+				"name": "TEST: Created card in done column",
+				"id": "538796f94b1ed3dad0b28330"
+			},
+			"board": {
+				"shortLink": "2nROp5bq",
+				"name": "Transp Backend",
+				"id": "520d5aa09b5a997f5a000e6b"
+			},
+			"list": {
+				"name": "Done for 2014-05-16",
+				"id": "536d4d530b76b3fe7435a072"
+			},
+			"card": {
+				"shortLink": "jht1p9H4",
+				"idShort": 1144,
+				"name": "TEST: Copied card in done column",
+				"id": "538797063ecd8f643503316e"
+			}
+		},
+		"type": "copyCard",
+		"date": "2014-05-29T20:22:30.817Z",
+		"memberCreator": {
+			"id": "5148b990bb8ad6045b003b1f",
+			"avatarHash": "4e71215f2b8bfed0e9812634e35d5648",
+			"fullName": "Scott Baldwin",
+			"initials": "SSB",
+			"username": "scottsbaldwin"
+		}
+	}
+]

data/spec/fixtures/actions.copied.single.json

@@ -0,0 +1,38 @@
+[
+	{
+		"id": "538797063ecd8f643503316f",
+		"idMemberCreator": "5148b990bb8ad6045b003b1f",
+		"data": {
+			"cardSource": {
+				"shortLink": "7odj0Q15",
+				"idShort": 1143,
+				"name": "TEST: Created card in done column",
+				"id": "538796f94b1ed3dad0b28330"
+			},
+			"board": {
+				"shortLink": "2nROp5bq",
+				"name": "Transp Backend",
+				"id": "520d5aa09b5a997f5a000e6b"
+			},
+			"list": {
+				"name": "Done for 2014-05-16",
+				"id": "536d4d530b76b3fe7435a072"
+			},
+			"card": {
+				"shortLink": "jht1p9H4",
+				"idShort": 1144,
+				"name": "TEST: Copied card in done column",
+				"id": "538797063ecd8f643503316e"
+			}
+		},
+		"type": "copyCard",
+		"date": "2014-05-29T20:22:30.817Z",
+		"memberCreator": {
+			"id": "5148b990bb8ad6045b003b1f",
+			"avatarHash": "4e71215f2b8bfed0e9812634e35d5648",
+			"fullName": "Scott Baldwin",
+			"initials": "SSB",
+			"username": "scottsbaldwin"
+		}
+	}
+]

data/spec/fixtures/card.copied.json

@@ -0,0 +1,43 @@
+{
+    "badges": {
+        "attachments": 1,
+        "checkItems": 0,
+        "checkItemsChecked": 0,
+        "comments": 8,
+        "description": true,
+        "due": "2014-06-13T16:00:00.000Z",
+        "fogbugz": "",
+        "subscribed": false,
+        "viewingMemberVoted": false,
+        "votes": 0
+    },
+    "checkItemStates": [],
+    "closed": false,
+    "dateLastActivity": "2014-05-20T20:57:27.749Z",
+    "desc": "Sorting dropdown is not available in right corner of results page for CSX members.",
+    "descData": null,
+    "due": "2014-06-13T16:00:00.000Z",
+    "id": "53725c8bdff8e1fa15e372e4",
+    "idAttachmentCover": "53725c8cdff8e1fa15e372e6",
+    "idBoard": "520d5aa09b5a997f5a000e6b",
+    "idChecklists": [],
+    "idList": "536d4d530b76b3fe7435a072",
+    "idMembers": [
+        "520a6b6fd1d45394140038dc",
+        "5205800dd1e439ae31002495",
+        "520557cd7c576964440039ed",
+        "5304d05539da911e1c7f8674"
+    ],
+    "idShort": 1112,
+    "labels": [
+        {
+            "color": "purple",
+            "name": "CapEx"
+        }
+    ],
+    "manualCoverAttachment": false,
+    "name": "SPIKE:  Sorting dropdown is not available for CSX members.(DEF020110)",
+    "pos": 144,
+    "shortUrl": "https://trello.com/c/ACYh6u9c",
+    "url": "https://trello.com/c/ACYh6u9c/1112-spike-sorting-dropdown-is-not-available-for-csx-members-def020110"
+}

data/spec/lib/trello_lead_time/board_spec.rb

@@ -217,7 +217,7 @@ describe TrelloLeadTime::Board do
 
   def stub_card_requests
     %w{1111 2222 3333 4444}.each do |card_id|
-      stub_request(:get, "https://api.trello.com/1/cards/#{card_id}/actions?filter=createCard,updateCard:idList,updateCard:closed&key=#{key}&token=#{token}").
+      stub_request(:get, "https://api.trello.com/1/cards/#{card_id}/actions?filter=copyCard,moveCardToBoard,createCard,updateCard:idList,updateCard:closed&key=#{key}&token=#{token}").
         with(headers).
         to_return(stub_returns(actions_json[card_id]))
 

data/spec/lib/trello_lead_time/card_spec.rb

@@ -3,78 +3,116 @@ require 'spec_helper'
 describe TrelloLeadTime::Card do
   let(:key) { 'key' }
   let(:token) { 'token' }
-  let(:card_json) {
-    File.read(File.expand_path("../../../fixtures/card.json", __FILE__))
-  }
-  let(:actions_json) {
-    File.read(File.expand_path("../../../fixtures/actions.1111.json", __FILE__))
-  }
-  let(:labels_json) {
-    File.read(File.expand_path("../../../fixtures/labels.json", __FILE__))
-  }
-  let(:comments_json) {
-    File.read(File.expand_path("../../../fixtures/comments.json", __FILE__))
-  }
-
-  subject { TrelloLeadTime::Card.from_trello_card(Trello::Card.parse(card_json)) }
-
-  def do_stubs(key, token)
-    stub_request(:get, "https://api.trello.com/1/cards/533dd01513e035206902124c/actions?filter=createCard,updateCard:idList,updateCard:closed&key=#{key}&token=#{token}").
-      with(:headers => {'Accept'=>'*/*; q=0.5, application/xml', 'Accept-Encoding'=>'gzip, deflate', 'User-Agent'=>'Ruby'}).
-      to_return(:status => 200, :body => actions_json, :headers => {})
-
-    stub_request(:get, "https://api.trello.com/1/cards/533dd01513e035206902124c/labels?key=#{key}&token=#{token}").
-      with(:headers => {'Accept'=>'*/*; q=0.5, application/xml', 'Accept-Encoding'=>'gzip, deflate', 'User-Agent'=>'Ruby'}).
-      to_return(:status => 200, :body => labels_json, :headers => {})
-
-    stub_request(:get, "https://api.trello.com/1/cards/533dd01513e035206902124c/actions?filter=commentCard&key=#{key}&token=#{token}").
-      with(:headers => {'Accept'=>'*/*; q=0.5, application/xml', 'Accept-Encoding'=>'gzip, deflate', 'User-Agent'=>'Ruby'}).
-      to_return(:status => 200, :body => comments_json, :headers => {})
-  end
 
-  describe ".done" do
-    it "should be a card" do
-      do_stubs(key, token)
-      subject.should be_an_instance_of(TrelloLeadTime::Card)
+  context "card with more than one action" do
+    let(:card_json) {
+      File.read(File.expand_path("../../../fixtures/card.json", __FILE__))
+    }
+    let(:actions_json) {
+      File.read(File.expand_path("../../../fixtures/actions.1111.json", __FILE__))
+    }
+    let(:labels_json) {
+      File.read(File.expand_path("../../../fixtures/labels.json", __FILE__))
+    }
+    let(:comments_json) {
+      File.read(File.expand_path("../../../fixtures/comments.json", __FILE__))
+    }
+
+    subject { TrelloLeadTime::Card.from_trello_card(Trello::Card.parse(card_json)) }
+
+    before(:each) {
+      key     = 'key'
+      token   = 'token'
+
+      stub_request(:get, "https://api.trello.com/1/cards/533dd01513e035206902124c/actions?filter=copyCard,moveCardToBoard,createCard,updateCard:idList,updateCard:closed&key=#{key}&token=#{token}").
+        with(:headers => {'Accept'=>'*/*; q=0.5, application/xml', 'Accept-Encoding'=>'gzip, deflate', 'User-Agent'=>'Ruby'}).
+        to_return(:status => 200, :body => actions_json, :headers => {})
+
+      stub_request(:get, "https://api.trello.com/1/cards/533dd01513e035206902124c/labels?key=#{key}&token=#{token}").
+        with(:headers => {'Accept'=>'*/*; q=0.5, application/xml', 'Accept-Encoding'=>'gzip, deflate', 'User-Agent'=>'Ruby'}).
+        to_return(:status => 200, :body => labels_json, :headers => {})
+
+      stub_request(:get, "https://api.trello.com/1/cards/533dd01513e035206902124c/actions?filter=commentCard&key=#{key}&token=#{token}").
+        with(:headers => {'Accept'=>'*/*; q=0.5, application/xml', 'Accept-Encoding'=>'gzip, deflate', 'User-Agent'=>'Ruby'}).
+        to_return(:status => 200, :body => comments_json, :headers => {})
+    }
+
+    describe ".done" do
+      it "should be a card" do
+        subject.should be_an_instance_of(TrelloLeadTime::Card)
+      end
     end
-  end
 
-  describe ".hash_tags" do
-    it "should have a hash tag" do
-      do_stubs(key, token)
-      expect(subject.hash_tags).to eq(%w{#tag1 #tag2 #tag3})
+    describe ".hash_tags" do
+      it "should have a hash tag" do
+        expect(subject.hash_tags).to eq(%w{#tag1 #tag2 #tag3})
+      end
     end
-  end
 
-  describe ".labels" do
-    it "should have labels" do
-      do_stubs(key, token)
-      expect(subject.labels.collect(&:name)).to eq(%w{iOS API})
+    describe ".labels" do
+      it "should have labels" do
+        expect(subject.labels.collect(&:name)).to eq(%w{iOS API})
 
+      end
     end
-  end
 
-  describe ".has_label_name?" do
-    it "should not have a named label" do
-      do_stubs(key, token)
-      subject.has_label_name?("blah").should be_false
+    describe ".has_label_name?" do
+      it "should not have a named label" do
+        subject.has_label_name?("blah").should be_false
+      end
+
+      it "should have a named label" do
+        subject.has_label_name?("ios").should be_true
+      end
     end
 
-    it "should have a named label" do
-      do_stubs(key, token)
-      subject.has_label_name?("ios").should be_true
+    describe ".has_label_color?" do
+      it "should not have a color label" do
+        subject.has_label_color?("yellow").should be_false
+      end
+
+      it "should have a color label" do
+        subject.has_label_color?("Green").should be_true
+      end
     end
   end
 
-  describe ".has_label_color?" do
-    it "should not have a color label" do
-      do_stubs(key, token)
-      subject.has_label_color?("yellow").should be_false
+  context "copied card" do
+    let(:card_id) { '53725c8bdff8e1fa15e372e4' }
+    let(:copied_card_json) {
+      File.read(File.expand_path("../../../fixtures/card.copied.json", __FILE__))
+    }
+
+    subject { TrelloLeadTime::Card.from_trello_card(Trello::Card.parse(copied_card_json)) }
+
+    context "with a single action" do
+      let(:copied_actions_json) {
+        File.read(File.expand_path("../../../fixtures/actions.copied.single.json", __FILE__))
+      }
+
+      it "should have an age of 0 seconds" do
+        stub_request(:get, "https://api.trello.com/1/cards/#{card_id}/actions?filter=copyCard,moveCardToBoard,createCard,updateCard:idList,updateCard:closed&key=#{key}&token=#{token}").
+          with(:headers => {'Accept'=>'*/*; q=0.5, application/xml', 'Accept-Encoding'=>'gzip, deflate', 'User-Agent'=>'Ruby'}).
+          to_return(:status => 200, :body => copied_actions_json, :headers => {})
+
+        subject.age_in_seconds.should == 0
+      end
     end
 
-    it "should have a color label" do
-      do_stubs(key, token)
-      subject.has_label_color?("Green").should be_true
+    context "with many actions" do
+      let(:copied_actions_json) {
+        File.read(File.expand_path("../../../fixtures/actions.copied.many.json", __FILE__))
+      }
+
+      it "should have an age of 0 seconds" do
+        stub_request(:get, "https://api.trello.com/1/cards/#{card_id}/actions?filter=copyCard,moveCardToBoard,createCard,updateCard:idList,updateCard:closed&key=#{key}&token=#{token}").
+          with(:headers => {'Accept'=>'*/*; q=0.5, application/xml', 'Accept-Encoding'=>'gzip, deflate', 'User-Agent'=>'Ruby'}).
+          to_return(:status => 200, :body => copied_actions_json, :headers => {})
+
+        subject.age_in_seconds.should == 1666
+      end
     end
+
   end
+
 end

data/spec/lib/trello_lead_time/list_spec.rb

@@ -202,7 +202,7 @@ describe TrelloLeadTime::List do
 
   def stub_card_requests
     %w{1111 2222 3333 4444}.each do |card_id|
-      stub_request(:get, "https://api.trello.com/1/cards/#{card_id}/actions?filter=createCard,updateCard:idList,updateCard:closed&key=#{key}&token=#{token}").
+      stub_request(:get, "https://api.trello.com/1/cards/#{card_id}/actions?filter=copyCard,moveCardToBoard,createCard,updateCard:idList,updateCard:closed&key=#{key}&token=#{token}").
         with(headers).
         to_return(stub_returns(actions_json[card_id]))
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: trello_lead_time
 version: !ruby/object:Gem::Version
-  version: 0.1.4
+  version: 0.1.5
 platform: ruby
 authors:
 - Scott Baldwin
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-05-19 00:00:00.000000000 Z
+date: 2014-05-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -83,7 +83,10 @@ files:
 - spec/fixtures/actions.2222.json
 - spec/fixtures/actions.3333.json
 - spec/fixtures/actions.4444.json
+- spec/fixtures/actions.copied.many.json
+- spec/fixtures/actions.copied.single.json
 - spec/fixtures/boards.json
+- spec/fixtures/card.copied.json
 - spec/fixtures/card.json
 - spec/fixtures/cards.json
 - spec/fixtures/comments.1111.json
@@ -136,7 +139,10 @@ test_files:
 - spec/fixtures/actions.2222.json
 - spec/fixtures/actions.3333.json
 - spec/fixtures/actions.4444.json
+- spec/fixtures/actions.copied.many.json
+- spec/fixtures/actions.copied.single.json
 - spec/fixtures/boards.json
+- spec/fixtures/card.copied.json
 - spec/fixtures/card.json
 - spec/fixtures/cards.json
 - spec/fixtures/comments.1111.json