trello_effort_tracker 0.0.3 → 0.0.4

data/.gitignore

@@ -13,6 +13,8 @@ test/tmp
 test/version_tmp
 tmp
 .tmtags
+.tags
+.tags_sorted_by_file
 
 # YARD artifacts
 .yardoc
@@ -20,6 +22,5 @@ _yardoc
 doc/
 
 config.yml
-config.yml.piero
 mongoid.yml
 .rvmrc

data/.travis.yml

@@ -6,7 +6,6 @@ env:
   global:
     - developer_public_key: e/zPNGKOwapoxFWZs/CBTAhaoqrDTkqqz+InOmCUvGBcZBpUxH398nPLv8Hi\nNQSvWuspzqanyNbbQrTA/2XhsWF1gIFX+gNexYM7S+MxtRwUD3cpVT8DzVOS\nMuckdMTEAADVsm92vIX/bUs5igxD4+zfXlhzXUNDrzRlZnsUF2M=
     - access_token_key: GG1Q8oq7GkaXjP0lbMgvQLLEi+LXOZlwmELqjPk39Exfy8114QUs2ki8nr9n\ndGO+tgOSZsCd/bt9IHxS3WWWU0INSYOTgp/prfsDDgosg7/Elk/b6w1OW0At\nX3VAjMeI0yAGloT6XB58LCFyrj6S2b4vCQqyaHR3tlTHai/5bMQ=
-    - developer_secret: jnWqZy2L5styLBGfgpZm9Unqog4KBlPTdtSHdFKG4I8PotrJEi6Kt2rSGljX\n8zFiRcnzelZSEEzGxa9z6pSMFuVz5Dkr3EK/Oa4+MpueMOXOoQA3zmty/865\n5Wokr1cEeJJOP/KXmnLgAkvPh9vOn7KEd8IlphsOkv5w+Rlmgb4=
     - tracker_username=trackinguser
     - MONGOID_ENV=test
 

data/CHANGELOG

@@ -0,0 +1,17 @@
+0.0.4
+  - A card moved into a DONE column is closed
+
+0.0.3
+  - When I send a tracking with "DONE" then the card is "closed" (aka "finished")
+  - Export all cards in a Google Docs spreadsheet
+  - When I card change its name, the tracked card should be updated too
+  - A card should tells its estimate error (3)
+
+0.0.2
+  - Very simple Rails app on a separate branch, still experimenting
+  - Should be able to open a Trello console with a rake task
+  - Avoid running the script if already run for that period
+  - Tracking data is now persisted in a mongo database
+  
+0.0.1
+  - Initial Release.

data/Gemfile

@@ -1,22 +1,25 @@
 source :rubygems
 
-gem 'trello_effort_tracker', :path => '.'
+gemspec
 
 gem 'ruby-trello', :require => 'trello'
-gem 'debugger'
+# gem 'ruby-trello', :require => 'trello', :path => '../ruby-trello' # to hack on the ruby-trello gem itself
+
 gem 'rainbow'
 gem 'chronic'
 
 gem 'mongoid'
 gem 'bson_ext'
 
-# google docs exporter
 gem 'google_drive'
 gem 'highline'
 
-group :test do
+group :test, :development, :spec do
   gem 'rake'
   gem 'rspec'
+  gem 'simplecov', :require => false, :platforms => [:mri, :mri_19]
   gem 'rspec-mocks'
   gem 'mongoid-rspec'
+  gem 'database_cleaner'
+  gem 'debugger'
 end

data/Gemfile.lock

@@ -1,7 +1,14 @@
 PATH
   remote: .
   specs:
-    trello_effort_tracker (0.0.2)
+    trello_effort_tracker (0.0.3)
+      bson_ext
+      chronic
+      google_drive
+      highline
+      mongoid
+      rainbow
+      ruby-trello
 
 GEM
   remote: http://rubygems.org/
@@ -13,23 +20,24 @@ GEM
       i18n (~> 0.6)
       multi_json (~> 1.0)
     addressable (2.3.2)
-    bson (1.8.1)
-    bson_ext (1.8.1)
-      bson (~> 1.8.1)
+    bson (1.8.2)
+    bson_ext (1.8.2)
+      bson (~> 1.8.2)
     builder (3.0.4)
     chronic (0.9.0)
     columnize (0.3.6)
-    debugger (1.2.3)
+    database_cleaner (0.9.1)
+    debugger (1.3.0)
       columnize (>= 0.3.1)
       debugger-linecache (~> 1.1.1)
-      debugger-ruby_core_source (~> 1.1.5)
+      debugger-ruby_core_source (~> 1.1.7)
     debugger-linecache (1.1.2)
       debugger-ruby_core_source (>= 1.1.1)
-    debugger-ruby_core_source (1.1.6)
+    debugger-ruby_core_source (1.1.7)
     diff-lcs (1.1.3)
     faraday (0.8.4)
       multipart-post (~> 1.1)
-    google_drive (0.3.2)
+    google_drive (0.3.3)
       nokogiri (>= 1.4.4, != 1.5.2, != 1.5.1)
       oauth (>= 0.3.6)
       oauth2 (>= 0.5.0)
@@ -40,12 +48,12 @@ GEM
     jwt (0.1.5)
       multi_json (>= 1.0)
     mime-types (1.19)
-    mongoid (3.0.17)
+    mongoid (3.0.19)
       activemodel (~> 3.1)
       moped (~> 1.2)
       origin (~> 1.0)
       tzinfo (~> 0.3.22)
-    mongoid-rspec (1.5.6)
+    mongoid-rspec (1.6.0)
       mongoid (>= 3.0.1)
       rake
       rspec (>= 2.9)
@@ -61,7 +69,7 @@ GEM
       multi_json (~> 1.0)
       rack (~> 1.2)
     origin (1.0.11)
-    rack (1.4.4)
+    rack (1.5.1)
     rainbow (1.1.4)
     rake (10.0.3)
     rest-client (1.6.7)
@@ -73,13 +81,17 @@ GEM
     rspec-core (2.12.2)
     rspec-expectations (2.12.1)
       diff-lcs (~> 1.1.3)
-    rspec-mocks (2.12.1)
-    ruby-trello (0.4.4.3)
+    rspec-mocks (2.12.2)
+    ruby-trello (0.5.0)
       activemodel
       addressable (~> 2.3)
       json
       oauth (~> 0.4.5)
       rest-client (~> 1.6.7)
+    simplecov (0.7.1)
+      multi_json (~> 1.0)
+      simplecov-html (~> 0.7.1)
+    simplecov-html (0.7.1)
     tzinfo (0.3.35)
 
 PLATFORMS
@@ -88,6 +100,7 @@ PLATFORMS
 DEPENDENCIES
   bson_ext
   chronic
+  database_cleaner
   debugger
   google_drive
   highline
@@ -98,4 +111,5 @@ DEPENDENCIES
   rspec
   rspec-mocks
   ruby-trello
+  simplecov
   trello_effort_tracker!

data/README.md

@@ -1,78 +1,110 @@
 [![Build Status](https://secure.travis-ci.org/xpepper/trello_effort_tracker.png)](http://travis-ci.org/xpepper/trello_effort_tracker)
 [![Code Climate](https://codeclimate.com/badge.png)](https://codeclimate.com/github/xpepper/trello_effort_tracker)
 
-# TrelloEffortTracker
+# Trello Effort Tracker
 
+## What is Trello Effort Tracker?
 The purpose of this tool is to extract and track estimates and actual efforts on Trello cards.
-You just have to notify all of your estimates and efforts tracked on your Trello cards using a conventional format.
-This tool will extract and store these estimates and actual efforts to let you extract useful key metrics (e.g. estimate errors, remaining efforts, pair programming frequencies, and so on).
+You simply notify all of your estimates and efforts tracked on your Trello cards using a conventional format.
+Trello Effort Tracker will extract and store these estimates and actual efforts to let you extract useful key metrics (e.g. estimate errors, remaining efforts, pair programming frequencies, and so on).
 
-The Trello API is used in readonly mode in this code, so all you need to access is your developer key.
-TrelloEffortTracker uses the [Trello API Ruby wrapper](https://github.com/jeremytregunna/ruby-trello) for this purpose.
+## Why Trello Effort Tracker?
+Trello is a very good surrogate for a physical team board: it's simple and effective, and it can really help when you have a distributed team.
+That said, Trello does not (still) offer a way to track time estimated and actually spent on cards, though many people [ask for that feature](https://trello.com/card/time-tracking/4d5ea62fd76aa1136000000c/1054) on Trello's development board.
+
+We had the need to add time tracking to Trello, so we define a simple convention to track estimates and efforts on cards: we use a predefined board member (let's call him 'tracking user') which we sent special notifications to (we call them 'tracking notifications').
+This 'tracking user' will then receives estimates and efforts notifications, and Trello Effort Tracker will collect them in a simple domain model, backed on a persistent storage.
+Moreover, a web app will be soon available to properly present card estimates and efforts. We're working on it.
+
+## More details
+All you need to have to start using Trello Effort Tracker is a Trello account, a Trello board and a board member to use as 'tracking user'. 
+You'll also need to know your Trello developer key and generate a proper auth token to have access to the trackinguser's notifications.
+To see how to have these two keys, see [the following section](#api_key).
+
+The Trello API is used behind the scenes to read data from the team board.
+Trello Effort Tracker uses the awesome [Trello API Ruby wrapper](https://github.com/jeremytregunna/ruby-trello) for this purpose.
+
+## Installation
+
+```
+# gem install trello_effort_tracker
+```
+
+Full Disclosure: This library is still work-in-progress, so if you find anything missing or not functioning as you expect it to, please [open an issue on github](https://github.com/xpepper/trello_effort_tracker/issues).
 
 ## Requirements
-* [rvm](https://rvm.io/rvm/install/)
 * [mongoDB](http://www.mongodb.org/) - mac users with homebrew will just run 'brew install mongodb' to have mongoDB installed on their machine.
+* [rvm](https://rvm.io/rvm/install/) (optional)
 
 ## Setup
 Copy the config template
 
-    cp config/config.template.yaml config/config.yml
+```shell
+cp config/config.template.yaml config/config.yml
+```
 
 and then fill the correct values in the placeholders in config.yml (see _"Where do I get an API key and API secret?"_ section).
 
 Then copy the mongoid config template
 
-    cp config/mongoid.template.yaml config/mongoid.yml
+```shell
+cp config/mongoid.template.yaml config/mongoid.yml
+```
 
 and fill the correct values for the mongodb environments ([see here](http://mongoid.org/en/mongoid/docs/installation.html#configuration) to have more details).
 
 Then run bundle to get all the required gems:
 
-    bundle install
+```shell
+bundle install
+```
 
-### Where do I get an API key and API secret?
-Log in as a Trello user and visit [this URL](https://trello.com/1/appKey/generate) to get your developer\_public\_key and the developer\_public\_key.
+### <a id="api_key"></a>Where do I get an API key?
+Log in to Trello with your account and visit [https://trello.com/1/appKey/generate](https://trello.com/1/appKey/generate) to get your developer\_public\_key.
 
 ### Where do I get an API Access Token Key?
-You will need an access token to use ruby-trello, which trello tracker depends on. To get it, you'll need to go to this URL:
+To generate a proper access token key, log in to Trello with the 'tracking user' account. Then go to this URL:
 
     https://trello.com/1/connect?key=<YOUR_DEVELOPER_PUBLIC_KEY>&name=Trello+Effort+Tracker&response_type=token&scope=read,write&expiration=never
 
-At the end of this process, You'll be told to give some key to the app, this is what you want to put in the access\_token\_key yml prop file.
+At the end of this process, you'll receive a valid access\_token\_key, which is needed by Trello Effort Tracker to fetch all the tracking notifications sent to the 'tracking user'.
 
 ## Usage
 The best way is to use one of the rake task defined, e.g.
 
-    rake 'run:today[test]' # will extract today's tracked data and store on the test db
+```ruby
+rake 'run:today[test]' # will extract today's tracked data and store on the test db
 
-    rake run:today  # will extract today's tracked data  and store on the default (that is development) db
+rake run:today  # will extract today's tracked data  and store on the default (that is development) db
 
-    rake 'run:from_day[2012-11-1, production]'  # will extract tracked data starting from November the 1st, 2012 and store them into the production db
+rake 'run:from_day[2012-11-1, production]'  # will extract tracked data starting from November the 1st, 2012 and store them into the production db
+```
 
 Or you may just create a TrelloTracker instance and execute its track method.
 
-    tracker = TrelloTracker.new
-    tracker.track
-
+```ruby
+tracker = TrelloTracker.new
+tracker.track
+```
 You can set the Trello's auth params in three ways
 
 * setting the three auth params via environment variables (ENV object)
-* using the config.yml (which remains the default mode)
 * passing into the constructor a hash containing the auth values, e.g.
+* using the config.yml (which remains the default mode)
 
-        tracker = TrelloTracker.new(
-         "developer_public_key" => "487635b55e6fe9021902fa763b4d101a",
-         "access_token_key" => "33bed56f2a12a49c9ba1c2d6ad3e2002e11a34358c3f3fe260d7fba746a06203",
-         "developer_secret" => "ab999c4396493dba4c04ade055eabfdfabdffd0ffd7c281a23234350a993524d")
-
-        tracker.track
+```ruby
+tracker = TrelloTracker.new(
+ "developer_public_key" => "487635b55e6fe9021902fa763b4d101a",
+ "access_token_key" => "33bed56f2a12a49c9ba1c2d6ad3e2002e11a34358c3f3fe260d7fba746a06203")
 
+tracker.track
+```
 ### Console
 You can open a irb console with the ruby-trello gem and this gem loaded, so that you can query the db or the Trello API and play with them
 
-    rake console
-
+```ruby
+rake console
+```
 
 ### Storage configuration
 Tracking data collected from Trello are stored in a MongoDB, as configured in config/mongoid.yml.
@@ -121,20 +153,32 @@ To set an effort just for other Trello users (excluding the current user), just
 
     @trackinguser +3p (@alessandrodescovi @michelevincenzi)
 
+### Tracking a card as finished (aka DONE)
+Sending a tracking notification with the word DONE
+
+    @trackinguser DONE
+
+will mark the card as closed.
+
 ## Database import/export
 To export the db you can execute something like:
 
-    mongoexport --db trello_effort_tracker_production --collection tracked_cards --out trello_effort_tracker_production.json
+```shell
+mongoexport --db trello_effort_tracker_production --collection tracked_cards --out trello_effort_tracker_production.json
+```
 
 To reimport that db:
 
-    mongoimport  --db trello_effort_tracker_production --collection tracked_cards --file trello_effort_tracker_production.json
+```shell
+mongoimport  --db trello_effort_tracker_production --collection tracked_cards --file trello_effort_tracker_production.json
+```
 
 ## Google Docs exporter
 To export all your tracked cards on a google docs named 'my_sheet' in the 'tracking' worksheet, run
 
-    rake "export:google_docs[my_sheet, tracking, production]"
-
+```ruby
+rake "export:google_docs[my_sheet, tracking, production]"
+```
 The default env is development.
 
 If you provide no name for the spreadsheet, a default name will be used.
@@ -142,18 +186,44 @@ If the spreadsheet name you provide does not exists, it will be created in you g
 
 So, running simply
 
-    rake export:google_docs
-    
+```ruby
+rake export:google_docs
+```
 will create (or update) a spreadsheet named "trello effort tracking" using the development db env.
 
+## Keeping your tracking database up to date
+You may install a crontab entry to run the trello tracker periodically, for example
+
+```shell
+SHELL=/Users/futur3/.rvm/bin/rvm-shell
+GEMSET="ruby-1.9.3-p194@spikes"
+PROJECT_PATH="/Users/$USER/Documents/workspace/trello_effort_tracker"
+LC_ALL=en_US.UTF-8
+
+# m h  dom mon dow   command
+*/10 * * * *  rvm-shell $GEMSET -c "cd $PROJECT_PATH;  bundle exec rake run:today[production]" >> /tmp/crontab.out 2>&1
+```
 
 ## Roadmap and improvements
 We develop Trello Effort Tracker using [Trello itself](https://trello.com/board/trello-effort-tracker-roadmap/509c3228dcb1ac3f1c018791).
 
 ## Contributing
+To get started, [sign the Contributor License Agreement](http://www.clahub.com/agreements/xpepper/trello_effort_tracker).
+
+If you'd like to hack on Trello Effort Tracker, start by forking the repo on GitHub:
+
+https://github.com/xpepper/trello_effort_tracker
 
-Several ways you can contribute. Documentation, code, tests, feature requests, bug reports.
+The best way to get your changes merged back into core is as follows:
 
-Pull requests are welcome :)
+1. Clone down your fork
+1. Create a thoughtfully named topic branch to contain your change
+1. Hack away
+1. Add tests and make sure everything still passes by running `rake spec`
+1. If you are adding new functionality, document it in the README
+1. Do not change the version number, we will do that on our end
+1. If necessary, rebase your commits into logical chunks, without errors
+1. Push the branch up to GitHub
+1. Send a pull request for your branch
 
 [@pierodibello](http://twitter.com/pierodibello)

data/Rakefile

@@ -59,7 +59,7 @@ namespace :export do
 end
 
 task :ensure_environment do
-  %w{developer_public_key developer_secret access_token_key}.each do |each_name|
+  %w{developer_public_key access_token_key}.each do |each_name|
     unless ENV[each_name] || authorization_params_from_config_file[each_name]
       puts "ERROR: Missing <#{each_name}> environment variable."
       exit 1

data/config/config.template.yml

@@ -1,7 +1,6 @@
 trello:
   developer_public_key: <here put the key taken from https://trello.com/1/appKey/generate>
   access_token_key: <here put the token taken in the 'Reading Private Data' section from https://trello.com/1/appKey/generate>
-  developer_secret: <here put the Secret (for OAuth signing) taken from https://trello.com/1/appKey/generate>
 
 tracker_username: <here put the Trello member used as recipient of the tracking notifications>
 google_docs_username: <here put your Google Docs username>

data/config/config.yml.trackinguser_for_test

@@ -0,0 +1,7 @@
+# read-only access to @trackinguser_for_test/testinguser! boards
+trello:
+  developer_public_key: ef7c400e711057d7ba5e00be20139a33
+  access_token_key: 9047d8fdbfdc960d41910673e300516cc8630dd4967e9b418fc27e410516362e
+
+tracker_username: trackinguser_for_test
+google_docs_username: pietro.dibello@xpeppers.com

data/lib/patches/trello/card.rb

@@ -0,0 +1,19 @@
+module Trello
+
+  class Card
+    # Reopening the Trello::Card class to add a  method detecting a card moved in a DONE column
+    def in_done_column?
+      list_name = ""
+      begin
+        list_name = list.name.strip
+      rescue Trello::Error => e
+        Trello::Logger.error("Cannot find column for card #{name}")
+      end
+
+      !!(list_name =~ /^DONE/i)
+    end
+  end
+
+end
+
+

data/lib/patches/trello/member.rb

@@ -1,14 +1,14 @@
 module Trello
-
   class Member
-    def notifications_from(from_date)
-      notifications(limit:1000).select(&greater_than_or_equal_to(from_date)).select(&tracking_notification?)
+    # Reopening the Trello::Member class to add a notifications helper method
+    def notifications_from(starting_date)
+      notifications(limit:1000).select(&greater_than_or_equal_to(starting_date)).select(&tracking_notification?)
     end
     
     private
 
-    def greater_than_or_equal_to(from_date)
-      lambda { |notification| Chronic.parse(notification.date) >= from_date }
+    def greater_than_or_equal_to(starting_date)
+      lambda { |notification| Chronic.parse(notification.date) >= starting_date }
     end
 
     def tracking_notification?

data/lib/trello_effort_tracker/tracked_card.rb

@@ -7,6 +7,7 @@ class TrackedCard
   field :description
   field :short_id,    type: Integer
   field :trello_id
+  field :done,        type: Boolean
   field :due,         type: Date
   field :closed,      type: Boolean
   field :url
@@ -25,10 +26,10 @@ class TrackedCard
   end
 
   def self.update_or_create_with(trello_card)
-    card = TrackedCard.find_or_create_by(trello_id: trello_card.id)
+    tracked_card = find_or_create_by(trello_id: trello_card.id)
     trello_card.attributes.delete(:id)
-    success = card.update_attributes(trello_card.attributes)
-    return card if success
+    updated_successfully = tracked_card.update_attributes(trello_card.attributes.merge(done: trello_card.in_done_column?))
+    return tracked_card if updated_successfully
   end
 
   def self.build_from(trello_card)
@@ -38,13 +39,19 @@ class TrackedCard
   end
 
   def add(tracking)
-    if tracking.estimate? && estimates.none? {|e| e.tracking_notification_id == tracking.estimate.tracking_notification_id}
-      estimates << tracking.estimate
-    elsif tracking.effort? && efforts.none? {|e| e.tracking_notification_id == tracking.effort.tracking_notification_id}
-      efforts << tracking.effort
-    else
-      Trello.logger.warn "Ignoring tracking notification: #{tracking}" if tracking.unknown_format?
-    end
+    tracking.add_to(self)
+  end
+
+  def add!(tracking)
+    add(tracking) && save!
+  end
+
+  def contains_effort?(effort)
+    efforts.any? { |e| e.tracking_notification_id == effort.tracking_notification_id }
+  end
+
+  def contains_estimate?(estimate)
+    estimates.any? { |e| e.tracking_notification_id == estimate.tracking_notification_id }
   end
 
   def no_tracking?

data/lib/trello_effort_tracker/tracking/base.rb

@@ -0,0 +1,82 @@
+module Tracking
+  module Base
+    extend Forwardable
+    include TrelloConfiguration
+
+    TIME_CONVERTERS = {
+      'h' => lambda { |estimate| estimate },
+      'd' => lambda { |estimate| estimate * 8 },
+      'g' => lambda { |estimate| estimate * 8 },
+      'p' => lambda { |estimate| estimate / 2  }
+    }
+
+    DURATION_REGEXP = '(\d+\.?\d*[phdg])'
+    DATE_REGEXP = /(\d{2})\.(\d{2})\.(\d{4})/
+
+    # delegate to the trello notification the member_creator method aliased as 'notifier'
+    def_delegator :@tracking_notification, :member_creator, :notifier
+
+    def initialize(tracking_notification)
+      @tracking_notification = tracking_notification
+    end
+
+    def date
+      Chronic.parse(date_as_string).to_date
+    end
+
+    def to_s
+      "[#{date}] From #{notifier.username.color(:green)}\t on card '#{trello_card.name.color(:yellow)}': #{raw_text}"
+    end
+
+    private
+
+    def tracking_notification
+      @tracking_notification
+    end
+
+    def trello_card
+      @trello_card ||= tracking_notification.card
+    end
+
+    def notification_date
+      Chronic.parse(tracking_notification.date).to_date
+    end
+
+    def raw_tracking
+      raw_text.gsub("@#{tracker_username}", "")
+    end
+
+    def raw_text
+      tracking_notification.data['text']
+    end
+
+    def convert_to_hours(duration_as_string)
+      return if duration_as_string.nil?
+
+      time_scale = duration_as_string.slice!(-1)
+      converter = TIME_CONVERTERS[time_scale]
+      converter.call(Float(duration_as_string))
+    end
+
+    def date_as_string
+      case raw_tracking
+      when DATE_REGEXP
+        day, month, year = raw_tracking.scan(DATE_REGEXP).flatten
+        "#{year}-#{month}-#{day}"
+      when /yesterday\s+\+#{DURATION_REGEXP}/, /\+#{DURATION_REGEXP}\s+yesterday/
+          (notification_date - 1).to_s
+      else
+        tracking_notification.date
+      end
+    end
+
+    def extract_match_from_raw_tracking(regexp)
+      extracted = nil
+      raw_tracking.scan(regexp) do |match|
+        extracted = match.first
+      end
+
+      extracted
+    end
+  end
+end

data/lib/trello_effort_tracker/tracking/card_done_tracking.rb

@@ -0,0 +1,10 @@
+module Tracking
+  class CardDoneTracking
+    include Base
+
+    def add_to(card)
+      card.done = true
+    end
+
+  end
+end

data/lib/trello_effort_tracker/tracking/effort_tracking.rb

@@ -0,0 +1,45 @@
+module Tracking
+  class EffortTracking
+    include Base
+
+    #TODO: rename to 'amount' ?
+    #TODO: avoid recomputing effort every time using a lazy instance variable
+    def effort
+      effort_amount = convert_to_hours(raw_effort)
+      if effort_amount
+        total_effort = effort_amount * effort_members.size
+        Effort.new(amount: total_effort, date: date, members: effort_members, tracking_notification_id: tracking_notification.id)
+      end
+    end
+
+    def add_to(card)
+      card.efforts << effort unless card.contains_effort?(effort)
+    end
+
+    private
+
+    def raw_effort
+      extract_match_from_raw_tracking(/\+#{DURATION_REGEXP}/)
+    end
+
+    def effort_members
+      @effort_members ||= users_involved_in_the_effort.map do |username|
+        Member.build_from(Trello::Member.find(username))
+      end
+
+      @effort_members
+    end
+
+    def users_involved_in_the_effort
+      users_involved_in_the_effort = raw_tracking.scan(/@(\w+)/).flatten
+      users_involved_in_the_effort << notifier.username unless should_count_only_listed_members?
+
+      users_involved_in_the_effort
+    end
+
+    def should_count_only_listed_members?
+      raw_tracking =~ /\((@\w+\W*\s*)+\)/
+    end
+
+  end
+end