tray-checkout 0.4.3 → 0.4.4

data/CHANGELOG.rdoc

@@ -1,3 +1,7 @@
+== Version 0.4.4
+- Parse general errors.
+- Using ActiveSupport >= 3.1 version.
+
 == Version 0.4.3
 - "url_img" parameter is in "product", not in "transaction".
 

data/lib/tray/checkout/response_parser.rb

@@ -7,7 +7,8 @@ class Tray::Checkout::ResponseParser
   end
 
   def self.get_parser(xml)
-    Tray::Checkout::ResponseParser.transaction?(xml) ? 
+    #TODO: Remove this POG, please!
+    Tray::Checkout::ResponseParser.transaction?(xml) ?
       Tray::Checkout::TransactionResponseParser.new(xml) :
       Tray::Checkout::AccountResponseParser.new(xml)
   end
@@ -65,6 +66,10 @@ class Tray::Checkout::ResponseParser
       error_response[:errors] = error_response.delete(:validation_errors)
     end
 
+    if error_response[:general_errors]
+      error_response[:errors] = error_response.delete(:general_errors)
+    end
+
     error_response[:errors]
   end
 end

data/lib/tray/checkout/version.rb

@@ -1,7 +1,7 @@
 # encoding: UTF-8
 module Tray
   module Checkout
-    VERSION = "0.4.3"
+    VERSION = '0.4.4'
   end
 end
 

data/spec/support/mock_request.rb

@@ -14,6 +14,7 @@ def body_for(response)
        :create_success_boleto,
        :create_success_mastercard,
        :create_failure_validation_errors,
+       :create_failure_general_errors,
        :create_temp_transaction_with_token,
        :get_account_info
     read_file_for(response)

data/spec/support/responses/create_failure_general_errors.xml

@@ -0,0 +1,14 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<tmp_transaction>
+  <message_response>
+    <message>error</message>
+  </message_response>
+  <error_response>
+    <general_errors type="array">
+      <general_error>
+        <code>058001</code>
+        <message>Revendedor inválido.</message>
+      </general_error>
+    </general_errors>
+  </error_response>
+</tmp_transaction>

data/spec/tray/checkout/account_spec.rb

@@ -23,7 +23,7 @@ describe Tray::Checkout::Account do
       end
 
       it 'response returns true' do
-        @response.success?.should be_true
+        @response.success?.should be true
       end
 
       it 'response has name attribute' do
@@ -43,7 +43,7 @@ describe Tray::Checkout::Account do
       end
 
       it 'response returns false' do
-        @response.success?.should be_false
+        @response.success?.should be false
       end
     end
   end

data/spec/tray/checkout/response_parser_spec.rb

@@ -9,7 +9,7 @@ describe Tray::Checkout::ResponseParser do
       let(:response) { parser.parse }
 
       it "returns success" do
-        response.success?.should be_true
+        response.success?.should be true
       end
     end
 
@@ -19,7 +19,7 @@ describe Tray::Checkout::ResponseParser do
       let(:response) { parser.parse  }
 
       it "does not return success" do
-        response.success?.should be_false
+        response.success?.should be false
       end
 
       context "returns error" do
@@ -39,7 +39,7 @@ describe Tray::Checkout::ResponseParser do
       let(:response) { parser.parse  }
 
       it "does not return success" do
-        response.success?.should be_false
+        response.success?.should be false
       end
 
       context "returns error" do
@@ -52,6 +52,26 @@ describe Tray::Checkout::ResponseParser do
         end
       end
     end
+
+    context "with general error response" do
+      let(:xml) { body_for :create_failure_general_errors }
+      let(:parser) { Tray::Checkout::ResponseParser.new(xml) }
+      let(:response) { parser.parse }
+
+      it "does not return success" do
+        response.success?.should be false
+      end
+
+      context "returns error" do
+        { code: "058001",
+          message: "Revendedor inválido."
+        }.each do |param, value|
+          it param do
+            response.errors.first[param].should == value
+          end
+        end
+      end
+    end
   end
 
   describe("transaction?") do
@@ -59,7 +79,7 @@ describe Tray::Checkout::ResponseParser do
       let(:xml) { body_for :get_success_boleto }
 
       it "returns true" do
-        Tray::Checkout::ResponseParser.transaction?(xml).should be_true
+        Tray::Checkout::ResponseParser.transaction?(xml).should be true
       end
     end
 
@@ -67,7 +87,7 @@ describe Tray::Checkout::ResponseParser do
       let(:xml) { body_for :get_account_info }
 
       it "returns false" do
-        Tray::Checkout::ResponseParser.transaction?(xml).should be_false
+        Tray::Checkout::ResponseParser.transaction?(xml).should be false
       end
     end
   end

data/spec/tray/checkout/response_spec.rb

@@ -6,7 +6,7 @@ describe Tray::Checkout::Response do
 
   describe ".new" do
     it "sets success to false" do
-      response.success?.should be_false
+      response.success?.should be false
     end
 
     it "sets errors to empty" do

data/spec/tray/checkout/transaction_response_parser_spec.rb

@@ -9,7 +9,7 @@ describe Tray::Checkout::TransactionResponseParser do
       let(:response) { parser.parse }
 
       it "returns success" do
-        response.success?.should be_true
+        response.success?.should be true
       end
 
       context "returns transaction" do
@@ -56,7 +56,7 @@ describe Tray::Checkout::TransactionResponseParser do
       let(:response) { parser.parse }
 
       it "returns success" do
-        response.success?.should be_true
+        response.success?.should be true
       end
 
       it "returns empty errors" do

data/spec/tray/checkout/transaction_spec.rb

@@ -92,7 +92,7 @@ describe Tray::Checkout::Transaction do
       end
 
       it "returns success" do
-        @response.success?.should be_true
+        @response.success?.should be true
       end
 
       it "returns the transaction with only one parameter" do
@@ -108,7 +108,7 @@ describe Tray::Checkout::Transaction do
       end
 
       it "returns success" do
-        @response.success?.should be_true
+        @response.success?.should be true
       end
 
       it "returns transaction data" do
@@ -134,7 +134,7 @@ describe Tray::Checkout::Transaction do
       end
 
       it "does not return success" do
-        @response.success?.should be_false
+        @response.success?.should be false
       end
 
       it "returns errors" do
@@ -156,7 +156,7 @@ describe Tray::Checkout::Transaction do
       end
 
       it "returns success" do
-        @response.success?.should be_true
+        @response.success?.should be true
       end
 
       it "returns transaction data" do
@@ -182,7 +182,7 @@ describe Tray::Checkout::Transaction do
       end
 
       it "returns success" do
-        @response.success?.should be_true
+        @response.success?.should be true
       end
 
       it "returns transaction data" do
@@ -210,7 +210,7 @@ describe Tray::Checkout::Transaction do
       end
 
       it "does not return success" do
-        @response.success?.should be_false
+        @response.success?.should be false
       end
 
       it "returns error" do

data/spec/tray/checkout/uri_spec.rb

@@ -6,14 +6,14 @@ describe URI do
     context "when is SSL" do
       it "returns true" do
         uri = URI.parse("https://prodis.webstorelw.com.br")
-        uri.ssl?.should be_true
+        uri.ssl?.should be true
       end
     end
 
     context "when is not SSL" do
       it "returns false" do
         uri = URI.parse("http://prodis.blog.br")
-        uri.ssl?.should be_false
+        uri.ssl?.should be false
       end
     end
   end

data/tray-checkout.gemspec

@@ -5,7 +5,7 @@ require 'tray/checkout/version'
 Gem::Specification.new do |gem|
   gem.name        = "tray-checkout"
   gem.version     = Tray::Checkout::VERSION
-  gem.authors     = ["Prodis a.k.a. Fernando Hamasaki"]
+  gem.authors     = ["Prodis a.k.a. Fernando Hamasaki de Amorim"]
   gem.email       = ["prodis@gmail.com"]
   gem.summary     = "Tray Checkout API"
   gem.description = "Tray Checkout API"
@@ -20,12 +20,12 @@ Gem::Specification.new do |gem|
   gem.platform              = Gem::Platform::RUBY
   gem.required_ruby_version = Gem::Requirement.new(">= 1.9.2")
 
-  gem.add_dependency "activesupport", "~> 3.1"
+  gem.add_dependency "activesupport", ">= 3.1"
   gem.add_dependency "log-me", '0.0.9'
 
   gem.add_development_dependency "pry"
   gem.add_development_dependency "rake"
-  gem.add_development_dependency "rspec",   "~> 2.12"
+  gem.add_development_dependency "rspec", "~> 2.12"
   gem.add_development_dependency "webmock", "~> 1.9"
   gem.add_development_dependency "vcr", "~> 2.6.0"
 end

metadata

@@ -1,32 +1,36 @@
 --- !ruby/object:Gem::Specification
 name: tray-checkout
 version: !ruby/object:Gem::Version
-  version: 0.4.3
+  version: 0.4.4
+  prerelease: 
 platform: ruby
 authors:
-- Prodis a.k.a. Fernando Hamasaki
+- Prodis a.k.a. Fernando Hamasaki de Amorim
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-01-09 00:00:00.000000000 Z
+date: 2015-06-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
   requirement: !ruby/object:Gem::Requirement
+    none: false
     requirements:
-    - - ~>
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '3.1'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
+    none: false
     requirements:
-    - - ~>
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '3.1'
 - !ruby/object:Gem::Dependency
   name: log-me
   requirement: !ruby/object:Gem::Requirement
+    none: false
     requirements:
     - - '='
       - !ruby/object:Gem::Version
@@ -34,6 +38,7 @@ dependencies:
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
+    none: false
     requirements:
     - - '='
       - !ruby/object:Gem::Version
@@ -41,6 +46,7 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: pry
   requirement: !ruby/object:Gem::Requirement
+    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
@@ -48,6 +54,7 @@ dependencies:
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
+    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
@@ -55,6 +62,7 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
+    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
@@ -62,6 +70,7 @@ dependencies:
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
+    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
@@ -69,6 +78,7 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
+    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -76,6 +86,7 @@ dependencies:
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
+    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -83,6 +94,7 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: webmock
   requirement: !ruby/object:Gem::Requirement
+    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -90,6 +102,7 @@ dependencies:
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
+    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -97,6 +110,7 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: vcr
   requirement: !ruby/object:Gem::Requirement
+    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -104,6 +118,7 @@ dependencies:
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
+    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -141,6 +156,7 @@ files:
 - lib/tray/checkout/web_service.rb
 - spec/spec_helper.rb
 - spec/support/mock_request.rb
+- spec/support/responses/create_failure_general_errors.xml
 - spec/support/responses/create_failure_validation_errors.xml
 - spec/support/responses/create_success_boleto.xml
 - spec/support/responses/create_success_mastercard.xml
@@ -177,30 +193,35 @@ files:
 homepage: https://github.com/prodis/tray-checkout
 licenses:
 - MIT
-metadata: {}
 post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
+  none: false
   requirements:
   - - ! '>='
     - !ruby/object:Gem::Version
       version: 1.9.2
 required_rubygems_version: !ruby/object:Gem::Requirement
+  none: false
   requirements:
   - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
+      segments:
+      - 0
+      hash: -1644705188012950785
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.2
+rubygems_version: 1.8.25
 signing_key: 
-specification_version: 4
+specification_version: 3
 summary: Tray Checkout API
 test_files:
 - spec/spec_helper.rb
 - spec/support/mock_request.rb
+- spec/support/responses/create_failure_general_errors.xml
 - spec/support/responses/create_failure_validation_errors.xml
 - spec/support/responses/create_success_boleto.xml
 - spec/support/responses/create_success_mastercard.xml

checksums.yaml

@@ -1,15 +0,0 @@
----
-!binary "U0hBMQ==":
-  metadata.gz: !binary |-
-    OGM3MDBhZDNlODkzYWE5MGEwYjI0YjFlMzJlMjhkNGJiNzE2Y2Q3Yg==
-  data.tar.gz: !binary |-
-    YzBkZDI4MjZiYjQ2MmMzM2IzNjRmOTFkMTY3ZmQ3NmUxY2M4MzVkNw==
-SHA512:
-  metadata.gz: !binary |-
-    ZmEzOTcwNWE3OTFkNTdkMDRiOTBlNDlhZDZhMjcyZjQ1NzBiYjJlMjg1Yjhk
-    MTdlYzVjNWI2NDU2YWMxODBjM2M0ZDU1NDI1Y2I4ZDBhMzIyY2IzZGY4ZTBl
-    ZDU0YWRhMjJiNDU1N2ZmYWNmYTlhMTg2ZTAwOTZjZTBkNGY5ZDM=
-  data.tar.gz: !binary |-
-    NmMzOTUzNGYyNmM4NDI0MGU4OTI3YjFiYTcyOGY0NDUwYzgxYmY0YjBlNjEz
-    NmQxODcxMGY1NmYyNjYwZjA3MGQ3ZTBiZTU5ZTgzODc4NGEwMGJlY2MzMDUx
-    NDliOTNiYThlYmJiM2MzNDZhZTFkMGNmZWE0YTg0MGE4MTA0MGE=