tray-checkout 0.4.2 → 0.4.3

checksums.yaml

@@ -1,15 +1,15 @@
 ---
 !binary "U0hBMQ==":
   metadata.gz: !binary |-
-    MTZhMjQ2ZTYyZmI5OTYwZjZmMTRlNzhmMzU5MjZiMzkwNzE4OGQ5NQ==
+    OGM3MDBhZDNlODkzYWE5MGEwYjI0YjFlMzJlMjhkNGJiNzE2Y2Q3Yg==
   data.tar.gz: !binary |-
-    MjY4MmQ5Y2U1ZmI4NzhiNjBmYjg4NDg4MDBlMmIyM2U2YzFiMmUyMg==
+    YzBkZDI4MjZiYjQ2MmMzM2IzNjRmOTFkMTY3ZmQ3NmUxY2M4MzVkNw==
 SHA512:
   metadata.gz: !binary |-
-    YTk1YzFlMDkyYmZjODVkNTExZGQxMGI3YTg5ZTA3ZmI5ZDdiNTFhNzY3MmNh
-    ZjgzNzFiYzRmODJiODY4ZTBiZTU1NWQ3ZWEzMzhjN2U2ZGM1NDcwZTQ1Y2I4
-    NTFkMjBlMGVlZjlhNGE0NTc2NTNjMjQzODAwZWU0YmI5NjFiNjE=
+    ZmEzOTcwNWE3OTFkNTdkMDRiOTBlNDlhZDZhMjcyZjQ1NzBiYjJlMjg1Yjhk
+    MTdlYzVjNWI2NDU2YWMxODBjM2M0ZDU1NDI1Y2I4ZDBhMzIyY2IzZGY4ZTBl
+    ZDU0YWRhMjJiNDU1N2ZmYWNmYTlhMTg2ZTAwOTZjZTBkNGY5ZDM=
   data.tar.gz: !binary |-
-    NTIwMDhlZWE1OWVjZTU5YjQ3N2ZjMjMzMTRhNzBmYmY0MWFmMmM4MTdjZDlj
-    YjQyZDRkYzY2YzFjNzMxNDY1YWZhZjA1MTJlMDE5OTBhODU0YmJlYTVhZjli
-    OGVkYzUzNWZhZDkyNWY2N2Y1OTFmODMxMDFjODk5YjcwYjllOGI=
+    NmMzOTUzNGYyNmM4NDI0MGU4OTI3YjFiYTcyOGY0NDUwYzgxYmY0YjBlNjEz
+    NmQxODcxMGY1NmYyNjYwZjA3MGQ3ZTBiZTU5ZTgzODc4NGEwMGJlY2MzMDUx
+    NDliOTNiYThlYmJiM2MzNDZhZTFkMGNmZWE0YTg0MGE4MTA0MGE=

data/CHANGELOG.rdoc

@@ -1,3 +1,6 @@
+== Version 0.4.3
+- "url_img" parameter is in "product", not in "transaction".
+
 == Version 0.4.2
 - Avoid errors in TrayCheckout API when "url_img" parameter does not have a value.
 

data/lib/tray/checkout/params_parser.rb

@@ -8,7 +8,6 @@ module Tray
 
       def parse
         token_account! @params
-        transaction_map! @params
         customer_map! @params[:customer]
         payment_map!  @params[:payment]
         products_map! @params
@@ -21,14 +20,6 @@ module Tray
         params[:token_account] = Tray::Checkout.token_account if params[:token_account].nil?
       end
 
-      def transaction_map!(params)
-        return unless params[:transaction]
-
-        if params[:transaction][:url_img].to_s.empty?
-          params[:transaction].delete(:url_img)
-        end
-      end
-
       def customer_map!(customer)
         return unless customer
         customer[:birth_date] = customer[:birth_date].strftime("%d/%m/%Y") if customer[:birth_date] && customer[:birth_date].is_a?(Date)
@@ -63,7 +54,12 @@ module Tray
 
       def products_map!(params)
         return unless params[:transaction]
+
         params[:transaction_product] = params[:transaction].delete(:products)
+
+        params[:transaction_product].each do |product|
+          product.delete(:url_img) if product[:url_img].to_s.empty?
+        end
       end
     end
   end

data/lib/tray/checkout/version.rb

@@ -1,7 +1,7 @@
 # encoding: UTF-8
 module Tray
   module Checkout
-    VERSION = "0.4.2"
+    VERSION = "0.4.3"
   end
 end
 

data/spec/tray/checkout/params_parser_spec.rb

@@ -41,17 +41,18 @@ describe Tray::Checkout::ParamsParser do
           shipping_type: "Sedex",
           shipping_price: 13.94,
           url_notification: "http://prodis.blog.br/tray_notification",
-          url_img: "http://prodis.net.br/images/prodis_150.gif",
           products: [
             { code: "LOGO-8278",
               quantity: 2,
               price_unit: 100.99,
-              description: "Logo Prodis"
+              description: "Logo Prodis",
+              url_img: "http://prodis.net.br/images/prodis_150.gif"
             },
             { code: "877",
               quantity: 1,
               price_unit: 10.00,
-              description: "Outro produto"
+              description: "Outro produto",
+              url_img: nil
             }
           ]
         },
@@ -73,19 +74,6 @@ describe Tray::Checkout::ParamsParser do
     let(:response_params) { parser.parse }
 
     describe "#parse" do
-      context "when transaction has image URL" do
-        it "keeps image URL parameter" do
-          response_params[:transaction][:url_img].should == params[:transaction][:url_img]
-        end
-      end
-
-      context "when image URL is nil" do
-        it "removes image URL parameter" do
-          params[:transaction][:url_img] = nil
-          response_params[:transaction].has_key?(:url_img).should eq false
-        end
-      end
-
       it "sets customer gender expect API value" do
         response_params[:customer][:gender].should == "M"
       end
@@ -138,6 +126,18 @@ describe Tray::Checkout::ParamsParser do
         response_params[:transaction_product][1][:description].should == "Outro produto"
       end
 
+      context "when product has image" do
+        it "keeps image URL parameter" do
+          response_params[:transaction_product][0][:url_img].should == "http://prodis.net.br/images/prodis_150.gif"
+        end
+      end
+
+      context "when image URL parameter is nil" do
+        it "removes image URL parameter" do
+          response_params[:transaction_product][1].has_key?(:url_img).should eq false
+        end
+      end
+
       it "keeps token account supplied in params" do
         response_params[:token_account].should == params[:token_account]
       end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: tray-checkout
 version: !ruby/object:Gem::Version
-  version: 0.4.2
+  version: 0.4.3
 platform: ruby
 authors:
 - Prodis a.k.a. Fernando Hamasaki