travis-lint 1.2.0 → 1.3.0

data/lib/travis/lint/linter.rb

@@ -20,7 +20,7 @@ module Travis
       def self.validate(hsh)
         hsh = Hashr.new hsh
 
-        issues = find_validators_for(hsh[:language]).inject([]) do |acc, val|
+        find_validators_for(hsh[:language]).inject([]) do |acc, val|
           acc << val.call(hsh)
           acc
         end.reject(&:first).map { |pair| pair[1] }
@@ -87,24 +87,53 @@ module Travis
         ("ruby" == hsh[:language].to_s.downcase) && hsh[:rvm].is_a?(Array) && !known_ruby_versions?(hsh[:rvm])
       end
 
-      validator_for :node_js, :node_js, "Detected unsupported Node.js versions. For an up-to-date list of supported Node.js versions, see #{DOCS_URL}" do |hsh|
-        ("node_js" == hsh[:language].to_s.downcase) && hsh[:node_js].is_a?(Array) && !known_node_js_versions?(hsh[:node_js])
+      validator_for :ruby, :language, "Language is set to Ruby but node_js key is present. Ruby builder will ignore node_js key." do |hsh|
+        hsh[:language].to_s.downcase == "ruby" && ! blank?(hsh[:node_js])
       end
 
+
+      KNOWN_RUBY_VERSIONS = %w(1.8.7 ruby-1.8.7 1.9.2 ruby-1.9.2 1.9.3 ruby-1.9.3 ruby-head jruby jruby-18mode jruby-19mode rbx rbx-18mode rbx-19mode jruby-head ree ree-1.8.7)
+      KNOWN_NODE_VERSIONS = %w(0.4 0.6 0.7)
+      KNOWN_PHP_VERSIONS  = %w(5.2 5.3 5.3.2 5.3.8 5.4)
+
+      KNOWN_PYTHON_VERSIONS  = %w(2.5 2.6 2.7 3.1 3.2)
+      KNOWN_PERL_VERSIONS    = %w(5.10 5.12 5.14)
+
+
+      #
+      # PHP
+      #
+
       validator_for :php, :php, "Detected unsupported PHP versions. For an up-to-date list of supported PHP versions, see #{DOCS_URL}" do |hsh|
         ("php" == hsh[:language].to_s.downcase) && hsh[:php].is_a?(Array) && !known_php_versions?(hsh[:php])
       end
 
+      #
+      # Python
+      #
 
+      validator_for :python, :python, "Detected unsupported Python versions. For an up-to-date list of supported Python versions, see #{DOCS_URL}" do |hsh|
+        ("python" == hsh[:language].to_s.downcase) && hsh[:python].is_a?(Array) && !known_python_versions?(hsh[:python])
+      end
 
-      validator_for :ruby, :language, "Language is set to Ruby but node_js key is present. Ruby builder will ignore node_js key." do |hsh|
-        hsh[:language].to_s.downcase == "ruby" && ! blank?(hsh[:node_js])
+      #
+      # Perl
+      #
+
+      validator_for :perl, :perl, "Detected unsupported Perl versions. For an up-to-date list of supported Perl versions, see #{DOCS_URL}" do |hsh|
+        ("perl" == hsh[:language].to_s.downcase) && hsh[:perl].is_a?(Array) && !known_perl_versions?(hsh[:perl])
+      end
+
+
+      #
+      # Node.js
+      #
+
+      validator_for :node_js, :node_js, "Detected unsupported Node.js versions. For an up-to-date list of supported Node.js versions, see #{DOCS_URL}" do |hsh|
+        ("node_js" == hsh[:language].to_s.downcase) && hsh[:node_js].is_a?(Array) && !known_node_js_versions?(hsh[:node_js])
       end
 
 
-      KNOWN_RUBY_VERSIONS = %w(1.8.7 ruby-1.8.7 1.9.2 ruby-1.9.2 1.9.3 ruby-1.9.3 ruby-head jruby jruby-18mode jruby-19mode rbx rbx-18mode rbx-19mode jruby-head ree ree-1.8.7)
-      KNOWN_NODE_VERSIONS = %w(0.4 0.6 0.7)
-      KNOWN_PHP_VERSIONS  = %w(5.2 5.3 5.3.2 5.3.8 5.4)
 
       protected
 
@@ -129,6 +158,20 @@ module Travis
         unknown.empty?
       end
 
+      def self.known_python_versions?(ary)
+        ary = ary.map(&:to_s)
+
+        unknown = ary - KNOWN_PYTHON_VERSIONS
+        unknown.empty?
+      end
+
+      def self.known_perl_versions?(ary)
+        ary = ary.map(&:to_s)
+
+        unknown = ary - KNOWN_PERL_VERSIONS
+        unknown.empty?
+      end
+
     end
   end
 end

data/lib/travis/lint/runner.rb

@@ -32,6 +32,7 @@ module Travis
             puts
             puts
           end
+          quit ".travis.yml at #{@travis_file_path} has issues and thus will be ignored by Travis CI."
         end
       end
 
@@ -47,7 +48,7 @@ module Travis
       def check_that_travis_yml_file_is_valid_yaml!
         begin
           YAML.load_file(@travis_file_path)
-        rescue ArgumentError, Psych::SyntaxError => e
+        rescue ArgumentError, Psych::SyntaxError
           quit ".travis.yml at #{@travis_file_path} is not a valid YAML file and thus will be ignored by Travis CI."
         end
       end

data/lib/travis/lint/version.rb

@@ -1,6 +1,6 @@
 module Travis
   module Lint
-    VERSION = "1.2.0"
+    VERSION = "1.3.0"
     Version = VERSION
   end
 end

data/spec/files/uses_unsupported_perl.yml

@@ -0,0 +1,7 @@
+language: perl
+perl:
+  - "5.6"
+  - "5.8"
+  - "5.10"
+  - "5.12"
+  - "5.14"

data/spec/files/uses_unsupported_python.yml

@@ -0,0 +1,7 @@
+language: python
+python:
+  - "2.3"
+  - "2.4"
+  - "2.5"
+  - "2.6"
+  - "2.7"

data/spec/travis_lint_runner_spec.rb

@@ -0,0 +1,27 @@
+require "spec_helper"
+require "stringio"
+
+def capture_stdout
+  $stdout = StringIO.new
+  yield
+ensure
+  $stdout = STDOUT
+end
+
+describe "A .travis.yml" do
+  context "with issues" do
+    it "run should exit with non-zero exit status" do
+      status = 0
+
+      begin
+        capture_stdout do
+          Travis::Lint::Runner.new(["spec/files/no_language_key.yml"]).run()
+        end
+      rescue SystemExit => e
+        status = e.status
+      end
+
+      status.should_not == 0
+    end
+  end
+end

data/spec/travis_lint_spec.rb

@@ -29,6 +29,9 @@ describe "A .travis.yml" do
     { :key => :otp_release, :issue => "Specify OTP releases you want to test against using the \"otp_release\" key" }
   end
 
+  let(:docs) { "Travis CI documentation at http://bit.ly/travis-ci-environment" }
+
+
 
   def content_of_sample_file(name)
     path = Pathname.new(File.join("spec", "files", name)).expand_path
@@ -105,8 +108,6 @@ describe "A .travis.yml" do
     end
 
 
-    let(:docs) { "Travis CI documentation at http://bit.ly/travis-ci-environment" }
-
 
     context "and uses an unsupported Ruby version" do
       let(:unsupported_rubies) do
@@ -124,6 +125,20 @@ describe "A .travis.yml" do
     end
 
 
+    context "that specifies Ruby as the language but tries to set node_js version" do
+      let(:travis_yml) do
+        { :language => "ruby", :rvm => ["1.9.3"], :node_js => ["0.6"] }
+      end
+
+      it "is invalid" do
+        Travis::Lint::Linter.validate(travis_yml).should include({ :key => :language, :issue => "Language is set to Ruby but node_js key is present. Ruby builder will ignore node_js key." })
+      end
+    end
+  end
+
+
+
+  context "that has language set to node_js" do
     context "and uses an unsupported Node.js version" do
       let(:unsupported_nodejs) do
         { :key => :node_js, :issue => "Detected unsupported Node.js versions. For an up-to-date list of supported Node.js versions, see #{docs}" }
@@ -138,7 +153,10 @@ describe "A .travis.yml" do
         Travis::Lint::Linter.valid?(content_of_sample_file("uses_unsupported_nodejs.yml")).should be_false
       end
     end
+  end
+
 
+  context "that has language set to PHP" do
     context "and uses an unsupported PHP version" do
       let(:unsupported_php) do
         { :key => :php, :issue => "Detected unsupported PHP versions. For an up-to-date list of supported PHP versions, see #{docs}" }
@@ -153,19 +171,50 @@ describe "A .travis.yml" do
         Travis::Lint::Linter.valid?(content_of_sample_file("uses_unsupported_php.yml")).should be_false
       end
     end
+  end
 
 
-    context "that specifies Ruby as the language but tries to set node_js version" do
+
+  context "that has language set to Python" do
+    context "and uses an unsupported Python version" do
+      let(:unsupported_python) do
+        { :key => :python, :issue => "Detected unsupported Python versions. For an up-to-date list of supported Python versions, see #{docs}" }
+      end
+
       let(:travis_yml) do
-        { :language => "ruby", :rvm => ["1.9.3"], :node_js => ["0.6"] }
+        { :language => "python", :python => ["stackless-py", "2.4", "2.3"] }
       end
 
       it "is invalid" do
-        Travis::Lint::Linter.validate(travis_yml).should include({ :key => :language, :issue => "Language is set to Ruby but node_js key is present. Ruby builder will ignore node_js key." })
+        Travis::Lint::Linter.validate(travis_yml).should include(unsupported_python)
+        Travis::Lint::Linter.valid?(content_of_sample_file("uses_unsupported_python.yml")).should be_false
+      end
+    end
+  end
+
+
+
+  context "that has language set to Perl" do
+    context "and uses an unsupported Perl version" do
+      let(:unsupported_perl) do
+        { :key => :perl, :issue => "Detected unsupported Perl versions. For an up-to-date list of supported Perl versions, see #{docs}" }
+      end
+
+      let(:travis_yml) do
+        { :language => "perl", :perl => ["5.6", "5.8"] }
+      end
+
+      it "is invalid" do
+        Travis::Lint::Linter.validate(travis_yml).should include(unsupported_perl)
+        Travis::Lint::Linter.valid?(content_of_sample_file("uses_unsupported_perl.yml")).should be_false
       end
     end
   end
 
+
+
+
+
   context "that has language set to erlang" do
     context "but has no \"otp_release\" key" do
       it "is invalid" do

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: travis-lint
 version: !ruby/object:Gem::Version 
-  hash: 31
+  hash: 27
   prerelease: 
   segments: 
   - 1
-  - 2
+  - 3
   - 0
-  version: 1.2.0
+  version: 1.3.0
 platform: ruby
 authors: 
 - Michael S. Klishin
@@ -16,7 +16,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2012-02-17 00:00:00 Z
+date: 2012-03-06 00:00:00 Z
 dependencies: 
 - !ruby/object:Gem::Dependency 
   name: hashr
@@ -80,9 +80,12 @@ files:
 - spec/files/uses_old_rbx_aliases.yml
 - spec/files/uses_ruby_as_language_but_tries_to_switch_nodejs.yml
 - spec/files/uses_unsupported_nodejs.yml
+- spec/files/uses_unsupported_perl.yml
 - spec/files/uses_unsupported_php.yml
+- spec/files/uses_unsupported_python.yml
 - spec/files/uses_unsupported_rubies.yml
 - spec/spec_helper.rb
+- spec/travis_lint_runner_spec.rb
 - spec/travis_lint_spec.rb
 - travis-lint.gemspec
 homepage: http://github.com/travis-ci
@@ -118,5 +121,17 @@ rubygems_version: 1.8.15
 signing_key: 
 specification_version: 3
 summary: Checks your .travis.yml for possible issues, deprecations and so on
-test_files: []
-
+test_files: 
+- spec/files/no_language_key.yml
+- spec/files/no_rvm_key.yml
+- spec/files/uses_jruby_instead_of_jruby_in_specific_mode.yml
+- spec/files/uses_old_rbx_aliases.yml
+- spec/files/uses_ruby_as_language_but_tries_to_switch_nodejs.yml
+- spec/files/uses_unsupported_nodejs.yml
+- spec/files/uses_unsupported_perl.yml
+- spec/files/uses_unsupported_php.yml
+- spec/files/uses_unsupported_python.yml
+- spec/files/uses_unsupported_rubies.yml
+- spec/spec_helper.rb
+- spec/travis_lint_runner_spec.rb
+- spec/travis_lint_spec.rb