transitions 1.2.1 → 1.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 58aeaa0b000342900f3a34bf42431cd65f8dd632
-  data.tar.gz: 5667fb95cdcbc4339f8dda5fc6b4a633b2d80efa
+SHA256:
+  metadata.gz: 499d85851d31ed292773802c44a68d0b1845280b4aaadbb569fc598b3c975028
+  data.tar.gz: 28f4dfd13383376ee30fc360aed8d948ce6d546c2de29673f5a4e4160df7afaf
 SHA512:
-  metadata.gz: f881e73d0a839f28cecd58f0c93a598a1884ef1ab167a8ede9e5168a94d62bd87160bc2ffe1b6452be218fb8ecd0a092ad2735feba2e62a434c59ca25ebc36f8
-  data.tar.gz: d1fda9b6559ba36cf35de667e71e5644a0a03d17ba000980e6ce22fbda0486c8b573f4e9f89b444e91dbc316cd5e4367510fa3d012ddb696ff8afc9103897089
+  metadata.gz: f1932cbdbcbea2a3b75abe4805536c1f2426b0139e83c73be9d0bf4ae28fe141285b9351df3a218b2da1c4ca4a2fa3b3e354973670671cda8ff4d3b1900f51ff
+  data.tar.gz: 75feff301bfb543636512c377ea1743e2970c07bd25fed3af4c42d4c19c6f3b8722841be9f85cf33d44c2e0bb20b2bdc20e62bd7cf97c9aaaabc10533aa53874

data/.gitignore

@@ -5,3 +5,4 @@ pkg
 Gemfile.lock
 gemfiles/*.lock
 *.swp
+vendor/bundle

data/.reek.yml

@@ -0,0 +1,100 @@
+# Auto generated by Reeks --todo flag
+---
+detectors:
+  Attribute:
+    exclude:
+    - Transitions::Machine#events
+    - Transitions::Machine#initial_state
+    - Transitions::Machine#state_index
+    - Transitions::Machine#states
+  BooleanParameter:
+    exclude:
+    - Transitions#update_current_state
+  ControlParameter:
+    exclude:
+    - Transitions#update_current_state
+  DataClump:
+    exclude:
+    - Transitions::Machine
+  DuplicateMethodCall:
+    exclude:
+    - ActiveModel::Transitions#read_state
+    - ActiveModel::Transitions#reload
+    - ActiveModel::Transitions#set_initial_state
+    - Transitions::Event#fire
+    - Transitions::Event#initialize
+    - Transitions::Event#update
+    - Transitions::Machine#handle_event_success_callback
+    - Transitions::Machine#initial_state
+    - Transitions::State#define_state_query_method
+  FeatureEnvy:
+    exclude:
+    - Transitions::Event#can_execute_transition_from_state?
+    - Transitions::Event#default_timestamp_name
+    - Transitions::Event#error_message_for_invalid_transitions
+  InstanceVariableAssumption:
+    exclude:
+    - Transitions::Machine
+    - Transitions::State
+  IrresponsibleModule:
+    exclude:
+    - ActiveModel::Transitions
+    - Transitions::Machine
+    - Transitions::Presenter
+    - Transitions::State
+    - Transitions::StateTransition
+    - Transitions
+    - Transitions::ClassMethods
+    - Transitions::InvalidMethodOverride
+    - Transitions::InvalidTransition
+  LongParameterList:
+    exclude:
+    - Transitions::Event#can_execute_transition_from_state?
+    - Transitions::Event#fire
+    - Transitions::Machine#fire_event
+    - Transitions::Machine#transition_to_new_state
+    - Transitions::StateTransition#perform_guard
+  ManualDispatch:
+    exclude:
+    - Transitions::Event#default_timestamp_name
+    - Transitions::Event#error_message_for_invalid_transitions
+    - Transitions::Machine#fire_event
+    - Transitions::Machine#handle_event_failed_callback
+    - Transitions::Machine#handle_event_fired_callback
+    - Transitions::Machine#include_scopes
+    - Transitions::StateTransition#perform_guard
+  NestedIterators:
+    exclude:
+    - Transitions::Event#build_success_callback
+  NilCheck:
+    exclude:
+    - ActiveModel::Transitions#state_not_set?
+    - Transitions::Event#timestamp_defined?
+    - Transitions::StateTransition#execute
+    - Transitions#current_state
+  TooManyInstanceVariables:
+    exclude:
+    - Transitions::Event
+    - Transitions::Machine
+    - Transitions::StateTransition
+  TooManyStatements:
+    exclude:
+    - initialize
+    - Transitions::Event#build_success_callback
+    - Transitions::Event#fire
+    - Transitions::Machine#fire_event
+    - Transitions#current_state
+  UncommunicativeVariableName:
+    exclude:
+    - ActiveModel::Transitions#state_included?
+    - Transitions::Event#can_execute_transition_from_state?
+    - Transitions::Event#fire
+    - Transitions::Event#transitions
+    - Transitions::Event#transitions_from_state?
+    - Transitions::Machine#fire_event
+    - Transitions::StateTransition#executable?
+  UtilityFunction:
+    exclude:
+    - Transitions::Machine#handle_event_failed_callback
+    - Transitions::Machine#handle_event_fired_callback
+    - Transitions::StateTransition#perform_guard

data/.ruby-version

@@ -1 +1 @@
-2.2.3
+2.7.5

data/.travis.yml

@@ -8,6 +8,7 @@ rvm:
   - 2.1
   - 2.2
   - 2.3.0
+  - 3.0.2
   - rbx-2
   - jruby
 matrix:
@@ -23,3 +24,14 @@ gemfile:
   - gemfiles/rails_3_1.gemfile
   - gemfiles/rails_3_2.gemfile
   - gemfiles/rails_4_0.gemfile
+  - gemfiles/rails_6_1.gemfile
+jobs:
+  exclude:
+  - rvm: 3.0.2
+    gemfile: gemfiles/rails_3_0.gemfile
+  - rvm: 3.0.2
+    gemfile: gemfiles/rails_3_1.gemfile
+  - rvm: 3.0.2
+    gemfile: gemfiles/rails_3_2.gemfile
+  - rvm: 3.0.2
+    gemfile: gemfiles/rails_4_0.gemfile

data/Appraisals

@@ -21,3 +21,9 @@ appraise "rails_4_0" do
   gem "activerecord-jdbcsqlite3-adapter", '1.3.0.rc1', :platforms=>:jruby
   gem 'sqlite3', :platforms => :ruby
 end
+
+appraise "rails_6_1" do
+  gem "activerecord", "~>6.1.0"
+  gem "activerecord-jdbcsqlite3-adapter", '61.1', :platforms=>:jruby
+  gem 'sqlite3', :platforms => :ruby
+end

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+# 1.3.0
+
+* Ruby 3.0 support (fishisfast)
+
 # 1.2.1 (2016-11-07)
 
 * (jdguzman) remove explicit ActiveRecord dependency

data/gemfiles/rails_3_0.gemfile

@@ -3,7 +3,7 @@
 source "https://rubygems.org"
 
 gem "activerecord", "~> 3.0.10"
-gem "activerecord-jdbcsqlite3-adapter", :platforms=>:jruby
-gem "sqlite3", :platforms=>:ruby
+gem "activerecord-jdbcsqlite3-adapter", platforms: :jruby
+gem "sqlite3", platforms: :ruby
 
 gemspec :path=>"../"

data/gemfiles/rails_3_1.gemfile

@@ -3,7 +3,7 @@
 source "https://rubygems.org"
 
 gem "activerecord", "~>3.1.12"
-gem "activerecord-jdbcsqlite3-adapter", :platforms=>:jruby
-gem "sqlite3", :platforms=>:ruby
+gem "activerecord-jdbcsqlite3-adapter", platforms: :jruby
+gem "sqlite3", platforms: :ruby
 
 gemspec :path=>"../"

data/gemfiles/rails_3_2.gemfile

@@ -3,7 +3,7 @@
 source "https://rubygems.org"
 
 gem "activerecord", "~>3.2.14"
-gem "activerecord-jdbcsqlite3-adapter", :platforms=>:jruby
-gem "sqlite3", :platforms=>:ruby
+gem "activerecord-jdbcsqlite3-adapter", platforms: :jruby
+gem "sqlite3", platforms: :ruby
 
 gemspec :path=>"../"

data/gemfiles/rails_4_0.gemfile

@@ -3,7 +3,7 @@
 source "https://rubygems.org"
 
 gem "activerecord", "~>4.0.0"
-gem "activerecord-jdbcsqlite3-adapter", "1.3.0.rc1", :platforms=>:jruby
-gem "sqlite3", :platforms=>:ruby
+gem "activerecord-jdbcsqlite3-adapter", "1.3.0.rc1", platforms: :jruby
+gem "sqlite3", platforms: :ruby
 
 gemspec :path=>"../"

data/gemfiles/rails_6_1.gemfile

@@ -0,0 +1,9 @@
+# This file was generated by Appraisal
+
+source "https://rubygems.org"
+
+gem "activerecord", "~>6.1.0"
+gem "activerecord-jdbcsqlite3-adapter", "61.1", platforms: :jruby
+gem "sqlite3", platforms: :ruby
+
+gemspec path: "../"

data/lib/active_model/transitions.rb

@@ -9,9 +9,9 @@ module ActiveModel
           alias_method :old_transitions_initialize, :initialize
           alias_method :old_transitions_update, :update
 
-          def new_transitions_initialize(*args, &block)
+          def new_transitions_initialize(*args, **kwargs, &block)
             @attribute_name = :state
-            old_transitions_initialize(*args, &block)
+            old_transitions_initialize(*args, **kwargs, &block)
           end
 
           def new_transitions_update(options = {}, &block)

data/lib/transitions/event.rb

@@ -3,46 +3,46 @@ module Transitions
   class Event
     attr_reader :name, :success, :timestamp
 
-    # :reek:TooManyStatements: { max_statements: 13 }
+    # :reek:TooManyStatements { max_statements: 13 }
     def initialize(machine, name, options = {}, &block)
       @machine = machine
       @name = name
       @transitions = []
       @timestamps = []
       if machine
-        machine.klass.send(:define_method, "#{name}!") do |*args|
-          machine.fire_event(name, self, true, *args)
+        machine.klass.send(:define_method, "#{name}!") do |*args, **kwargs|
+          machine.fire_event(name, self, true, *args, **kwargs)
         end
 
-        machine.klass.send(:define_method, name.to_s) do |*args|
-          machine.fire_event(name, self, false, *args)
+        machine.klass.send(:define_method, name.to_s) do |*args, **kwargs|
+          machine.fire_event(name, self, false, *args, **kwargs)
         end
 
         machine.klass.send(:define_method, "can_#{name}?") do |*_args|
           machine.events_for(current_state).include?(name.to_sym)
         end
 
-        machine.klass.send(:define_method, "can_execute_#{name}?") do |*args|
+        machine.klass.send(:define_method, "can_execute_#{name}?") do |*args, **kwargs|
           event = name.to_sym
 
-          send("can_#{name}?", *args) &&
-            machine.events[event].can_execute_transition_from_state?(current_state, self, *args)
+          send("can_#{name}?", *args, **kwargs) &&
+            machine.events[event].can_execute_transition_from_state?(current_state, self, *args, **kwargs)
         end
       end
       update(options, &block)
     end
 
-    def fire(obj, to_state = nil, *args)
+    def fire(obj, to_state = nil, *args, **kwargs)
       transitions = @transitions.select { |t| t.from == obj.current_state }
       fail InvalidTransition, error_message_for_invalid_transitions(obj) if transitions.size == 0
 
       next_state = nil
       transitions.each do |transition|
         next if to_state && !Array(transition.to).include?(to_state)
-        next unless transition.executable?(obj, *args)
+        next unless transition.executable?(obj, *args, **kwargs)
 
         next_state = to_state || Array(transition.to).first
-        transition.execute(obj, *args)
+        transition.execute(obj, *args, **kwargs)
         update_event_timestamp(obj, next_state) if timestamp_defined?
         break
       end
@@ -54,8 +54,8 @@ module Transitions
       @transitions.any? { |t| t.from? state }
     end
 
-    def can_execute_transition_from_state?(state, obj, *args)
-      @transitions.select { |t| t.from? state }.any? { |t| t.executable?(obj, *args) }
+    def can_execute_transition_from_state?(state, obj, *args, **kwargs)
+      @transitions.select { |t| t.from? state }.any? { |t| t.executable?(obj, *args, **kwargs) }
     end
 
     def ==(other)

data/lib/transitions/machine.rb

@@ -27,9 +27,9 @@ module Transitions
     #
     # rubocop:disable Metrics/MethodLength
     #
-    def fire_event(event, record, persist, *args)
+    def fire_event(event, record, persist, *args, **kwargs)
       handle_state_exit_callback record
-      if new_state = transition_to_new_state(record, event, *args)
+      if new_state = transition_to_new_state(record, event, *args, **kwargs)
         handle_state_enter_callback record, new_state
         handle_event_fired_callback record, new_state, event
         record.update_current_state(new_state, persist)
@@ -61,8 +61,8 @@ module Transitions
       state_index[record.current_state].call_action(:exit, record)
     end
 
-    def transition_to_new_state(record, event, *args)
-      @events[event].fire(record, nil, *args)
+    def transition_to_new_state(record, event, *args, **kwargs)
+      @events[event].fire(record, nil, *args, **kwargs)
     end
 
     def handle_state_enter_callback(record, new_state)
@@ -95,7 +95,7 @@ module Transitions
       (@events[name] ||= Event.new(self, name)).update(options, &block)
     end
 
-    # :reek:TooManyStatements: { max_statements: 7 }
+    # :reek:TooManyStatements { max_statements: 7 }
     def include_scopes
       @states.each do |state|
         state_name = state.name.to_s

data/lib/transitions/state_transition.rb

@@ -23,8 +23,8 @@ module Transitions
     #
     # @return [Bool]
     #
-    def executable?(obj, *args)
-      [@guard].flatten.all? { |g| perform_guard(obj, g, *args) }
+    def executable?(obj, *args, **kwargs)
+      [@guard].flatten.all? { |g| perform_guard(obj, g, *args, **kwargs) }
     end
 
     #
@@ -40,17 +40,17 @@ module Transitions
     #
     # rubocop:disable Metrics/MethodLength
     #
-    def execute(obj, *args)
+    def execute(obj, *args, **kwargs)
       case @on_transition
       when Symbol, String
-        obj.send(@on_transition, *args)
+        obj.send(@on_transition, *args, **kwargs)
       when Proc
-        @on_transition.call(obj, *args)
+        @on_transition.call(obj, *args, **kwargs)
       when Array
         @on_transition.each do |callback|
           # Yes, we're passing always the same parameters for each callback in here.
           # We should probably drop args altogether in case we get an array.
-          obj.send(callback, *args)
+          obj.send(callback, *args, **kwargs)
         end
       else
         # TODO: We probably should check for this in the constructor and not that late.
@@ -70,11 +70,11 @@ module Transitions
 
     private
 
-    def perform_guard(obj, guard, *args)
+    def perform_guard(obj, guard, *args, **kwargs)
       if guard.respond_to?(:call)
-        guard.call(obj, *args)
+        guard.call(obj, *args, **kwargs)
       elsif guard.is_a?(Symbol) || guard.is_a?(String)
-        obj.send(guard, *args)
+        obj.send(guard, *args, **kwargs)
       else
         true
       end

data/lib/transitions/version.rb

@@ -1,3 +1,3 @@
 module Transitions
-  VERSION = '1.2.1'.freeze
+  VERSION = '1.3.0'.freeze
 end

data/transitions.gemspec

@@ -17,13 +17,14 @@ Gem::Specification.new do |spec|
   spec.files         = `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(test|spec|features)/}) }
   spec.require_paths = ['lib']
 
-  spec.add_development_dependency 'bundler', '~> 1.0'
-  spec.add_development_dependency 'rake'
-  spec.add_development_dependency 'test-unit', '~> 2.5'
+  spec.add_development_dependency 'bundler', '~> 2.0'
+  spec.add_development_dependency 'rake', '< 11.0'
+  spec.add_development_dependency 'test-unit', '~> 3.5'
   spec.add_development_dependency 'mocha', '~> 0.11.0' # With mocha 0.12 we get: undefined method `run' for #<StateMachineMachineTest:0x94918b8> (NoMethodError)
   spec.add_development_dependency 'random_data'
   spec.add_development_dependency 'appraisal'
-  spec.add_development_dependency 'activerecord', ['>= 3.0', '<= 4.0']
+  spec.add_development_dependency 'activerecord', ['~> 6.1']
   spec.add_development_dependency 'rubocop', '~> 0.36.0'
+  spec.add_development_dependency 'rexml'
   spec.add_development_dependency 'reek'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: transitions
 version: !ruby/object:Gem::Version
-  version: 1.2.1
+  version: 1.3.0
 platform: ruby
 authors:
 - Timo Rößner
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2016-11-07 00:00:00.000000000 Z
+date: 2022-03-31 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -16,42 +16,42 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.0'
+        version: '2.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.0'
+        version: '2.0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "<"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '11.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "<"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '11.0'
 - !ruby/object:Gem::Dependency
   name: test-unit
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.5'
+        version: '3.5'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.5'
+        version: '3.5'
 - !ruby/object:Gem::Dependency
   name: mocha
   requirement: !ruby/object:Gem::Requirement
@@ -98,22 +98,16 @@ dependencies:
   name: activerecord
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '3.0'
-    - - "<="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '4.0'
+        version: '6.1'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '3.0'
-    - - "<="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '4.0'
+        version: '6.1'
 - !ruby/object:Gem::Dependency
   name: rubocop
   requirement: !ruby/object:Gem::Requirement
@@ -128,6 +122,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: 0.36.0
+- !ruby/object:Gem::Dependency
+  name: rexml
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: reek
   requirement: !ruby/object:Gem::Requirement
@@ -151,9 +159,9 @@ extra_rdoc_files: []
 files:
 - ".codeclimate.yml"
 - ".gitignore"
+- ".reek.yml"
 - ".rubocop.yml"
 - ".ruby-version"
-- ".todo.reek"
 - ".travis.yml"
 - Appraisals
 - CHANGELOG.md
@@ -166,6 +174,7 @@ files:
 - gemfiles/rails_3_1.gemfile
 - gemfiles/rails_3_2.gemfile
 - gemfiles/rails_4_0.gemfile
+- gemfiles/rails_6_1.gemfile
 - lib/active_model/transitions.rb
 - lib/active_record/transitions.rb
 - lib/transitions.rb
@@ -180,7 +189,7 @@ homepage: http://github.com/troessner/transitions
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -195,9 +204,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.5.1
-signing_key: 
+rubygems_version: 3.1.6
+signing_key:
 specification_version: 4
 summary: State machine extracted from ActiveModel
 test_files: []

data/.todo.reek

@@ -1,96 +0,0 @@
----
-DuplicateMethodCall:
-  exclude:
-  - ActiveModel::Transitions#read_state
-  - ActiveModel::Transitions#reload
-  - ActiveModel::Transitions#set_initial_state
-  - Transitions::Event#error_message_for_invalid_transitions
-  - Transitions::Event#fire
-  - Transitions::Event#initialize
-  - Transitions::Event#update
-  - Transitions::Machine#handle_event_success_callback
-  - Transitions::Machine#initial_state
-  - Transitions::State#define_state_query_method
-IrresponsibleModule:
-  exclude:
-  - ActiveModel::Transitions
-  - Transitions::Machine
-  - Transitions::Presenter
-  - Transitions::State
-  - Transitions::StateTransition
-  - Transitions
-  - Transitions::ClassMethods
-  - Transitions::InvalidMethodOverride
-  - Transitions::InvalidTransition
-NilCheck:
-  exclude:
-  - ActiveModel::Transitions#state_not_set?
-  - Transitions::Event#timestamp_defined?
-  - Transitions::StateTransition#execute
-  - Transitions#current_state
-UncommunicativeVariableName:
-  exclude:
-  - ActiveModel::Transitions#state_included?
-  - Transitions::Event#can_execute_transition_from_state?
-  - Transitions::Event#fire
-  - Transitions::Event#transitions
-  - Transitions::Event#transitions_from_state?
-  - Transitions::Machine#fire_event
-  - Transitions::StateTransition#executable?
-FeatureEnvy:
-  exclude:
-  - Transitions::Event#can_execute_transition_from_state?
-  - Transitions::Event#default_timestamp_name
-  - Transitions::Event#error_message_for_invalid_transitions
-InstanceVariableAssumption:
-  exclude:
-  - Transitions::Event
-  - Transitions::Machine
-  - Transitions::State
-ManualDispatch:
-  exclude:
-  - Transitions::Event#default_timestamp_name
-  - Transitions::Event#error_message_for_invalid_transitions
-  - Transitions::Machine#fire_event
-  - Transitions::Machine#handle_event_failed_callback
-  - Transitions::Machine#handle_event_fired_callback
-  - Transitions::Machine#include_scopes
-  - Transitions::StateTransition#perform_guard
-NestedIterators:
-  exclude:
-  - Transitions::Event#build_success_callback
-TooManyInstanceVariables:
-  exclude:
-  - Transitions::Event
-  - Transitions::Machine
-  - Transitions::StateTransition
-TooManyStatements:
-  exclude:
-  - initialize
-  - Transitions::Event#build_success_callback
-  - Transitions::Event#fire
-  - Transitions::Machine#fire_event
-  - Transitions#current_state
-Attribute:
-  exclude:
-  - Transitions::Machine#events
-  - Transitions::Machine#initial_state
-  - Transitions::Machine#state_index
-  - Transitions::Machine#states
-DataClump:
-  exclude:
-  - Transitions::Machine
-LongParameterList:
-  exclude:
-  - Transitions::Machine#fire_event
-UtilityFunction:
-  exclude:
-  - Transitions::Machine#handle_event_failed_callback
-  - Transitions::Machine#handle_event_fired_callback
-  - Transitions::StateTransition#perform_guard
-BooleanParameter:
-  exclude:
-  - Transitions#update_current_state
-ControlParameter:
-  exclude:
-  - Transitions#update_current_state