transbank-webpay 0.2.1 → 0.2.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: da218d0486264efe68c50b094191a25635527e46
-  data.tar.gz: 359d79d85aace9647dc7179ed4e1689aae94293d
+  metadata.gz: e41cf49e63380f433816c8ffeab129a4439af783
+  data.tar.gz: 2b4a58573ff7140c13de428a2054a48606878220
 SHA512:
-  metadata.gz: 39322504f0976c64ef41db5558f4b24457346b8fab2b1bcc125b0eeb6d24a337fde87fecbbb39d893a8968815064a42b1ecf04b9c53a514556d1965516776e2b
-  data.tar.gz: c55dc3592895bee04a99c91291ca90b0d403961799fa450179e9071d7981060a8521b4168dfa17cebc8361fe4d0b7624c9b36d7513e59f4ed14bfea988693bde
+  metadata.gz: 159796edc3f3ee02ab7f39aaa0b8703e0571012205101edeb8762276f149961e7ed63c4a776ce45afad0ca14f5f3ce5a85fb17d7c0c4468f4ed3baf39ea78688
+  data.tar.gz: fb85fa5eb42c292da501c63211531b81d9c296817df4e046926d13aa4bf380695dd9a10256b3704db3d328f1ced29037ef52d1d1d0a7f1f996fc7512f68cb7e9

data/lib/transbank/webpay.rb

@@ -7,6 +7,7 @@ require 'builder'
 
 require 'transbank/webpay/version'
 require 'transbank/webpay/configuration'
+require 'transbank/webpay/vault'
 require 'transbank/webpay/validations'
 require 'transbank/webpay/struct'
 require 'transbank/webpay/reader'
@@ -23,19 +24,19 @@ require 'transbank/webpay/api'
 module Transbank
   module Webpay
     class << self
-      attr_accessor :configuration
+      attr_reader :configuration
 
       # Delegate api
       Api.instance_methods.each { |m| define_method(m) { |*args| api.send(m, *args) } }
-    end
 
-    def self.configure
-      self.configuration ||= Configuration.new
-      yield(configuration)
-    end
+      def configure
+        @configuration ||= Configuration.new
+        yield(@configuration)
+      end
 
-    def self.api
-      @api ||= Api.new
+      def api
+        @api ||= Api.new
+      end
     end
   end
 end

data/lib/transbank/webpay/document.rb

@@ -46,8 +46,8 @@ module Transbank
         unsigned_xml = unsigned_document.to_s
 
         signer = Signer.new(unsigned_xml)
-        signer.cert = cert
-        signer.private_key = private_key
+        signer.cert = Transbank::Webpay::Vault.cert
+        signer.private_key = Transbank::Webpay::Vault.private_key
 
         signer.document.xpath('//soapenv:Body', soapenv: SOAPENV).each do |node|
           signer.digest!(node)
@@ -81,13 +81,13 @@ module Transbank
         end
       end
 
-      def cert
-        @cert ||= OpenSSL::X509::Certificate.new open(Transbank::Webpay.configuration.cert_path)
-      end
+      # def cert
+      #   @cert ||= OpenSSL::X509::Certificate.new open(Transbank::Webpay.configuration.cert_path)
+      # end
 
-      def private_key
-        @private_key ||= OpenSSL::PKey::RSA.new open(Transbank::Webpay.configuration.key_path)
-      end
+      # def private_key
+      #   @private_key ||= OpenSSL::PKey::RSA.new open(Transbank::Webpay.configuration.key_path)
+      # end
     end
   end
 end

data/lib/transbank/webpay/reader.rb

@@ -27,7 +27,7 @@ module Transbank
       end
 
       def response_code_display
-        RESPONSE_CODE.fetch(action, RESPONSE_CODE[:default]).fetch(response_code, response_code)
+        RESPONSE_CODE.fetch(action, RESPONSE_CODE[:default]).fetch(xml_response_code, xml_response_code)
       end
 
       def body
@@ -56,7 +56,7 @@ module Transbank
         doc.xpath("//faultstring")
       end
 
-      def response_code
+      def xml_response_code
         doc.xpath("//responseCode").text
       end
 

data/lib/transbank/webpay/validations.rb

@@ -29,21 +29,21 @@ module Transbank
         Base64.encode64(digest).strip
       end
 
-      def server_cert
-        @server_cert ||= begin
-          path = Transbank::Webpay.configuration.server_cert_path
-          OpenSSL::X509::Certificate.new File.read(path)
-        end
-      end
+      # def server_cert
+      #   @server_cert ||= begin
+      #     path = Transbank::Webpay.configuration.server_cert_path
+      #     OpenSSL::X509::Certificate.new File.read(path)
+      #   end
+      # end
 
-      def pub_key
-        server_cert.public_key
-      end
+      # def pub_key
+      #   server_cert.public_key
+      # end
 
       # Validations
       def validate_response_code!
-        return if response_code.empty?
-        @errors << response_code_display if response_code != '0'
+        return if xml_response_code.empty?
+        @errors << response_code_display if xml_response_code != '0'
       end
 
       def validate_http_response!
@@ -63,7 +63,11 @@ module Transbank
           Nokogiri::XML::XML_C14N_EXCLUSIVE_1_0, ["soap"], nil
         )
 
-        pub_key.verify OpenSSL::Digest::SHA1.new, signature_decode, signed_node_canonicalize
+        Transbank::Webpay::Vault.pub_key.verify(
+          OpenSSL::Digest::SHA1.new,
+          signature_decode,
+          signed_node_canonicalize
+        )
       end
 
       def validate_digest

data/lib/transbank/webpay/vault.rb

@@ -0,0 +1,27 @@
+require 'benchmark'
+module Transbank
+  module Webpay
+    class Vault
+      class << self
+        def cert
+          @cert ||= OpenSSL::X509::Certificate.new open(Transbank::Webpay.configuration.cert_path)
+        end
+
+        def private_key
+          @private_key ||= OpenSSL::PKey::RSA.new open(Transbank::Webpay.configuration.key_path)
+        end
+
+        def server_cert
+          @server_cert ||= begin
+            path = Transbank::Webpay.configuration.server_cert_path
+            OpenSSL::X509::Certificate.new File.read(path)
+          end
+        end
+
+        def pub_key
+          server_cert.public_key
+        end
+      end
+    end
+  end
+end

data/lib/transbank/webpay/version.rb

@@ -1,5 +1,5 @@
 module Transbank
   module Webpay
-    VERSION = '0.2.1'
+    VERSION = '0.2.2'.freeze
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: transbank-webpay
 version: !ruby/object:Gem::Version
-  version: 0.2.1
+  version: 0.2.2
 platform: ruby
 authors:
 - Ramón Soto
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2016-07-18 00:00:00.000000000 Z
+date: 2016-08-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: signer
@@ -142,6 +142,7 @@ files:
 - lib/transbank/webpay/response.rb
 - lib/transbank/webpay/struct.rb
 - lib/transbank/webpay/validations.rb
+- lib/transbank/webpay/vault.rb
 - lib/transbank/webpay/version.rb
 - transbank-webpay.gemspec
 homepage: ''