tramway 3.1.2.7 → 3.1.2.8

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 1bc6a1e219c499e701dd4ec09e3e04d722ba480744c25db62f4b8f5b75f3c365
-  data.tar.gz: 5fd9987b47419d936e0bd50dbf727147c149c33948188d53589cc3666482829b
+  metadata.gz: 4734bad656c9c6530213422f8e87e54ce595404ef127010b781e45af3f94967a
+  data.tar.gz: d9b3ee1e03ccfe40912955fd490ccc88a6b127965696b9956ecf5d5ced27e727
 SHA512:
-  metadata.gz: 7c4fb50d8f6579be7bb697af7a93b3e1b69199724e6ca23b1a54e03809bc8de896a43d2faf22dcfd0bc3f1755648689c888659c0ffcb19f90407a2036a2c0d44
-  data.tar.gz: cc2131f3a6f9302ab31db63ca04fce6339e770c9694a97d147e340e8294002ed1707bd5ed5c511b2e1293f369f23139bd57e6236d467fcc9a7f84b8bc0e00e68
+  metadata.gz: 54ade07629589d86733af1c559579cae2d1dab1d35f21616bd3e01ddcd3e964f027ce8fa71a44dede44061382b5637887151c680236b22ca2eb5abba5af82346
+  data.tar.gz: 9c37d9d2b6e868e34c533034e3f40e4953c21120986c0d68aaadf351f21732e7ef31955a354048a2bae669e624711691e743778507cd6107de57fd66211dc04c

data/README.md

@@ -1380,6 +1380,9 @@ Autocomplete select example:
 `autocomplete: true` renders an autocomplete-enabled select. It cannot be used together with `multiselect: true` in the
 same select field.
 
+When you use `multiselect: true`, make sure any preselected values still exist in the collection you render. Unknown
+values are ignored by the widget so the select can still boot safely.
+
 **Examples**
 
 1. Sign In Form for `devise` authentication

data/app/assets/javascripts/tramway/tramway.js

@@ -1,4 +1,5 @@
 import { Controller } from "@hotwired/stimulus"
+/* global console */
 
 class TramwaySelect extends Controller {
   static targets = ["dropdown", "showSelectedArea", "hiddenInput", "caretDown", "caretUp"]
@@ -32,11 +33,21 @@ class TramwaySelect extends Controller {
     });
 
     const initialValues = this.element.dataset.value === undefined ? [] : JSON.parse(this.element.dataset.value);
+    const selectedValues = new Set(initialValues.map(value => value.toString()));
+    const missingValues = initialValues
+      .map(value => value.toString())
+      .filter(value => !this.items.some(item => item.value.toString() === value));
+
+    if (missingValues.length > 0) {
+      console.warn(
+        `Tramway select ignored ${missingValues.length} stale selected value${missingValues.length === 1 ? '' : 's'} ` +
+        `that are not present in the collection: ${missingValues.join(', ')}.`
+      );
+    }
 
-    initialValues.map((value) => {
-      const itemIndex = this.items.findIndex(x => x.value.toString() === value.toString());
-      this.items[itemIndex].selected = true;
-    })
+    this.items.forEach(item => {
+      item.selected = selectedValues.has(item.value.toString());
+    });
 
     this.selectedItems = this.items.filter(item => item.selected);
 
@@ -137,6 +148,10 @@ class TramwaySelect extends Controller {
     const itemIndex = this.items.findIndex(x => x.value === currentTarget.dataset.value);
     const itemSelectedIndex = this.selectedItems.findIndex(x => x.value === currentTarget.dataset.value);
 
+    if (itemIndex === -1) {
+      return;
+    }
+
     if (!this.multiple()) {
       this.selectedItems = [];
       this.items.forEach(item => item.selected = false);

data/app/components/tramway/flash_component.html.haml

@@ -2,14 +2,20 @@
   @keyframes fadeout {
     0% {
       opacity: 1;
+      visibility: visible;
+      pointer-events: auto;
     }
 
     80% {
       opacity: 1;
+      visibility: visible;
+      pointer-events: auto;
     }
 
     100% {
       opacity: 0;
+      visibility: hidden;
+      pointer-events: none;
     }
   }
 

data/lib/tramway/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Tramway
-  VERSION = '3.1.2.7'
+  VERSION = '3.1.2.8'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: tramway
 version: !ruby/object:Gem::Version
-  version: 3.1.2.7
+  version: 3.1.2.8
 platform: ruby
 authors:
 - kalashnikovisme